- gerrit-log - lists.osmocom.org

[XS] Change in libosmo-abis[master]: ipaccess: Assert explicitly about non-null ptr
by pespin 02 Dec '24

02 Dec '24

pespin has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/38995?usp=email ) Change subject: ipaccess: Assert explicitly about non-null ptr ...................................................................... ipaccess: Assert explicitly about non-null ptr Make coverity happy. Those pointers can never be NULL due to related logic of e1i_ts_has_pending_tx_msgs() and e1inp_tx_ts(). Closes: Coverity CID#435269 Change-Id: Ifc79899bba787f08cc83206b0a53b04b66861c7b --- M src/input/ipaccess.c 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified osmith: Looks good to me, approved diff --git a/src/input/ipaccess.c b/src/input/ipaccess.c index 94f1b2b..5a24686 100644 --- a/src/input/ipaccess.c +++ b/src/input/ipaccess.c @@ -557,6 +557,8 @@ struct e1inp_sign_link *sign_link = NULL; struct msgb *msg; msg = e1inp_tx_ts(e1i_ts, &sign_link); + OSMO_ASSERT(msg); + OSMO_ASSERT(sign_link); rc |= ipaccess_bts_send_msg(e1i_ts, sign_link, cli, msg); } return rc; -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/38995?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: Ifc79899bba787f08cc83206b0a53b04b66861c7b Gerrit-Change-Number: 38995 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in libosmo-abis[master]: ipaccess: Assert fd is positive
by osmith 02 Dec '24

02 Dec '24

Attention is currently required from: pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-abis/+/38997?usp=email ) Change subject: ipaccess: Assert fd is positive ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/38997?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I09004040107fb72b6170618a6253a6225f4351c2 Gerrit-Change-Number: 38997 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 02 Dec 2024 12:40:28 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in libosmo-abis[master]: ipaccess: Assert explicitly about non-null ptr
by osmith 02 Dec '24

02 Dec '24

Attention is currently required from: pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-abis/+/38995?usp=email ) Change subject: ipaccess: Assert explicitly about non-null ptr ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/38995?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: Ifc79899bba787f08cc83206b0a53b04b66861c7b Gerrit-Change-Number: 38995 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 02 Dec 2024 12:40:10 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in libosmo-abis[master]: ipaccess: Assert explicitly about non-null ptr
by osmith 02 Dec '24

02 Dec '24

Attention is currently required from: pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-abis/+/38995?usp=email ) Change subject: ipaccess: Assert explicitly about non-null ptr ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/38995?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: Ifc79899bba787f08cc83206b0a53b04b66861c7b Gerrit-Change-Number: 38995 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 02 Dec 2024 12:40:06 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in libosmo-abis[master]: Drop internal use of osmocom/abis/ipaccess.h
by osmith 02 Dec '24

02 Dec '24

Attention is currently required from: pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-abis/+/38988?usp=email ) Change subject: Drop internal use of osmocom/abis/ipaccess.h ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/38988?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: Ifc9759b17a9b966cb713f7533a13f6223161a4cd Gerrit-Change-Number: 38988 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 02 Dec 2024 12:39:27 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in libosmocore[master]: osmo_io: Improve osmo_iofd_notify_connected() documentation
by osmith 02 Dec '24

02 Dec '24

Attention is currently required from: fixeria, jolly, laforge, pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmocore/+/38985?usp=email ) Change subject: osmo_io: Improve osmo_iofd_notify_connected() documentation ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/38985?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ica20a050b98d117995a5b625b23ab9faa61aabee Gerrit-Change-Number: 38985 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 02 Dec 2024 10:29:13 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in libosmo-abis[master]: ipaccess: Assert fd is positive
by pespin 02 Dec '24

02 Dec '24

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-abis/+/38997?usp=email ) Change subject: ipaccess: Assert fd is positive ...................................................................... ipaccess: Assert fd is positive Make coverity happy. We are in a rx path from socket, so socket should be fine at that point. Closes: Coverity CID#435266 Change-Id: I09004040107fb72b6170618a6253a6225f4351c2 --- M src/input/ipaccess.c 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-abis refs/changes/97/38997/1 diff --git a/src/input/ipaccess.c b/src/input/ipaccess.c index 5a24686..505ec3f 100644 --- a/src/input/ipaccess.c +++ b/src/input/ipaccess.c @@ -958,6 +958,7 @@ /* ping, pong and acknowledgment cases. */ struct osmo_fd tmp_ofd = { .fd = osmo_stream_cli_get_fd(cli) }; + OSMO_ASSERT(tmp_ofd.fd >= 0); ret = ipa_ccm_rcvmsg_bts_base(msg, &tmp_ofd); if (ret < 0) goto err; -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/38997?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I09004040107fb72b6170618a6253a6225f4351c2 Gerrit-Change-Number: 38997 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in libosmocore[master]: gsm48: add additional GSM 24.008 IE for GMM
by pespin 02 Dec '24

02 Dec '24

Attention is currently required from: lynxis lazus. pespin has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/libosmocore/+/38996?usp=email ) Change subject: gsm48: add additional GSM 24.008 IE for GMM ...................................................................... Patch Set 1: Code-Review+1 (1 comment) Patchset: PS1: Please remember to add it to the tlv defintion in osmo-sgsn and libosmo-gprs. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/38996?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I4824a319948f1088137c13d1cf610a1b1c2529f2 Gerrit-Change-Number: 38996 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Mon, 02 Dec 2024 10:20:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[S] Change in libosmocore[master]: gsm48: add additional GSM 24.008 IE for GMM
by lynxis lazus 02 Dec '24

02 Dec '24

lynxis lazus has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/38996?usp=email ) Change subject: gsm48: add additional GSM 24.008 IE for GMM ...................................................................... gsm48: add additional GSM 24.008 IE for GMM Add release 17 GMM IEs Change-Id: I4824a319948f1088137c13d1cf610a1b1c2529f2 --- M include/osmocom/gsm/protocol/gsm_04_08_gprs.h 1 file changed, 16 insertions(+), 5 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/96/38996/1 diff --git a/include/osmocom/gsm/protocol/gsm_04_08_gprs.h b/include/osmocom/gsm/protocol/gsm_04_08_gprs.h index b9d8b74..6ba92c2 100644 --- a/include/osmocom/gsm/protocol/gsm_04_08_gprs.h +++ b/include/osmocom/gsm/protocol/gsm_04_08_gprs.h @@ -81,31 +81,42 @@ #define GSM48_MT_GMM_SERVICE_REJ 0x0e enum gsm48_gprs_ie_mm { - GSM48_IE_GMM_CIPH_CKSN = 0x08, /* 10.5.1.2 */ - GSM48_IE_GMM_PTMSI_TYPE = 0x0e, /* 10.5.5.29 */ - GSM48_IE_GMM_TMSI_BASED_NRI_C = 0x10, /* 10.5.5.31 */ + GSM48_IE_GMM_CIPH_CKSN = 0x08, /* 10.5.1.2 */ + GSM48_IE_GMM_TMSI_STATUS = 0x09, /* 10.5.5.4 */ + GSM48_IE_GMM_MS_NET_FEAT_SUP = 0x0c, /* 10.5.1.15 */ + GSM48_IE_GMM_DEVICE_PROP = 0x0d, /* 10.5.7.8 */ + GSM48_IE_GMM_PTMSI_TYPE = 0x0e, /* 10.5.5.29 */ + GSM48_IE_GMM_ADD_UPDATE_TYPE = 0x0f, /* 10.5.5.0 */ + GSM48_IE_GMM_TMSI_BASED_NRI_C = 0x10, /* 10.5.5.31 */ + GSM48_IE_GMM_MS_CLASSMARK2 = 0x11, /* 10.5.1.6 */ + GSM48_IE_GMM_OLD_LAI = 0x14, /* 10.5.5.30 */ GSM48_IE_GMM_TIMER_READY = 0x17, /* 10.5.7.3 */ GSM48_IE_GMM_ALLOC_PTMSI = 0x18, /* 10.5.1.4 */ GSM48_IE_GMM_PTMSI_SIG = 0x19, /* 10.5.5.8 */ GSM48_IE_GMM_ADD_IDENTITY = 0x1a, /* 10.5.1.4 */ GSM48_IE_GMM_RAI2 = 0x1b, /* 10.5.5.15a */ + GSM48_IE_GMM_MS_CLASSMARK3 = 0x20, /* 10.5.1.7 */ GSM48_IE_GMM_AUTH_RAND = 0x21, /* 10.5.3.1 */ GSM48_IE_GMM_AUTH_SRES = 0x22, /* 10.5.3.2 */ GSM48_IE_GMM_IMEISV = 0x23, /* 10.5.1.4 */ GSM48_IE_GMM_CAUSE = 0x25, /* 10.5.5.14 */ - GSM48_IE_GMM_RX_NPDU_NUM_LIST = 0x26, /* 10.5.5.11 */ + GSM48_IE_GMM_RX_NPDU_NUM_LIST = 0x26, /* 10.5.5.11 */ GSM48_IE_GMM_DRX_PARAM = 0x27, /* 10.5.5.6 */ GSM48_IE_GMM_AUTN = 0x28, /* 10.5.3.1.1 */ - GSM48_IE_GMM_AUTH_RES_EXT = 0x29, /* 10.5.3.2.1 */ + GSM48_IE_GMM_AUTH_RES_EXT = 0x29, /* 10.5.3.2.1 */ GSM48_IE_GMM_TIMER_T3302 = 0x2A, /* 10.5.7.4 */ GSM48_IE_GMM_AUTH_FAIL_PAR = 0x30, /* 10.5.3.2.2 */ GSM48_IE_GMM_MS_NET_CAPA = 0x31, /* 10.5.5.12 */ GSM48_IE_GMM_PDP_CTX_STATUS = 0x32, /* 10.5.7.1 */ GSM48_IE_GMM_PS_LCS_CAPA = 0x33, /* 10.5.5.22 */ GSM48_IE_GMM_GMM_MBMS_CTX_ST = 0x35, /* 10.5.7.6 */ + GSM48_IE_GMM_TIMER_T3312_EXT = 0x39, /* 10.5.7.4a */ GSM48_IE_GMM_TIMER_T3346 = 0x3A, /* 10.5.7.4 */ + GSM48_IE_GMM_SUPP_CODEC_LIST = 0x40, /* 10.5.4.32 */ GSM48_IE_GMM_UE_NET_CAP = 0x58, /* 10.5.5.26 */ GSM48_IE_GMM_VD_PREF_UE_USAGE = 0x5d, /* 10.5.5.28 */ + GMM48_IE_GMM_TIMER_T3324 = 0x6a, /* 10.5.7.4 */ + GSM48_IE_GMM_EXT_DRX_PARAMS = 0x6e, /* 10.5.5.32 */ GSM48_IE_GMM_NET_FEAT_SUPPORT = 0xB0, /* 10.5.5.23 */ }; -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/38996?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I4824a319948f1088137c13d1cf610a1b1c2529f2 Gerrit-Change-Number: 38996 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>

1 0

[XS] Change in libosmo-abis[master]: ipaccess: Assert explicitly about non-null ptr
by pespin 02 Dec '24

02 Dec '24

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-abis/+/38995?usp=email ) Change subject: ipaccess: Assert explicitly about non-null ptr ...................................................................... ipaccess: Assert explicitly about non-null ptr Make coverity happy. Those pointers can never be NULL due to related logic of e1i_ts_has_pending_tx_msgs() and e1inp_tx_ts(). Closes: Coverity CID#435269 Change-Id: Ifc79899bba787f08cc83206b0a53b04b66861c7b --- M src/input/ipaccess.c 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-abis refs/changes/95/38995/1 diff --git a/src/input/ipaccess.c b/src/input/ipaccess.c index 94f1b2b..5a24686 100644 --- a/src/input/ipaccess.c +++ b/src/input/ipaccess.c @@ -557,6 +557,8 @@ struct e1inp_sign_link *sign_link = NULL; struct msgb *msg; msg = e1inp_tx_ts(e1i_ts, &sign_link); + OSMO_ASSERT(msg); + OSMO_ASSERT(sign_link); rc |= ipaccess_bts_send_msg(e1i_ts, sign_link, cli, msg); } return rc; -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/38995?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: Ifc79899bba787f08cc83206b0a53b04b66861c7b Gerrit-Change-Number: 38995 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

2026

2025

2024

2023

2022

gerrit-log