- gerrit-log - lists.osmocom.org

[S] Change in osmo-ttcn3-hacks[master]: RAW_NS: SNS Add: handle IPv4/IPv6 element in SNS Ack
by lynxis lazus 10 Dec '24

10 Dec '24

Attention is currently required from: fixeria. lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39063?usp=email ) Change subject: RAW_NS: SNS Add: handle IPv4/IPv6 element in SNS Ack ...................................................................... Patch Set 4: (1 comment) File library/RAW_NS.ttcnpp: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39063/comment/d66b1456_0200… : PS4, Line 512: if (isvalue(cause) and valueof(cause) == NS_CAUSE_UNKNOWN_IP_ENDPOINT) { > @vyanitskiy@sysmocom. […] the ttcn3 cheat sheet says it's only for record/unions. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39063?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I18c659e43db79400c1b428ed745267a5e6e59102 Gerrit-Change-Number: 39063 Gerrit-PatchSet: 4 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 10 Dec 2024 12:08:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in osmo-ttcn3-hacks[master]: RAW_NS: SNS Add: handle IPv4/IPv6 element in SNS Ack
by pespin 10 Dec '24

10 Dec '24

Attention is currently required from: fixeria, lynxis lazus. pespin has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39063?usp=email ) Change subject: RAW_NS: SNS Add: handle IPv4/IPv6 element in SNS Ack ...................................................................... Patch Set 4: Code-Review+1 (1 comment) File library/RAW_NS.ttcnpp: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39063/comment/2e5d435d_3ccc… : PS4, Line 512: if (isvalue(cause) and valueof(cause) == NS_CAUSE_UNKNOWN_IP_ENDPOINT) { @vyanitskiy@sysmocom.de is "isvalue()" working fine here or should "ispresent()" be used? I always find confusing what each of those returns in each scenario... -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39063?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I18c659e43db79400c1b428ed745267a5e6e59102 Gerrit-Change-Number: 39063 Gerrit-PatchSet: 4 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Tue, 10 Dec 2024 12:06:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-ttcn3-hacks[master]: PCU_Tests_SNS: SNS Add: handle NS_Alive while waiting for SNS_Ack
by lynxis lazus 10 Dec '24

10 Dec '24

lynxis lazus has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39060?usp=email ) Change subject: PCU_Tests_SNS: SNS Add: handle NS_Alive while waiting for SNS_Ack ...................................................................... PCU_Tests_SNS: SNS Add: handle NS_Alive while waiting for SNS_Ack Similiar to 61ccea9ecadc ("PCU_Tests_SNS: del/change weight: don't fail on NS"), the SNS Add procedure might have to handle a NS Alive PDU in the receiving queue while waiting for a SNS ACK. Related: OS#6611 Change-Id: I10646d9acfe280ddfb8852a4d5c37882aae99874 --- M pcu/PCU_Tests_SNS.ttcn 1 file changed, 4 insertions(+), 0 deletions(-) Approvals: pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified fixeria: Looks good to me, approved diff --git a/pcu/PCU_Tests_SNS.ttcn b/pcu/PCU_Tests_SNS.ttcn index 263e205..07f147c 100644 --- a/pcu/PCU_Tests_SNS.ttcn +++ b/pcu/PCU_Tests_SNS.ttcn @@ -303,7 +303,9 @@ /* create another NS codec port on the tester side */ f_init_ns_codec(mp_nsconfig, 2); + g_handle_rx_alive := true; f_outgoing_sns_add(idx_add := 2, w_sig := 0, w_user := 1, idx := 0); + g_handle_rx_alive := false; /* wait for one ALIVE cycle, then ACK any further ALIVE in the background */ as_rx_alive_tx_ack(oneshot := true, idx := 2); @@ -316,6 +318,8 @@ /* Test adding an already present IP endpoint at runtime */ testcase TC_sns_add_nack() runs on RAW_Test_CT { + g_handle_rx_alive := true; + f_sns_bringup_1c1u(); f_outgoing_sns_add(idx_add := 0, w_sig := 0, w_user := 1, idx := 0, cause := NS_CAUSE_PROTOCOL_ERROR_UNSPECIFIED); -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39060?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I10646d9acfe280ddfb8852a4d5c37882aae99874 Gerrit-Change-Number: 39060 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in osmo-ttcn3-hacks[master]: SGSN_Tests: f_TC_attach_usim_resync: fix IMEISV value
by lynxis lazus 10 Dec '24

10 Dec '24

lynxis lazus has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39073?usp=email ) Change subject: SGSN_Tests: f_TC_attach_usim_resync: fix IMEISV value ...................................................................... SGSN_Tests: f_TC_attach_usim_resync: fix IMEISV value IMEISV is IMEI + 2 digit software version. Change-Id: I044eeccd02e2d3f891879516f5a9c003ac8f849a --- M sgsn/SGSN_Tests.ttcn 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins Builder: Verified lynxis lazus: Looks good to me, approved fixeria: Looks good to me, but someone else must approve pespin: Looks good to me, but someone else must approve diff --git a/sgsn/SGSN_Tests.ttcn b/sgsn/SGSN_Tests.ttcn index c6c2c0a..99e53f5 100644 --- a/sgsn/SGSN_Tests.ttcn +++ b/sgsn/SGSN_Tests.ttcn @@ -2177,7 +2177,7 @@ if (ispresent(l3_mt.msgs.gprs_mm.authenticationAndCipheringRequest.imeisvRequest) and l3_mt.msgs.gprs_mm.authenticationAndCipheringRequest.imeisvRequest.valueField == '001'B) { l3_mo.msgs.gprs_mm.authenticationAndCipheringResponse.imeisv := - valueof(ts_MI_IMEISV_TLV(g_pars.imei & '0'H)); + valueof(ts_MI_IMEISV_TLV(g_pars.imei & '00'H)); } f_send_l3(l3_mo); deactivate(di); -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39073?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I044eeccd02e2d3f891879516f5a9c003ac8f849a Gerrit-Change-Number: 39073 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in osmo-ttcn3-hacks[master]: SGSN_Tests: f_TC_attach_usim_resync: fix IMEISV value
by lynxis lazus 10 Dec '24

10 Dec '24

lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39073?usp=email ) Change subject: SGSN_Tests: f_TC_attach_usim_resync: fix IMEISV value ...................................................................... Patch Set 1: Code-Review+2 (1 comment) Patchset: PS1: 1+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39073?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I044eeccd02e2d3f891879516f5a9c003ac8f849a Gerrit-Change-Number: 39073 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 10 Dec 2024 12:03:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[S] Change in osmo-ttcn3-hacks[master]: RAW_NS: SNS Add: handle IPv4/IPv6 element in SNS Ack
by lynxis lazus 10 Dec '24

10 Dec '24

Attention is currently required from: fixeria, pespin. lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39063?usp=email ) Change subject: RAW_NS: SNS Add: handle IPv4/IPv6 element in SNS Ack ...................................................................... Patch Set 3: (2 comments) File library/RAW_NS.ttcnpp: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39063/comment/c1fec76b_b54d… : PS3, Line 512: istemplatekind(cause, "*")) > Indeed, good catch. Done https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39063/comment/8e2ff96c_3464… : PS3, Line 524: istemplatekind(cause, "*")) > Same here. Done -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39063?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I18c659e43db79400c1b428ed745267a5e6e59102 Gerrit-Change-Number: 39063 Gerrit-PatchSet: 3 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 10 Dec 2024 12:02:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[S] Change in osmo-ttcn3-hacks[master]: RAW_NS: SNS Add: handle IPv4/IPv6 element in SNS Ack
by lynxis lazus 10 Dec '24

10 Dec '24

Attention is currently required from: fixeria, lynxis lazus. Hello Jenkins Builder, fixeria, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39063?usp=email to look at the new patch set (#4). The following approvals got outdated and were removed: Code-Review-1 by fixeria, Verified+1 by Jenkins Builder Change subject: RAW_NS: SNS Add: handle IPv4/IPv6 element in SNS Ack ...................................................................... RAW_NS: SNS Add: handle IPv4/IPv6 element in SNS Ack When adding a new NS-VC via SNS Add, the SNS Ack should only contains the IEs "List of IP4/6 elements" if the cause code is Unknown IP endpoint. However the libosmocore/ns2 code isn't following this behavior yet. Change-Id: I18c659e43db79400c1b428ed745267a5e6e59102 --- M library/RAW_NS.ttcnpp 1 file changed, 11 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/63/39063/4 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39063?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I18c659e43db79400c1b428ed745267a5e6e59102 Gerrit-Change-Number: 39063 Gerrit-PatchSet: 4 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>

1 0

[XS] Change in osmo-ttcn3-hacks[master]: RAW_NS: SNS Changeweight: remove IPv4/IPv6 element in SNS Ack
by lynxis lazus 10 Dec '24

10 Dec '24

Attention is currently required from: lynxis lazus. Hello Jenkins Builder, fixeria, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39064?usp=email to look at the new patch set (#4). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder The change is no longer submittable: Verified is unsatisfied now. Change subject: RAW_NS: SNS Changeweight: remove IPv4/IPv6 element in SNS Ack ...................................................................... RAW_NS: SNS Changeweight: remove IPv4/IPv6 element in SNS Ack When changweights of a NS-VC via SNS, the SNS Ack should only contains the IEs "List of IP4/6 elements" if the cause code is Unknown IP endpoint. However the libosmocore/ns2 code isn't following this behavior yet. Change-Id: Ibf00cbab0c6691cdb72fe592ee30e122dd8f4783 --- M library/RAW_NS.ttcnpp 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/64/39064/4 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39064?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ibf00cbab0c6691cdb72fe592ee30e122dd8f4783 Gerrit-Change-Number: 39064 Gerrit-PatchSet: 4 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>

1 0

[S] Change in osmo-ttcn3-hacks[master]: s1gw: make f_ConnHdlr_rx_session_modify_req() more flexible
by fixeria 10 Dec '24

10 Dec '24

Attention is currently required from: pespin. fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39076?usp=email ) Change subject: s1gw: make f_ConnHdlr_rx_session_modify_req() more flexible ...................................................................... Patch Set 1: (1 comment) File s1gw/S1GW_ConnHdlr.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39076/comment/b3b76dfc_9a05… : PS1, Line 739: far_id := 1); > isn't far ids being 1 and 2 just an implementation detail on how the node works? It could be any num […] See https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39079. I think I am starting to understand what you mean, and in general I think it can be done (store FAR IDs during the session creation and then use them). Let's move the discussion there. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39076?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I52317e79ac02cb4e321b49c2cd824de28e25a1c6 Gerrit-Change-Number: 39076 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 10 Dec 2024 11:23:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[S] Change in libosmocore[master]: osmo_io: segmented_read: Avoid triggering read events if user unregis...
by pespin 10 Dec '24

10 Dec '24

pespin has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/39072?usp=email ) Change subject: osmo_io: segmented_read: Avoid triggering read events if user unregisters ...................................................................... osmo_io: segmented_read: Avoid triggering read events if user unregisters The user code doesn't expect to receive any more read cb events after unregistering the FD. Avoid keep calling the read cb if several entire messages were received at once in a single tcp chunk. Related: SYS#7063 Change-Id: Id2199b9aa805cc7e7793c1a8aecd10b61f2b4c90 --- M src/core/osmo_io.c 1 file changed, 9 insertions(+), 1 deletion(-) Approvals: fixeria: Looks good to me, but someone else must approve osmith: Looks good to me, but someone else must approve pespin: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/core/osmo_io.c b/src/core/osmo_io.c index c61c8e9..d1767d2 100644 --- a/src/core/osmo_io.c +++ b/src/core/osmo_io.c @@ -340,8 +340,16 @@ do { pending = NULL; res = iofd_handle_segmentation(iofd, msg, &pending); - if (res != IOFD_SEG_ACT_DEFER || rc < 0) + if (res != IOFD_SEG_ACT_DEFER || rc < 0) { iofd->io_ops.read_cb(iofd, rc, msg); + /* The user could unregister/close the iofd during read_cb() above. + * Once that's done, it doesn't expect to receive any more events, + * so discard it: */ + if (!IOFD_FLAG_ISSET(iofd, IOFD_FLAG_FD_REGISTERED)) { + msgb_free(pending); + return; + } + } if (res == IOFD_SEG_ACT_HANDLE_MORE) msg = pending; } while (res == IOFD_SEG_ACT_HANDLE_MORE); -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/39072?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Id2199b9aa805cc7e7793c1a8aecd10b61f2b4c90 Gerrit-Change-Number: 39072 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

2026

2025

2024

2023

2022

gerrit-log