- gerrit-log - lists.osmocom.org

[S] Change in libosmo-abis[master]: input: Get rid of abis/ipa.h dependency in e1_input and ipaccess.c
by osmith 10 Dec '24

10 Dec '24

Attention is currently required from: fixeria, pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-abis/+/39043?usp=email ) Change subject: input: Get rid of abis/ipa.h dependency in e1_input and ipaccess.c ...................................................................... Patch Set 6: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/39043?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I4efb11ae44c28c4f56f71f5797966f6106493f2b Gerrit-Change-Number: 39043 Gerrit-PatchSet: 6 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 10 Dec 2024 14:53:21 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in libosmo-abis[master]: tests/Makefile.am: Fix missing LIBOSMONETIF_LIBS/CFLAGS
by osmith 10 Dec '24

10 Dec '24

Attention is currently required from: pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-abis/+/39081?usp=email ) Change subject: tests/Makefile.am: Fix missing LIBOSMONETIF_LIBS/CFLAGS ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/39081?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I5b62e17deb9a6d769ddf98a5751e84d69132fecc Gerrit-Change-Number: 39081 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 10 Dec 2024 14:51:46 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in libosmo-abis[master]: input: Get rid of abis/ipa.h dependency in e1_input and ipaccess.c
by pespin 10 Dec '24

10 Dec '24

Attention is currently required from: fixeria, pespin. Hello Jenkins Builder, fixeria, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-abis/+/39043?usp=email to look at the new patch set (#6). The following approvals got outdated and were removed: Code-Review+1 by fixeria, Verified+1 by Jenkins Builder Change subject: input: Get rid of abis/ipa.h dependency in e1_input and ipaccess.c ...................................................................... input: Get rid of abis/ipa.h dependency in e1_input and ipaccess.c abis/ipa.h will eventually be deprecated. The only current use of abis/ipa.h in libosmo-abis itself is in helper code such as: * tests/ipa_recv/ipa_recv_test.c * src/ipa_proxy.c ipaccess e1_input driver is also using struct ipa_keepalive_params, which is only exported publicly in e1_input.h as a pointer and is only really used internally, hence move a copy of the struct to internal.h and use it internally (e1_input_vty.c) from there. Leave a copy of the struct in its original abis/ipa.h (which as mentioned contains code to be deprecated) for old users. Change-Id: I4efb11ae44c28c4f56f71f5797966f6106493f2b --- M include/internal.h M include/osmocom/abis/e1_input.h M src/e1_input_vty.c M src/input/ipa.c M src/input/ipaccess.c M src/ipa_proxy.c 6 files changed, 11 insertions(+), 6 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-abis refs/changes/43/39043/6 -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/39043?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I4efb11ae44c28c4f56f71f5797966f6106493f2b Gerrit-Change-Number: 39043 Gerrit-PatchSet: 6 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in osmo-sgsn[master]: sgsn_vty: Drop unneeded use of abis/ipa.h header
by pespin 10 Dec '24

10 Dec '24

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/39083?usp=email ) Change subject: sgsn_vty: Drop unneeded use of abis/ipa.h header ...................................................................... sgsn_vty: Drop unneeded use of abis/ipa.h header The header is not needed and will eventually be deprecated. Change-Id: I48a513b8ea63dadbc6d6d571380980f55ff04a06 --- M src/sgsn/sgsn_vty.c 1 file changed, 0 insertions(+), 1 deletion(-) Approvals: fixeria: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/sgsn/sgsn_vty.c b/src/sgsn/sgsn_vty.c index 2cb8819..1a104b3 100644 --- a/src/sgsn/sgsn_vty.c +++ b/src/sgsn/sgsn_vty.c @@ -54,7 +54,6 @@ #include <osmocom/vty/misc.h> #include <osmocom/crypt/gprs_cipher.h> #include <osmocom/crypt/utran_cipher.h> -#include <osmocom/abis/ipa.h> #include <osmocom/gprs/gprs_bssgp.h> -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/39083?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I48a513b8ea63dadbc6d6d571380980f55ff04a06 Gerrit-Change-Number: 39083 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in libosmo-abis[master]: input: Get rid of abis/ipa.h dependency in e1_input and ipaccess.c
by fixeria 10 Dec '24

10 Dec '24

Attention is currently required from: pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-abis/+/39043?usp=email ) Change subject: input: Get rid of abis/ipa.h dependency in e1_input and ipaccess.c ...................................................................... Patch Set 5: Code-Review+1 (1 comment) File include/internal.h: https://gerrit.osmocom.org/c/libosmo-abis/+/39043/comment/d42586d1_515da4e3… : PS5, Line 16: interval Is it in seconds? Please clarify at least in comments. -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/39043?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I4efb11ae44c28c4f56f71f5797966f6106493f2b Gerrit-Change-Number: 39043 Gerrit-PatchSet: 5 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 10 Dec 2024 14:22:42 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[M] Change in libosmo-abis[master]: ipaccess: Use new osmo_ipa_ka_fsm_inst APIs from libosmo-netif
by fixeria 10 Dec '24

10 Dec '24

Attention is currently required from: laforge, pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-abis/+/39042?usp=email ) Change subject: ipaccess: Use new osmo_ipa_ka_fsm_inst APIs from libosmo-netif ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/39042?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I6164a44847fcd88d08c77f977d928c2fdf657719 Gerrit-Change-Number: 39042 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 10 Dec 2024 14:20:22 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in libosmo-abis[master]: tests/Makefile.am: Fix missing LIBOSMONETIF_LIBS/CFLAGS
by fixeria 10 Dec '24

10 Dec '24

Attention is currently required from: pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-abis/+/39081?usp=email ) Change subject: tests/Makefile.am: Fix missing LIBOSMONETIF_LIBS/CFLAGS ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/39081?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I5b62e17deb9a6d769ddf98a5751e84d69132fecc Gerrit-Change-Number: 39081 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 10 Dec 2024 14:15:22 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-sgsn[master]: sgsn_vty: Drop unneeded use of abis/ipa.h header
by fixeria 10 Dec '24

10 Dec '24

Attention is currently required from: pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/39083?usp=email ) Change subject: sgsn_vty: Drop unneeded use of abis/ipa.h header ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/39083?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I48a513b8ea63dadbc6d6d571380980f55ff04a06 Gerrit-Change-Number: 39083 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 10 Dec 2024 14:13:47 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-bsc[master]: Drop unneeded use of abis/ipa.h header
by fixeria 10 Dec '24

10 Dec '24

Attention is currently required from: pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-bsc/+/39084?usp=email ) Change subject: Drop unneeded use of abis/ipa.h header ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/39084?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ib5b9557ff5611fd6606cd0ae6af9046e14cceda0 Gerrit-Change-Number: 39084 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 10 Dec 2024 14:13:30 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-hlr[master]: Drop unneeded use of abis/ipa.h header
by fixeria 10 Dec '24

10 Dec '24

Attention is currently required from: pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-hlr/+/39085?usp=email ) Change subject: Drop unneeded use of abis/ipa.h header ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/39085?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Change-Id: I72d0787d4f5641a6a2fbe51427ac490120cbc616 Gerrit-Change-Number: 39085 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 10 Dec 2024 14:13:25 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

2026

2025

2024

2023

2022

gerrit-log