Attention is currently required from: laforge, osmith.
pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-remsim/+/39132?usp=email )
Change subject: Several logging improvements
......................................................................
Patch Set 2:
(2 comments)
File src/bankd/bankd_main.c:
https://gerrit.osmocom.org/c/osmo-remsim/+/39132/comment/a396205d_ee580fbf?… :
PS1, Line 429: fprintf(stderr, "ERROR: reading PCSC slots\n");
> this s ounds like it's an error related to the PC/SC driver. […]
Done
File src/server/rspro_server.c:
https://gerrit.osmocom.org/c/osmo-remsim/+/39132/comment/4d0fc51f_5f8cf082?… :
PS1, Line 784: ,
> I'd say this is DEBUG level.
Done
--
To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/39132?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-remsim
Gerrit-Branch: master
Gerrit-Change-Id: I4fa91ca8c8e576094d3a9598df5ad96b230bbde0
Gerrit-Change-Number: 39132
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Comment-Date: Thu, 12 Dec 2024 19:08:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>
Attention is currently required from: osmith, pespin.
Hello Jenkins Builder, osmith,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-remsim/+/39134?usp=email
to look at the new patch set (#2).
The following approvals got outdated and were removed:
Code-Review+1 by osmith, Verified+1 by Jenkins Builder
Change subject: bankd: Add -T and -e cmdline params
......................................................................
bankd: Add -T and -e cmdline params
Change-Id: I2c33c667be77578699f4a5fb70c8b74c67f6e2cf
---
M doc/manuals/chapters/remsim-bankd.adoc
M src/bankd/bankd_main.c
2 files changed, 21 insertions(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-remsim refs/changes/34/39134/2
--
To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/39134?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: osmo-remsim
Gerrit-Branch: master
Gerrit-Change-Id: I2c33c667be77578699f4a5fb70c8b74c67f6e2cf
Gerrit-Change-Number: 39134
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Attention is currently required from: osmith, pespin.
Hello Jenkins Builder, osmith,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-remsim/+/39132?usp=email
to look at the new patch set (#2).
The following approvals got outdated and were removed:
Code-Review+1 by osmith, Verified+1 by Jenkins Builder
Change subject: Several logging improvements
......................................................................
Several logging improvements
Improve logging in several places which proved to be usfeful while
analyzing behavior of the program.
Change-Id: I4fa91ca8c8e576094d3a9598df5ad96b230bbde0
---
M src/bankd/bankd_main.c
M src/rspro_client_fsm.c
M src/server/rspro_server.c
3 files changed, 14 insertions(+), 5 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-remsim refs/changes/32/39132/2
--
To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/39132?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: osmo-remsim
Gerrit-Branch: master
Gerrit-Change-Id: I4fa91ca8c8e576094d3a9598df5ad96b230bbde0
Gerrit-Change-Number: 39132
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Attention is currently required from: fixeria.
laforge has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/39115?usp=email )
Change subject: erab_fsm: store UID, expose it via fetch_info/1
......................................................................
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/39115?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: erlang/osmo-s1gw
Gerrit-Branch: master
Gerrit-Change-Id: I63fbd1d3d3531a74b35c09345cec094c30d19356
Gerrit-Change-Number: 39115
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 12 Dec 2024 19:04:50 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes