- gerrit-log - lists.osmocom.org

[M] Change in ...osmo-s1gw[master]: s1ap_proxy: rework handle_ie/2 into handle_ie/3
by fixeria 13 Dec '24

13 Dec '24

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/39111?usp=email ) Change subject: s1ap_proxy: rework handle_ie/2 into handle_ie/3 ...................................................................... s1ap_proxy: rework handle_ie/2 into handle_ie/3 This patch prepares for a follow-up change adding E-RAB MODIFY REQ/RSP. Instead of passing the whole record #'ProtocolIE-Field' to handle_ie(), pass the IEI ('id' field) and IE content ('value' field) as separate arguments. This split-up allows to pass the full IEI path to handle_ie() in a follow-up change, and also allows to expand some fields of the IE content right in the function header. Change-Id: Ic71c8c07739b0e354ca9c9b03c000a366d8c2c43 --- M src/s1ap_proxy.erl 1 file changed, 58 insertions(+), 67 deletions(-) Approvals: pespin: Looks good to me, but someone else must approve laforge: Looks good to me, but someone else must approve Jenkins Builder: Verified fixeria: Looks good to me, approved diff --git a/src/s1ap_proxy.erl b/src/s1ap_proxy.erl index 5cacb59..4d78b29 100644 --- a/src/s1ap_proxy.erl +++ b/src/s1ap_proxy.erl @@ -60,7 +60,7 @@ -type s1ap_pdu() :: {initiatingMessage, #'InitiatingMessage'{}} | {successfulOutcome, #'SuccessfulOutcome'{}} | {unsuccessfulOutcome, #'UnsuccessfulOutcome'{}}. --type s1ap_ie() :: #'ProtocolIE-Field'{}. +-type s1ap_ie_id() :: non_neg_integer(). -type s1ap_ie_val() :: tuple(). -type mme_ue_id() :: 0..16#ffffffff. @@ -392,20 +392,23 @@ %% Handle a single IE (Information Element) -type handle_ie_result() :: {ok, s1ap_ie_val()} | {error, term()}. --spec handle_ie(s1ap_ie(), proxy_state()) -> {handle_ie_result(), proxy_state()}. +-spec handle_ie(IEI, C, S) -> Result + when IEI :: s1ap_ie_id(), + C :: s1ap_ie_val(), + S :: proxy_state(), + Result :: {handle_ie_result(), + proxy_state()}. %% E-RAB SETUP REQUEST related IEs -handle_ie(#'ProtocolIE-Field'{id = ?'id-E-RABToBeSetupListBearerSUReq', - value = Content}, S) -> +handle_ie(?'id-E-RABToBeSetupListBearerSUReq', C, S) -> %% This IE contains a list of BearerSUReq, so patch inner IEs - handle_ies(Content, ?'id-E-RABToBeSetupItemBearerSUReq', S); + handle_ies(C, ?'id-E-RABToBeSetupItemBearerSUReq', S); -handle_ie(#'ProtocolIE-Field'{id = ?'id-E-RABToBeSetupItemBearerSUReq', - value = C0}, S0) -> +handle_ie(?'id-E-RABToBeSetupItemBearerSUReq', + #'E-RABToBeSetupItemBearerSUReq'{'e-RAB-ID' = ERABId, + 'transportLayerAddress' = TLA_In, + 'gTP-TEID' = << TEID_In:32/big >>} = C0, S0) -> %% start and register an E-RAB FSM - #'E-RABToBeSetupItemBearerSUReq'{'e-RAB-ID' = ERABId, - 'transportLayerAddress' = TLA_In, - 'gTP-TEID' = << TEID_In:32/big >>} = C0, {Pid, S1} = erab_fsm_start_reg(ERABId, S0), case erab_fsm:erab_setup_req(Pid, {TEID_In, TLA_In}) of {ok, {TEID_Out, TLA_Out}} -> @@ -417,17 +420,15 @@ end; %% E-RAB SETUP RESPONSE related IEs -handle_ie(#'ProtocolIE-Field'{id = ?'id-E-RABSetupListBearerSURes', - value = Content}, S) -> +handle_ie(?'id-E-RABSetupListBearerSURes', C, S) -> %% This IE contains a list of BearerSURes, so patch inner IEs - handle_ies(Content, ?'id-E-RABSetupItemBearerSURes', S); + handle_ies(C, ?'id-E-RABSetupItemBearerSURes', S); -handle_ie(#'ProtocolIE-Field'{id = ?'id-E-RABSetupItemBearerSURes', - value = C0}, S) -> +handle_ie(?'id-E-RABSetupItemBearerSURes', + #'E-RABSetupItemBearerSURes'{'e-RAB-ID' = ERABId, + 'transportLayerAddress' = TLA_In, + 'gTP-TEID' = << TEID_In:32/big >>} = C0, S) -> %% poke E-RAB FSM - #'E-RABSetupItemBearerSURes'{'e-RAB-ID' = ERABId, - 'transportLayerAddress' = TLA_In, - 'gTP-TEID' = << TEID_In:32/big >>} = C0, case erab_fsm_find(ERABId, S) of {ok, Pid} -> case erab_fsm:erab_setup_rsp(Pid, {TEID_In, TLA_In}) of @@ -444,18 +445,17 @@ end; %% 9.1.3.5 E-RAB RELEASE COMMAND related IEs -handle_ie(#'ProtocolIE-Field'{id = ?'id-E-RABToBeReleasedList', - value = Content}, S) -> +handle_ie(?'id-E-RABToBeReleasedList', C, S) -> %% This IE contains a list of E-RABItem - handle_ies(Content, ?'id-E-RABItem', S); + handle_ies(C, ?'id-E-RABItem', S); -handle_ie(#'ProtocolIE-Field'{id = ?'id-E-RABItem', - value = C}, S) -> +handle_ie(?'id-E-RABItem', + #'E-RABItem'{'e-RAB-ID' = ERABId} = C, + #proxy_state{rel_kind = RelKind} = S) -> %% poke E-RAB FSM - #'E-RABItem'{'e-RAB-ID' = ERABId} = C, case erab_fsm_find(ERABId, S) of {ok, Pid} -> - ok = erab_fsm:erab_release(Pid, S#proxy_state.rel_kind), + ok = erab_fsm:erab_release(Pid, RelKind), {{ok, C}, S}; error -> ?LOG_ERROR("E-RAB ~p is not registered", [erab_uid(ERABId, S)]), @@ -463,15 +463,13 @@ end; %% 9.1.3.6 E-RAB RELEASE RESPONSE related IEs -handle_ie(#'ProtocolIE-Field'{id = ?'id-E-RABReleaseListBearerRelComp', - value = Content}, S) -> +handle_ie(?'id-E-RABReleaseListBearerRelComp', C, S) -> %% This IE contains a list of E-RABReleaseItemBearerRelComp - handle_ies(Content, ?'id-E-RABReleaseItemBearerRelComp', S); + handle_ies(C, ?'id-E-RABReleaseItemBearerRelComp', S); -handle_ie(#'ProtocolIE-Field'{id = ?'id-E-RABReleaseItemBearerRelComp', - value = C}, S) -> +handle_ie(?'id-E-RABReleaseItemBearerRelComp', + #'E-RABReleaseItemBearerRelComp'{'e-RAB-ID' = ERABId} = C, S) -> %% poke E-RAB FSM - #'E-RABReleaseItemBearerRelComp'{'e-RAB-ID' = ERABId} = C, case erab_fsm_find(ERABId, S) of {ok, Pid} -> ok = erab_fsm:erab_release_rsp(Pid), @@ -482,44 +480,39 @@ end; %% 9.1.3.7 E-RAB RELEASE INDICATION related IEs -handle_ie(#'ProtocolIE-Field'{id = ?'id-E-RABReleasedList', - value = Content}, S) -> +handle_ie(?'id-E-RABReleasedList', C, S) -> %% This IE contains a list of E-RABItem - handle_ies(Content, ?'id-E-RABItem', S); + handle_ies(C, ?'id-E-RABItem', S); %% E-RAB MODIFICATION INDICATION related IEs -handle_ie(#'ProtocolIE-Field'{id = ?'id-E-RABToBeModifiedListBearerModInd', - value = Content}, S) -> +handle_ie(?'id-E-RABToBeModifiedListBearerModInd', C, S) -> %% This IE contains a list of BearerModInd, so patch inner IEs - handle_ies(Content, ?'id-E-RABToBeModifiedItemBearerModInd', S); + handle_ies(C, ?'id-E-RABToBeModifiedItemBearerModInd', S); -handle_ie(#'ProtocolIE-Field'{id = ?'id-E-RABToBeModifiedItemBearerModInd', - value = C}, S) -> +handle_ie(?'id-E-RABToBeModifiedItemBearerModInd', + #'E-RABToBeModifiedItemBearerModInd'{} = C, S) -> %% TODO: find and poke an E-RAB FSM associated with this E-RAB {{ok, C}, S}; -handle_ie(#'ProtocolIE-Field'{id = ?'id-E-RABNotToBeModifiedListBearerModInd', - value = Content}, S) -> +handle_ie(?'id-E-RABNotToBeModifiedListBearerModInd', C, S) -> %% This IE contains a list of BearerModInd, so patch inner IEs - handle_ies(Content, ?'id-E-RABNotToBeModifiedItemBearerModInd', S); + handle_ies(C, ?'id-E-RABNotToBeModifiedItemBearerModInd', S); -handle_ie(#'ProtocolIE-Field'{id = ?'id-E-RABNotToBeModifiedItemBearerModInd', - value = C}, S) -> +handle_ie(?'id-E-RABNotToBeModifiedItemBearerModInd', + #'E-RABNotToBeModifiedItemBearerModInd'{} = C, S) -> %% TODO: find and poke an E-RAB FSM associated with this E-RAB {{ok, C}, S}; %% INITIAL CONTEXT SETUP REQUEST related IEs -handle_ie(#'ProtocolIE-Field'{id = ?'id-E-RABToBeSetupListCtxtSUReq', - value = Content}, S) -> +handle_ie(?'id-E-RABToBeSetupListCtxtSUReq', C, S) -> %% This IE contains a list of CtxtSUReq, so patch inner IEs - handle_ies(Content, ?'id-E-RABToBeSetupItemCtxtSUReq', S); + handle_ies(C, ?'id-E-RABToBeSetupItemCtxtSUReq', S); -handle_ie(#'ProtocolIE-Field'{id = ?'id-E-RABToBeSetupItemCtxtSUReq', - value = C0}, S0) -> +handle_ie(?'id-E-RABToBeSetupItemCtxtSUReq', + #'E-RABToBeSetupItemCtxtSUReq'{'e-RAB-ID' = ERABId, + 'transportLayerAddress' = TLA_In, + 'gTP-TEID' = << TEID_In:32/big >>} = C0, S0) -> %% start and register an E-RAB FSM - #'E-RABToBeSetupItemCtxtSUReq'{'e-RAB-ID' = ERABId, - 'transportLayerAddress' = TLA_In, - 'gTP-TEID' = << TEID_In:32/big >>} = C0, {Pid, S1} = erab_fsm_start_reg(ERABId, S0), case erab_fsm:erab_setup_req(Pid, {TEID_In, TLA_In}) of {ok, {TEID_Out, TLA_Out}} -> @@ -531,17 +524,15 @@ end; %% INITIAL CONTEXT SETUP RESPONSE related IEs -handle_ie(#'ProtocolIE-Field'{id = ?'id-E-RABSetupListCtxtSURes', - value = Content}, S) -> +handle_ie(?'id-E-RABSetupListCtxtSURes', C, S) -> %% This IE contains a list of CtxtSURes, so patch inner IEs - handle_ies(Content, ?'id-E-RABSetupItemCtxtSURes', S); + handle_ies(C, ?'id-E-RABSetupItemCtxtSURes', S); -handle_ie(#'ProtocolIE-Field'{id = ?'id-E-RABSetupItemCtxtSURes', - value = C0}, S) -> +handle_ie(?'id-E-RABSetupItemCtxtSURes', + #'E-RABSetupItemCtxtSURes'{'e-RAB-ID' = ERABId, + 'transportLayerAddress' = TLA_In, + 'gTP-TEID' = << TEID_In:32/big >>} = C0, S) -> %% poke E-RAB FSM - #'E-RABSetupItemCtxtSURes'{'e-RAB-ID' = ERABId, - 'transportLayerAddress' = TLA_In, - 'gTP-TEID' = << TEID_In:32/big >>} = C0, case erab_fsm_find(ERABId, S) of {ok, Pid} -> case erab_fsm:erab_setup_rsp(Pid, {TEID_In, TLA_In}) of @@ -558,8 +549,8 @@ end; %% Catch-all variant, which should not be called normally -handle_ie(#'ProtocolIE-Field'{} = IE, S) -> - ?LOG_ERROR("[BUG] Unhandled S1AP IE: ~p", [IE]), +handle_ie(IEI, C, S) -> + ?LOG_ERROR("[BUG] Unhandled S1AP IE: ~p, ~p", [IEI, C]), {{error, unhandled_ie}, S}. @@ -567,16 +558,16 @@ %% calling function handle_ie/1 for IEs matching the given IEI. %% Additionally look for {MME,eNB}-UE-S1AP-ID IEs and store their values. -type handle_ies_result() :: {ok, list()} | {error, term()}. --spec handle_ies(list(), integer(), proxy_state()) -> {handle_ies_result(), proxy_state()}. +-spec handle_ies(list(), s1ap_ie_id(), proxy_state()) -> {handle_ies_result(), proxy_state()}. handle_ies(IEs, IEI, S) -> handle_ies([], IEs, IEI, S). handle_ies(Acc, [IE | IEs], IEI, S0) -> case IE of - #'ProtocolIE-Field'{id = IEI} -> - case handle_ie(IE, S0) of - {{ok, C}, S1} -> - NewIE = IE#'ProtocolIE-Field'{value = C}, + #'ProtocolIE-Field'{id = IEI, value = C0} -> + case handle_ie(IEI, C0, S0) of + {{ok, C1}, S1} -> + NewIE = IE#'ProtocolIE-Field'{value = C1}, handle_ies([NewIE | Acc], IEs, IEI, S1); {{error, Reason}, S1} -> {{error, Reason}, S1} -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/39111?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: Ic71c8c07739b0e354ca9c9b03c000a366d8c2c43 Gerrit-Change-Number: 39111 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in ...osmo-s1gw[master]: erab_fsm: session_modify(): split PFCP PDU handling
by fixeria 13 Dec '24

13 Dec '24

fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/39124?usp=email ) Change subject: erab_fsm: session_modify(): split PFCP PDU handling ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/39124?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: I04fec627300fa9240e6b2bf22ff9ae08dd4c0f0d Gerrit-Change-Number: 39124 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 13 Dec 2024 07:25:15 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in ...osmo-s1gw[master]: erab_fsm: store UID, expose it via fetch_info/1
by fixeria 13 Dec '24

13 Dec '24

fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/39115?usp=email ) Change subject: erab_fsm: store UID, expose it via fetch_info/1 ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/39115?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: I63fbd1d3d3531a74b35c09345cec094c30d19356 Gerrit-Change-Number: 39115 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 13 Dec 2024 07:25:10 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in ...osmo-s1gw[master]: s1ap_proxy: handle_ies(): also handle #'ProtocolExtensionField'
by fixeria 13 Dec '24

13 Dec '24

fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/39114?usp=email ) Change subject: s1ap_proxy: handle_ies(): also handle #'ProtocolExtensionField' ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/39114?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: Ic1ed2c4662e82bd739c35f9179eaaec20c3cad98 Gerrit-Change-Number: 39114 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 13 Dec 2024 07:25:05 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in ...osmo-s1gw[master]: s1ap_proxy: handle_ies(): pass IEI path to handle_ie()
by fixeria 13 Dec '24

13 Dec '24

fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/39113?usp=email ) Change subject: s1ap_proxy: handle_ies(): pass IEI path to handle_ie() ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/39113?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: I35528a91f7dbf321ad1a0811f1bbcdfb529d3530 Gerrit-Change-Number: 39113 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 13 Dec 2024 07:25:01 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in ...osmo-s1gw[master]: s1ap_proxy: handle_ies(): reorder arguments
by fixeria 13 Dec '24

13 Dec '24

fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/39112?usp=email ) Change subject: s1ap_proxy: handle_ies(): reorder arguments ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/39112?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: Ic9c7257bef290a7f0c2546d4c1ca3b9d4aed20d2 Gerrit-Change-Number: 39112 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 13 Dec 2024 07:24:53 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in ...osmo-s1gw[master]: s1ap_proxy: rework handle_ie/2 into handle_ie/3
by fixeria 13 Dec '24

13 Dec '24

fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/39111?usp=email ) Change subject: s1ap_proxy: rework handle_ie/2 into handle_ie/3 ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/39111?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: Ic71c8c07739b0e354ca9c9b03c000a366d8c2c43 Gerrit-Change-Number: 39111 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 13 Dec 2024 07:24:49 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in ...osmo-s1gw[master]: erab_fsm: implement E-RAB MODIFY Req/Rsp procedure
by fixeria 13 Dec '24

13 Dec '24

Attention is currently required from: pespin. fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/39116?usp=email ) Change subject: erab_fsm: implement E-RAB MODIFY Req/Rsp procedure ...................................................................... Patch Set 3: (1 comment) File src/erab_fsm.erl: https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/39116/comment/c43f5d0a_b234… : PS3, Line 323: ok > probably easier to match upon return if you return {ok, undefined}? I don't see how returning dummy values makes things easier, sorry. This reply becomes a return value for `erab_modify_rsp/2`. It's documented that it can return either `ok` or `{error, ...}`. -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/39116?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: I24d57ea390d71b640cb42046a8658e9d30670682 Gerrit-Change-Number: 39116 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 13 Dec 2024 07:21:36 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in osmo-bsc[master]: Use correct bts_nr field during MO init
by fixeria 13 Dec '24

13 Dec '24

Attention is currently required from: pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-bsc/+/39139?usp=email ) Change subject: Use correct bts_nr field during MO init ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/39139?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I8a70c61cef74c0febeefae88dee575fbb4936d3e Gerrit-Change-Number: 39139 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 13 Dec 2024 06:08:41 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in osmo-remsim[master]: bankd: Add -T and -e cmdline params
by laforge 12 Dec '24

12 Dec '24

Attention is currently required from: osmith, pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-remsim/+/39134?usp=email ) Change subject: bankd: Add -T and -e cmdline params ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/39134?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I2c33c667be77578699f4a5fb70c8b74c67f6e2cf Gerrit-Change-Number: 39134 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 12 Dec 2024 20:35:53 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

2026

2025

2024

2023

2022

gerrit-log