- gerrit-log - lists.osmocom.org

[XS] Change in dahdi-linux[master]: dahdi-base: Allow reselection of the same clock master
by tnt 17 Dec '24

17 Dec '24

tnt has submitted this change. ( https://gerrit.osmocom.org/c/dahdi-linux/+/39154?usp=email ) Change subject: dahdi-base: Allow reselection of the same clock master ...................................................................... dahdi-base: Allow reselection of the same clock master __dahdi_find_master_span is called from a bunch of different places, like when a span comes on-line, this is to potentially select a new master. However the way it's written now, when it's called, it will ALWAYS tried to find a DIFFERENT master than what is selected now if there is another available, no matter is the current one is earlier in the list. Change-Id: Ibe2365953c5ac7f3dcc7c10526b9eb797ea320ee Signed-off-by: Sylvain Munaut <tnt(a)246tNt.com> --- M drivers/dahdi/dahdi-base.c 1 file changed, 0 insertions(+), 2 deletions(-) Approvals: laforge: Looks good to me, but someone else must approve pespin: Looks good to me, but someone else must approve tnt: Looks good to me, approved; Verified diff --git a/drivers/dahdi/dahdi-base.c b/drivers/dahdi/dahdi-base.c index ef29c4b..43948bd 100644 --- a/drivers/dahdi/dahdi-base.c +++ b/drivers/dahdi/dahdi-base.c @@ -3995,8 +3995,6 @@ continue; if (!can_provide_timing(s)) continue; - if (master_span == s) - continue; master_span = s; break; -- To view, visit https://gerrit.osmocom.org/c/dahdi-linux/+/39154?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: dahdi-linux Gerrit-Branch: master Gerrit-Change-Id: Ibe2365953c5ac7f3dcc7c10526b9eb797ea320ee Gerrit-Change-Number: 39154 Gerrit-PatchSet: 1 Gerrit-Owner: tnt <tnt(a)246tNt.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: tnt <tnt(a)246tNt.com>

1 0

[XS] Change in dahdi-linux[master]: dahdi-base: Allow reselection of the same clock master
by tnt 17 Dec '24

17 Dec '24

tnt has posted comments on this change by tnt. ( https://gerrit.osmocom.org/c/dahdi-linux/+/39154?usp=email ) Change subject: dahdi-base: Allow reselection of the same clock master ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/dahdi-linux/+/39154?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: dahdi-linux Gerrit-Branch: master Gerrit-Change-Id: Ibe2365953c5ac7f3dcc7c10526b9eb797ea320ee Gerrit-Change-Number: 39154 Gerrit-PatchSet: 1 Gerrit-Owner: tnt <tnt(a)246tNt.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: tnt <tnt(a)246tNt.com> Gerrit-Comment-Date: Tue, 17 Dec 2024 11:36:04 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in dahdi-linux[master]: dahdi-base: Allow reselection of the same clock master
by tnt 17 Dec '24

17 Dec '24

tnt has posted comments on this change by tnt. ( https://gerrit.osmocom.org/c/dahdi-linux/+/39154?usp=email ) Change subject: dahdi-base: Allow reselection of the same clock master ...................................................................... Patch Set 1: Verified+1 -- To view, visit https://gerrit.osmocom.org/c/dahdi-linux/+/39154?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: dahdi-linux Gerrit-Branch: master Gerrit-Change-Id: Ibe2365953c5ac7f3dcc7c10526b9eb797ea320ee Gerrit-Change-Number: 39154 Gerrit-PatchSet: 1 Gerrit-Owner: tnt <tnt(a)246tNt.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: tnt <tnt(a)246tNt.com> Gerrit-Comment-Date: Tue, 17 Dec 2024 11:36:02 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in dahdi-linux[master]: dahdi-base: Allow reselection of the same clock master
by tnt 17 Dec '24

17 Dec '24

Attention is currently required from: tnt. tnt has removed a vote from this change. ( https://gerrit.osmocom.org/c/dahdi-linux/+/39154?usp=email ) Change subject: dahdi-base: Allow reselection of the same clock master ...................................................................... Removed Verified-1 by Jenkins Builder (1000002) -- To view, visit https://gerrit.osmocom.org/c/dahdi-linux/+/39154?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: deleteVote Gerrit-Project: dahdi-linux Gerrit-Branch: master Gerrit-Change-Id: Ibe2365953c5ac7f3dcc7c10526b9eb797ea320ee Gerrit-Change-Number: 39154 Gerrit-PatchSet: 1 Gerrit-Owner: tnt <tnt(a)246tNt.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: tnt <tnt(a)246tNt.com>

1 0

[XS] Change in dahdi-linux[master]: voicebus: Don't check BAR0 is an IO resource
by tnt 17 Dec '24

17 Dec '24

tnt has posted comments on this change by tnt. ( https://gerrit.osmocom.org/c/dahdi-linux/+/39153?usp=email ) Change subject: voicebus: Don't check BAR0 is an IO resource ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/dahdi-linux/+/39153?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: dahdi-linux Gerrit-Branch: master Gerrit-Change-Id: I3c6fe1664e8dc3f158c64d16640b912fa5a4d12e Gerrit-Change-Number: 39153 Gerrit-PatchSet: 1 Gerrit-Owner: tnt <tnt(a)246tNt.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: tnt <tnt(a)246tNt.com> Gerrit-Comment-Date: Tue, 17 Dec 2024 11:35:52 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in dahdi-linux[master]: voicebus: Don't check BAR0 is an IO resource
by tnt 17 Dec '24

17 Dec '24

tnt has removed a vote from this change. ( https://gerrit.osmocom.org/c/dahdi-linux/+/39153?usp=email ) Change subject: voicebus: Don't check BAR0 is an IO resource ...................................................................... Removed Verified-1 by Jenkins Builder (1000002) -- To view, visit https://gerrit.osmocom.org/c/dahdi-linux/+/39153?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: deleteVote Gerrit-Project: dahdi-linux Gerrit-Branch: master Gerrit-Change-Id: I3c6fe1664e8dc3f158c64d16640b912fa5a4d12e Gerrit-Change-Number: 39153 Gerrit-PatchSet: 1 Gerrit-Owner: tnt <tnt(a)246tNt.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: tnt <tnt(a)246tNt.com>

1 0

[XS] Change in dahdi-linux[master]: voicebus: Don't check BAR0 is an IO resource
by tnt 17 Dec '24

17 Dec '24

tnt has posted comments on this change by tnt. ( https://gerrit.osmocom.org/c/dahdi-linux/+/39153?usp=email ) Change subject: voicebus: Don't check BAR0 is an IO resource ...................................................................... Patch Set 1: Verified+1 -- To view, visit https://gerrit.osmocom.org/c/dahdi-linux/+/39153?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: dahdi-linux Gerrit-Branch: master Gerrit-Change-Id: I3c6fe1664e8dc3f158c64d16640b912fa5a4d12e Gerrit-Change-Number: 39153 Gerrit-PatchSet: 1 Gerrit-Owner: tnt <tnt(a)246tNt.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: tnt <tnt(a)246tNt.com> Gerrit-Comment-Date: Tue, 17 Dec 2024 11:35:40 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in dahdi-linux[master]: Misc warning/build fixes for more recent kernels
by tnt 17 Dec '24

17 Dec '24

Attention is currently required from: tnt. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/dahdi-linux/+/39159?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Verified-1 by Jenkins Builder Change subject: Misc warning/build fixes for more recent kernels ...................................................................... Misc warning/build fixes for more recent kernels Change-Id: I54e89040dfc6e21d23f620df407b6613397f7e45 Signed-off-by: Sylvain Munaut <tnt(a)246tNt.com> --- M drivers/dahdi/dahdi-base.c M drivers/dahdi/dahdi_dynamic_ethmf.c M drivers/dahdi/wcaxx-base.c M drivers/dahdi/wct4xxp/base.c M drivers/dahdi/wctdm24xxp/base.c M drivers/dahdi/wcte13xp-base.c M drivers/dahdi/wcte43x-base.c M drivers/dahdi/xpp/xbus-core.c 8 files changed, 15 insertions(+), 22 deletions(-) git pull ssh://gerrit.osmocom.org:29418/dahdi-linux refs/changes/59/39159/3 -- To view, visit https://gerrit.osmocom.org/c/dahdi-linux/+/39159?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: dahdi-linux Gerrit-Branch: master Gerrit-Change-Id: I54e89040dfc6e21d23f620df407b6613397f7e45 Gerrit-Change-Number: 39159 Gerrit-PatchSet: 3 Gerrit-Owner: tnt <tnt(a)246tNt.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: tnt <tnt(a)246tNt.com>

1 0

[S] Change in dahdi-linux[master]: Misc warning/build fixes for more recent kernels
by tnt 17 Dec '24

17 Dec '24

Attention is currently required from: tnt. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/dahdi-linux/+/39159?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified-1 by Jenkins Builder Change subject: Misc warning/build fixes for more recent kernels ...................................................................... Misc warning/build fixes for more recent kernels Change-Id: I54e89040dfc6e21d23f620df407b6613397f7e45 Signed-off-by: Sylvain Munaut <tnt(a)246tNt.com> --- M drivers/dahdi/dahdi-base.c M drivers/dahdi/wct4xxp/base.c M drivers/dahdi/wctdm24xxp/base.c M drivers/dahdi/xpp/xbus-core.c 4 files changed, 9 insertions(+), 14 deletions(-) git pull ssh://gerrit.osmocom.org:29418/dahdi-linux refs/changes/59/39159/2 -- To view, visit https://gerrit.osmocom.org/c/dahdi-linux/+/39159?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: dahdi-linux Gerrit-Branch: master Gerrit-Change-Id: I54e89040dfc6e21d23f620df407b6613397f7e45 Gerrit-Change-Number: 39159 Gerrit-PatchSet: 2 Gerrit-Owner: tnt <tnt(a)246tNt.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: tnt <tnt(a)246tNt.com>

1 0

[XS] Change in dahdi-linux[master]: Misc warning/build fixes for more recent kernels
by tnt 17 Dec '24

17 Dec '24

tnt has uploaded this change for review. ( https://gerrit.osmocom.org/c/dahdi-linux/+/39159?usp=email ) Change subject: Misc warning/build fixes for more recent kernels ...................................................................... Misc warning/build fixes for more recent kernels Change-Id: I54e89040dfc6e21d23f620df407b6613397f7e45 Signed-off-by: Sylvain Munaut <tnt(a)246tNt.com> --- M drivers/dahdi/wctdm24xxp/base.c M drivers/dahdi/xpp/xbus-core.c 2 files changed, 4 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/dahdi-linux refs/changes/59/39159/1 diff --git a/drivers/dahdi/wctdm24xxp/base.c b/drivers/dahdi/wctdm24xxp/base.c index 9725d3c..ba328aa 100644 --- a/drivers/dahdi/wctdm24xxp/base.c +++ b/drivers/dahdi/wctdm24xxp/base.c @@ -1501,16 +1501,16 @@ unsigned char data = 0; int count = 0; - #define MAX 10 /* attempts */ + #define MAX_ATTEMPTS 10 /* Wait for indirect access */ - while (count++ < MAX) { + while (count++ < MAX_ATTEMPTS) { data = wctdm_getreg(wc, mod, I_STATUS); if (!data) return 0; } - if (count > (MAX-1)) { + if (count > (MAX_ATTEMPTS-1)) { dev_notice(&wc->vb.pdev->dev, " ##### Loop error (%02x) #####\n", data); } diff --git a/drivers/dahdi/xpp/xbus-core.c b/drivers/dahdi/xpp/xbus-core.c index e08e2d6..141c54f 100644 --- a/drivers/dahdi/xpp/xbus-core.c +++ b/drivers/dahdi/xpp/xbus-core.c @@ -113,7 +113,7 @@ { if (!xbus) return -ENOENT; - if (xbus->label && *(xbus->label)) { + if (xbus->label[0]) { xbus_t *xbus_old; XBUS_DBG(DEVICES, xbus, "Checking LABEL='%s'\n", xbus->label); -- To view, visit https://gerrit.osmocom.org/c/dahdi-linux/+/39159?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: dahdi-linux Gerrit-Branch: master Gerrit-Change-Id: I54e89040dfc6e21d23f620df407b6613397f7e45 Gerrit-Change-Number: 39159 Gerrit-PatchSet: 1 Gerrit-Owner: tnt <tnt(a)246tNt.com>

1 0

2026

2025

2024

2023

2022

gerrit-log