- gerrit-log - lists.osmocom.org

[S] Change in osmo-ci[master]: jobs/ttcn3-testsuites: adjust timer for bts
by osmith 17 Dec '24

17 Dec '24

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/39155?usp=email ) Change subject: jobs/ttcn3-testsuites: adjust timer for bts ...................................................................... jobs/ttcn3-testsuites: adjust timer for bts BTS testsuites tend to fail with timeouts on heavy loads. Group them in a timeslot where jenkins nodes are otherwise not busy according to stats in grafana to hopefully make the test results more stable. Once we can replace faketrx with a rewrite (OS#6672), this should not be necessary anymore. Change-Id: If25009a5b9215a0f51381529e26bfb3ba2303ae2 --- M jobs/ttcn3-testsuites.yml 1 file changed, 15 insertions(+), 9 deletions(-) Approvals: pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified fixeria: Looks good to me, approved diff --git a/jobs/ttcn3-testsuites.yml b/jobs/ttcn3-testsuites.yml index 92b7e6d..5d44718 100644 --- a/jobs/ttcn3-testsuites.yml +++ b/jobs/ttcn3-testsuites.yml @@ -26,8 +26,6 @@ timer: H 03 * * * - nplab-sua-test: # ~1 min timer: H 03 * * * - - ttcn3-bts-test: # ~135 min - timer: H 03 * * * - ttcn3-remsim-test: # ~6 min timer: H 03 * * * - ttcn3-sccp-test: # ~2 min @@ -68,8 +66,6 @@ timer: H 04 * * * - ttcn3-msc-test-latest: # ~35 min timer: H 04 * * * - - ttcn3-bts-test-latest: # ~135 min - timer: H 05 * * * - ttcn3-remsim-test-latest: # ~6 min timer: H 05 * * * - ttcn3-sccp-test-latest: # ~2 min @@ -96,15 +92,25 @@ # With LIBOSMO_IO_BACKEND=IO_URING (OS#6357) - ttcn3-msc-test-io_uring: # ~35 min - timer: H 06 * * * + timer: H 05 * * * - ttcn3-gbproxy-test-io_uring: # ~15 min - timer: H 06 * * * + timer: H 05 * * * + + # BTS testsuites tend to fail with timeouts on heavy loads. Group them + # here in a timeslot where jenkins nodes are otherwise not busy according + # to stats in grafana to hopefully make the test results more stable. + # Once we can replace faketrx with a rewrite (OS#6672), this should not + # be necessary anymore. - ttcn3-bts-test-io_uring: # ~135 min - timer: H 06 * * * + timer: 0 06 * * * + - ttcn3-bts-test: # ~135 min + timer: 0 06 * * * + - ttcn3-bts-test-latest: # ~135 min + timer: 0 06 * * * + - ttcn3-bts-test-asan: # ~135 min + timer: 0 06 * * * # With sanitizer (OS#5301) - - ttcn3-bts-test-asan: # ~135 min - timer: H 07 * * * - ttcn3-gbproxy-test-asan: # ~15 min timer: H 07 * * * - ttcn3-msc-test-asan: # ~35 min -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/39155?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: If25009a5b9215a0f51381529e26bfb3ba2303ae2 Gerrit-Change-Number: 39155 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in osmo-ci[master]: jobs/ttcn3-testsuites: adjust timer for bts
by fixeria 17 Dec '24

17 Dec '24

Attention is currently required from: osmith. fixeria has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ci/+/39155?usp=email ) Change subject: jobs/ttcn3-testsuites: adjust timer for bts ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/39155?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: If25009a5b9215a0f51381529e26bfb3ba2303ae2 Gerrit-Change-Number: 39155 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Tue, 17 Dec 2024 14:00:35 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in osmo-upf[master]: upf_gtp: automatically delete old gtp devices
by pespin 17 Dec '24

17 Dec '24

Attention is currently required from: osmith. pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-upf/+/39161?usp=email ) Change subject: upf_gtp: automatically delete old gtp devices ...................................................................... Patch Set 2: Code-Review+1 (1 comment) File src/osmo-upf/upf_gtp.c: https://gerrit.osmocom.org/c/osmo-upf/+/39161/comment/b7d436f1_c1c27e69?usp… : PS2, Line 181: static int dev_gtp_create(struct upf_gtp_dev *dev, int gtp0_fd, int gtp1_fd) upf_gtp_dev_create? -- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/39161?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: I7bb5c1ed51f4e05964688ee77b8de77fd3c0f345 Gerrit-Change-Number: 39161 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Tue, 17 Dec 2024 13:32:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[XS] Change in libgtpnl[master]: dev_create: support returning -EEXIST
by pespin 17 Dec '24

17 Dec '24

Attention is currently required from: osmith. pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/libgtpnl/+/39160?usp=email ) Change subject: dev_create: support returning -EEXIST ...................................................................... Patch Set 1: Code-Review+1 (1 comment) File src/gtp-rtnl.c: https://gerrit.osmocom.org/c/libgtpnl/+/39160/comment/114d720c_0846d28b?usp… : PS1, Line 149: if (rc < 0 && errno == EEXIST) why not doing this for any kind of error returned from netlink? -- To view, visit https://gerrit.osmocom.org/c/libgtpnl/+/39160?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libgtpnl Gerrit-Branch: master Gerrit-Change-Id: Ib99bd8eed854014a5c9118c23e4058a41f3145f2 Gerrit-Change-Number: 39160 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Tue, 17 Dec 2024 13:29:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[S] Change in osmo-upf[master]: upf_gtp: automatically delete old gtp devices
by laforge 17 Dec '24

17 Dec '24

Attention is currently required from: osmith. laforge has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-upf/+/39161?usp=email ) Change subject: upf_gtp: automatically delete old gtp devices ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/39161?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: I7bb5c1ed51f4e05964688ee77b8de77fd3c0f345 Gerrit-Change-Number: 39161 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Tue, 17 Dec 2024 13:22:22 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in libgtpnl[master]: dev_create: support returning -EEXIST
by laforge 17 Dec '24

17 Dec '24

Attention is currently required from: osmith. laforge has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/libgtpnl/+/39160?usp=email ) Change subject: dev_create: support returning -EEXIST ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libgtpnl/+/39160?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libgtpnl Gerrit-Branch: master Gerrit-Change-Id: Ib99bd8eed854014a5c9118c23e4058a41f3145f2 Gerrit-Change-Number: 39160 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Tue, 17 Dec 2024 13:21:55 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in osmo-upf[master]: upf_gtp: automatically delete old gtp devices
by osmith 17 Dec '24

17 Dec '24

osmith has uploaded a new patch set (#2). ( https://gerrit.osmocom.org/c/osmo-upf/+/39161?usp=email ) Change subject: upf_gtp: automatically delete old gtp devices ...................................................................... upf_gtp: automatically delete old gtp devices If osmo-upf crashes without running the destructor, we may have a leftover gtp device. This can be simulated with "killall -9 osmo-upf". Clean it up automatically. Related: SYS#7240 Depends: libgtpnl Ib99bd8eed854014a5c9118c23e4058a41f3145f2 Change-Id: I7bb5c1ed51f4e05964688ee77b8de77fd3c0f345 --- M src/osmo-upf/upf_gtp.c 1 file changed, 14 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-upf refs/changes/61/39161/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/39161?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: I7bb5c1ed51f4e05964688ee77b8de77fd3c0f345 Gerrit-Change-Number: 39161 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de>

1 0

[S] Change in osmo-upf[master]: upf_gtp: automatically clean old gtp devices
by osmith 17 Dec '24

17 Dec '24

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-upf/+/39161?usp=email ) Change subject: upf_gtp: automatically clean old gtp devices ...................................................................... upf_gtp: automatically clean old gtp devices If osmo-upf crashes without running the destructor, we may have a leftover gtp device. This can be simulated with "killall -9 osmo-upf". Clean it up automatically. Related: SYS#7240 Depends: libgtpnl Ib99bd8eed854014a5c9118c23e4058a41f3145f2 Change-Id: I7bb5c1ed51f4e05964688ee77b8de77fd3c0f345 --- M src/osmo-upf/upf_gtp.c 1 file changed, 14 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-upf refs/changes/61/39161/1 diff --git a/src/osmo-upf/upf_gtp.c b/src/osmo-upf/upf_gtp.c index e2c6d07..78acd47 100644 --- a/src/osmo-upf/upf_gtp.c +++ b/src/osmo-upf/upf_gtp.c @@ -178,6 +178,13 @@ return 0; } +static int dev_gtp_create(struct upf_gtp_dev *dev, int gtp0_fd, int gtp1_fd) +{ + if (dev->sgsn_mode) + return gtp_dev_create_sgsn(-1, dev->name, gtp0_fd, gtp1_fd); + return gtp_dev_create(-1, dev->name, gtp0_fd, gtp1_fd); +} + int upf_gtp_dev_open(const char *name, bool create_gtp_dev, const char *local_addr, bool listen_for_gtpv0, bool sgsn_mode) { const struct osmo_sockaddr any = { @@ -235,10 +242,13 @@ if (create_gtp_dev) { int gtp0_fd = listen_for_gtpv0 ? dev->gtpv0.ofd.fd : -1; int gtp1_fd = dev->gtpv1.ofd.fd; - if (dev->sgsn_mode) - rc = gtp_dev_create_sgsn(-1, dev->name, gtp0_fd, gtp1_fd); - else - rc = gtp_dev_create(-1, dev->name, gtp0_fd, gtp1_fd); + + rc = dev_gtp_create(dev, gtp0_fd, gtp1_fd); + if (rc == -EEXIST && gtp_dev_destroy(dev->name) == 0) { + LOG_GTP_DEV(dev, LOGL_ERROR, "deleted GTP device from unclean shutdown\n"); + rc = dev_gtp_create(dev, gtp0_fd, gtp1_fd); + } + if (rc < 0) { LOG_GTP_DEV(dev, LOGL_ERROR, "Cannot create GTP device: rc=%d\n", rc); /* name = NULL: signal to the destructor that it does not need to delete the device */ -- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/39161?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: I7bb5c1ed51f4e05964688ee77b8de77fd3c0f345 Gerrit-Change-Number: 39161 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de>

1 0

[XS] Change in libgtpnl[master]: dev_create: support returning -EEXIST
by osmith 17 Dec '24

17 Dec '24

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/libgtpnl/+/39160?usp=email ) Change subject: dev_create: support returning -EEXIST ...................................................................... dev_create: support returning -EEXIST Check if netlink has set errno to EEXIST and return -EEXIST in gtp_dev_create() and gtp_dev_create_sgsn(). Users of the function can use this to delete the GTP device and try creating it again. Related: SYS#7240 Change-Id: Ib99bd8eed854014a5c9118c23e4058a41f3145f2 --- M src/gtp-rtnl.c 1 file changed, 7 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libgtpnl refs/changes/60/39160/1 diff --git a/src/gtp-rtnl.c b/src/gtp-rtnl.c index e0db921..b43d9d6 100644 --- a/src/gtp-rtnl.c +++ b/src/gtp-rtnl.c @@ -25,6 +25,7 @@ #include <unistd.h> #include <string.h> #include <time.h> +#include <errno.h> #include <libmnl/libmnl.h> #include <net/if.h> @@ -143,7 +144,12 @@ EXPORT_SYMBOL(gtp_dev_create); int gtp_dev_create(int dest_ns, const char *gtp_ifname, int fd0, int fd1) { - return _gtp_dev_create(dest_ns, gtp_ifname, fd0, fd1, GTP_ROLE_GGSN); + int rc = _gtp_dev_create(dest_ns, gtp_ifname, fd0, fd1, GTP_ROLE_GGSN); + + if (rc < 0 && errno == EEXIST) + return -EEXIST; + + return rc; } EXPORT_SYMBOL(gtp_dev_create_sgsn); -- To view, visit https://gerrit.osmocom.org/c/libgtpnl/+/39160?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libgtpnl Gerrit-Branch: master Gerrit-Change-Id: Ib99bd8eed854014a5c9118c23e4058a41f3145f2 Gerrit-Change-Number: 39160 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de>

1 0

[XS] Change in dahdi-linux[master]: voicebus: Don't check BAR0 is an IO resource
by tnt 17 Dec '24

17 Dec '24

tnt has submitted this change. ( https://gerrit.osmocom.org/c/dahdi-linux/+/39153?usp=email ) Change subject: voicebus: Don't check BAR0 is an IO resource ...................................................................... voicebus: Don't check BAR0 is an IO resource BAR0 isn't actually _used_ by anything, all commnication goes through BAR1 which is MMIO. So that check just prevents it to work on devices that don't support IO transactions at all (like RPi5) but for no good reason. Change-Id: I3c6fe1664e8dc3f158c64d16640b912fa5a4d12e Signed-off-by: Sylvain Munaut <tnt(a)246tNt.com> --- M drivers/dahdi/voicebus/voicebus.c 1 file changed, 0 insertions(+), 5 deletions(-) Approvals: laforge: Looks good to me, but someone else must approve tnt: Looks good to me, approved; Verified pespin: Looks good to me, but someone else must approve diff --git a/drivers/dahdi/voicebus/voicebus.c b/drivers/dahdi/voicebus/voicebus.c index 8a1f7a6..eb110ea 100644 --- a/drivers/dahdi/voicebus/voicebus.c +++ b/drivers/dahdi/voicebus/voicebus.c @@ -1794,11 +1794,6 @@ goto cleanup; } - if (0 == (pci_resource_flags(vb->pdev, 0)&IORESOURCE_IO)) { - dev_err(&vb->pdev->dev, "BAR0 is not IO Memory.\n"); - retval = -EIO; - goto cleanup; - } vb->iobase = pci_iomap(vb->pdev, 1, 0); if (request_mem_region(pci_resource_start(vb->pdev, 1), pci_resource_len(vb->pdev, 1), -- To view, visit https://gerrit.osmocom.org/c/dahdi-linux/+/39153?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: dahdi-linux Gerrit-Branch: master Gerrit-Change-Id: I3c6fe1664e8dc3f158c64d16640b912fa5a4d12e Gerrit-Change-Number: 39153 Gerrit-PatchSet: 1 Gerrit-Owner: tnt <tnt(a)246tNt.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: tnt <tnt(a)246tNt.com>

1 0

2026

2025

2024

2023

2022

gerrit-log