- gerrit-log - lists.osmocom.org

[M] Change in osmo-bsc[master]: nokia_site: add missing element names
by laforge 08 Jan '25

08 Jan '25

Attention is currently required from: csaba.sipos. laforge has posted comments on this change by csaba.sipos. ( https://gerrit.osmocom.org/c/osmo-bsc/+/39252?usp=email ) Change subject: nokia_site: add missing element names ...................................................................... Patch Set 1: (1 comment) File src/osmo-bsc/bts_nokia_site.c: https://gerrit.osmocom.org/c/osmo-bsc/+/39252/comment/7b036e4b_06899d15?usp… : PS1, Line 551: if you're changing the original "If" to "if". This makes it inconsistent with another parameters where the Abis interface is abbreviated "Abis If": 0xE3 I guess this was unintentional? I don't really care if it's capitalized or not - I just care about consistency. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/39252?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ia4026bbe458817e164b756847229cf6a90d02865 Gerrit-Change-Number: 39252 Gerrit-PatchSet: 1 Gerrit-Owner: csaba.sipos <metro4(a)freemail.hu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: csaba.sipos <metro4(a)freemail.hu> Gerrit-Comment-Date: Wed, 08 Jan 2025 11:06:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[S] Change in osmo-bsc[master]: nokia_site: add some missing message IDs
by laforge 08 Jan '25

08 Jan '25

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/39251?usp=email ) Change subject: nokia_site: add some missing message IDs ...................................................................... nokia_site: add some missing message IDs Change-Id: I2ecd2ac285493352a9b121b09bf6a3a560e14c6c Signed-off-by: csaba.sipos <metro4(a)freemail.hu> --- M src/osmo-bsc/bts_nokia_site.c 1 file changed, 15 insertions(+), 0 deletions(-) Approvals: pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/src/osmo-bsc/bts_nokia_site.c b/src/osmo-bsc/bts_nokia_site.c index dc8ff14..dad61ae 100644 --- a/src/osmo-bsc/bts_nokia_site.c +++ b/src/osmo-bsc/bts_nokia_site.c @@ -217,6 +217,7 @@ /* TODO: put in a separate file ? */ static const struct value_string nokia_msgt_name[] = { + { 0x7F, "NOKIA_BTS_RSSI_VSWR_COUNTERS_REQ" }, { 0x80, "NOKIA_BTS_CONF_DATA" }, { 0x81, "NOKIA_BTS_ACK" }, { 0x82, "NOKIA_BTS_OMU_STARTED" }, @@ -275,6 +276,20 @@ { 0xB7, "NOKIA_BTS_LCS_ANSWER" }, { 0xB8, "NOKIA_BTS_LMU_FN_OFFSET_COMMAND" }, { 0xB9, "NOKIA_BTS_LMU_FN_OFFSET_ANSWER" }, + { 0xBA, "NOKIA_BTS_LAPD_CTR_REP" }, + { 0xBB, "NOKIA_BTS_TRX_CONFIGURATION_UPDATE" }, + { 0xBC, "NOKIA_BTS_DYNAMIC_LOAD_INFO" }, + { 0xBD, "NOKIA_BTS_CONF_DATA_BS2" }, + { 0xBE, "NOKIA_BTS_REGISTRY_REQ" }, + { 0xBF, "NOKIA_BTS_SFS_UPLOAD_REQ" }, + { 0xC0, "NOKIA_BTS_DELAY_MEAS_REQ" }, + { 0xC1, "NOKIA_BTS_DELAY_MEAS_ACK" }, + { 0xC2, "NOKIA_BTS_PABIS_MEAS_REQ" }, + { 0xC3, "NOKIA_BTS_PABIS_MEAS_ACK" }, + { 0xC4, "NOKIA_BSC_RESET_INFO" }, + { 0xC5, "NOKIA_BSC_RESET_COMPL" }, + { 0xC6, "NOKIA_BSC_RESET_COMPL_ANSWER" }, + { 0xC7, "NOKIA_BTS_RSSI_VSWR_COUNTERS" }, { 0, NULL } }; -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/39251?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I2ecd2ac285493352a9b121b09bf6a3a560e14c6c Gerrit-Change-Number: 39251 Gerrit-PatchSet: 2 Gerrit-Owner: csaba.sipos <metro4(a)freemail.hu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in osmo-bsc[master]: nokia_site: add some missing message IDs
by laforge 08 Jan '25

08 Jan '25

Attention is currently required from: csaba.sipos. laforge has posted comments on this change by csaba.sipos. ( https://gerrit.osmocom.org/c/osmo-bsc/+/39251?usp=email ) Change subject: nokia_site: add some missing message IDs ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/39251?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I2ecd2ac285493352a9b121b09bf6a3a560e14c6c Gerrit-Change-Number: 39251 Gerrit-PatchSet: 2 Gerrit-Owner: csaba.sipos <metro4(a)freemail.hu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: csaba.sipos <metro4(a)freemail.hu> Gerrit-Comment-Date: Wed, 08 Jan 2025 11:04:40 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in osmo-bsc[master]: nokia_site: add missing element names
by pespin 08 Jan '25

08 Jan '25

Attention is currently required from: csaba.sipos. pespin has posted comments on this change by csaba.sipos. ( https://gerrit.osmocom.org/c/osmo-bsc/+/39252?usp=email ) Change subject: nokia_site: add missing element names ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/39252?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ia4026bbe458817e164b756847229cf6a90d02865 Gerrit-Change-Number: 39252 Gerrit-PatchSet: 1 Gerrit-Owner: csaba.sipos <metro4(a)freemail.hu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: csaba.sipos <metro4(a)freemail.hu> Gerrit-Comment-Date: Wed, 08 Jan 2025 10:38:25 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in osmo-bsc[master]: nokia_site: add some missing message IDs
by pespin 08 Jan '25

08 Jan '25

Attention is currently required from: csaba.sipos, laforge. pespin has posted comments on this change by csaba.sipos. ( https://gerrit.osmocom.org/c/osmo-bsc/+/39251?usp=email ) Change subject: nokia_site: add some missing message IDs ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/39251?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I2ecd2ac285493352a9b121b09bf6a3a560e14c6c Gerrit-Change-Number: 39251 Gerrit-PatchSet: 2 Gerrit-Owner: csaba.sipos <metro4(a)freemail.hu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: csaba.sipos <metro4(a)freemail.hu> Gerrit-Comment-Date: Wed, 08 Jan 2025 10:37:36 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in osmo-bsc[master]: nokia_site: add some missing message IDs
by csaba.sipos 08 Jan '25

08 Jan '25

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bsc/+/39251?usp=email to look at the new patch set (#2). Change subject: nokia_site: add some missing message IDs ...................................................................... nokia_site: add some missing message IDs Change-Id: I2ecd2ac285493352a9b121b09bf6a3a560e14c6c Signed-off-by: csaba.sipos <metro4(a)freemail.hu> --- M src/osmo-bsc/bts_nokia_site.c 1 file changed, 15 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/51/39251/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/39251?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I2ecd2ac285493352a9b121b09bf6a3a560e14c6c Gerrit-Change-Number: 39251 Gerrit-PatchSet: 2 Gerrit-Owner: csaba.sipos <metro4(a)freemail.hu> Gerrit-Reviewer: Jenkins Builder

1 0

[M] Change in osmo-bsc[master]: nokia_site: add missing element names
by csaba.sipos 08 Jan '25

08 Jan '25

csaba.sipos has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/39252?usp=email ) Change subject: nokia_site: add missing element names ...................................................................... nokia_site: add missing element names Change-Id: Ia4026bbe458817e164b756847229cf6a90d02865 Signed-off-by: csaba.sipos <metro4(a)freemail.hu> --- M src/osmo-bsc/bts_nokia_site.c 1 file changed, 82 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/52/39252/1 diff --git a/src/osmo-bsc/bts_nokia_site.c b/src/osmo-bsc/bts_nokia_site.c index dad61ae..b54142a 100644 --- a/src/osmo-bsc/bts_nokia_site.c +++ b/src/osmo-bsc/bts_nokia_site.c @@ -471,7 +471,88 @@ { 0xAA, "TSC" }, { 0xAB, "Special TX Power Setting" }, { 0xAC, "Optional sync settings" }, - { 0xFA, "Abis If parameters" }, + { 0xAD, "STIRC Option Setting" }, + { 0xAE, "Rx Difference Samples Count" }, + { 0xAF, "BTS Object Mapping" }, + { 0xB0, "Abis Mapping" }, + { 0xB1, "LAPDm T200 Values" }, + { 0xB2, "DTRX info" }, + { 0xB3, "Link and Counters" }, + { 0xB4, "TRS and BTS licensing" }, + { 0xB5, "TRX DDU association" }, + { 0xB6, "Power control reason" }, + { 0xB7, "CSDAP" }, + { 0xB8, "BS2 parameters" }, + { 0xB9, "BSC parameters" }, + { 0xBA, "BTS parameters" }, + { 0xBB, "TRX parameters" }, + { 0xBC, "HO parameters" }, + { 0xBD, "POC parameters" }, + { 0xBE, "ADJC parameters" }, + { 0xBF, "ADJC object" }, + { 0xC0, "UADJC parameters" }, + { 0xC1, "UADJC object" }, + { 0xC2, "BTS PCM id" }, + { 0xC3, "Segment Object id" }, + { 0xC4, "Cell load parameters" }, + { 0xC5, "Dynamic cell load info" }, + { 0xC6, "BSC Release information" }, + { 0xC7, "Complete data" }, + { 0xC8, "OMUSIG PCM info" }, + { 0xC9, "Line type" }, + { 0xCA, "Concurrent OMUSIGs priorities" }, + { 0xCB, "OMUSIG Priority" }, + { 0xCC, "OSC support" }, + { 0xCD, "CSDAP id" }, + { 0xCE, "CSDAP parameters" }, + { 0xCF, "Local Switching Counters" }, + { 0xD0, "TX queue handling parameters" }, + { 0xD1, "Valid History Records" }, + { 0xD2, "Measurement Operation Status" }, + { 0xD3, "Abis Delay Counters" }, + { 0xD4, "Abis Measurement channel" }, + { 0xD5, "Packet Abis BCF group configuration" }, + { 0xD6, "Traffic to DSCP mapping" }, + { 0xD7, "UL Shaping parameters" }, + { 0xD8, "Traffic scheduling" }, + { 0xD9, "Random Fill Bits usage" }, + { 0xDA, "Packet Abis BCF group id" }, + { 0xDB, "UDP" }, + { 0xDC, "Backhaul utilization monitor parameters" }, + { 0xDD, "Packet loss monitor parameters" }, + { 0xDE, "Congestion control" }, + { 0xDF, "Congestion reaction hysteresis parameters" }, + { 0xE0, "Multiplexing parameters" }, + { 0xE1, "IP addresses" }, + { 0xE2, "TRX feature capability" }, + { 0xE3, "Packet Abis If configuration" }, + { 0xE4, "BTS IPv4 address C/U-plane" }, + { 0xE5, "IPv4 address" }, + { 0xE6, "Subnet mask" }, + { 0xE7, "BSC IPv4 address C-plane" }, + { 0xE8, "BSC IPv4 address CS U-plane" }, + { 0xE9, "BSC IPv4 address PS U-plane" }, + { 0xEA, "MC-PPP class map" }, + { 0xEB, "SCTP parameters" }, + { 0xEC, "Packet Abis mapping" }, + { 0xED, "Sig ID" }, + { 0xEE, "Packet Abis mapping" }, + { 0xEF, "Measurement Request Type" }, + { 0xF0, "Peer BTS info" }, + { 0xF1, "Packet Abis Counters" }, + { 0xF2, "Waiting time for BSC restarting" }, + { 0xF3, "Peer BCF ID" }, + { 0xF4, "TRX starting mode" }, + { 0xF5, "GSM-R configuration" }, + { 0xF6, "DSCP to VLAN priority mapping" }, + { 0xF7, "TRX Assosiation" }, + { 0xF8, "Power Finetuning" }, + { 0xF9, "Abis Delay Measurement UDP port" }, + { 0xFA, "Abis if parameters" }, + { 0xFB, "PDV" }, + { 0xFC, "Horizon BTS parameters" }, + { 0xFD, "reserved" }, + { 0xFE, "Radio Module SW" }, { 0, NULL } }; -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/39252?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ia4026bbe458817e164b756847229cf6a90d02865 Gerrit-Change-Number: 39252 Gerrit-PatchSet: 1 Gerrit-Owner: csaba.sipos <metro4(a)freemail.hu>

1 0

[S] Change in osmo-bsc[master]: nokia_site: add some missing meesage IDs
by csaba.sipos 08 Jan '25

08 Jan '25

csaba.sipos has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/39251?usp=email ) Change subject: nokia_site: add some missing meesage IDs ...................................................................... nokia_site: add some missing meesage IDs Change-Id: I2ecd2ac285493352a9b121b09bf6a3a560e14c6c Signed-off-by: csaba.sipos <metro4(a)freemail.hu> --- M src/osmo-bsc/bts_nokia_site.c 1 file changed, 15 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/51/39251/1 diff --git a/src/osmo-bsc/bts_nokia_site.c b/src/osmo-bsc/bts_nokia_site.c index dc8ff14..dad61ae 100644 --- a/src/osmo-bsc/bts_nokia_site.c +++ b/src/osmo-bsc/bts_nokia_site.c @@ -217,6 +217,7 @@ /* TODO: put in a separate file ? */ static const struct value_string nokia_msgt_name[] = { + { 0x7F, "NOKIA_BTS_RSSI_VSWR_COUNTERS_REQ" }, { 0x80, "NOKIA_BTS_CONF_DATA" }, { 0x81, "NOKIA_BTS_ACK" }, { 0x82, "NOKIA_BTS_OMU_STARTED" }, @@ -275,6 +276,20 @@ { 0xB7, "NOKIA_BTS_LCS_ANSWER" }, { 0xB8, "NOKIA_BTS_LMU_FN_OFFSET_COMMAND" }, { 0xB9, "NOKIA_BTS_LMU_FN_OFFSET_ANSWER" }, + { 0xBA, "NOKIA_BTS_LAPD_CTR_REP" }, + { 0xBB, "NOKIA_BTS_TRX_CONFIGURATION_UPDATE" }, + { 0xBC, "NOKIA_BTS_DYNAMIC_LOAD_INFO" }, + { 0xBD, "NOKIA_BTS_CONF_DATA_BS2" }, + { 0xBE, "NOKIA_BTS_REGISTRY_REQ" }, + { 0xBF, "NOKIA_BTS_SFS_UPLOAD_REQ" }, + { 0xC0, "NOKIA_BTS_DELAY_MEAS_REQ" }, + { 0xC1, "NOKIA_BTS_DELAY_MEAS_ACK" }, + { 0xC2, "NOKIA_BTS_PABIS_MEAS_REQ" }, + { 0xC3, "NOKIA_BTS_PABIS_MEAS_ACK" }, + { 0xC4, "NOKIA_BSC_RESET_INFO" }, + { 0xC5, "NOKIA_BSC_RESET_COMPL" }, + { 0xC6, "NOKIA_BSC_RESET_COMPL_ANSWER" }, + { 0xC7, "NOKIA_BTS_RSSI_VSWR_COUNTERS" }, { 0, NULL } }; -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/39251?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I2ecd2ac285493352a9b121b09bf6a3a560e14c6c Gerrit-Change-Number: 39251 Gerrit-PatchSet: 1 Gerrit-Owner: csaba.sipos <metro4(a)freemail.hu>

1 0

[S] Change in osmo-mgw[master]: mgw: MDCX: Simplify early return code paths
by pespin 07 Jan '25

07 Jan '25

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-mgw/+/39250?usp=email ) Change subject: mgw: MDCX: Simplify early return code paths ...................................................................... mgw: MDCX: Simplify early return code paths Change-Id: Icb03a95e34e0c7d9396fefc2e37ee33ab09daa89 --- M src/libosmo-mgcp/mgcp_protocol.c 1 file changed, 15 insertions(+), 17 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-mgw refs/changes/50/39250/1 diff --git a/src/libosmo-mgcp/mgcp_protocol.c b/src/libosmo-mgcp/mgcp_protocol.c index 46c6815..9166854 100644 --- a/src/libosmo-mgcp/mgcp_protocol.c +++ b/src/libosmo-mgcp/mgcp_protocol.c @@ -1189,26 +1189,24 @@ if (mgcp_conn_rtp_is_osmux(conn_rtp)) { OSMO_ASSERT(conn_rtp->osmux.local_cid_allocated); if (hpars->remote_osmux_cid < -1) { - LOGPCONN(conn, DLMGCP, LOGL_ERROR, - "MDCX: Failed to parse Osmux CID!\n"); + LOGPCONN(conn, DLMGCP, LOGL_ERROR, "MDCX: Failed to parse Osmux CID!\n"); goto error3; - } else if (hpars->remote_osmux_cid == -1) { - LOGPCONN(conn, DLMGCP, LOGL_ERROR, - "MDCX: wilcard in MDCX is not supported!\n"); + } + if (hpars->remote_osmux_cid == -1) { + LOGPCONN(conn, DLMGCP, LOGL_ERROR, "MDCX: wilcard in MDCX is not supported!\n"); goto error3; - } else if (conn_rtp->osmux.remote_cid_present && - hpars->remote_osmux_cid != conn_rtp->osmux.remote_cid) { - LOGPCONN(conn, DLMGCP, LOGL_ERROR, - "MDCX: changing already allocated CID is not supported!\n"); + } + if (conn_rtp->osmux.remote_cid_present && + hpars->remote_osmux_cid != conn_rtp->osmux.remote_cid) { + LOGPCONN(conn, DLMGCP, LOGL_ERROR, "MDCX: changing already allocated CID is not supported!\n"); goto error3; - } else { - conn_rtp->osmux.remote_cid_present = true; - conn_rtp->osmux.remote_cid = hpars->remote_osmux_cid; - if (conn_osmux_event_rx_crcx_mdcx(conn_rtp) < 0) { - LOGPCONN(conn, DLMGCP, LOGL_ERROR, - "MDCX: Osmux handling failed!\n"); - goto error3; - } + } + conn_rtp->osmux.remote_cid_present = true; + conn_rtp->osmux.remote_cid = hpars->remote_osmux_cid; + if (conn_osmux_event_rx_crcx_mdcx(conn_rtp) < 0) { + LOGPCONN(conn, DLMGCP, LOGL_ERROR, + "MDCX: Osmux handling failed!\n"); + goto error3; } } -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/39250?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Icb03a95e34e0c7d9396fefc2e37ee33ab09daa89 Gerrit-Change-Number: 39250 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in osmo-mgw[master]: mgw: Remove wrong TODO comment
by pespin 07 Jan '25

07 Jan '25

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-mgw/+/39249?usp=email ) Change subject: mgw: Remove wrong TODO comment ...................................................................... mgw: Remove wrong TODO comment The TODO was written because the author had in mind the ptr where the codec was stored was a MGCP endpoint object, but it is actually an rtp_end which is an object under conn_rtp, so that's fine already with current code. Change-Id: I99d2211e81443883c45cc3fdda10e39a8c152063 --- M src/libosmo-mgcp/mgcp_protocol.c 1 file changed, 0 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-mgw refs/changes/49/39249/1 diff --git a/src/libosmo-mgcp/mgcp_protocol.c b/src/libosmo-mgcp/mgcp_protocol.c index dca98a2..46c6815 100644 --- a/src/libosmo-mgcp/mgcp_protocol.c +++ b/src/libosmo-mgcp/mgcp_protocol.c @@ -1182,7 +1182,6 @@ goto error3; } /* Upgrade the conn type RTP_DEFAULT->RTP_IUUP if needed based on requested codec: */ - /* TODO: "codec" probably needs to be moved from endp to conn */ if (conn_rtp->type == MGCP_RTP_DEFAULT && strcmp(conn_rtp->end.cset.codec->subtype_name, "VND.3GPP.IUFP") == 0) rc = mgcp_conn_iuup_init(conn_rtp); -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/39249?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I99d2211e81443883c45cc3fdda10e39a8c152063 Gerrit-Change-Number: 39249 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

2026

2025

2024

2023

2022

gerrit-log