Attention is currently required from: csaba.sipos. laforge has posted comments on this change by csaba.sipos. ( https://gerrit.osmocom.org/c/osmo-bsc/+/39252?usp=email ) Change subject: nokia_site: add missing element names ...................................................................... Patch Set 1: (1 comment) File src/osmo-bsc/bts_nokia_site.c: https://gerrit.osmocom.org/c/osmo-bsc/+/39252/comment/7b036e4b_06899d15?usp=... : PS1, Line 551: if you're changing the original "If" to "if". This makes it inconsistent with another parameters where the Abis interface is abbreviated "Abis If": 0xE3 I guess this was unintentional? I don't really care if it's capitalized or not - I just care about consistency. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/39252?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ia4026bbe458817e164b756847229cf6a90d02865 Gerrit-Change-Number: 39252 Gerrit-PatchSet: 1 Gerrit-Owner: csaba.sipos <metro4@freemail.hu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin@sysmocom.de> Gerrit-CC: laforge <laforge@osmocom.org> Gerrit-Attention: csaba.sipos <metro4@freemail.hu> Gerrit-Comment-Date: Wed, 08 Jan 2025 11:06:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No