- gerrit-log - lists.osmocom.org

[S] Change in osmo-upf[master]: Bump version: 0.2.0.7-b6d6-dirty → 0.3.0
by osmith 18 Feb '25

18 Feb '25

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-upf/+/39570?usp=email ) Change subject: Bump version: 0.2.0.7-b6d6-dirty → 0.3.0 ...................................................................... Bump version: 0.2.0.7-b6d6-dirty → 0.3.0 Change-Id: I645f50a09db9ef16262c1b990c33c2bf115027c5 --- M configure.ac M debian/changelog M debian/control 3 files changed, 24 insertions(+), 9 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-upf refs/changes/70/39570/1 diff --git a/configure.ac b/configure.ac index de2f1ae..c841676 100644 --- a/configure.ac +++ b/configure.ac @@ -36,11 +36,11 @@ PKG_PROG_PKG_CONFIG([0.20]) dnl checks for libraries -PKG_CHECK_MODULES(LIBOSMOCORE, libosmocore >= 1.10.0) -PKG_CHECK_MODULES(LIBOSMOVTY, libosmovty >= 1.10.0) -PKG_CHECK_MODULES(LIBOSMOCTRL, libosmoctrl >= 1.10.0) -PKG_CHECK_MODULES(LIBOSMOPFCP, libosmo-pfcp >= 0.4.0) -PKG_CHECK_MODULES(LIBGTPNL, libgtpnl >= 1.3.0) +PKG_CHECK_MODULES(LIBOSMOCORE, libosmocore >= 1.11.0) +PKG_CHECK_MODULES(LIBOSMOVTY, libosmovty >= 1.11.0) +PKG_CHECK_MODULES(LIBOSMOCTRL, libosmoctrl >= 1.11.0) +PKG_CHECK_MODULES(LIBOSMOPFCP, libosmo-pfcp >= 0.5.0) +PKG_CHECK_MODULES(LIBGTPNL, libgtpnl >= 1.3.2) PKG_CHECK_MODULES(LIBNFTABLES, libnftables >= 1.0.2) dnl checks for header files diff --git a/debian/changelog b/debian/changelog index e8b8d87..1de5ce0 100644 --- a/debian/changelog +++ b/debian/changelog @@ -1,3 +1,18 @@ +osmo-upf (0.3.0) unstable; urgency=medium + + [ Oliver Smith ] + * upf_gtp: automatically delete old gtp devices + + [ Pau Espin Pedrol ] + * Improve logging reading packets from gtp device + * Remove unused file up_session_to_gtp.c + * Simplify up_session_choose_f_teid() with early returns + * Introduce hashtable to lookup session by F-TEID + * Introduce hashtable to lookup chain_id + * Introduce hashtable to look up gtp_tundev by local TEID + + -- Oliver Smith <osmith(a)sysmocom.de> Tue, 18 Feb 2025 12:20:35 +0100 + osmo-upf (0.2.0) unstable; urgency=medium [ Neels Hofmeyr ] diff --git a/debian/control b/debian/control index 1dbf8d5..9d3c84d 100644 --- a/debian/control +++ b/debian/control @@ -12,11 +12,11 @@ pkg-config, python3-minimal, libtalloc-dev, - libgtpnl-dev (>= 1.3.0), + libgtpnl-dev (>= 1.3.2), libnftables-dev (>= 1.0.2), - libosmocore-dev (>= 1.10.0), - libosmo-pfcp-dev (>= 0.4.0), - osmo-gsm-manuals-dev (>= 1.2.0) + libosmocore-dev (>= 1.11.0), + libosmo-pfcp-dev (>= 0.5.0), + osmo-gsm-manuals-dev (>= 1.6.0) Standards-Version: 3.9.8 Vcs-Git: https://gitea.osmocom.org/cellular-infrastructure/osmo-upf Vcs-Browser: https://gitea.osmocom.org/cellular-infrastructure/osmo-upf -- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/39570?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: I645f50a09db9ef16262c1b990c33c2bf115027c5 Gerrit-Change-Number: 39570 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de>

1 0

[S] Change in osmo-bts[master]: trx_data_read_cb(): make length checks waterproof
by fixeria 18 Feb '25

18 Feb '25

Attention is currently required from: neels. fixeria has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/osmo-bts/+/39379?usp=email ) Change subject: trx_data_read_cb(): make length checks waterproof ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/39379?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ic658824a5884598d1245511897bcc00050c14317 Gerrit-Change-Number: 39379 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Tue, 18 Feb 2025 11:04:33 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[L] Change in libosmo-abis[master]: tests: add trau2rtp_gen program
by pespin 18 Feb '25

18 Feb '25

Attention is currently required from: falconia, laforge. pespin has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/libosmo-abis/+/39558?usp=email ) Change subject: tests: add trau2rtp_gen program ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/39558?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I3cc8502406e930317b680b0ace2fce479e495ccd Gerrit-Change-Number: 39558 Gerrit-PatchSet: 2 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: falconia <falcon(a)freecalypso.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Tue, 18 Feb 2025 11:02:46 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in libosmocore[master]: gprs: define OSMO_RESERVED_RAC 0xff
by pespin 18 Feb '25

18 Feb '25

Attention is currently required from: lynxis lazus. pespin has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/libosmocore/+/39557?usp=email ) Change subject: gprs: define OSMO_RESERVED_RAC 0xff ...................................................................... Patch Set 1: (1 comment) File include/osmocom/gsm/protocol/gsm_04_08_gprs.h: https://gerrit.osmocom.org/c/libosmocore/+/39557/comment/05dd96ee_08a072cf?… : PS1, Line 14: #define OSMO_RESERVED_RAC 0xff > because it is more an implicit definition. […] I didn't get what you mean sorry, do hou mind rephrasing? -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/39557?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I17a2adedc2c2ab158f40d58280f5df5c6967b8ec Gerrit-Change-Number: 39557 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Tue, 18 Feb 2025 11:00:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: lynxis lazus <lynxis(a)fe80.eu>

1 0

[S] Change in osmo-upf[master]: Introduce hashtable to look up gtp_tundev by local TEID
by pespin 18 Feb '25

18 Feb '25

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-upf/+/39568?usp=email ) Change subject: Introduce hashtable to look up gtp_tundev by local TEID ...................................................................... Introduce hashtable to look up gtp_tundev by local TEID Use this hashtable while looking up for tunend based on <access.local.teid, access.remote.teid, access.remote.addr>. This kind of look up is used every time a session is added or removed, which means potentially thousands of tunend sessions were being iterated linerarly every time. For simplification (easier/quicker hashtable key generation), reduce the whole key presented above to a more general one based on "access.local.teid". This is usually enough since we are anyways allocating local TEIDs globally per tunnel without caring about remote address. Change-Id: Ib12ecc8ce87175071c52c0ed2217a29d901f0f05 --- M include/osmocom/upf/upf_gtp.h M src/osmo-upf/upf_gtp.c 2 files changed, 10 insertions(+), 2 deletions(-) Approvals: fixeria: Looks good to me, approved laforge: Looks good to me, but someone else must approve osmith: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/include/osmocom/upf/upf_gtp.h b/include/osmocom/upf/upf_gtp.h index b4cd3df..1162861 100644 --- a/include/osmocom/upf/upf_gtp.h +++ b/include/osmocom/upf/upf_gtp.h @@ -24,6 +24,7 @@ #pragma once #include <osmocom/core/linuxlist.h> +#include <osmocom/core/hashtable.h> #include <osmocom/core/select.h> #include <osmocom/core/logging.h> @@ -55,6 +56,8 @@ /* list of struct upf_gtp_tunend */ struct llist_head tunnels; + /* hashtable of (struct upf_gtp_tunen) with key desc.access.local.teid */ + DECLARE_HASHTABLE(tunnels_by_local_f_teid, 10); }; /* Description of a GTP encapsulation / decapsulation. diff --git a/src/osmo-upf/upf_gtp.c b/src/osmo-upf/upf_gtp.c index 528937b..4cbebcd 100644 --- a/src/osmo-upf/upf_gtp.c +++ b/src/osmo-upf/upf_gtp.c @@ -134,6 +134,7 @@ .gtpv1.ofd.fd = -1, }; INIT_LLIST_HEAD(&dev->tunnels); + hash_init(dev->tunnels_by_local_f_teid); osmo_sockaddr_str_from_str(&addr_conv, local_addr, PORT_GTP0_U); @@ -318,7 +319,8 @@ } struct upf_gtp_tunend { - struct llist_head entry; + struct llist_head entry; /* item in (struct upf_gtp_dev)->tunnels */ + struct hlist_node node_by_local_f_teid; /* item in g_upf->gtp.pdrs_by_local_f_teid */ struct upf_gtp_dev *dev; struct upf_tunend desc; @@ -349,6 +351,7 @@ { if (tun->active) upf_gtp_tunend_deactivate(tun); + hash_del(&tun->node_by_local_f_teid); llist_del(&tun->entry); return 0; } @@ -369,6 +372,7 @@ .dev = dev, .desc = *desc, }; + hash_add(dev->tunnels_by_local_f_teid, &tun->node_by_local_f_teid, tun->desc.access.local.teid); llist_add(&tun->entry, &dev->tunnels); talloc_set_destructor(tun, upf_gtp_tunend_destruct); return tun; @@ -425,7 +429,8 @@ { struct upf_gtp_tunend *tun; tunend_validate(tunend); - llist_for_each_entry(tun, &dev->tunnels, entry) { + + hash_for_each_possible(dev->tunnels_by_local_f_teid, tun, node_by_local_f_teid, tunend->access.local.teid) { if (upf_gtp_tunend_cmp(tunend, &tun->desc)) continue; return tun; -- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/39568?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: Ib12ecc8ce87175071c52c0ed2217a29d901f0f05 Gerrit-Change-Number: 39568 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in osmo-ci[master]: ansible/obs-worker: lxc<5: link to upstream issue
by osmith 18 Feb '25

18 Feb '25

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/39567?usp=email ) Change subject: ansible/obs-worker: lxc<5: link to upstream issue ...................................................................... ansible/obs-worker: lxc<5: link to upstream issue Change-Id: Ia1a575a137c7141d49d974e4d6ffb2472abb64bf --- M ansible/roles/osmocom-obs-worker/tasks/obs.yml 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve fixeria: Looks good to me, approved diff --git a/ansible/roles/osmocom-obs-worker/tasks/obs.yml b/ansible/roles/osmocom-obs-worker/tasks/obs.yml index 693f964..c3e6c07 100644 --- a/ansible/roles/osmocom-obs-worker/tasks/obs.yml +++ b/ansible/roles/osmocom-obs-worker/tasks/obs.yml @@ -33,6 +33,7 @@ zypper: name: # obs-build requires lxc <= 4.x (OS#6186#note-50) + # https://github.com/openSUSE/obs-build/issues/1060 - lxc<5.0.0 - liblxc1<5.0.0 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/39567?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ia1a575a137c7141d49d974e4d6ffb2472abb64bf Gerrit-Change-Number: 39567 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in osmo-ci[master]: ansible: update build5-obsworker ssh key
by osmith 18 Feb '25

18 Feb '25

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/39566?usp=email ) Change subject: ansible: update build5-obsworker ssh key ...................................................................... ansible: update build5-obsworker ssh key I've reinstalled the build5-obsworker lxc after first upgrading to openSUSE 15.6 and then discovering that the lxc version is incompatible with obs-build: 15.6 doesn't have lxc 4 anymore, but a higher version is not supported by obs-build. I've added a big warning in the wiki so we don't run into this again until obs-build has been adjusted. Related: https://github.com/openSUSE/obs-build/issues/1060 Change-Id: I70a4e404fef74694ee851345345924ae95319b3e --- M ansible/util/known_hosts 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve fixeria: Looks good to me, approved diff --git a/ansible/util/known_hosts b/ansible/util/known_hosts index 84a9465..67427e3 100644 --- a/ansible/util/known_hosts +++ b/ansible/util/known_hosts @@ -9,4 +9,4 @@ 2a01:4f8:121:200a::1:2 ssh-ed25519 AAAAC3NzaC1lZDI1NTE5AAAAIFyp0daWkfsRHErCVCcP/FZmtiRvFNAsK2A5TlQ6Ja+P 10.9.25.28 ssh-ed25519 AAAAC3NzaC1lZDI1NTE5AAAAIG0rQGxSxWJHwNNT5XdeuMPSYCAXpcDnFDzvyw5+sH3l 2a01:4f8:140:926a::1:3 ssh-ed25519 AAAAC3NzaC1lZDI1NTE5AAAAIFU0ICXO2Mq6HjOrgWJqWifEYwz+Y3eyPd8ZOkp8el3l -2a01:4f8:140:926a::1:2 ssh-ed25519 AAAAC3NzaC1lZDI1NTE5AAAAIAXVP4aycCJ8owNkuRayPKwUSCBsk4G8oBVfHwIEnQMa +2a01:4f8:140:926a::1:2 ssh-ed25519 AAAAC3NzaC1lZDI1NTE5AAAAIOQvi5s82dH4Duhp2YV4mo71+i3J6bybD/Ph/ibysdGE -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/39566?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I70a4e404fef74694ee851345345924ae95319b3e Gerrit-Change-Number: 39566 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in osmo-ci[master]: ansible/obs-worker: lxc<5: link to upstream issue
by fixeria 18 Feb '25

18 Feb '25

Attention is currently required from: osmith. fixeria has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ci/+/39567?usp=email ) Change subject: ansible/obs-worker: lxc<5: link to upstream issue ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/39567?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ia1a575a137c7141d49d974e4d6ffb2472abb64bf Gerrit-Change-Number: 39567 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Tue, 18 Feb 2025 10:34:54 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-ci[master]: ansible: update build5-obsworker ssh key
by fixeria 18 Feb '25

18 Feb '25

Attention is currently required from: osmith. fixeria has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ci/+/39566?usp=email ) Change subject: ansible: update build5-obsworker ssh key ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/39566?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I70a4e404fef74694ee851345345924ae95319b3e Gerrit-Change-Number: 39566 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Tue, 18 Feb 2025 10:34:36 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in osmo-upf[master]: Introduce hashtable to look up gtp_tundev by local TEID
by fixeria 18 Feb '25

18 Feb '25

Attention is currently required from: pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-upf/+/39568?usp=email ) Change subject: Introduce hashtable to look up gtp_tundev by local TEID ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/39568?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: Ib12ecc8ce87175071c52c0ed2217a29d901f0f05 Gerrit-Change-Number: 39568 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 18 Feb 2025 10:33:15 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

2026

2025

2024

2023

2022

gerrit-log