- gerrit-log - lists.osmocom.org

[XS] Change in libosmocore[master]: gprs: define OSMO_RESERVED_RAC 0xff
by pespin 19 Feb '25

19 Feb '25

Attention is currently required from: lynxis lazus. pespin has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/libosmocore/+/39557?usp=email ) Change subject: gprs: define OSMO_RESERVED_RAC 0xff ...................................................................... Patch Set 1: (1 comment) File include/osmocom/gsm/protocol/gsm_04_08_gprs.h: https://gerrit.osmocom.org/c/libosmocore/+/39557/comment/6eb468e3_c158614c?… : PS1, Line 14: #define OSMO_RESERVED_RAC 0xff > Somehow I send it away in the middle of the sentence.. […] Yeah ok, but I don't see how any of that makes it osmocom specific... -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/39557?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I17a2adedc2c2ab158f40d58280f5df5c6967b8ec Gerrit-Change-Number: 39557 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Wed, 19 Feb 2025 13:11:19 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: lynxis lazus <lynxis(a)fe80.eu>

1 0

[L] Change in libosmo-abis[master]: tests: add trau2rtp_gen program
by fixeria 19 Feb '25

19 Feb '25

Attention is currently required from: falconia, laforge. fixeria has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/libosmo-abis/+/39558?usp=email ) Change subject: tests: add trau2rtp_gen program ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/39558?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I3cc8502406e930317b680b0ace2fce479e495ccd Gerrit-Change-Number: 39558 Gerrit-PatchSet: 2 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: falconia <falcon(a)freecalypso.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Wed, 19 Feb 2025 12:41:11 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in libosmocore[master]: gprs: define OSMO_RESERVED_RAC 0xff
by lynxis lazus 18 Feb '25

18 Feb '25

Attention is currently required from: pespin. lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/libosmocore/+/39557?usp=email ) Change subject: gprs: define OSMO_RESERVED_RAC 0xff ...................................................................... Patch Set 1: (1 comment) File include/osmocom/gsm/protocol/gsm_04_08_gprs.h: https://gerrit.osmocom.org/c/libosmocore/+/39557/comment/04069be3_b1ef0c11?… : PS1, Line 14: #define OSMO_RESERVED_RAC 0xff > I didn't get what you mean sorry, do hou mind rephrasing? Somehow I send it away in the middle of the sentence.. Because it is more an implicit definition. So far I understand, the 0xff is invalid for a RAC as cell id to be transmitted over the air. But a UE will save the RAC 0xff on the simcard if it doensn't has a valid RAC (e.g. no PS services). -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/39557?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I17a2adedc2c2ab158f40d58280f5df5c6967b8ec Gerrit-Change-Number: 39557 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 18 Feb 2025 21:14:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: lynxis lazus <lynxis(a)fe80.eu>

1 0

[XS] Change in osmo-upf[master]: Increase per PDR (F-TEID) hashtable size
by pespin 18 Feb '25

18 Feb '25

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-upf/+/39581?usp=email ) Change subject: Increase per PDR (F-TEID) hashtable size ...................................................................... Increase per PDR (F-TEID) hashtable size In tunmap scenario there's usually 2 PDRs/local-F-TEIDs per session, hence it makes sense to at least double the hashtable size with respect to session hashtable. In here we actually multiply it by 2 twice since this is actually global and not per peer, hence we account for multiple peers. Change-Id: I7ee3e875020d707c05e13ee70952174ca4daad30 --- M include/osmocom/upf/upf.h 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-upf refs/changes/81/39581/1 diff --git a/include/osmocom/upf/upf.h b/include/osmocom/upf/upf.h index 1e5d702..2f25c99 100644 --- a/include/osmocom/upf/upf.h +++ b/include/osmocom/upf/upf.h @@ -116,13 +116,13 @@ int priority_post; uint32_t next_chain_id_state; /* hashtable of (struct upf_nft_tun)->node_by_chain_id: */ - DECLARE_HASHTABLE(nft_tun_by_chain_id, 10); + DECLARE_HASHTABLE(nft_tun_by_chain_id, 12); } tunmap; struct { uint32_t next_local_teid_state; /* hashtable of (struct pdr)->node_by_local_f_teid: */ - DECLARE_HASHTABLE(pdrs_by_local_f_teid, 10); + DECLARE_HASHTABLE(pdrs_by_local_f_teid, 12); uint16_t next_echo_seq_nr; } gtp; -- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/39581?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: I7ee3e875020d707c05e13ee70952174ca4daad30 Gerrit-Change-Number: 39581 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in libosmo-pfcp[master]: pfcp_endpoint: Increase sent_{requests,responses}_by_seq_nr hashtable...
by pespin 18 Feb '25

18 Feb '25

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-pfcp/+/39580?usp=email ) Change subject: pfcp_endpoint: Increase sent_{requests,responses}_by_seq_nr hashtable size ...................................................................... pfcp_endpoint: Increase sent_{requests,responses}_by_seq_nr hashtable size Change-Id: Ie0bb28240b3a83a1776702f26d79a09e8f0e30f6 --- M src/libosmo-pfcp/pfcp_endpoint.c 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-pfcp refs/changes/80/39580/1 diff --git a/src/libosmo-pfcp/pfcp_endpoint.c b/src/libosmo-pfcp/pfcp_endpoint.c index d6c109b..7c1058f 100644 --- a/src/libosmo-pfcp/pfcp_endpoint.c +++ b/src/libosmo-pfcp/pfcp_endpoint.c @@ -52,12 +52,12 @@ * For a transmitted Request message, wait for a matching Response from a remote peer; if none arrives, * retransmit (see n1 and t1_ms). */ struct llist_head sent_requests; - DECLARE_HASHTABLE(sent_requests_by_seq_nr, 10); + DECLARE_HASHTABLE(sent_requests_by_seq_nr, 12); /* All transmitted PFCP Response messages, list of osmo_pfcp_queue_entry. * For a transmitted Response message, keep it in the queue for a fixed amount of time. If the peer retransmits * the original Request, do not dispatch the Request, but respond with the queued message directly. */ struct llist_head sent_responses; - DECLARE_HASHTABLE(sent_responses_by_seq_nr, 10); + DECLARE_HASHTABLE(sent_responses_by_seq_nr, 12); }; /*! Entry of pfcp_endpoint message queue of PFCP messages, for re-transsions. */ -- To view, visit https://gerrit.osmocom.org/c/libosmo-pfcp/+/39580?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmo-pfcp Gerrit-Branch: master Gerrit-Change-Id: Ie0bb28240b3a83a1776702f26d79a09e8f0e30f6 Gerrit-Change-Number: 39580 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in osmo-upf[master]: up_peer: Increase up/cp seid hashtable sizes
by pespin 18 Feb '25

18 Feb '25

pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-upf/+/39579?usp=email ) Change subject: up_peer: Increase up/cp seid hashtable sizes ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: With this I can already create 200K tunend sessions in 30s. This is faster than tunmap since nft is not involved here. -- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/39579?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: I424778a4c75000fb67ba4725a6a3e3e91a80fc76 Gerrit-Change-Number: 39579 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Tue, 18 Feb 2025 18:20:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[XS] Change in osmo-upf[master]: up_peer: Document field
by pespin 18 Feb '25

18 Feb '25

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-upf/+/39577?usp=email ) Change subject: up_peer: Document field ...................................................................... up_peer: Document field Change-Id: I194074f657fb793681658c021579880f352a3f91 --- M include/osmocom/upf/up_peer.h 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-upf refs/changes/77/39577/1 diff --git a/include/osmocom/upf/up_peer.h b/include/osmocom/upf/up_peer.h index 59c2b91..be5dd52 100644 --- a/include/osmocom/upf/up_peer.h +++ b/include/osmocom/upf/up_peer.h @@ -41,6 +41,7 @@ }; struct up_peer { + /* item in up_endpoint->peers */ struct llist_head entry; struct osmo_fsm_inst *fi; -- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/39577?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: I194074f657fb793681658c021579880f352a3f91 Gerrit-Change-Number: 39577 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in osmo-upf[master]: up_peer: Increase up/cp seid hashtable sizes
by pespin 18 Feb '25

18 Feb '25

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-upf/+/39579?usp=email ) Change subject: up_peer: Increase up/cp seid hashtable sizes ...................................................................... up_peer: Increase up/cp seid hashtable sizes During a 200K session setup, this can still take quite a noticeable amount of time (20% of a full CPU) during session creation. Change-Id: I424778a4c75000fb67ba4725a6a3e3e91a80fc76 --- M include/osmocom/upf/up_peer.h 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-upf refs/changes/79/39579/1 diff --git a/include/osmocom/upf/up_peer.h b/include/osmocom/upf/up_peer.h index be5dd52..559b87c 100644 --- a/include/osmocom/upf/up_peer.h +++ b/include/osmocom/upf/up_peer.h @@ -63,8 +63,8 @@ struct osmo_use_count use_count; struct osmo_use_count_entry use_count_buf[5]; - DECLARE_HASHTABLE(sessions_by_up_seid, 6); - DECLARE_HASHTABLE(sessions_by_cp_seid, 6); + DECLARE_HASHTABLE(sessions_by_up_seid, 10); + DECLARE_HASHTABLE(sessions_by_cp_seid, 10); }; struct up_peer *up_peer_find_or_add(struct up_endpoint *up_ep, const struct osmo_sockaddr *remote_addr); -- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/39579?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: I424778a4c75000fb67ba4725a6a3e3e91a80fc76 Gerrit-Change-Number: 39579 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in osmo-upf[master]: Introduce hashtable to look up session in endpoint by UP SEID
by pespin 18 Feb '25

18 Feb '25

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-upf/+/39578?usp=email ) Change subject: Introduce hashtable to look up session in endpoint by UP SEID ...................................................................... Introduce hashtable to look up session in endpoint by UP SEID This is used every time a new PFCP session was being allocated. It allows looking up if a given UP SEID exists in any of the peers. Before this patch, iterating over tens/hundreds of UP peers on every session creation took 38% of a full CPU. Change-Id: I617b405e59a3435a1c4912bf4161bc9e036754b4 --- M include/osmocom/upf/up_endpoint.h M include/osmocom/upf/up_session.h M src/osmo-upf/up_endpoint.c M src/osmo-upf/up_session.c 4 files changed, 14 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-upf refs/changes/78/39578/1 diff --git a/include/osmocom/upf/up_endpoint.h b/include/osmocom/upf/up_endpoint.h index ac240cd..2aed25a 100644 --- a/include/osmocom/upf/up_endpoint.h +++ b/include/osmocom/upf/up_endpoint.h @@ -24,6 +24,7 @@ #pragma once #include <osmocom/core/linuxlist.h> +#include <osmocom/core/hashtable.h> struct osmo_pfcp_msg; struct osmo_pfcp_endpoint; @@ -37,6 +38,10 @@ /* list of struct up_peer. */ struct llist_head peers; + /* hashtable of (struct up_session) with key up_seid. + * Allows quick access to sessions (and its endpoint as backpointer) + * with a given up_seid. */ + DECLARE_HASHTABLE(sessions_by_up_seid, 10); uint64_t next_up_seid_state; }; diff --git a/include/osmocom/upf/up_session.h b/include/osmocom/upf/up_session.h index 3dc7bb1..a20ae06 100644 --- a/include/osmocom/upf/up_session.h +++ b/include/osmocom/upf/up_session.h @@ -45,6 +45,9 @@ struct hlist_node node_by_up_seid; struct hlist_node node_by_cp_seid; + /* item in up_endpoint->peers_by_up_seid: */ + struct hlist_node ep_node_by_up_seid; + struct osmo_fsm_inst *fi; /* backpointer */ struct up_peer *up_peer; diff --git a/src/osmo-upf/up_endpoint.c b/src/osmo-upf/up_endpoint.c index 34351a6..f400bdc 100644 --- a/src/osmo-upf/up_endpoint.c +++ b/src/osmo-upf/up_endpoint.c @@ -239,6 +239,7 @@ struct up_endpoint *up_ep; up_ep = talloc_zero(ctx, struct up_endpoint); INIT_LLIST_HEAD(&up_ep->peers); + hash_init(up_ep->sessions_by_up_seid); cfg = (struct osmo_pfcp_endpoint_cfg){ .local_addr = *local_addr, @@ -263,10 +264,9 @@ static struct up_session *up_endpoint_find_session(struct up_endpoint *ep, uint64_t up_seid) { - struct up_peer *peer; - llist_for_each_entry(peer, &ep->peers, entry) { - struct up_session *session = up_session_find_by_up_seid(peer, up_seid); - if (session) + struct up_session *session; + hash_for_each_possible(ep->sessions_by_up_seid, session, ep_node_by_up_seid, up_seid) { + if (session->up_seid == up_seid) return session; } return NULL; diff --git a/src/osmo-upf/up_session.c b/src/osmo-upf/up_session.c index 97c9367..a9bc7c3 100644 --- a/src/osmo-upf/up_session.c +++ b/src/osmo-upf/up_session.c @@ -885,6 +885,7 @@ up_session_clear_pdr_far(session); + hash_del(&session->ep_node_by_up_seid); hash_del(&session->node_by_up_seid); hash_del(&session->node_by_cp_seid); } @@ -1022,6 +1023,7 @@ hash_add(peer->sessions_by_up_seid, &session->node_by_up_seid, session->up_seid); hash_add(peer->sessions_by_cp_seid, &session->node_by_cp_seid, session->cp_f_seid.seid); + hash_add(peer->up_endpoint->sessions_by_up_seid, &session->ep_node_by_up_seid, session->up_seid); return session; } -- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/39578?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: I617b405e59a3435a1c4912bf4161bc9e036754b4 Gerrit-Change-Number: 39578 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in upf-benchmark[master]: osmo-upf-load-gen: Introduce hashtable to look up session by CP SEID
by pespin 18 Feb '25

18 Feb '25

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/upf-benchmark/+/39576?usp=email ) Change subject: osmo-upf-load-gen: Introduce hashtable to look up session by CP SEID ...................................................................... osmo-upf-load-gen: Introduce hashtable to look up session by CP SEID When adding tens of thousands of tunend sessions, osmo-upf-load-gen used 100% CPU and 90% of it was spent in pfcp_tool_session_find(). Change-Id: Icab511fa1c136c75403e7469f63d91004e75dab4 --- M include/osmocom/upfloadgen/pfcp_tool.h M src/osmo-upf-load-gen/pfcp_tool.c 2 files changed, 8 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/upf-benchmark refs/changes/76/39576/1 diff --git a/include/osmocom/upfloadgen/pfcp_tool.h b/include/osmocom/upfloadgen/pfcp_tool.h index 28be674..26cd639 100644 --- a/include/osmocom/upfloadgen/pfcp_tool.h +++ b/include/osmocom/upfloadgen/pfcp_tool.h @@ -25,6 +25,7 @@ #pragma once #include <osmocom/core/linuxlist.h> +#include <osmocom/core/hashtable.h> #include <osmocom/core/tdef.h> #include <osmocom/core/socket.h> #include <osmocom/core/sockaddr_str.h> @@ -63,7 +64,10 @@ uint64_t next_seid_state; + /* llist of struct pfcp_tool_session->entry */ struct llist_head sessions; + /* hashtable of (struct pfcp_tool_session) with key cp_seid */ + DECLARE_HASHTABLE(sessions_by_cp_seid, 10); }; struct pfcp_tool_gtp_tun_ep { @@ -90,6 +94,7 @@ struct pfcp_tool_session { struct llist_head entry; + struct hlist_node node_by_cp_seid; /* item in (struct pfcp_tool_peer)->sessions_by_cp_seid */ struct pfcp_tool_peer *peer; uint64_t cp_seid; diff --git a/src/osmo-upf-load-gen/pfcp_tool.c b/src/osmo-upf-load-gen/pfcp_tool.c index f07acf0..38dc2cd 100644 --- a/src/osmo-upf-load-gen/pfcp_tool.c +++ b/src/osmo-upf-load-gen/pfcp_tool.c @@ -91,6 +91,7 @@ peer->remote_addr = *remote_addr; peer->next_seid_state = 0x1234567; INIT_LLIST_HEAD(&peer->sessions); + hash_init(peer->sessions_by_cp_seid); llist_add(&peer->entry, &g_pfcp_tool->peers); return peer; } @@ -98,7 +99,7 @@ struct pfcp_tool_session *pfcp_tool_session_find(struct pfcp_tool_peer *peer, uint64_t cp_seid) { struct pfcp_tool_session *session; - llist_for_each_entry(session, &peer->sessions, entry) { + hash_for_each_possible(peer->sessions_by_cp_seid, session, node_by_cp_seid, cp_seid) { if (session->cp_seid == cp_seid) return session; } @@ -119,6 +120,7 @@ .kind = kind, }; llist_add(&session->entry, &peer->sessions); + hash_add(peer->sessions_by_cp_seid, &session->node_by_cp_seid, cp_seid); return session; } -- To view, visit https://gerrit.osmocom.org/c/upf-benchmark/+/39576?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: upf-benchmark Gerrit-Branch: master Gerrit-Change-Id: Icab511fa1c136c75403e7469f63d91004e75dab4 Gerrit-Change-Number: 39576 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

2026

2025

2024

2023

2022

gerrit-log