- gerrit-log - lists.osmocom.org

[S] Change in osmo-ttcn3-hacks[master]: bts: expect TC_data_{rtp,facch}_tchf144 to pass
by laforge 25 Feb '25

25 Feb '25

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39599?usp=email ) Change subject: bts: expect TC_data_{rtp,facch}_tchf144 to pass ...................................................................... bts: expect TC_data_{rtp,facch}_tchf144 to pass Change-Id: I5dfcecc9cb6829ad208a54d7a3092a4cde327fb3 Related: OS#6167 --- M bts/expected-results.xml 1 file changed, 2 insertions(+), 12 deletions(-) Approvals: pespin: Looks good to me, but someone else must approve laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/bts/expected-results.xml b/bts/expected-results.xml index c10e668..ca5ad2f 100644 --- a/bts/expected-results.xml +++ b/bts/expected-results.xml @@ -183,23 +183,13 @@ <testcase classname='BTS_Tests' name='TC_speech_rtp_tchh' time='MASKED'/> <testcase classname='BTS_Tests' name='TC_speech_osmux_tchf' time='MASKED'/> <testcase classname='BTS_Tests' name='TC_speech_osmux_tchh' time='MASKED'/> - <testcase classname='BTS_Tests' name='TC_data_rtp_tchf144' time='MASKED'> - <failure type='fail-verdict'>Rx unexpected RSL port message: MASKED - BTS_Tests.ttcn:MASKED BTS_Tests control part - BTS_Tests.ttcn:MASKED TC_data_rtp_tchf144 testcase - </failure> - </testcase> + <testcase classname='BTS_Tests' name='TC_data_rtp_tchf144' time='MASKED'/> <testcase classname='BTS_Tests' name='TC_data_rtp_tchf96' time='MASKED'/> <testcase classname='BTS_Tests' name='TC_data_rtp_tchf48' time='MASKED'/> <testcase classname='BTS_Tests' name='TC_data_rtp_tchh48' time='MASKED'/> <testcase classname='BTS_Tests' name='TC_data_rtp_tchf24' time='MASKED'/> <testcase classname='BTS_Tests' name='TC_data_rtp_tchh24' time='MASKED'/> - <testcase classname='BTS_Tests' name='TC_data_facch_tchf144' time='MASKED'> - <failure type='fail-verdict'>Rx unexpected RSL port message: MASKED - BTS_Tests.ttcn:MASKED BTS_Tests control part - BTS_Tests.ttcn:MASKED TC_data_rtp_tchf144 testcase - </failure> - </testcase> + <testcase classname='BTS_Tests' name='TC_data_facch_tchf144' time='MASKED'/> <testcase classname='BTS_Tests' name='TC_data_facch_tchf96' time='MASKED'/> <testcase classname='BTS_Tests' name='TC_data_facch_tchf48' time='MASKED'/> <testcase classname='BTS_Tests' name='TC_data_facch_tchh48' time='MASKED'/> -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39599?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I5dfcecc9cb6829ad208a54d7a3092a4cde327fb3 Gerrit-Change-Number: 39599 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in osmo-ttcn3-hacks[master]: mgw: osmo-mgw.cfg: remove deprecated no-op params
by laforge 25 Feb '25

25 Feb '25

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39598?usp=email ) Change subject: mgw: osmo-mgw.cfg: remove deprecated no-op params ...................................................................... mgw: osmo-mgw.cfg: remove deprecated no-op params This patch fixes the following warnings: % Deprecated 'sdp audio-payload number <0-255>' config no longer has any effect % Deprecated 'sdp audio-payload name NAME' config no longer has any effect % Deprecated 'loop (0|1)' config no longer has any effect % Deprecated 'allow-transcoding' config no longer has any effect % Deprecated 'loop (0|1)' config no longer has any effect % Deprecated 'allow-transcoding' config no longer has any effect Change-Id: Ie4f2b46eda2e848781b77e590ad20e80fed86257 --- M mgw/osmo-mgw.cfg 1 file changed, 0 insertions(+), 6 deletions(-) Approvals: laforge: Looks good to me, approved pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/mgw/osmo-mgw.cfg b/mgw/osmo-mgw.cfg index 2af7dff..8f390df 100644 --- a/mgw/osmo-mgw.cfg +++ b/mgw/osmo-mgw.cfg @@ -49,14 +49,10 @@ no rtp keep-alive no rtcp-omit no rtp-patch - sdp audio-payload number 98 - sdp audio-payload name GSM sdp audio-payload send-ptime sdp audio-payload send-name conn-timeout 0 - loop 0 number endpoints 300 - allow-transcoding osmux off osmux bind-ip 127.0.0.1 osmux bind-ip-v6 ::1 @@ -64,8 +60,6 @@ sdp audio-payload send-ptime sdp audio-payload send-name no rtp keep-alive - loop 0 no rtcp-omit no rtp-patch - allow-transcoding line 0 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39598?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ie4f2b46eda2e848781b77e590ad20e80fed86257 Gerrit-Change-Number: 39598 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in osmo-ttcn3-hacks[master]: bts: expect TC_data_{rtp,facch}_tchf144 to pass
by laforge 25 Feb '25

25 Feb '25

Attention is currently required from: fixeria. laforge has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39599?usp=email ) Change subject: bts: expect TC_data_{rtp,facch}_tchf144 to pass ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39599?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I5dfcecc9cb6829ad208a54d7a3092a4cde327fb3 Gerrit-Change-Number: 39599 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 25 Feb 2025 12:13:07 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-ttcn3-hacks[master]: mgw: osmo-mgw.cfg: remove deprecated no-op params
by laforge 25 Feb '25

25 Feb '25

Attention is currently required from: dexter, fixeria, neels. laforge has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39598?usp=email ) Change subject: mgw: osmo-mgw.cfg: remove deprecated no-op params ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39598?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ie4f2b46eda2e848781b77e590ad20e80fed86257 Gerrit-Change-Number: 39598 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Tue, 25 Feb 2025 12:12:56 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in docker-playground[master]: ttcn3-bts-test: do not use respawn.sh
by laforge 25 Feb '25

25 Feb '25

laforge has submitted this change. ( https://gerrit.osmocom.org/c/docker-playground/+/39597?usp=email ) Change subject: ttcn3-bts-test: do not use respawn.sh ...................................................................... ttcn3-bts-test: do not use respawn.sh Re-spawning osmo-bts is no longer necessary. For quite some time now, it has been able to attempt OML link re-establishment in a loop instead of exit()ing. Additionally, using respawn.sh makes crashes harder to detect. Whether we should restart the IUT process and continue executing the remaining test cases after a crash is debatable. However, none of the other testsuites (except ttcn3-pcu-test, which actually requires restarting osmo-pcu after each TC) use respawn.sh for that purpose. Change-Id: I770a0530f90c5e03d2073bfc1c4cfd0e840379c9 Related: OS#6728, OS#6729 --- M ttcn3-bts-test/jenkins.sh 1 file changed, 1 insertion(+), 3 deletions(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve diff --git a/ttcn3-bts-test/jenkins.sh b/ttcn3-bts-test/jenkins.sh index 40c00ac..d4b59e7 100755 --- a/ttcn3-bts-test/jenkins.sh +++ b/ttcn3-bts-test/jenkins.sh @@ -40,7 +40,6 @@ start_bts() { local variant variant="$1" - sleep_time_respawn="$2" echo Starting container with BTS if [ -z "$variant" ]; then echo ERROR: You have to specify a BTS variant @@ -51,11 +50,10 @@ --ulimit core=-1 \ -v $VOL_BASE_DIR/bts:/data \ -v $VOL_BASE_DIR/unix:/data/unix \ - -e "SLEEP_BEFORE_RESPAWN=$sleep_time_respawn" \ --name ${BUILD_TAG}-bts -d \ $DOCKER_ARGS \ $REPO_USER/osmo-bts-$IMAGE_SUFFIX \ - /bin/sh -c "/usr/local/bin/respawn.sh osmo-bts-$variant -c /data/osmo-bts.gen.cfg >>/data/osmo-bts.log 2>&1" + /bin/sh -c "osmo-bts-$variant -c /data/osmo-bts.gen.cfg >>/data/osmo-bts.log 2>&1" } start_fake_trx() { -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/39597?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I770a0530f90c5e03d2073bfc1c4cfd0e840379c9 Gerrit-Change-Number: 39597 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in docker-playground[master]: ttcn3-bts-test: do not use respawn.sh
by laforge 25 Feb '25

25 Feb '25

Attention is currently required from: fixeria, osmith. laforge has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/docker-playground/+/39597?usp=email ) Change subject: ttcn3-bts-test: do not use respawn.sh ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/39597?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I770a0530f90c5e03d2073bfc1c4cfd0e840379c9 Gerrit-Change-Number: 39597 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 25 Feb 2025 12:12:42 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in docker-playground[master]: ttcn3-bts-test: do not use respawn.sh
by laforge 25 Feb '25

25 Feb '25

Attention is currently required from: laforge, osmith. laforge has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/docker-playground/+/39597?usp=email ) Change subject: ttcn3-bts-test: do not use respawn.sh ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/39597?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I770a0530f90c5e03d2073bfc1c4cfd0e840379c9 Gerrit-Change-Number: 39597 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Tue, 25 Feb 2025 12:12:38 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XL] Change in osmo-ggsn[master]: gtp: add support for SGSN Context Req/Resp/Ack
by laforge 25 Feb '25

25 Feb '25

Attention is currently required from: daniel, lynxis lazus. laforge has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/38938?usp=email ) Change subject: gtp: add support for SGSN Context Req/Resp/Ack ...................................................................... Patch Set 11: (6 comments) File gtp/gtp.c: https://gerrit.osmocom.org/c/osmo-ggsn/+/38938/comment/e2e69e10_106b6071?us… : PS11, Line 899: struct Im surprised that the destination peer is not 'const'. Likeweise I'd normally expect any othe rinput data like local_ref or ie to be 'const' as the called function shouldn't modify any of these. Probably you're doing it this way as a lot / all of the existing code does it this way? https://gerrit.osmocom.org/c/osmo-ggsn/+/38938/comment/9712d78b_434ec111?us… : PS11, Line 1134: int gtp_decode_pdp_ctx(const uint8_t *buf, unsigned int size, struct pdp_t *pdp, uint16_t *sapi) I think the function could deserve some documentation as a comment [doxygen style or not] https://gerrit.osmocom.org/c/osmo-ggsn/+/38938/comment/b510fb7e_0eb96e0f?us… : PS11, Line 1273: int gtp_encode_pdp_ctx(uint8_t *buf, unsigned int size, const struct pdp_t *pdp, uint16_t sapi) I think the function could deserve some documentation as a comment [doxygen style or not] https://gerrit.osmocom.org/c/osmo-ggsn/+/38938/comment/3a753755_77d7eb15?us… : PS11, Line 1403: LOGP(DLGTP, LOGL_NOTICE, shouldn't we print some kind of context? Like which GSN peer (address) has sent us the message with the wrong version? https://gerrit.osmocom.org/c/osmo-ggsn/+/38938/comment/2acd816c_11141355?us… : PS11, Line 1410: "SGSN Context Response expected Sequence flag set. Flags %d\n", packet->flags); shouldn't we print some kind of context? Like which GSN peer (address) has sent us the message with the wrong flags? https://gerrit.osmocom.org/c/osmo-ggsn/+/38938/comment/4777d45d_0b8ecfc0?us… : PS11, Line 1458: "SGSN Context Request expected only on GTPCv1: %u\n", version); same here -- To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/38938?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: Idb8ed0bb87200a68bb8caedd734fc070df9179c0 Gerrit-Change-Number: 38938 Gerrit-PatchSet: 11 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: daniel <dwillmann(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Tue, 25 Feb 2025 12:11:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[XS] Change in libosmo-abis[master]: ipaccess: Reset pointer before calling stream_cli func triggering cal...
by fixeria 25 Feb '25

25 Feb '25

Attention is currently required from: osmith, pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-abis/+/39607?usp=email ) Change subject: ipaccess: Reset pointer before calling stream_cli func triggering callback ...................................................................... Patch Set 3: Code-Review+1 (1 comment) Commit Message: https://gerrit.osmocom.org/c/libosmo-abis/+/39607/comment/f4b28e87_ad2541eb… : PS2, Line 21: SYS > s/SYS/OS/ Done -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/39607?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I2f1da24580effab5e3dfeacb6514c3b1e3a650c9 Gerrit-Change-Number: 39607 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 25 Feb 2025 11:18:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[XS] Change in libosmo-abis[master]: ipaccess: Reset pointer before calling stream_cli func triggering cal...
by fixeria 25 Feb '25

25 Feb '25

Attention is currently required from: osmith, pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-abis/+/39607?usp=email ) Change subject: ipaccess: Reset pointer before calling stream_cli func triggering callback ...................................................................... Patch Set 2: Code-Review+1 (1 comment) Commit Message: https://gerrit.osmocom.org/c/libosmo-abis/+/39607/comment/a7a1854b_f53f4254… : PS2, Line 21: SYS s/SYS/OS/ -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/39607?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I2f1da24580effab5e3dfeacb6514c3b1e3a650c9 Gerrit-Change-Number: 39607 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 25 Feb 2025 11:18:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

2026

2025

2024

2023

2022

gerrit-log