- gerrit-log - lists.osmocom.org

[XS] Change in libosmocore[master]: configure: set min python version check to 3.5
by osmith 17 Mar '25

17 Mar '25

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/39801?usp=email ) Change subject: configure: set min python version check to 3.5 ...................................................................... configure: set min python version check to 3.5 The osmo-gsm-tester and 201705 jobs, which use the OE poky SDK from 2017 have started failing since the check for python 3.6 was added. This SDK has version 3.5, so lower the required version check to that for now. Fixes: 489a6f ("configure.ac: check for Python interpreter unconditionally") Change-Id: Ia39e7e04dd8a31efaf87fd1f0fbbfdc5b5fa37c2 --- M configure.ac 1 file changed, 2 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/01/39801/1 diff --git a/configure.ac b/configure.ac index 25db55c..80d1b76 100644 --- a/configure.ac +++ b/configure.ac @@ -175,7 +175,8 @@ dnl Search for a Python interpreter on the system dnl python is needed at built-time for auto-generating code -AM_PATH_PYTHON([3.6]) +dnl Don't require a newer version than 3.5 for now, as poky 201705 ships that +AM_PATH_PYTHON([3.5]) PKG_CHECK_MODULES(TALLOC, [talloc >= 2.1.0]) -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/39801?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ia39e7e04dd8a31efaf87fd1f0fbbfdc5b5fa37c2 Gerrit-Change-Number: 39801 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de>

1 0

[XS] Change in osmo-ci[master]: lint/lint_diff: allow skipping with OSMO_LINT=0
by osmith 17 Mar '25

17 Mar '25

Attention is currently required from: pespin. osmith has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ci/+/39797?usp=email ) Change subject: lint/lint_diff: allow skipping with OSMO_LINT=0 ...................................................................... Patch Set 2: (1 comment) File lint/lint_diff.sh: https://gerrit.osmocom.org/c/osmo-ci/+/39797/comment/e565997e_c2bf84c6?usp=… : PS1, Line 8: if [ "$LINT" = 0 ]; then > maybe adding some OSMO_ prefix would make this a lot less prone to conflict with something else. Done -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/39797?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ia4563c13d9916a879a1e8afeacad8c541662adaa Gerrit-Change-Number: 39797 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 17 Mar 2025 07:45:42 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in osmo-ci[master]: lint/lint_diff: allow skipping with OSMO_LINT=0
by osmith 17 Mar '25

17 Mar '25

Attention is currently required from: osmith. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ci/+/39797?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: lint/lint_diff: allow skipping with OSMO_LINT=0 ...................................................................... lint/lint_diff: allow skipping with OSMO_LINT=0 When this script is set as pre-commit hook, it can be useful to skip the linter with this env var to make a commit that intentionally does not pass the linter (e.g. to test if it will be caught in gerrit + jenkins). There is also "git commit --no-verify", but with that the hook that applies the Change-Id does not run. Change-Id: Ia4563c13d9916a879a1e8afeacad8c541662adaa --- M lint/lint_diff.sh 1 file changed, 5 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/97/39797/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/39797?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ia4563c13d9916a879a1e8afeacad8c541662adaa Gerrit-Change-Number: 39797 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de>

1 0

[XS] Change in osmo-pcu[master]: checkpath: Exclude csn1 files
by osmith 17 Mar '25

17 Mar '25

Attention is currently required from: pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-pcu/+/39782?usp=email ) Change subject: checkpath: Exclude csn1 files ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/39782?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Ib6e7d2dcc3d8f262092f0100e55cad397aa226f4 Gerrit-Change-Number: 39782 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 17 Mar 2025 07:29:26 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in docker-playground[master]: osmo-{bsc,bts,sgsn}-master: remove unused deps
by pespin 16 Mar '25

16 Mar '25

Attention is currently required from: fixeria. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/docker-playground/+/39800?usp=email ) Change subject: osmo-{bsc,bts,sgsn}-master: remove unused deps ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/39800?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I8350091e3b0ce7af48edba10bd0b88875fe8ec41 Gerrit-Change-Number: 39800 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Sun, 16 Mar 2025 20:10:04 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in docker-playground[master]: osmo-{bsc,bts,sgsn}-master: remove unused deps
by fixeria 16 Mar '25

16 Mar '25

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/docker-playground/+/39800?usp=email ) Change subject: osmo-{bsc,bts,sgsn}-master: remove unused deps ...................................................................... osmo-{bsc,bts,sgsn}-master: remove unused deps Change-Id: I8350091e3b0ce7af48edba10bd0b88875fe8ec41 --- M osmo-bsc-master/Dockerfile M osmo-bts-master/Dockerfile M osmo-sgsn-master/Dockerfile 3 files changed, 2 insertions(+), 6 deletions(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/00/39800/1 diff --git a/osmo-bsc-master/Dockerfile b/osmo-bsc-master/Dockerfile index ff0b6fa..643d601 100644 --- a/osmo-bsc-master/Dockerfile +++ b/osmo-bsc-master/Dockerfile @@ -12,8 +12,7 @@ libosmo-abis-dev \ libosmo-netif-dev \ libosmo-sigtran-dev \ - libosmo-mgcp-client-dev \ - libgtp-dev && \ + libosmo-mgcp-client-dev && \ apt-get clean \ ;; \ centos*) \ diff --git a/osmo-bts-master/Dockerfile b/osmo-bts-master/Dockerfile index 2d0fb45..2e1b628 100644 --- a/osmo-bts-master/Dockerfile +++ b/osmo-bts-master/Dockerfile @@ -10,9 +10,7 @@ apt-get install -y --no-install-recommends \ libosmocore-dev \ libosmo-abis-dev \ - libosmo-netif-dev \ - libsmpp34-dev \ - libgtp-dev && \ + libosmo-netif-dev && \ apt-get clean \ ;; \ centos*) \ diff --git a/osmo-sgsn-master/Dockerfile b/osmo-sgsn-master/Dockerfile index 6d97458..c4455e6 100644 --- a/osmo-sgsn-master/Dockerfile +++ b/osmo-sgsn-master/Dockerfile @@ -14,7 +14,6 @@ libosmo-netif-dev \ libosmo-ranap-dev \ libosmo-sigtran-dev \ - libsmpp34-dev \ libgtp-dev \ libasn1c-dev && \ apt-get clean \ -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/39800?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I8350091e3b0ce7af48edba10bd0b88875fe8ec41 Gerrit-Change-Number: 39800 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[XS] Change in libosmocore[master]: configure.ac: check for Python interpreter unconditionally
by fixeria 15 Mar '25

15 Mar '25

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/39776?usp=email ) Change subject: configure.ac: check for Python interpreter unconditionally ...................................................................... configure.ac: check for Python interpreter unconditionally Python is required at built-time for auto-generating code. Change-Id: Ib19c4c4bb2b8dd12805ce470896ec5d82c72b064 Fixes: OS#4885 --- M configure.ac 1 file changed, 4 insertions(+), 1 deletion(-) Approvals: pespin: Looks good to me, approved Jenkins Builder: Verified osmith: Looks good to me, but someone else must approve diff --git a/configure.ac b/configure.ac index 6c7126f..25db55c 100644 --- a/configure.ac +++ b/configure.ac @@ -173,6 +173,10 @@ dnl Generate the output AC_CONFIG_HEADER(config.h) +dnl Search for a Python interpreter on the system +dnl python is needed at built-time for auto-generating code +AM_PATH_PYTHON([3.6]) + PKG_CHECK_MODULES(TALLOC, [talloc >= 2.1.0]) AC_ARG_ENABLE([uring], [AS_HELP_STRING([--disable-uring], [Build without io_uring support])], @@ -463,7 +467,6 @@ [Include the VTY/CTRL tests in make check [default=no]]), [enable_ext_tests="$enableval"],[enable_ext_tests="no"]) if test "x$enable_ext_tests" = "xyes" ; then - AM_PATH_PYTHON AC_CHECK_PROG(OSMOTESTEXT_CHECK,osmo_verify_transcript_vty.py,yes) if test "x$OSMOTESTEXT_CHECK" != "xyes" ; then AC_MSG_ERROR([Please install https://gitea.osmocom.org/cellular-infrastructure/osmo-python-tests to run the VTY/CTRL tests.]) -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/39776?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ib19c4c4bb2b8dd12805ce470896ec5d82c72b064 Gerrit-Change-Number: 39776 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in osmo-pcu[master]: csn1: Use enum to select enc/dec direction
by fixeria 15 Mar '25

15 Mar '25

Attention is currently required from: pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-pcu/+/39778?usp=email ) Change subject: csn1: Use enum to select enc/dec direction ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/39778?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I845bcab61e354436bff1c3a0f2b6f49de9705716 Gerrit-Change-Number: 39778 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Sat, 15 Mar 2025 08:03:30 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-pcu[master]: checkpath: Exclude csn1 files
by fixeria 15 Mar '25

15 Mar '25

Attention is currently required from: osmith, pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-pcu/+/39782?usp=email ) Change subject: checkpath: Exclude csn1 files ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/39782?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Ib6e7d2dcc3d8f262092f0100e55cad397aa226f4 Gerrit-Change-Number: 39782 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Sat, 15 Mar 2025 08:03:19 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in libosmo-abis[master]: trau2rtp HR: update to TW-TS-002 version 1.2.0
by falconia 15 Mar '25

15 Mar '25

falconia has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-abis/+/39799?usp=email ) Change subject: trau2rtp HR: update to TW-TS-002 version 1.2.0 ...................................................................... trau2rtp HR: update to TW-TS-002 version 1.2.0 osmo_trau2rtp() in HRv1 mode emits either RFC 5993 or TW-TS-002 format, depending on whether or not the latter extended format is enabled. TW-TS-002 can represent BFIs and invalid SID frames, in addition to good speech and valid SID in common with RFC 5993. TW-TS-002 spec has recently been updated to version 1.2.0: https://www.freecalypso.org/specs/tw-ts-002-v010200.txt The principal difference is the way invalid SID frames are represented: in version 1.1.0 all payload bits were stripped in the case of invalid SID; version 1.2.0 allows these payload bits to be preserved if they exist. Section 5.4 in the new spec version provides the detailed rationale for this change. Change osmo_trau2rtp() operating on HR frames in TW-TS-002 mode to emit invalid SID frames in the "verbose" form of TW-TS-002 version 1.2.0. Compatibility considerations: there is no currently released or deployed software that accepts TW-TS-002 version 1.1.0 but not version 1.2.0. More specifically: * osmo_rtp2trau() in TRAU-UL/TFO output mode accepts invalid SID in both short and long forms since first implementation; * Themyscira libgsmhr1, the library that accepts TW-TS-002 RTP input for either full speech decoding or TFO transform, has not yet reached its first release. The current code in Hg implements TW-TS-002 version 1.2.0, thus the library will support both short and long forms of invalid SID upon its upcoming first release. Change-Id: I497ad7b1f0f7229dc9a50cd3cc318e3dc1394171 --- M src/trau/trau_rtp_conv.c M tests/trau_conv/trau2rtp_hr_twts002.ok 2 files changed, 7 insertions(+), 5 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-abis refs/changes/99/39799/1 diff --git a/src/trau/trau_rtp_conv.c b/src/trau/trau_rtp_conv.c index a36d317..f2e0022 100644 --- a/src/trau/trau_rtp_conv.c +++ b/src/trau/trau_rtp_conv.c @@ -294,9 +294,10 @@ if (tf->c_bits[11] && sidc == OSMO_GSM631_SID_CLASS_SPEECH) out[0] = FT_BFI_WITH_DATA << 4; twts002_hr16_set_extra_flags(out, tf); - /* invalid SID frames are truncated in TW-TS-002 */ + /* Invalid SID handling updated in TW-TS-002 version 1.2.0: + * see sections 5.4 and 6.2.3. */ if (sidc == OSMO_GSM631_SID_CLASS_INVALID) - return 1; + out[0] |= 0x04; /* Invalid_SID_Verbose bit */ } /* TS 101 318 Section 5.2: The order of occurrence of the codec parameters in the buffer is @@ -398,12 +399,13 @@ /* can be represented only in TW-TS-002, not in RFC 5993 */ if (!emit_twts002) return 0; - out[0] = FT_INVALID_SID << 4; + out[0] = (FT_INVALID_SID << 4) | 0x04; /* Invalid_SID_Verbose */ twts002_hr8_set_extra_flags(out, tf); /* XC4 is TAF with this frame type */ if (tf->xc_bits[3]) out[0] |= 0x01; - return 1; /* short format per TW-TS-002 */ + osmo_ubit2pbit(out + 1, tf->d_bits, 112); + return GSM_HR_BYTES_RTP_RFC5993; case 6: case 7: /* bad speech frame (BFI=1, SID=0) */ diff --git a/tests/trau_conv/trau2rtp_hr_twts002.ok b/tests/trau_conv/trau2rtp_hr_twts002.ok index db65082..3593eb9 100644 --- a/tests/trau_conv/trau2rtp_hr_twts002.ok +++ b/tests/trau_conv/trau2rtp_hr_twts002.ok @@ -7,7 +7,7 @@ 00C4FF2305E137DF28F928DD5231EB 00CCFF0580FEB85D20AF485C70CFD0 20025FBB32FFFFFFFFFFFFFFFFFFFF -10 +140399BCE3FFFFFFFFFFFFDD7FFAFF 70 70 70 -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/39799?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I497ad7b1f0f7229dc9a50cd3cc318e3dc1394171 Gerrit-Change-Number: 39799 Gerrit-PatchSet: 1 Gerrit-Owner: falconia <falcon(a)freecalypso.org>

1 0

2026

2025

2024

2023

2022

gerrit-log