- gerrit-log - lists.osmocom.org

[XS] Change in osmo-ci[master]: lint/lint_diff: allow skipping with OSMO_LINT=0
by laforge 17 Mar '25

17 Mar '25

Attention is currently required from: osmith. laforge has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ci/+/39797?usp=email ) Change subject: lint/lint_diff: allow skipping with OSMO_LINT=0 ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/39797?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ia4563c13d9916a879a1e8afeacad8c541662adaa Gerrit-Change-Number: 39797 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Mon, 17 Mar 2025 11:57:59 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in libosmocore[master]: cosmetic: lapd: Fix typo in comment
by pespin 17 Mar '25

17 Mar '25

pespin has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/39806?usp=email ) Change subject: cosmetic: lapd: Fix typo in comment ...................................................................... cosmetic: lapd: Fix typo in comment Change-Id: Ica6df273b95b25d217ff19bb3686ae1990790d94 --- M src/gsm/lapdm.c 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/gsm/lapdm.c b/src/gsm/lapdm.c index 1fc986d..61ea535 100644 --- a/src/gsm/lapdm.c +++ b/src/gsm/lapdm.c @@ -301,7 +301,7 @@ } } -/* lfush and release all resources in LAPDm channel +/* flush and release all resources in LAPDm channel * * A convenience wrapper calling \ref lapdm_entity_exit on both * entities inside the \ref lapdm_channel -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/39806?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ica6df273b95b25d217ff19bb3686ae1990790d94 Gerrit-Change-Number: 39806 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in osmo-bsc[master]: TW-TS-* support: pass RTP extensions to MGW
by laforge 17 Mar '25

17 Mar '25

Attention is currently required from: falconia. laforge has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/osmo-bsc/+/39798?usp=email ) Change subject: TW-TS-* support: pass RTP extensions to MGW ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/39798?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Iaa6e4c56313f06b79852c06dcec686f21950e638 Gerrit-Change-Number: 39798 Gerrit-PatchSet: 1 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: falconia <falcon(a)freecalypso.org> Gerrit-Comment-Date: Mon, 17 Mar 2025 11:57:30 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in libosmocore[master]: lapd: Take talloc msgb ownsership when enqueueing it
by pespin 17 Mar '25

17 Mar '25

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/39807?usp=email ) Change subject: lapd: Take talloc msgb ownsership when enqueueing it ...................................................................... lapd: Take talloc msgb ownsership when enqueueing it Otherwise the msg talloc rererence is kept parented at some unknown pointer in some unknown upper layer. Related: OS#6728 Change-Id: I32729060b5a18576310b3789da522f4392d9611e --- M src/isdn/lapd_core.c 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/07/39807/1 diff --git a/src/isdn/lapd_core.c b/src/isdn/lapd_core.c index b32ed26..b26edfc 100644 --- a/src/isdn/lapd_core.c +++ b/src/isdn/lapd_core.c @@ -1922,6 +1922,8 @@ LOGDL(dl, LOGL_INFO, "writing message to send-queue: l3len: %d\n", msgb_l3len(msg)); + /* Take ownsership of msg, since we are keeping it around in this layer: */ + talloc_steal(tall_lapd_ctx, msg); /* Write data into the send queue */ msgb_enqueue(&dl->send_queue, msg); -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/39807?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I32729060b5a18576310b3789da522f4392d9611e Gerrit-Change-Number: 39807 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in libosmocore[master]: lapdm: Take talloc msgb ownsership when enqueueing it
by pespin 17 Mar '25

17 Mar '25

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/39808?usp=email ) Change subject: lapdm: Take talloc msgb ownsership when enqueueing it ...................................................................... lapdm: Take talloc msgb ownsership when enqueueing it Otherwise the msg talloc rererence is kept parented at some unknown pointer in some unknown upper layer. Change-Id: Iba7b11bd9541c883588f34df67fdd865d72710d7 Related: OS#6728 --- M src/gsm/lapdm.c 1 file changed, 4 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/08/39808/1 diff --git a/src/gsm/lapdm.c b/src/gsm/lapdm.c index 61ea535..8f7db90 100644 --- a/src/gsm/lapdm.c +++ b/src/gsm/lapdm.c @@ -376,6 +376,8 @@ *msgb_push(msg, 1) = pad; *msgb_push(msg, 1) = link_id; *msgb_push(msg, 1) = chan_nr; + /* Take ownsership of msg, since we are keeping it around in this layer: */ + talloc_steal(tall_lapd_ctx, msg); msgb_enqueue(&dl->dl.tx_queue, msg); return 0; } @@ -403,6 +405,8 @@ *msgb_push(msg, 1) = pad; *msgb_push(msg, 1) = link_id; *msgb_push(msg, 1) = chan_nr; + /* Take ownsership of msg, since we are keeping it around in this layer: */ + talloc_steal(tall_lapd_ctx, msg); msgb_enqueue(&dl->tx_ui_queue, msg); return 0; } -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/39808?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Iba7b11bd9541c883588f34df67fdd865d72710d7 Gerrit-Change-Number: 39808 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in libosmo-abis[master]: trau2rtp HR: update to TW-TS-002 version 1.2.0
by laforge 17 Mar '25

17 Mar '25

Attention is currently required from: falconia. laforge has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/libosmo-abis/+/39799?usp=email ) Change subject: trau2rtp HR: update to TW-TS-002 version 1.2.0 ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/39799?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I497ad7b1f0f7229dc9a50cd3cc318e3dc1394171 Gerrit-Change-Number: 39799 Gerrit-PatchSet: 1 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: falconia <falcon(a)freecalypso.org> Gerrit-Comment-Date: Mon, 17 Mar 2025 11:56:41 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in libosmo-abis[master]: examples/lapd-over-datagram: Use newer non-deprecated API lapd_instan...
by laforge 17 Mar '25

17 Mar '25

Attention is currently required from: pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-abis/+/39805?usp=email ) Change subject: examples/lapd-over-datagram: Use newer non-deprecated API lapd_instance_alloc2() ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/39805?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I548343db3bf5d2375ed1c77f3d0474a2d0c80476 Gerrit-Change-Number: 39805 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 17 Mar 2025 11:55:23 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in libosmocore[master]: cosmetic: lapd: Fix typo in comment
by laforge 17 Mar '25

17 Mar '25

Attention is currently required from: pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmocore/+/39806?usp=email ) Change subject: cosmetic: lapd: Fix typo in comment ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/39806?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ica6df273b95b25d217ff19bb3686ae1990790d94 Gerrit-Change-Number: 39806 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 17 Mar 2025 11:55:04 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in libosmocore[master]: cosmetic: lapd: Fix typo in comment
by pespin 17 Mar '25

17 Mar '25

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/39806?usp=email ) Change subject: cosmetic: lapd: Fix typo in comment ...................................................................... cosmetic: lapd: Fix typo in comment Change-Id: Ica6df273b95b25d217ff19bb3686ae1990790d94 --- M src/gsm/lapdm.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/06/39806/1 diff --git a/src/gsm/lapdm.c b/src/gsm/lapdm.c index 1fc986d..61ea535 100644 --- a/src/gsm/lapdm.c +++ b/src/gsm/lapdm.c @@ -301,7 +301,7 @@ } } -/* lfush and release all resources in LAPDm channel +/* flush and release all resources in LAPDm channel * * A convenience wrapper calling \ref lapdm_entity_exit on both * entities inside the \ref lapdm_channel -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/39806?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ica6df273b95b25d217ff19bb3686ae1990790d94 Gerrit-Change-Number: 39806 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in libosmo-abis[master]: examples/lapd-over-datagram: Use newer non-deprecated API lapd_instan...
by pespin 17 Mar '25

17 Mar '25

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-abis/+/39805?usp=email ) Change subject: examples/lapd-over-datagram: Use newer non-deprecated API lapd_instance_alloc2() ...................................................................... examples/lapd-over-datagram: Use newer non-deprecated API lapd_instance_alloc2() libosmocore API lapd_instance_alloc() has been deprecated for a while now. Change-Id: I548343db3bf5d2375ed1c77f3d0474a2d0c80476 --- M doc/examples/lapd-over-datagram/lapd-over-datagram-network.c M doc/examples/lapd-over-datagram/lapd-over-datagram-user.c 2 files changed, 4 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-abis refs/changes/05/39805/1 diff --git a/doc/examples/lapd-over-datagram/lapd-over-datagram-network.c b/doc/examples/lapd-over-datagram/lapd-over-datagram-network.c index 8915e81..eecba8e 100644 --- a/doc/examples/lapd-over-datagram/lapd-over-datagram-network.c +++ b/doc/examples/lapd-over-datagram/lapd-over-datagram-network.c @@ -151,8 +151,8 @@ osmo_dgram_set_remote_port(conn, 10000); osmo_dgram_set_read_cb(conn, read_cb); - lapd = lapd_instance_alloc(1, lapd_tx_cb, conn, lapd_rx_cb, conn, - &lapd_profile_sat); + lapd = lapd_instance_alloc2(1, lapd_tx_cb, conn, lapd_rx_cb, conn, + &lapd_profile_sat, "lapd_test"); if (lapd == NULL) { LOGP(DLAPDTEST, LOGL_ERROR, "cannot allocate instance\n"); exit(EXIT_FAILURE); diff --git a/doc/examples/lapd-over-datagram/lapd-over-datagram-user.c b/doc/examples/lapd-over-datagram/lapd-over-datagram-user.c index c988b22..5eb58e8 100644 --- a/doc/examples/lapd-over-datagram/lapd-over-datagram-user.c +++ b/doc/examples/lapd-over-datagram/lapd-over-datagram-user.c @@ -201,8 +201,8 @@ * initialize LAPD stuff. */ - lapd = lapd_instance_alloc(0, lapd_tx_cb, NULL, lapd_rx_cb, &num_msgs, - &lapd_profile_sat); + lapd = lapd_instance_alloc2(0, lapd_tx_cb, NULL, lapd_rx_cb, &num_msgs, + &lapd_profile_sat, "lapd_test"); if (lapd == NULL) { LOGP(DLINP, LOGL_ERROR, "cannot allocate instance\n"); exit(EXIT_FAILURE); -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/39805?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I548343db3bf5d2375ed1c77f3d0474a2d0c80476 Gerrit-Change-Number: 39805 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

2026

2025

2024

2023

2022

gerrit-log