Attention is currently required from: fixeria.
pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmocore/+/39941?usp=email )
Change subject: vty: Add 'show runtime' command
......................................................................
Patch Set 1:
(1 comment)
File src/vty/misc_vty.c:
https://gerrit.osmocom.org/c/libosmocore/+/39941/comment/f352c4dd_3ad37bd3?… :
PS1, Line 23: config.h
> Do we actually use this header here?
In general I prefer keeping the config.h included everywhere, to avoid weird scenarios where some define is checked but then silently failed to ever be defined.
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/39941?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I7994c820894b3525bfe78b5d389ff30a1e543226
Gerrit-Change-Number: 39941
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 07 Apr 2025 10:45:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Attention is currently required from: pespin.
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/upf-benchmark/+/39931?usp=email
to look at the new patch set (#2).
The following approvals got outdated and were removed:
Verified-1 by Jenkins Builder
Change subject: testsuites: eupf: Apply correct iface name in yaml file
......................................................................
testsuites: eupf: Apply correct iface name in yaml file
Change-Id: Idde13ca376fa97ddc509a9f2d53a0ca903e7f46f
---
M testsuites/gtplab-sysmo2025/tunend/upf/eupf/configure.sh
M testsuites/gtplab-sysmo2025/tunend/upf/eupf/eupf.yaml
M testsuites/gtplab-sysmo2025/tunmap/upf/eupf/configure.sh
M testsuites/gtplab-sysmo2025/tunmap/upf/eupf/eupf.yaml
M testsuites/gtplab-sysmo2025/tunmap/upf/osmo-upf/configure.sh
5 files changed, 11 insertions(+), 2 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/upf-benchmark refs/changes/31/39931/2
--
To view, visit https://gerrit.osmocom.org/c/upf-benchmark/+/39931?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: upf-benchmark
Gerrit-Branch: master
Gerrit-Change-Id: Idde13ca376fa97ddc509a9f2d53a0ca903e7f46f
Gerrit-Change-Number: 39931
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Attention: pespin <pespin(a)sysmocom.de>