Attention is currently required from: Hoernchen, laforge.
osmith has uploaded a new patch set (#4) to the change originally created by Hoernchen. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27341?usp=email )
Change subject: octsim: initial commit
......................................................................
octsim: initial commit
This testsuite is for the sysmoOCTSIM.
Related: https://www.sysmocom.de/products/sim/sysmooctsim/
Related: SYS#5489
Tweaked-by: Eric Wild <ewild(a)sysmocom.de>
Tweaked-by: Oliver Smith <osmith(a)sysmocom.de>
Change-Id: Iada6422d694eb5fc862477c8b43b8642c8d96692
---
M Makefile
A octsim/OCTSIM_Tests.cfg
A octsim/OCTSIM_Tests.default
A octsim/OCTSIM_Tests.ttcn
A octsim/README.md
A octsim/gen_links.sh
A octsim/regen_makefile.sh
7 files changed, 313 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/41/27341/4
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27341?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Iada6422d694eb5fc862477c8b43b8642c8d96692
Gerrit-Change-Number: 27341
Gerrit-PatchSet: 4
Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-CC: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Attention is currently required from: Hoernchen, laforge.
osmith has posted comments on this change by Hoernchen. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27341?usp=email )
Change subject: octsim: initial commit
......................................................................
Patch Set 3:
(1 comment)
Commit Message:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27341/comment/86def883_80f8… :
PS1, Line 7: octsim: initial commit
> ping? It has been 2 months...
I've rebased the patchset and added a link to https://www.sysmocom.de/products/sim/sysmooctsim/. See also SYS#5489.
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27341?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Iada6422d694eb5fc862477c8b43b8642c8d96692
Gerrit-Change-Number: 27341
Gerrit-PatchSet: 3
Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-CC: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Comment-Date: Wed, 25 Jun 2025 09:51:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>
Attention is currently required from: Hoernchen.
osmith has uploaded a new patch set (#3) to the change originally created by Hoernchen. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27342?usp=email )
The following approvals got outdated and were removed:
Verified+1 by Jenkins Builder
The change is no longer submittable: Verified is unsatisfied now.
Change subject: simtrace emulation: check that port is connected to prevent errors due to delayed msg
......................................................................
simtrace emulation: check that port is connected to prevent errors due to delayed msg
Change-Id: I5d5dda0cf1443223b2615f1059cfdcf698f1acae
---
M library/SIMTRACE_Emulation.ttcn
1 file changed, 6 insertions(+), 2 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/42/27342/3
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27342?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I5d5dda0cf1443223b2615f1059cfdcf698f1acae
Gerrit-Change-Number: 27342
Gerrit-PatchSet: 3
Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de>
Attention is currently required from: Hoernchen.
osmith has uploaded a new patch set (#3) to the change originally created by Hoernchen. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27341?usp=email )
Change subject: octsim: initial commit
......................................................................
octsim: initial commit
This testsuite is for the sysmoOCTSIM.
Related: https://www.sysmocom.de/products/sim/sysmooctsim/
Tweaked-by: Eric Wild <ewild(a)sysmocom.de>
Tweaked-by: Oliver Smith <osmith(a)sysmocom.de>
Change-Id: Iada6422d694eb5fc862477c8b43b8642c8d96692
---
M Makefile
A octsim/OCTSIM_Tests.cfg
A octsim/OCTSIM_Tests.default
A octsim/OCTSIM_Tests.ttcn
A octsim/README.md
A octsim/gen_links.sh
A octsim/regen_makefile.sh
7 files changed, 313 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/41/27341/3
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27341?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Iada6422d694eb5fc862477c8b43b8642c8d96692
Gerrit-Change-Number: 27341
Gerrit-PatchSet: 3
Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de>
Attention is currently required from: Hoernchen.
osmith has uploaded a new patch set (#2) to the change originally created by Hoernchen. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27342?usp=email )
The following approvals got outdated and were removed:
Verified+1 by Jenkins Builder
The change is no longer submittable: Verified is unsatisfied now.
Change subject: simtrace emulation: check that port is connected to prevent errors due to delayed msg
......................................................................
simtrace emulation: check that port is connected to prevent errors due to delayed msg
Change-Id: I5d5dda0cf1443223b2615f1059cfdcf698f1acae
---
M library/SIMTRACE_Emulation.ttcn
1 file changed, 6 insertions(+), 2 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/42/27342/2
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27342?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I5d5dda0cf1443223b2615f1059cfdcf698f1acae
Gerrit-Change-Number: 27342
Gerrit-PatchSet: 2
Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de>
Attention is currently required from: Hoernchen.
osmith has uploaded a new patch set (#2) to the change originally created by Hoernchen. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27341?usp=email )
The following approvals got outdated and were removed:
Verified-1 by Jenkins Builder
Change subject: octsim: initial commit
......................................................................
octsim: initial commit
This testsuite is for the sysmoOCTSIM.
Related: https://www.sysmocom.de/products/sim/sysmooctsim/
Tweaked-by: Eric Wild <ewild(a)sysmocom.de>
Tweaked-by: Oliver Smith <osmith(a)sysmocom.de>
Change-Id: Iada6422d694eb5fc862477c8b43b8642c8d96692
---
M Makefile
A octsim/OCTSIM_Tests.cfg
A octsim/OCTSIM_Tests.default
A octsim/OCTSIM_Tests.ttcn
A octsim/README.md
A octsim/gen_links.sh
A octsim/regen_makefile.sh
7 files changed, 313 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/41/27341/2
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27341?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Iada6422d694eb5fc862477c8b43b8642c8d96692
Gerrit-Change-Number: 27341
Gerrit-PatchSet: 2
Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de>
Attention is currently required from: Hoernchen, laforge.
osmith has uploaded a new patch set (#2) to the change originally created by Hoernchen. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27343?usp=email )
The following approvals got outdated and were removed:
Code-Review+1 by laforge, Verified-1 by Jenkins Builder
Change subject: simtrace emulation: set usb configuration
......................................................................
simtrace emulation: set usb configuration
Tweaked-by: Oliver Smith <osmith(a)sysmocom.de>
Change-Id: I9def79343b4d2575f8b1bc7b9c9c8170b631ed49
---
M deps/Makefile
M library/SIMTRACE_Emulation.ttcn
2 files changed, 2 insertions(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/43/27343/2
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27343?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I9def79343b4d2575f8b1bc7b9c9c8170b631ed49
Gerrit-Change-Number: 27343
Gerrit-PatchSet: 2
Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Attention is currently required from: dexter, laforge.
Hoernchen has posted comments on this change by Hoernchen. ( https://gerrit.osmocom.org/c/pysim/+/40464?usp=email )
Change subject: smdpp: add proper tls support, cert generation FOR TESTING
......................................................................
Patch Set 6:
(7 comments)
File contrib/generate_smdpp_certs.py:
https://gerrit.osmocom.org/c/pysim/+/40464/comment/339f62a9_c8663cc1?usp=em… :
PS5, Line 2:
> To me this looks like an independent tool. […]
no, this is the tool and these are the options, these things belong together and make absolutely no sense as single commits with random mystery options and useless certs.
File osmo-smdpp.py:
https://gerrit.osmocom.org/c/pysim/+/40464/comment/4382ca7d_ea805b69?usp=em… :
PS5, Line 26: from pathlib import Path
> You have moved a lot of those imports from another code location. […]
Done
https://gerrit.osmocom.org/c/pysim/+/40464/comment/bc8c1331_3407f1b1?usp=em… :
PS5, Line 53:
> We now support SSL and we have means to point to different certificate sub directories. […]
not related to this patch at all, we cann add stuff if we need it later.
https://gerrit.osmocom.org/c/pysim/+/40464/comment/6ee98918_c7b38b8d?usp=em… :
PS5, Line 586: parser.add_argument("-p", "--port", help="TCP port to bind HTTP to", default=8000)
> Maybe 8443, since we now support SSL?
no, because that is being used by something else on my system, we really do not want to default to a port commonly used for anything like https for a toy smdpp.
https://gerrit.osmocom.org/c/pysim/+/40464/comment/3817ef0e_da2c40d3?usp=em… :
PS5, Line 587: parser.add_argument("-c", "--certpath", help=f"cert subdir relative to {DATA_DIR}", default="certs")
> I think --certpath is a bit irritating as one may thing that it is possible to provide an absolute p […]
Done .. the help line literally explains that it is relative
https://gerrit.osmocom.org/c/pysim/+/40464/comment/a7b3dcc9_fe1f3390?usp=em… :
PS5, Line 588: parser.add_argument("-s", "--nossl", help="do NOT use ssl", action='store_true', default=False)
> I wonder if this may break anything when osmo-smdpp suddenly supports SSL by default. […]
The number of users is probably... low.. anyway.
https://gerrit.osmocom.org/c/pysim/+/40464/comment/f5aa1340_7306aee3?usp=em… :
PS5, Line 591: common_cert_path = os.path.join(DATA_DIR, args.certpath)
> (see above) Maybe having DATA_DIR as a commandline parameter would be a good idea.
I dont't need it, and it is not related to this patch either.
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/40464?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I84b2666422b8ff565620f3827ef4d4d7635a21be
Gerrit-Change-Number: 40464
Gerrit-PatchSet: 6
Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 25 Jun 2025 08:51:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: dexter <pmaier(a)sysmocom.de>