Attention is currently required from: Hoernchen, laforge, pespin.
osmith has posted comments on this change by Hoernchen. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27341?usp=email )
Change subject: octsim: initial commit
......................................................................
Patch Set 5:
(2 comments)
File octsim/OCTSIM_Tests.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27341/comment/0b427f35_173c… :
PS4, Line 22: //USB_Device_Match mp_usb_dev_match := { vid_pid := { vid := '1d50'H, pid := '60e3'H} };
> can this be dropped?
Done
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27341/comment/60ee2d75_b280… :
PS4, Line 74: //activate(as_Tguard);
> would be great to have Tguard working from the first commit...
I took over the patches from Eric, but can't test them currently as I don't have access to an octsim-tester setup. In SYS#5489#note-20 I posted an idea of how to test it in jenkins.
I'll wait with making more (especially non-cosmetic) changes until I can actually run the tests and verify they still work as intended.
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27341?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Iada6422d694eb5fc862477c8b43b8642c8d96692
Gerrit-Change-Number: 27341
Gerrit-PatchSet: 5
Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-CC: osmith <osmith(a)sysmocom.de>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 25 Jun 2025 13:23:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Attention is currently required from: Hoernchen, pespin.
osmith has posted comments on this change by Hoernchen. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27345?usp=email )
Change subject: octsim: tester support
......................................................................
Patch Set 6:
(1 comment)
File octsim/OCTSIM_Tests.cfg:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27345/comment/1e9c90c5_3583… :
PS5, Line 10: LogFile := "%e-%c-%h-%r.%s"
> I don't recall we have all of this in any testsuite. […]
@ewild@sysmocom.de: do you recall what the purpose of using custom logging here was / can this be removed?
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27345?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Id7c7e529a5444cffc8e79b385959a522dc9a6beb
Gerrit-Change-Number: 27345
Gerrit-PatchSet: 6
Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-CC: osmith <osmith(a)sysmocom.de>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 25 Jun 2025 13:18:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Attention is currently required from: Hoernchen, pespin.
osmith has posted comments on this change by Hoernchen. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27345?usp=email )
Change subject: octsim: tester support
......................................................................
Patch Set 5:
(2 comments)
File octsim/OCTSIM_Tests.cfg:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27345/comment/6196c74d_5cb1… :
PS5, Line 28: #OCTSIM_Tests.TC_test_grouped
> this can be removed.
Done
File octsim/OCTSIM_Tests.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27345/comment/95459b15_5458… :
PS5, Line 583: python to generate tests
> This can most probably go into a separate file?
Done
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27345?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Id7c7e529a5444cffc8e79b385959a522dc9a6beb
Gerrit-Change-Number: 27345
Gerrit-PatchSet: 5
Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-CC: osmith <osmith(a)sysmocom.de>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 25 Jun 2025 13:18:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Attention is currently required from: Hoernchen, laforge, osmith.
osmith has uploaded a new patch set (#5) to the change originally created by Hoernchen. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27341?usp=email )
The following approvals got outdated and were removed:
Verified+1 by Jenkins Builder
Change subject: octsim: initial commit
......................................................................
octsim: initial commit
This testsuite is for the sysmoOCTSIM.
Related: https://www.sysmocom.de/products/sim/sysmooctsim/
Related: SYS#5489
Tweaked-by: Eric Wild <ewild(a)sysmocom.de>
Tweaked-by: Oliver Smith <osmith(a)sysmocom.de>
Change-Id: Iada6422d694eb5fc862477c8b43b8642c8d96692
---
M Makefile
A octsim/OCTSIM_Tests.cfg
A octsim/OCTSIM_Tests.default
A octsim/OCTSIM_Tests.ttcn
A octsim/README.md
A octsim/gen_links.sh
A octsim/regen_makefile.sh
7 files changed, 312 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/41/27341/5
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27341?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Iada6422d694eb5fc862477c8b43b8642c8d96692
Gerrit-Change-Number: 27341
Gerrit-PatchSet: 5
Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-CC: osmith <osmith(a)sysmocom.de>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Attention is currently required from: Hoernchen, osmith.
osmith has uploaded a new patch set (#5) to the change originally created by Hoernchen. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27342?usp=email )
The following approvals got outdated and were removed:
Verified+1 by Jenkins Builder
The change is no longer submittable: Verified is unsatisfied now.
Change subject: simtrace emulation: check that port is connected to prevent errors due to delayed msg
......................................................................
simtrace emulation: check that port is connected to prevent errors due to delayed msg
Change-Id: I5d5dda0cf1443223b2615f1059cfdcf698f1acae
---
M library/SIMTRACE_Emulation.ttcn
1 file changed, 6 insertions(+), 2 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/42/27342/5
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27342?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I5d5dda0cf1443223b2615f1059cfdcf698f1acae
Gerrit-Change-Number: 27342
Gerrit-PatchSet: 5
Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de>
Attention is currently required from: Hoernchen, osmith.
osmith has uploaded a new patch set (#6) to the change originally created by Hoernchen. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27345?usp=email )
The following approvals got outdated and were removed:
Verified+1 by Jenkins Builder
Change subject: octsim: tester support
......................................................................
octsim: tester support
This adds tests for the octsim tester that try all voltages on all slots,
5v tests use the default (slow) rate because the cables apparently make higher
rates at higher voltages a bit error prone.
Tweaked-by: Oliver Smith <osmith(a)sysmocom.de>
Change-Id: Id7c7e529a5444cffc8e79b385959a522dc9a6beb
---
M octsim/OCTSIM_Tests.cfg
M octsim/OCTSIM_Tests.ttcn
A octsim/generate_tests.py
3 files changed, 430 insertions(+), 50 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/45/27345/6
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27345?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Id7c7e529a5444cffc8e79b385959a522dc9a6beb
Gerrit-Change-Number: 27345
Gerrit-PatchSet: 6
Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de>
Attention is currently required from: pespin.
osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40521?usp=email )
Change subject: stp: m3ua: Introduce test TC_combinedlset_loadshare
......................................................................
Patch Set 4: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40521?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I20a67648072f4d9839b1d1fceded1680362bf979
Gerrit-Change-Number: 40521
Gerrit-PatchSet: 4
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 25 Jun 2025 13:00:58 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: pespin.
osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/40500?usp=email )
Change subject: Move sccp_address_book logic out of vty.c
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/40500?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: libosmo-sigtran
Gerrit-Branch: master
Gerrit-Change-Id: Ib37a2503b8cf0fadce9072020e0e14a2a05561bf
Gerrit-Change-Number: 40500
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 25 Jun 2025 12:46:46 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes