- gerrit-log - lists.osmocom.org

[XS] Change in libosmo-sigtran[master]: cosmetic: sua: Fix API documentation typo
by osmith 25 Jun '25

25 Jun '25

Attention is currently required from: pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/40499?usp=email ) Change subject: cosmetic: sua: Fix API documentation typo ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/40499?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I5aa42a3dfd5782425e23278f1b6a8ee8b9af2cac Gerrit-Change-Number: 40499 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 25 Jun 2025 12:44:24 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in libosmo-sigtran[master]: xua_snm.c: Handle DAUD with aff_pc containing wildcards
by osmith 25 Jun '25

25 Jun '25

Attention is currently required from: daniel, pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/40498?usp=email ) Change subject: xua_snm.c: Handle DAUD with aff_pc containing wildcards ...................................................................... Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/40498?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: Icdb726ae66d3bee19b2113b1e77d68b517e8fb4d Gerrit-Change-Number: 40498 Gerrit-PatchSet: 4 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Wed, 25 Jun 2025 12:44:16 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in osmo-ttcn3-hacks[master]: stp: m3ua: Introduce test TC_combinedlset_loadshare
by pespin 25 Jun '25

25 Jun '25

Attention is currently required from: osmith. Hello Jenkins Builder, osmith, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40521?usp=email to look at the new patch set (#4). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: stp: m3ua: Introduce test TC_combinedlset_loadshare ...................................................................... stp: m3ua: Introduce test TC_combinedlset_loadshare Test combined linkset loadsharing on M3UA AS. Related: SYS#7112 Change-Id: I20a67648072f4d9839b1d1fceded1680362bf979 --- M stp/STP_Tests_M3UA.cfg M stp/STP_Tests_M3UA.ttcn M stp/expected-results.xml M stp/osmo-stp-m3ua.confmerge 4 files changed, 129 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/21/40521/4 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40521?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I20a67648072f4d9839b1d1fceded1680362bf979 Gerrit-Change-Number: 40521 Gerrit-PatchSet: 4 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de>

1 0

[M] Change in osmo-ttcn3-hacks[master]: stp: m3ua: Introduce test TC_combinedlset_loadshare
by pespin 25 Jun '25

25 Jun '25

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40521?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: stp: m3ua: Introduce test TC_combinedlset_loadshare ...................................................................... stp: m3ua: Introduce test TC_combinedlset_loadshare Test combined linkset loadsharing on M3UA AS. Related: SYS#7112 Change-Id: I20a67648072f4d9839b1d1fceded1680362bf979 --- M stp/STP_Tests_M3UA.cfg M stp/STP_Tests_M3UA.ttcn M stp/expected-results.xml M stp/osmo-stp-m3ua.confmerge 4 files changed, 128 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/21/40521/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40521?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I20a67648072f4d9839b1d1fceded1680362bf979 Gerrit-Change-Number: 40521 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder

1 0

[L] Change in osmo-ttcn3-hacks[master]: octsim: tester support
by pespin 25 Jun '25

25 Jun '25

Attention is currently required from: Hoernchen, osmith. pespin has posted comments on this change by Hoernchen. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27345?usp=email ) Change subject: octsim: tester support ...................................................................... Patch Set 5: (3 comments) File octsim/OCTSIM_Tests.cfg: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27345/comment/9693171a_9b26… : PS5, Line 10: LogFile := "%e-%c-%h-%r.%s" I don't recall we have all of this in any testsuite. Are you sure this is needed? is it for personal specific debugging? https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27345/comment/2298dbc1_9319… : PS5, Line 28: #OCTSIM_Tests.TC_test_grouped this can be removed. File octsim/OCTSIM_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27345/comment/38513726_5e58… : PS5, Line 583: python to generate tests This can most probably go into a separate file? -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27345?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Id7c7e529a5444cffc8e79b385959a522dc9a6beb Gerrit-Change-Number: 27345 Gerrit-PatchSet: 5 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Comment-Date: Wed, 25 Jun 2025 11:28:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[XS] Change in osmo-ttcn3-hacks[master]: simtrace emulation: adjust templates to support octsim tester
by pespin 25 Jun '25

25 Jun '25

Attention is currently required from: Hoernchen, laforge, osmith. pespin has posted comments on this change by Hoernchen. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27344?usp=email ) Change subject: simtrace emulation: adjust templates to support octsim tester ...................................................................... Patch Set 5: (1 comment) Commit Message: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27344/comment/5168b909_96e8… : PS5, Line 9: It has multiple switchable slots. by "multiple" you mean "two"? because I see you are limiting some range to 0..1. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27344?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I00576170a2b6921d99906ed8bd45d9eece053056 Gerrit-Change-Number: 27344 Gerrit-PatchSet: 5 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Wed, 25 Jun 2025 11:24:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[XS] Change in osmo-ttcn3-hacks[master]: simtrace emulation: set usb configuration
by pespin 25 Jun '25

25 Jun '25

Attention is currently required from: Hoernchen, laforge, osmith. pespin has posted comments on this change by Hoernchen. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27343?usp=email ) Change subject: simtrace emulation: set usb configuration ...................................................................... Patch Set 4: (1 comment) Patchset: PS4: A bit of description on what's that configuration "1" and why it needs to be set would be welcome... -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27343?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I9def79343b4d2575f8b1bc7b9c9c8170b631ed49 Gerrit-Change-Number: 27343 Gerrit-PatchSet: 4 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Wed, 25 Jun 2025 11:23:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[XS] Change in osmo-ttcn3-hacks[master]: simtrace emulation: check that port is connected to prevent errors du...
by pespin 25 Jun '25

25 Jun '25

Attention is currently required from: Hoernchen, osmith. pespin has posted comments on this change by Hoernchen. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27342?usp=email ) Change subject: simtrace emulation: check that port is connected to prevent errors due to delayed msg ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27342?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I5d5dda0cf1443223b2615f1059cfdcf698f1acae Gerrit-Change-Number: 27342 Gerrit-PatchSet: 4 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Comment-Date: Wed, 25 Jun 2025 11:20:54 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[L] Change in osmo-ttcn3-hacks[master]: octsim: initial commit
by pespin 25 Jun '25

25 Jun '25

Attention is currently required from: Hoernchen, laforge, osmith. pespin has posted comments on this change by Hoernchen. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27341?usp=email ) Change subject: octsim: initial commit ...................................................................... Patch Set 4: (6 comments) File octsim/OCTSIM_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27341/comment/7fc8dc30_02cf… : PS4, Line 22: //USB_Device_Match mp_usb_dev_match := { vid_pid := { vid := '1d50'H, pid := '60e3'H} }; can this be dropped? https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27341/comment/cb08642c_22ef… : PS4, Line 36: private template (value) USB_IF_Params ts_UsbPars_path(charstring path, uint8_t if_nr) := { shouldn't this go into USB_Templates.ttcn? https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27341/comment/e612b18c_54d7… : PS4, Line 74: //activate(as_Tguard); would be great to have Tguard working from the first commit... https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27341/comment/ca7413ce_5861… : PS4, Line 81: function f_st_drain() runs on test_CT { what's the purpose of this function? I think it requires some documentation. Perhaps simply calling ST.clear() would be the right thing? https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27341/comment/bf643089_d34f… : PS4, Line 110: setverdict(fail, "Timeout waiting for ", exp_rx); FYI we have Misc_Helpers.f_shutdown() to make sure everything is shutdown properly. https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27341/comment/1d15528e_184f… : PS4, Line 191: testcase TC_test() runs on test_CT can we name this with a more specific scenario? -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27341?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Iada6422d694eb5fc862477c8b43b8642c8d96692 Gerrit-Change-Number: 27341 Gerrit-PatchSet: 4 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-CC: osmith <osmith(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Wed, 25 Jun 2025 11:20:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[XS] Change in osmo-ttcn3-hacks[master]: testenv/podman_install: fix regex warning
by pespin 25 Jun '25

25 Jun '25

Attention is currently required from: osmith. pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40522?usp=email ) Change subject: testenv/podman_install: fix regex warning ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40522?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I33ef4e16f3d3e4fa627f726d6fddd950b7826620 Gerrit-Change-Number: 40522 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Wed, 25 Jun 2025 11:13:32 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

2026

2025

2024

2023

2022

gerrit-log