Attention is currently required from: daniel.
lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43454?usp=email )
Change subject: SGSN: as_service_request(): use as_ciph_utran() to parse the Security Command
......................................................................
Patch Set 1:
(1 comment)
File sgsn/BSSGP_ConnHdlr.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43454/comment/01f102ce_198b… :
PS1, Line 776: setverdict(pass);
> setverdict() is no longer needed in this branch?
Good catch. (All tests are still green).
Will add it in the next patch set.
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43454?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ice385045c96e2d2eac7aa3c523c7b7c3c39e8bf4
Gerrit-Change-Number: 43454
Gerrit-PatchSet: 1
Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: daniel <dwillmann(a)sysmocom.de>
Gerrit-Attention: daniel <dwillmann(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 02 Sep 2026 10:29:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: daniel <dwillmann(a)sysmocom.de>
Attention is currently required from: laforge, lynxis lazus.
fixeria has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39256?usp=email )
Change subject: SGSN: add TC_attach_gmm_attach_req_while_gmm_attach_changed
......................................................................
Patch Set 15: Code-Review-1
(4 comments)
File sgsn/SGSN_Tests.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39256/comment/54042ac1_d27e… :
PS15, Line 2194: as_gmm_auth
Why do you activate the authentication handler so early? According to the test scenario, it's expected to happen only when IMSI is known and only after `as_gmm_gsup_lu_isd()` triggers. This makes the test scenario harder to follow/debug.
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39256/comment/a10876ec_dc42… :
PS15, Line 2210: as_gmm_gsup_lu_isd
IIUC, the ISD is expected to happen only after you respond to the Identity Request? Why don't you just put this to the respective alt-statement(s)?
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39256/comment/d23016f0_262a… :
PS15, Line 2223: FIXME
Is this still relevant here? I see `f_process_attach_accept()` does P-TMSI extraction.
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39256/comment/313f326a_8368… :
PS15, Line 2237: Identity Request IMSI (retrans)
Likewise, the test does reply to the 2nd Identity Request.
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39256?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ia721d3c29bf09014b197670ae02d1cd1901750bc
Gerrit-Change-Number: 39256
Gerrit-PatchSet: 15
Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Comment-Date: Wed, 02 Sep 2026 10:27:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes