Attention is currently required from: laforge, lynxis lazus.

fixeria has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39256?usp=email )

Change subject: SGSN: add TC_attach_gmm_attach_req_while_gmm_attach_changed ......................................................................

Patch Set 15: Code-Review-1

(4 comments)

File sgsn/SGSN_Tests.ttcn:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39256/comment/54042ac1_d27e9... : PS15, Line 2194: as_gmm_auth Why do you activate the authentication handler so early? According to the test scenario, it's expected to happen only when IMSI is known and only after `as_gmm_gsup_lu_isd()` triggers. This makes the test scenario harder to follow/debug.

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39256/comment/a10876ec_dc428... : PS15, Line 2210: as_gmm_gsup_lu_isd IIUC, the ISD is expected to happen only after you respond to the Identity Request? Why don't you just put this to the respective alt-statement(s)?

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39256/comment/d23016f0_262a1... : PS15, Line 2223: FIXME Is this still relevant here? I see `f_process_attach_accept()` does P-TMSI extraction.

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39256/comment/313f326a_8368e... : PS15, Line 2237: Identity Request IMSI (retrans) Likewise, the test does reply to the 2nd Identity Request.