Attention is currently required from: laforge, lynxis lazus.

Patch set 15:Code-Review -1

View Change

4 comments:

• File sgsn/SGSN_Tests.ttcn:

  • Patch Set #15, Line 2194: as_gmm_auth

    Why do you activate the authentication handler so early? According to the test scenario, it's expected to happen only when IMSI is known and only after `as_gmm_gsup_lu_isd()` triggers. This makes the test scenario harder to follow/debug.

  • Patch Set #15, Line 2210: as_gmm_gsup_lu_isd

    IIUC, the ISD is expected to happen only after you respond to the Identity Request? Why don't you just put this to the respective alt-statement(s)?

  • Patch Set #15, Line 2223: FIXME

    Is this still relevant here? I see `f_process_attach_accept()` does P-TMSI extraction.

  • Patch Set #15, Line 2237: Identity Request IMSI (retrans)

    Likewise, the test does reply to the 2nd Identity Request.

To view, visit change 39256. To unsubscribe, or for help writing mail filters, visit settings.