Attention is currently required from: pespin.
lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43452?usp=email )
Change subject: SGSN: Iu: ensure every tests use a new subscriber
......................................................................
Patch Set 1:
(1 comment)
Commit Message:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43452/comment/48a944f2_3adb… :
PS1, Line 7: SGSN: Iu: ensure every tests use a new subscriber
> test uses
Done
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43452?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I4928d63b3166843fa90b19bea4880da125474906
Gerrit-Change-Number: 43452
Gerrit-PatchSet: 1
Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 02 Sep 2026 09:26:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
lynxis lazus has submitted this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/43481?usp=email )
Change subject: libvlr: lu_fsm: PS: don't terminate by timer to prevent cascade
......................................................................
libvlr: lu_fsm: PS: don't terminate by timer to prevent cascade
To prevent a termination cascade, don't termine the FSM by the timer
callback when running as PS/SGSN.
The SGSN binds the LU FSM to the Attach/RAU FSM.
When the timeout happens, the Attach/RAU FSM will terminate the child FSMs
because the Attach/RAU FSM gets notified by tx_lu_rej().
Change-Id: I483bd3e734b1046fcafdae31189bc5df5b122a48
---
M src/libvlr/vlr_lu_fsm.c
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
pespin: Looks good to me, but someone else must approve
Jenkins Builder: Verified
lynxis lazus: Looks good to me, approved
laforge: Looks good to me, but someone else must approve
diff --git a/src/libvlr/vlr_lu_fsm.c b/src/libvlr/vlr_lu_fsm.c
index e63f1ee..8fa6c54 100644
--- a/src/libvlr/vlr_lu_fsm.c
+++ b/src/libvlr/vlr_lu_fsm.c
@@ -1594,8 +1594,8 @@
}
lfp->vlr->ops.tx_lu_rej(lfp->msc_conn_ref, gsm48_cause, lfp->lu_type);
- /* 1 will terminate the fsm */
- return 1;
+ /* The callback might have already cleaned up this FSM */
+ return 0;
}
switch (fi->state) {
--
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/43481?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: I483bd3e734b1046fcafdae31189bc5df5b122a48
Gerrit-Change-Number: 43481
Gerrit-PatchSet: 4
Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>