Attention is currently required from: fixeria, laforge, pespin.
osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/43500?usp=email )
Change subject: xUA: Validate multiple Routing Context in SNM messages
......................................................................
Patch Set 1:
(1 comment)
Commit Message:
https://gerrit.osmocom.org/c/libosmo-sigtran/+/43500/comment/5f7de9e1_1e4a5… :
PS1, Line 14: work.
Depending on how long this will take to implement, it might make sense to print a warning if there is more than one routing context?
--
To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/43500?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: libosmo-sigtran
Gerrit-Branch: master
Gerrit-Change-Id: Ic3a9dc13d128a0c5777981616923ee1856210b21
Gerrit-Change-Number: 43500
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 02 Sep 2026 10:18:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43496?usp=email )
Change subject: eim: set mp_restop_path using TESTENV_SRC_DIR
......................................................................
eim: set mp_restop_path using TESTENV_SRC_DIR
* Use $TESTENV_SRC_DIR instead of ../../, as the latter may not always
be the directory where the sources get cloned.
* Adjust the path in eIM_Tests.cfg instead of copying restop.py to the
logs dir and starting it from there.
* Change onomondo-eim/contrib/rest_api_usage_example/restop.py to
onomondo-eim/contrib/restop.py as that seems to be the proper path
on current master:
https://gerrit.osmocom.org/plugins/gitiles/onomondo-eim/+/refs/heads/master…
Change-Id: I2ee9a487b2eb77485f09133918d91d6d7275d4c6
---
A eim/prepare.sh
M eim/testenv.cfg
2 files changed, 11 insertions(+), 1 deletion(-)
Approvals:
pespin: Looks good to me, but someone else must approve
jolly: Looks good to me, approved
Jenkins Builder: Verified
diff --git a/eim/prepare.sh b/eim/prepare.sh
new file mode 100755
index 0000000..1cb2d57
--- /dev/null
+++ b/eim/prepare.sh
@@ -0,0 +1,9 @@
+#!/bin/sh -ex
+
+# Set mp_restop_path
+RESTOP="$TESTENV_SRC_DIR"/onomondo-eim/contrib/restop.py
+test -e "$RESTOP"
+sed \
+ -i \
+ "s,^eIM_Tests\.mp_restop_path := .*,eIM_Tests.mp_restop_path := \"$RESTOP\"," \
+ eIM_Tests.cfg
diff --git a/eim/testenv.cfg b/eim/testenv.cfg
index bf404f5..b375fec 100644
--- a/eim/testenv.cfg
+++ b/eim/testenv.cfg
@@ -1,7 +1,8 @@
[testsuite]
program=eIM_Tests
config=eIM_Tests.cfg
-copy=../../onomondo-eim/contrib/rest_api_usage_example/restop.py ../ipad/example_ca/pki/private/alttest.key ../ipad/example_ca/pki/issued/alttest.crt
+copy=../ipad/example_ca/pki/private/alttest.key ../ipad/example_ca/pki/issued/alttest.crt
+prepare=prepare.sh
[eim]
program=onomondo-eim -c "$TESTENV_INSTALL_DIR"/etc/osmocom/onomondo-eim.config -r "$TESTENV_INSTALL_DIR"/usr/lib/onomondo-eim -m ./mnesia_db -l debug
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43496?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I2ee9a487b2eb77485f09133918d91d6d7275d4c6
Gerrit-Change-Number: 43496
Gerrit-PatchSet: 3
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/43491?usp=email )
Change subject: jobs/ttcn3-testsuites-testenv: set basedir
......................................................................
jobs/ttcn3-testsuites-testenv: set basedir
Clone the osmo-ttcn3-hacks repository to $WORKSPACE/src/osmo-ttcn3-hacks
instead of $WORKSPACE. This is in preparation for building programs from
source with these jobs for which we don't build binary packages
(onomondo-ipa, -eim), which requires cloning additional repositories to
a sibling directory of osmo-ttcn3-hacks (now $WORKSPACE/src).
As side effect, this also makes the directory structure easier to
browser as the logs and cache dirs are not mixed with the
osmo-ttcn3-hacks directory structure anymore.
Furthermore 3rd party repositories in osmo-ttcn3-hacks/deps are not
cached anymore between runs. This saves disk space at the expense of
cloning them again at the start of job runs. This trade-off is
acceptable now that we are cloning these repositories from the Osmocom
mirrors (https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43245).
Change-Id: Ib7c4324df58aad6adca2abf5e72e9b8753842714
---
M jobs/ttcn3-testsuites-testenv.yml
1 file changed, 5 insertions(+), 4 deletions(-)
Approvals:
fixeria: Looks good to me, approved
pespin: Looks good to me, but someone else must approve
Jenkins Builder: Verified
diff --git a/jobs/ttcn3-testsuites-testenv.yml b/jobs/ttcn3-testsuites-testenv.yml
index 5a94b4e..e9a5756 100644
--- a/jobs/ttcn3-testsuites-testenv.yml
+++ b/jobs/ttcn3-testsuites-testenv.yml
@@ -676,10 +676,10 @@
fi
done
- rm -rf logs _cache .linux
+ rm -rf logs _cache src/osmo-ttcn3-hacks/.linux
if [ "$KERNEL" != "none" ]; then
- mv linux .linux
+ mv linux src/osmo-ttcn3-hacks/.linux
fi
set +x # Don't output the color codes we set here
@@ -696,7 +696,7 @@
uptime | grep --color=always -o "load.*"
RC=0
- if ! ./testenv.py run \
+ if ! src/osmo-ttcn3-hacks/testenv.py run \
{testsuite} \
--podman \
--cache "$PWD"/_cache \
@@ -709,7 +709,7 @@
# Free up space from downloaded apt packages, build artifacts etc.
# The osmo-ttcn3-hacks deps dir and ccache are persistent.
if [ "$RC" = 0 ]; then
- rm -rf _cache .linux
+ rm -rf _cache src
fi
uptime | grep --color=always -o "load.*"
@@ -723,6 +723,7 @@
git-config-name: 'Jenkins Builder'
git-config-email: 'jenkins(a)osmocom.org'
wipe-workspace: false
+ basedir: src/osmo-ttcn3-hacks
triggers:
- timed: "{obj:timer}"
publishers:
--
To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/43491?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-Change-Id: Ib7c4324df58aad6adca2abf5e72e9b8753842714
Gerrit-Change-Number: 43491
Gerrit-PatchSet: 2
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>