Attention is currently required from: laforge, pespin.
Hello Jenkins Builder, laforge, pespin,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-msc/+/43479?usp=email
to look at the new patch set (#3).
The following approvals got outdated and were removed:
Code-Review+1 by laforge, Code-Review+1 by pespin, Verified+1 by Jenkins Builder
Change subject: libvlr: add PVLR support
......................................................................
libvlr: add PVLR support
Allow to retrieve information from the PVLR (Previous VLR).
In case of PS/SGSN this can be another SGSN or a MME.
Introduce a new callback for CS and PS to check if the LAI or RAI
is currently served.
Change-Id: I189c041dbc3a33ad15746092691cb382d1911495
---
M include/osmocom/vlr/vlr.h
M src/libmsc/gsm_04_08.c
M src/libvlr/vlr.c
M src/libvlr/vlr_lu_fsm.c
4 files changed, 80 insertions(+), 17 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/79/43479/3
--
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/43479?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: I189c041dbc3a33ad15746092691cb382d1911495
Gerrit-Change-Number: 43479
Gerrit-PatchSet: 3
Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
dexter has submitted this change. ( https://gerrit.osmocom.org/c/onomondo-eim/+/43451?usp=email )
Change subject: esipa_asn_handler: add TODO about missing TLS / SNI support
......................................................................
esipa_asn_handler: add TODO about missing TLS / SNI support
SGP.32 requires an eIM to support SNI, however since this eIM has
no multi tenant support at all, it may not benefit much from this
feature at the moment.
However, according to the cowboy documentation SNI is supported
and the effort to integrate it is manageable. Let's postpone this
until we add multi tenant support.
Related: SYS#8100
Change-Id: Iaebe29563259ae5fabeb9825839a03062d7fc24d
---
M src/onomondo_eim_app.erl
1 file changed, 3 insertions(+), 0 deletions(-)
Approvals:
Jenkins Builder: Verified
dexter: Looks good to me, approved
diff --git a/src/onomondo_eim_app.erl b/src/onomondo_eim_app.erl
index 89ffd4a..c5ea149 100644
--- a/src/onomondo_eim_app.erl
+++ b/src/onomondo_eim_app.erl
@@ -31,6 +31,9 @@
[InterfaceName, Ip, Port, Cert, Key]
),
+ % TODO: GSMA SGP.32, section 2.6.5 requires an eIM to support the SNI TLS extension. However, this eIM
+ % implementation still lacks SNI support. The effort required to add SNI support should be manageable as Cowboy
+ % offers SNI support (sni_fun).
cowboy:start_tls(
https_listener_esipa,
[
--
To view, visit https://gerrit.osmocom.org/c/onomondo-eim/+/43451?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: onomondo-eim
Gerrit-Branch: master
Gerrit-Change-Id: Iaebe29563259ae5fabeb9825839a03062d7fc24d
Gerrit-Change-Number: 43451
Gerrit-PatchSet: 2
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
dexter has submitted this change. ( https://gerrit.osmocom.org/c/onomondo-eim/+/43450?usp=email )
(
1 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.
)Change subject: esipa_rest_utils: add spec reference to existing TODO
......................................................................
esipa_rest_utils: add spec reference to existing TODO
Related: SYS#8100
Change-Id: I33a1b1a03c67632b4a10a043928e0a265730b7e2
---
M src/esipa_rest_utils.erl
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Jenkins Builder: Verified
laforge: Looks good to me, approved
diff --git a/src/esipa_rest_utils.erl b/src/esipa_rest_utils.erl
index 3b16492..b71f885 100644
--- a/src/esipa_rest_utils.erl
+++ b/src/esipa_rest_utils.erl
@@ -512,7 +512,7 @@
% Generate an ipaEuiccDataRequest from a eDR Order (JSON REST API)
edr_order_to_ipaEuiccDataRequest(Order, EimTransactionId) ->
% TODO: also add support for the two optional parameters euiccCiPKIdentifierToBeUsed, searchCriteriaNotification,
- % and searchCriteriaEuiccPackageResult.
+ % and searchCriteriaEuiccPackageResult (see also GSMA SGP.32, section 2.11.1.2)
case Order of
{[{<<"edr">>, {[{<<"tagList">>, TagList}]}}]} ->
{ipaEuiccDataRequest, #{
--
To view, visit https://gerrit.osmocom.org/c/onomondo-eim/+/43450?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: onomondo-eim
Gerrit-Branch: master
Gerrit-Change-Id: I33a1b1a03c67632b4a10a043928e0a265730b7e2
Gerrit-Change-Number: 43450
Gerrit-PatchSet: 2
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>