September 2026 - gerrit-log - lists.osmocom.org

[XS] Change in osmo-sgsn[master]: Fixup: shift left of 32bit int
by lynxis lazus 02 Sep '26

02 Sep '26

lynxis lazus has abandoned this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/43512?usp=email ) Change subject: Fixup: shift left of 32bit int ...................................................................... Abandoned -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/43512?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: abandon Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I5bb56d3623e7740defa8f77adfb40e9699455791 Gerrit-Change-Number: 43512 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>

1 0

[XS] Change in osmo-sgsn[master]: Fixup: shift left of 32bit int
by lynxis lazus 02 Sep '26

02 Sep '26

lynxis lazus has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/43512?usp=email ) Change subject: Fixup: shift left of 32bit int ...................................................................... Fixup: shift left of 32bit int Change-Id: I5bb56d3623e7740defa8f77adfb40e9699455791 --- M src/sgsn/gprs_gmm.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/12/43512/1 diff --git a/src/sgsn/gprs_gmm.c b/src/sgsn/gprs_gmm.c index d3b4101..67f136c 100644 --- a/src/sgsn/gprs_gmm.c +++ b/src/sgsn/gprs_gmm.c @@ -1504,7 +1504,7 @@ guti->gummei.mme.group_id = req->old_rai.lac.lac; guti->gummei.mme.code = req->old_rai.rac; /* bits 31 to 30 are always 11; P-TMSI bits29 to 24, 15 to 0 */ - guti->mtmsi |= (1 << 31) | (1 << 30) | (ptmsi & 0x3f00ffff); + guti->mtmsi |= (1ul << 31) | (1ul << 30) | (ptmsi & 0x3f00ffff); guti->mtmsi |= (ptmsi_mtmsi << 16); /* bits 23 to 16 is the NRI */ /* eutran_nri = (ptmsi >> 16) & 0xff; */ -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/43512?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I5bb56d3623e7740defa8f77adfb40e9699455791 Gerrit-Change-Number: 43512 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>

1 0

[XL] Change in osmo-sgsn[master]: Rework SGSN code to use new libvlr code
by lynxis lazus 02 Sep '26

02 Sep '26

Attention is currently required from: lynxis lazus. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-sgsn/+/39562?usp=email to look at the new patch set (#11). The following approvals got outdated and were removed: Verified-1 by Jenkins Builder Change subject: Rework SGSN code to use new libvlr code ...................................................................... Rework SGSN code to use new libvlr code The libvlr code will take most of the logic of the Routing Area handling. By using the new libvlr code, the ACL and usage of the SGSN without the HLR has been removed. Change-Id: I9c5b4ec1b337c35e85c2d1a3d09b318380ae6ef8 --- M include/osmocom/sgsn/debug.h M include/osmocom/sgsn/gprs_gmm.h M include/osmocom/sgsn/gprs_gmm_attach.h M include/osmocom/sgsn/gprs_gmm_fsm.h A include/osmocom/sgsn/gprs_rau_fsm.h M include/osmocom/sgsn/gprs_subscriber.h M include/osmocom/sgsn/mmctx.h M include/osmocom/sgsn/sgsn.h M src/sgsn/Makefile.am M src/sgsn/gprs_gmm.c M src/sgsn/gprs_gmm_attach.c M src/sgsn/gprs_gmm_fsm.c M src/sgsn/gprs_ranap.c A src/sgsn/gprs_rau_fsm.c M src/sgsn/gprs_subscriber.c M src/sgsn/mmctx.c M src/sgsn/sgsn.c M src/sgsn/sgsn_auth.c M src/sgsn/sgsn_libgtp.c M src/sgsn/sgsn_main.c M src/sgsn/sgsn_vty.c M tests/Makefile.am M tests/gprs_routing_area/Makefile.am M tests/sgsn/sgsn_test.c M tests/testsuite.at M tests/vty_test_runner.py 26 files changed, 1,341 insertions(+), 2,654 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/62/39562/11 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/39562?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I9c5b4ec1b337c35e85c2d1a3d09b318380ae6ef8 Gerrit-Change-Number: 39562 Gerrit-PatchSet: 11 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>

1 0

[S] Change in simtrace2[master]: firmware: Add talloc_report_buf() encode the allocation by bits
by lynxis lazus 02 Sep '26

02 Sep '26

lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/simtrace2/+/43004?usp=email ) Change subject: firmware: Add talloc_report_buf() encode the allocation by bits ...................................................................... Patch Set 9: (1 comment) File firmware/libcommon/source/pseudo_talloc.c: https://gerrit.osmocom.org/c/simtrace2/+/43004/comment/ad31f039_7bde8407?us… : PS6, Line 101: return bitoff + 1; > +1 is always correct. if bitpos == 7 we might waste a byte. Done -- To view, visit https://gerrit.osmocom.org/c/simtrace2/+/43004?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-Change-Id: I3a8ddbe4100f342db2c59ad1fb9aa0014efc62b8 Gerrit-Change-Number: 43004 Gerrit-PatchSet: 9 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 02 Sep 2026 20:56:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: lynxis lazus <lynxis(a)fe80.eu>

1 0

[XL] Change in osmo-sgsn[master]: Rework SGSN code to use new libvlr code
by Jenkins Builder 02 Sep '26

02 Sep '26

Attention is currently required from: lynxis lazus. Jenkins Builder has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/39562?usp=email ) Change subject: Rework SGSN code to use new libvlr code ...................................................................... Patch Set 10: (2 comments) File src/sgsn/gprs_gmm.c: Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-sgsn/+/39562/comment/bcf18ec5_6658a6c8?us… : PS10, Line 1288: if (!mmctx->attach_rau.rau_fsm || rc != 0) { braces {} are not necessary for single statement blocks Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-sgsn/+/39562/comment/d2b16ad6_176f1b07?us… : PS10, Line 1809: if (!mmctx->attach_rau.rau_fsm || rc != 0) { braces {} are not necessary for single statement blocks -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/39562?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I9c5b4ec1b337c35e85c2d1a3d09b318380ae6ef8 Gerrit-Change-Number: 39562 Gerrit-PatchSet: 10 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Wed, 02 Sep 2026 20:41:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[L] Change in osmo-sgsn[master]: Add Gn support to allow MME->SGSN, SGSN->MME cell reselection
by Jenkins Builder 02 Sep '26

02 Sep '26

Attention is currently required from: lynxis lazus. Jenkins Builder has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/39563?usp=email ) Change subject: Add Gn support to allow MME->SGSN, SGSN->MME cell reselection ...................................................................... Patch Set 10: (6 comments) File src/sgsn/sgsn_libgtp.c: Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-sgsn/+/39563/comment/269737b5_1b12a0d7?us… : PS10, Line 908: #define CHECK_SPACE_ERR(bytes) \ Macros starting with if should be enclosed by a do - while loop to avoid possible if/else logic defects Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-sgsn/+/39563/comment/cc1ee420_a9e16c2c?us… : PS10, Line 913: #define MEMCPY_CHK(dst, src, len) \ Macros with multiple statements should be enclosed in a do - while loop Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-sgsn/+/39563/comment/c114a8f1_9bfdfb15?us… : PS10, Line 913: #define MEMCPY_CHK(dst, src, len) \ macros should not use a trailing semicolon Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-sgsn/+/39563/comment/19a4cc5d_7c92aa1b?us… : PS10, Line 1120: if (buf_len <= 0) { braces {} are not necessary for single statement blocks Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-sgsn/+/39563/comment/165e71b4_1aeb0901?us… : PS10, Line 1134: // break; please, no space before tabs Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-sgsn/+/39563/comment/39e5b9e9_70fdc51d?us… : PS10, Line 1373: strncpy(mmctx->imsi, imsi_str, sizeof(mmctx->imsi)); Instead of strncpy()/strcpy(), use osmo_strlcpy() or OSMO_STRLCPY_ARRAY() -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/39563?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: Iffe83b31db2b6e6869fedf2351375184096cff6f Gerrit-Change-Number: 39563 Gerrit-PatchSet: 10 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Wed, 02 Sep 2026 20:41:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[S] Change in osmo-sgsn[master]: libvlr: lu_fsm: split off creation and start of the LU FSM
by lynxis lazus 02 Sep '26

02 Sep '26

lynxis lazus has abandoned this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/43475?usp=email ) Change subject: libvlr: lu_fsm: split off creation and start of the LU FSM ...................................................................... Abandoned Commit got merged into osmo-msc and integrated into the initial libvlr commit -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/43475?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: abandon Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I2ed3d7cc79b208d1810b4c03c4cb2d6cab83020f Gerrit-Change-Number: 43475 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder

1 0

[S] Change in osmo-sgsn[master]: libvlr: auth_fsm: split off fsm creation and start of it
by lynxis lazus 02 Sep '26

02 Sep '26

lynxis lazus has abandoned this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/43474?usp=email ) Change subject: libvlr: auth_fsm: split off fsm creation and start of it ...................................................................... Abandoned Commit got merged into osmo-msc and integrated into the initial libvlr commit -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/43474?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: abandon Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: Id5c77290f7181adb40d3429183b9696b4a40013b Gerrit-Change-Number: 43474 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder

1 0

[XS] Change in osmo-sgsn[master]: libvlr: lu_fsm: dont terminate by timer to prevent cascade
by lynxis lazus 02 Sep '26

02 Sep '26

lynxis lazus has abandoned this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/43473?usp=email ) Change subject: libvlr: lu_fsm: dont terminate by timer to prevent cascade ...................................................................... Abandoned Commit got merged into osmo-msc and integrated into the initial libvlr commit -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/43473?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: abandon Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: Ie726c21c2f9dc064c1dfd9bc9f9ec12d1e47fadf Gerrit-Change-Number: 43473 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu>

1 0

[S] Change in osmo-sgsn[master]: libvlr: auth: never re-use auth tuples for authentication
by lynxis lazus 02 Sep '26

02 Sep '26

lynxis lazus has abandoned this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/43472?usp=email ) Change subject: libvlr: auth: never re-use auth tuples for authentication ...................................................................... Abandoned Commit got superseded by a different approach in osmo-msc and got integrated into the initial libvlr commit -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/43472?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: abandon Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I102e0cca101525b11ae2b0f5796b60e263205d61 Gerrit-Change-Number: 43472 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu>

1 0

2026

2025

2024

2023

2022

gerrit-log September 2026