Attention is currently required from: fixeria, laforge.
pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-trx/+/43111?usp=email )
Change subject: libosmo-trx/ep: add TRX endpoint module
......................................................................
Patch Set 5: Code-Review+1
(2 comments)
File libosmo-trx/src/trx_ep.c:
https://gerrit.osmocom.org/c/osmo-trx/+/43111/comment/5eeae130_d3a0396c?usp… :
PS5, Line 427: talloc_free(ep->chans); /* re-alloc: free() and allocate again */
if (num_chans == ep->num_chans) return 0;
https://gerrit.osmocom.org/c/osmo-trx/+/43111/comment/5b168e01_c00d6b3e?usp… :
PS5, Line 433: ep->chans[n] = (struct osmo_trx_ep_chan){
FYI, having this is a static function trx_ep_chan_init() is handy later on when readers try to understand the lifecycle of such objects.
--
To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/43111?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Change-Id: I767fa43a9ca88be40c385f6dcb9de22891a6afc3
Gerrit-Change-Number: 43111
Gerrit-PatchSet: 5
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 03 Sep 2026 08:21:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43517?usp=email )
Change subject: sgsn: fix running against current stable osmo-sgsn
......................................................................
sgsn: fix running against current stable osmo-sgsn
Fix that running the sgsn testsuite fails with osmo-sgsn 1.13.x:
There is no such command.
Error occurred during reading the below line:
gummei 262 42 12 6
% VTY node 'asp' without a '[no] shutdown' command at the end is deprecated, please make sure you update your cfg file for future compatibility.
Failed to parse the config file: 'osmo-sgsn.cfg'
Fixes: b638bb03 ("SGSN: osmo-sgsn.cfg: assign gummei to test-mme0")
Change-Id: I3f5476d526517ce391b36d127cf7b0105ea7bc8d
---
M sgsn/testenv_generic.cfg
1 file changed, 2 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/17/43517/1
diff --git a/sgsn/testenv_generic.cfg b/sgsn/testenv_generic.cfg
index d58b49d..9d76d19 100644
--- a/sgsn/testenv_generic.cfg
+++ b/sgsn/testenv_generic.cfg
@@ -15,3 +15,5 @@
copy=osmo-sgsn.cfg
vty_port=4245
vty_host=127.0.0.10
+# remove once osmo-sgsn >= 1.14.0 is released
+prepare_latest=sed -i '/^ gummei.*/d' osmo-sgsn.cfg
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43517?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I3f5476d526517ce391b36d127cf7b0105ea7bc8d
Gerrit-Change-Number: 43517
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Attention is currently required from: lynxis lazus, pespin.
osmith has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/39560?usp=email )
Change subject: add libvlr based on MSC commit 7a628a1029ef174328f7e86183f19e54e5d9df8f
......................................................................
Patch Set 7:
(1 comment)
Commit Message:
https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/848afa9d_61990815?us… :
PS6, Line 8:
> It would be great to have the reasoning here why this is done.
Thank you for adding some reasoning. I'm now wondering why we are not linking against libvlr in osmo-msc, instead of copying it over. What is the reason for that?
--
To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/39560?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-Change-Id: I221114e00e6f338a75ae0dd7ac285e262b23635d
Gerrit-Change-Number: 39560
Gerrit-PatchSet: 7
Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: osmith <osmith(a)sysmocom.de>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Comment-Date: Thu, 03 Sep 2026 06:41:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: osmith <osmith(a)sysmocom.de>
neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/43516?usp=email )
Change subject: saip/batch: add blacklist to to_csv_rows()
......................................................................
saip/batch: add blacklist to to_csv_rows()
Allow calling code to mute specific parameters from an output CSV.
For example, the SUCI CalcInfo data should be identical for all profiles
of a batch, and is also very long data. After this patch, an application
can name specific parameters to omit from an output CSV.
Change-Id: I5e567e59a007cf4b5d75a4dcea5371ff4404bf24
Jenkins: skip-card-test
---
M pySim/esim/saip/batch.py
1 file changed, 4 insertions(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/16/43516/1
diff --git a/pySim/esim/saip/batch.py b/pySim/esim/saip/batch.py
index 338c5d1..5939d65 100644
--- a/pySim/esim/saip/batch.py
+++ b/pySim/esim/saip/batch.py
@@ -324,12 +324,15 @@
return batch_audit
- def to_csv_rows(self, headers=True, sort_key=None):
+ def to_csv_rows(self, headers=True, sort_key=None, column_blacklist=None):
"""generator that yields all audits' values as rows, useful feed to a csv.writer."""
columns = set()
for audit in self:
columns.update(audit.keys())
+ if column_blacklist:
+ columns.difference_update(set(column_blacklist))
+
columns = tuple(sorted(columns, key=sort_key))
if headers:
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/43516?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I5e567e59a007cf4b5d75a4dcea5371ff4404bf24
Gerrit-Change-Number: 43516
Gerrit-PatchSet: 1
Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de>
neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/43515?usp=email )
Change subject: personalization: EF_SMSP: keep same length as found in template
......................................................................
personalization: EF_SMSP: keep same length as found in template
The correct length seems to be 42, according to the SAIP spec. However,
leave this decision the template: if anyone finds 42 to be unfit, they
can modify the value in the template without having to patch this code.
Change-Id: Id24752101ae82c4986209f4103cc9cbdcce8ce1d
Jenkins: skip-card-test
---
M pySim/esim/saip/personalization.py
1 file changed, 5 insertions(+), 4 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/15/43515/1
diff --git a/pySim/esim/saip/personalization.py b/pySim/esim/saip/personalization.py
index 6f88d52..d56c0a8 100644
--- a/pySim/esim/saip/personalization.py
+++ b/pySim/esim/saip/personalization.py
@@ -635,13 +635,14 @@
# - To generate the right amount of fillFileContent, pass total_len=42 to encode_record_bin().
# - To show the right size in the PES, set f_smsp.rec_len = 42
ef_smsp_dec['alpha_id'] = ''
- f_smsp.rec_len = 42
+
+ # we can set this to choose a fixed length:
+ #f_smsp.rec_len = 42
+ # but leave rec_len unchanged to keep the same length as was found in the eSIM template.
# re-encode into the File body.
- #
- #print("SMSP (new): %s" % f_smsp.body)
- # re-generate the pe.decoded member from the File instance
f_smsp.body = ef_smsp.encode_record_bin(ef_smsp_dec, 1, total_len=f_smsp.rec_len)
+ # re-generate the pe.decoded member from the File instance
pe.file2pe(f_smsp)
@classmethod
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/43515?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: Id24752101ae82c4986209f4103cc9cbdcce8ce1d
Gerrit-Change-Number: 43515
Gerrit-PatchSet: 1
Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de>