August 2026 - gerrit-log - lists.osmocom.org

[XS] Change in osmo-sgsn[pespin/rel-1.13.1]: pdpctx: Use pdp->teic_own as rate_ctr id
by pespin 20 Aug '26

20 Aug '26

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/43338?usp=email ) Change subject: pdpctx: Use pdp->teic_own as rate_ctr id ...................................................................... pdpctx: Use pdp->teic_own as rate_ctr id Otherwise we run into errors due to non-unique ids. Related: SYS#7125 Change-Id: I388d7e4550e874cabc51e016d1a35a1074be7ac3 (cherry picked from commit 968b60ef3afc2735b9493e8acbf16429869bd6b9) --- M src/sgsn/pdpctx.c 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins Builder: Verified osmith: Looks good to me, approved diff --git a/src/sgsn/pdpctx.c b/src/sgsn/pdpctx.c index fb30a3a..be11338 100644 --- a/src/sgsn/pdpctx.c +++ b/src/sgsn/pdpctx.c @@ -70,7 +70,7 @@ if (!pctx) return NULL; - pctx->ctrg = rate_ctr_group_alloc(pctx, &pdpctx_ctrg_desc, nsapi); + pctx->ctrg = rate_ctr_group_alloc(pctx, &pdpctx_ctrg_desc, pdp->teic_own); if (!pctx->ctrg) { LOGPDPCTXP(LOGL_ERROR, pctx, "Error allocation counter group\n"); talloc_free(pctx); -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/43338?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-sgsn Gerrit-Branch: pespin/rel-1.13.1 Gerrit-Change-Id: I388d7e4550e874cabc51e016d1a35a1074be7ac3 Gerrit-Change-Number: 43338 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in osmo-sgsn[pespin/rel-1.13.1]: sndcp: Remove unused variable
by pespin 20 Aug '26

20 Aug '26

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/43340?usp=email ) Change subject: sndcp: Remove unused variable ...................................................................... sndcp: Remove unused variable gcc 16.1.1 warns about it. Change-Id: Ie2bd3d2935cd7e0ad023a163c9be9a05b83fbc5e (cherry picked from commit b40a36793c28339432a2ec0a97ca77502e136321) --- M src/sgsn/gprs_sndcp_xid.c 1 file changed, 1 insertion(+), 3 deletions(-) Approvals: osmith: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/sgsn/gprs_sndcp_xid.c b/src/sgsn/gprs_sndcp_xid.c index a19f645..344fda4 100644 --- a/src/sgsn/gprs_sndcp_xid.c +++ b/src/sgsn/gprs_sndcp_xid.c @@ -1352,7 +1352,6 @@ uint8_t tag; uint16_t tag_len; const uint8_t *val; - int byte_counter = 0; int rc; int tlv_count = 0; @@ -1403,8 +1402,7 @@ if (rc < 0) { talloc_free(comp_fields); return -EINVAL; - } else - byte_counter += rc; + } } /* Stop when no further TLV elements can be expected */ -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/43340?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-sgsn Gerrit-Branch: pespin/rel-1.13.1 Gerrit-Change-Id: Ie2bd3d2935cd7e0ad023a163c9be9a05b83fbc5e Gerrit-Change-Number: 43340 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in osmo-sgsn[pespin/rel-1.13.1]: tests/v42bis: Remove unused variable
by pespin 20 Aug '26

20 Aug '26

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/43341?usp=email ) Change subject: tests/v42bis: Remove unused variable ...................................................................... tests/v42bis: Remove unused variable gcc 16.1.1 warns about it. Change-Id: I715e57513ee62b7c61492a1d206232a5db107ea0 (cherry picked from commit 8972707b23ca79582def0d210f381dbc28e7809d) --- M tests/v42bis/v42bis_test.c 1 file changed, 0 insertions(+), 4 deletions(-) Approvals: osmith: Looks good to me, approved Jenkins Builder: Verified diff --git a/tests/v42bis/v42bis_test.c b/tests/v42bis/v42bis_test.c index e9c5069..0c58bfa 100644 --- a/tests/v42bis/v42bis_test.c +++ b/tests/v42bis/v42bis_test.c @@ -333,7 +333,6 @@ uint8_t *uncompressed; v42bis_state_t *rx_state; int rc; - int rc_sum = 0; int len; struct v42bis_output_buffer uncompressed_data; @@ -363,13 +362,10 @@ rx_state->decompress.user_data = (&uncompressed_data); rc = v42bis_decompress_flush(rx_state); printf("v42bis_decompress_flush() rc=%d\n", rc); - rc_sum += rc; rc = v42bis_decompress(rx_state, compressed, compressed_len); printf("v42bis_decompress() rc=%d\n", rc); - rc_sum += rc; rc = v42bis_decompress_flush(rx_state); printf("v42bis_decompress_flush() rc=%d\n", rc); - rc_sum += rc; /* Check results */ printf("compressed= %s ASCII:", -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/43341?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-sgsn Gerrit-Branch: pespin/rel-1.13.1 Gerrit-Change-Id: I715e57513ee62b7c61492a1d206232a5db107ea0 Gerrit-Change-Number: 43341 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in osmo-ci[master]: jobs/ttcn3-testsuites-testenv: use tmpfs
by pespin 20 Aug '26

20 Aug '26

Attention is currently required from: fixeria, osmith. pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ci/+/43344?usp=email ) Change subject: jobs/ttcn3-testsuites-testenv: use tmpfs ...................................................................... Patch Set 1: -Code-Review -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/43344?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I4e9cd491f528bda2f556fc6922d8780785d058f6 Gerrit-Change-Number: 43344 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 20 Aug 2026 14:01:51 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in osmo-ci[master]: jobs/ttcn3-testsuites-testenv: use tmpfs
by laforge 20 Aug '26

20 Aug '26

Attention is currently required from: fixeria, osmith. laforge has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ci/+/43344?usp=email ) Change subject: jobs/ttcn3-testsuites-testenv: use tmpfs ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: for which jobs does this apply? I think we have to be careful in terms of RAM utilization. So which jobs does it aplpy to? how large are they? how many parallel builders do we have concurrently? IMHO for example TTCN-3 jobs are not suitable for tmpfs, as the compiler already needs *massive* amounts of RAM. -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/43344?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I4e9cd491f528bda2f556fc6922d8780785d058f6 Gerrit-Change-Number: 43344 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 20 Aug 2026 14:01:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[S] Change in osmo-ci[master]: jobs/ttcn3-testsuites-testenv: use tmpfs
by pespin 20 Aug '26

20 Aug '26

Attention is currently required from: fixeria, osmith. pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ci/+/43344?usp=email ) Change subject: jobs/ttcn3-testsuites-testenv: use tmpfs ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/43344?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I4e9cd491f528bda2f556fc6922d8780785d058f6 Gerrit-Change-Number: 43344 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 20 Aug 2026 14:01:01 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in libosmo-sigtran[master]: sua: refactor sua_parse_gt() digit loop
by fixeria 20 Aug '26

20 Aug '26

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/43348?usp=email ) Change subject: sua: refactor sua_parse_gt() digit loop ...................................................................... sua: refactor sua_parse_gt() digit loop The digit-parsing loop in sua_parse_gt() bounded output writes to gt->digits[] via mid-loop break checks against the clamped num_digits, while the loop itself iterated over datalen-8. Although provably safe, Coverity cannot correlate the break conditions with the loop bound and flags a false-positive overrun. Rewrite the loop to iterate directly over num_digits, so the bound on writes into gt->digits[] is syntactically obvious. No functional change. Change-Id: I39c1e8acbec371a27c7871799619695d77b4d61e Related: OS#7046, CID#562801 --- M src/sua.c 1 file changed, 12 insertions(+), 8 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/48/43348/1 diff --git a/src/sua.c b/src/sua.c index 35c4a8e..7c6d57f 100644 --- a/src/sua.c +++ b/src/sua.c @@ -412,16 +412,20 @@ rc = -ENOSPC; } - /* parse digits */ + /* parse digits: bounded by num_digits (already clamped above), so this + * can never write more than sizeof(gt->digits)-1 nibbles into gt->digits[] */ out_digits = gt->digits; - for (i = 0; i < datalen-8; i++) { - uint8_t byte = data[8+i]; - *out_digits++ = osmo_bcd2char(byte & 0x0F); - if (out_digits - gt->digits >= num_digits) + for (i = 0; i < num_digits; i++) { + unsigned int byte_off = 8 + i / 2; + uint8_t byte; + + if (byte_off >= datalen) break; - *out_digits++ = osmo_bcd2char(byte >> 4); - if (out_digits - gt->digits >= num_digits) - break; + byte = data[byte_off]; + if (i & 1) + *out_digits++ = osmo_bcd2char(byte >> 4); + else + *out_digits++ = osmo_bcd2char(byte & 0x0F); } *out_digits++ = '\0'; -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/43348?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I39c1e8acbec371a27c7871799619695d77b4d61e Gerrit-Change-Number: 43348 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[XS] Change in osmo-ci[master]: jobs/ttcn3-testsuites-testenv: adjust apt pattern
by pespin 20 Aug '26

20 Aug '26

Attention is currently required from: osmith. pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ci/+/43345?usp=email ) Change subject: jobs/ttcn3-testsuites-testenv: adjust apt pattern ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/43345?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I82eba41631d520abedc6fb2e2507afbbe618066a Gerrit-Change-Number: 43345 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Thu, 20 Aug 2026 14:00:38 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-ci[master]: jobs/ttcn3-testsuites-testenv: adjust apt pattern
by laforge 20 Aug '26

20 Aug '26

Attention is currently required from: osmith. laforge has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ci/+/43345?usp=email ) Change subject: jobs/ttcn3-testsuites-testenv: adjust apt pattern ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/43345?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I82eba41631d520abedc6fb2e2507afbbe618066a Gerrit-Change-Number: 43345 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Thu, 20 Aug 2026 13:59:52 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in osmo-remsim[master]: remsim_client: only set usb parameters if given by config
by laforge 20 Aug '26

20 Aug '26

Attention is currently required from: lynxis lazus. laforge has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-remsim/+/43347?usp=email ) Change subject: remsim_client: only set usb parameters if given by config ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/43347?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I30f27b166db72fa8796aa4da98f9fc01e348c87a Gerrit-Change-Number: 43347 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Thu, 20 Aug 2026 13:59:20 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

2026

2025

2024

2023

2022

gerrit-log August 2026