Attention is currently required from: lynxis lazus.
Hello Jenkins Builder, laforge, pespin,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39260?usp=email
to look at the new patch set (#15).
The following approvals got outdated and were removed:
Verified+1 by Jenkins Builder
The change is no longer submittable: Verified is unsatisfied now.
Change subject: SGSN: remove TC_attach_no_imei_response
......................................................................
SGSN: remove TC_attach_no_imei_response
The SGSN doesn't request the IMEI via Identity Response anymore.
This information is requested via Authentication/Ciphering Req/Resp.
Change-Id: I42dc927513fb54b0fd2d07dda4cf8d4646b9f351
---
M sgsn/SGSN_Tests.ttcn
M sgsn/expected-results.xml
2 files changed, 0 insertions(+), 48 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/60/39260/15
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39260?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I42dc927513fb54b0fd2d07dda4cf8d4646b9f351
Gerrit-Change-Number: 39260
Gerrit-PatchSet: 15
Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>
Attention is currently required from: laforge, lynxis lazus.
Hello Jenkins Builder, daniel, dexter, laforge, pespin,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39261?usp=email
to look at the new patch set (#15).
The following approvals got outdated and were removed:
Verified+1 by Jenkins Builder
The change is no longer submittable: Verified is unsatisfied now.
Change subject: SGSN: Remove unsupport test cases
......................................................................
SGSN: Remove unsupport test cases
The functionality for ACL based authentication (only use
the IMSI, but don't request information from the HLR) will
be removed from the SGSN.
Change-Id: I1506324300fe3864069706d5b05860e7b44cd895
---
M sgsn/SGSN_Tests.ttcn
M sgsn/expected-results.xml
2 files changed, 0 insertions(+), 181 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/61/39261/15
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39261?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I1506324300fe3864069706d5b05860e7b44cd895
Gerrit-Change-Number: 39261
Gerrit-PatchSet: 15
Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>
Attention is currently required from: laforge, lynxis lazus.
pespin has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/libosmocore/+/43346?usp=email )
Change subject: usb: osmo_libusb_open_claim_interface: print an error when no device was found
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/43346?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I59d31f80a9d5b6bf7b33ca80f4387748531b4cce
Gerrit-Change-Number: 43346
Gerrit-PatchSet: 1
Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Comment-Date: Thu, 20 Aug 2026 16:07:34 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: jolly.
pespin has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/osmo-bsc/+/43293?usp=email )
Change subject: OM2K: Check bounds of OM2K Negotiation Request
......................................................................
Patch Set 1:
(1 comment)
File src/osmo-bsc/abis_om2000.c:
https://gerrit.osmocom.org/c/osmo-bsc/+/43293/comment/99d56c47_1891a05d?usp… :
PS1, Line 2777: uint8_t *cur = o2h->data+3;
You are accessing msg already here before the first check you added in 2785, are you sure this is correct?
--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/43293?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I2de0db1b717a97ab07964d49509a8242c7e4c3ed
Gerrit-Change-Number: 43293
Gerrit-PatchSet: 1
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: jolly <andreas(a)eversberg.eu>
Gerrit-Comment-Date: Thu, 20 Aug 2026 16:06:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Attention is currently required from: fixeria.
pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/43349?usp=email )
Change subject: sua: sua_parse_gt(): reject GT with num_digits exceeding blob length
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
File src/sua.c:
https://gerrit.osmocom.org/c/libosmo-sigtran/+/43349/comment/ea9df4ab_feb72… :
PS1, Line 417: /* Parse as much as we can; return -EINVAL */
I wonder what's the point in parsing as much as we can if anyway we end up in error, but ok...To me working on known malfunctioned packets doesn't seem like a good idea.
--
To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/43349?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: libosmo-sigtran
Gerrit-Branch: master
Gerrit-Change-Id: I918278b6471bc78511bf97a292204e6719d4031a
Gerrit-Change-Number: 43349
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 20 Aug 2026 16:04:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Attention is currently required from: laforge.
lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/libosmocore/+/43346?usp=email )
Change subject: usb: osmo_libusb_open_claim_interface: print an error when no device was found
......................................................................
Patch Set 1:
(1 comment)
File src/usb/osmo_libusb.c:
https://gerrit.osmocom.org/c/libosmocore/+/43346/comment/485d94ce_39f81e48?… :
PS1, Line 583:
> do we really need the goto? Doesn the if (!usb_devh) nicely cover what we need here?
Without the goto you will have:
"""
Cannot set interface altsetting X
Failed to find a matching usb device
"""
The second line would be wrong in the error case, because it found a matching device, but couldn't configure it in the right way.
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/43346?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I59d31f80a9d5b6bf7b33ca80f4387748531b4cce
Gerrit-Change-Number: 43346
Gerrit-PatchSet: 1
Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Comment-Date: Thu, 20 Aug 2026 15:54:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>
Attention is currently required from: lynxis lazus.
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-remsim/+/43352?usp=email
to look at the new patch set (#2).
The following approvals got outdated and were removed:
Verified-1 by Jenkins Builder
Change subject: handle_options(): exit(2) if an unparsed argument was given
......................................................................
handle_options(): exit(2) if an unparsed argument was given
All osmo-remsim binaries are only supporting arguments starting with a dash ('-'),
but no positional argument.
Ensure all binaries will exit when an positional argument was given and
do the same when an unrecognized argument was given.
Change-Id: I84658bda7614d9463bd7d20eb584da8e7050f1e5
---
M src/bankd/bankd_main.c
M src/client/remsim_client_main.c
M src/server/remsim_server.c
3 files changed, 28 insertions(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-remsim refs/changes/52/43352/2
--
To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/43352?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: osmo-remsim
Gerrit-Branch: master
Gerrit-Change-Id: I84658bda7614d9463bd7d20eb584da8e7050f1e5
Gerrit-Change-Number: 43352
Gerrit-PatchSet: 2
Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>