Attention is currently required from: dexter.
jolly has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/onomondo-ipa/+/43302?usp=email )
Change subject: Add missing Pepare Download error handling
......................................................................
Patch Set 2:
(1 comment)
File src/ipa/libipa/proc_prfle_dwnld.c:
https://gerrit.osmocom.org/c/onomondo-ipa/+/43302/comment/599086d4_1dae227a… :
PS1, Line 53: * result as a whole to the eIM. In case of failure it is the responsibility of the eIM to look at error
> Now this comment is wrong, I would rephrase it like this: […]
Done
--
To view, visit https://gerrit.osmocom.org/c/onomondo-ipa/+/43302?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: onomondo-ipa
Gerrit-Branch: master
Gerrit-Change-Id: I6f13a12c494be57d6a6f377567bf38b0235ec4aa
Gerrit-Change-Number: 43302
Gerrit-PatchSet: 2
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: dexter <pmaier(a)sysmocom.de>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 21 Aug 2026 13:16:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: dexter <pmaier(a)sysmocom.de>
Attention is currently required from: dexter, laforge.
jolly has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/onomondo-ipa/+/43062?usp=email )
Change subject: V1.2: Change of IpaEuiccDataRequest and results
......................................................................
Patch Set 9:
(4 comments)
File src/ipa/libipa/es10b_retr_notif_from_lst.c:
https://gerrit.osmocom.org/c/onomondo-ipa/+/43062/comment/697bcab1_406ec7e8… :
PS8, Line 168: "no euiccPackageResults searchCriteria in IpaEuiccDataRequest!\n");
> In SGP.32 2.11.1. […]
Done
https://gerrit.osmocom.org/c/onomondo-ipa/+/43062/comment/dd1f64e4_e629da1e… :
PS8, Line 229: "no searchCriteria in IpaEuiccDataRequest!\n");
> (see comment above)
Done
https://gerrit.osmocom.org/c/onomondo-ipa/+/43062/comment/e30383ad_28cf4604… :
PS8, Line 246: "empty searchCriteria in IpaEuiccDataRequest!\n");
> (see comment above)
Done
https://gerrit.osmocom.org/c/onomondo-ipa/+/43062/comment/c4435fd8_6d1eeddb… :
PS8, Line 255: "no searchCriteria in IpaEuiccDataRequest!\n");
> (see comment above)
Done
--
To view, visit https://gerrit.osmocom.org/c/onomondo-ipa/+/43062?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: onomondo-ipa
Gerrit-Branch: master
Gerrit-Change-Id: I411111c71787ce27615b6b66fc8b19488883d15b
Gerrit-Change-Number: 43062
Gerrit-PatchSet: 9
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 21 Aug 2026 13:16:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: dexter <pmaier(a)sysmocom.de>
Attention is currently required from: dexter, laforge.
jolly has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/onomondo-ipa/+/43055?usp=email )
Change subject: V1.2: Change fields in ProvideEimPackage(Result)
......................................................................
Patch Set 7:
(1 comment)
File src/ipa/libipa/esipa_prvde_eim_pkg_rslt.c:
https://gerrit.osmocom.org/c/onomondo-ipa/+/43055/comment/9ca2e1fc_651177fe… :
PS6, Line 86: res->eim_acknowledgements = &msg_to_ipa->choice.provideEimPackageResultResponse.choice.eimAcknowledgements;
> I wonder if we should be more explcit in the case of an emptyResponse. […]
Done
--
To view, visit https://gerrit.osmocom.org/c/onomondo-ipa/+/43055?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: onomondo-ipa
Gerrit-Branch: master
Gerrit-Change-Id: I24baab4f9351aec27c58403b94974cba4b274c34
Gerrit-Change-Number: 43055
Gerrit-PatchSet: 7
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 21 Aug 2026 13:15:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: dexter <pmaier(a)sysmocom.de>
Attention is currently required from: dexter, laforge.
jolly has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/onomondo-ipa/+/43054?usp=email )
Change subject: V1.2: Add function ES10b.GetConnectivityParameters
......................................................................
Patch Set 8:
(2 comments)
File src/ipa/libipa/ipad.c:
https://gerrit.osmocom.org/c/onomondo-ipa/+/43054/comment/54c0eef1_1a1631cb… :
PS7, Line 366: res->res->choice.connectivityParameters.httpParams->buf);
> maybe the sheer absence of httpParams is not an error. Its an optional fields. […]
Done
https://gerrit.osmocom.org/c/onomondo-ipa/+/43054/comment/775159a8_18a28b38… :
PS7, Line 369: }
> maybe it makes sense to evaluate the GetConnectivityParametersResponse_PR_connectivityParametersErro […]
Done
--
To view, visit https://gerrit.osmocom.org/c/onomondo-ipa/+/43054?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: onomondo-ipa
Gerrit-Branch: master
Gerrit-Change-Id: I075590e095dbbe05fa6cdb0a96d5b38c7a17ff78
Gerrit-Change-Number: 43054
Gerrit-PatchSet: 8
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 21 Aug 2026 13:15:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: dexter <pmaier(a)sysmocom.de>
Attention is currently required from: osmith, pespin.
Hello Jenkins Builder, osmith,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43307?usp=email
to look at the new patch set (#2).
The following approvals got outdated and were removed:
Code-Review+1 by osmith, Verified+1 by Jenkins Builder
Change subject: smf: Introduce testsuite
......................................................................
smf: Introduce testsuite
This commit introduces a ttcn3-test-smf-testsuite reusing (copying over)
most of existing ttcn3 code in pgw testsuite.
Contrary to the PGW one, this testsuite allows to test specifically the
SMF, hence also validating PFCP interface.
Moreover, this testsuite will be extended to also test 5G SMF
functionality by using the N11 interface (SBI based) instead of LTE
GTPv2C based interace.
With the current commit the testsuite is not expected to pass tests yet,
only TC_tx_echo() is probably passing, because others still lack the
PFCP support, which will be added in a follow up commit. This way it's
easier to track what was copied from pgw/ (basically a trimmed down
version removing UECUPs functionalities).
Change-Id: Ide6275323085f3d1f5d1ab01f3425fd6baa0f8b3
---
M Makefile
A smf/README.md
A smf/SMF_Session_CT.ttcn
A smf/SMF_Tests.cfg
A smf/SMF_Tests.default
A smf/SMF_Tests.ttcn
A smf/expected-results.xml
A smf/freediameter.conf
A smf/gen_links.sh
A smf/open5gs-nrf.yaml
A smf/open5gs-smf.yaml
A smf/regen_makefile.sh
A smf/testenv.cfg
13 files changed, 1,127 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/07/43307/2
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43307?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ide6275323085f3d1f5d1ab01f3425fd6baa0f8b3
Gerrit-Change-Number: 43307
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Attention is currently required from: jolly.
Hello Jenkins Builder, dexter, laforge,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/onomondo-ipa/+/43056?usp=email
to look at the new patch set (#7).
The following approvals got outdated and were removed:
Verified+1 by Jenkins Builder
The change is no longer submittable: Verified is unsatisfied now.
Change subject: V1.2: Add eimTransactionId to InitiateAuthenticationRequestEsipa
......................................................................
V1.2: Add eimTransactionId to InitiateAuthenticationRequestEsipa
Add new eimTransactionId field to InitiateAuthenticationRequestEsipa.
The eimTransactionId walks through the IPA process like this:
* The eimTransactionId is retrieved from ProfileDownloadTriggerRequest
at proc_eim_pkg_retr.c.
* Then it is handed to the Common Mutual Authentication Procedure at
proc_indirect_prfle_dwnld.c.
* There it is handed to the InitiateAuthentication function at
proc_cmn_mtl_auth.c.
* There it is stored in initiateAuthenticationRequestEsipa at
esipa_init_auth.c.
Reference: SGP.32 Section 5.14.1
Related: SYS#8101
Change-Id: I1c8ef6fc0a3f7ab5735e401597fc8c6b2021fc09
---
M asn1/SGP32Definitions.asn
M src/ipa/libasn/InitiateAuthenticationRequestEsipa.c
M src/ipa/libasn/InitiateAuthenticationRequestEsipa.h
M src/ipa/libipa/esipa_init_auth.c
M src/ipa/libipa/esipa_init_auth.h
M src/ipa/libipa/proc_cmn_mtl_auth.c
M src/ipa/libipa/proc_cmn_mtl_auth.h
M src/ipa/libipa/proc_eim_pkg_retr.c
M src/ipa/libipa/proc_indirect_prfle_dwnld.c
M src/ipa/libipa/proc_indirect_prfle_dwnld.h
10 files changed, 31 insertions(+), 9 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/onomondo-ipa refs/changes/56/43056/7
--
To view, visit https://gerrit.osmocom.org/c/onomondo-ipa/+/43056?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: onomondo-ipa
Gerrit-Branch: master
Gerrit-Change-Id: I1c8ef6fc0a3f7ab5735e401597fc8c6b2021fc09
Gerrit-Change-Number: 43056
Gerrit-PatchSet: 7
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: jolly <andreas(a)eversberg.eu>
Attention is currently required from: dexter, jolly, laforge.
Hello Jenkins Builder, dexter, laforge,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/onomondo-ipa/+/43055?usp=email
to look at the new patch set (#7).
The following approvals got outdated and were removed:
Code-Review+1 by dexter, Code-Review+1 by laforge, Verified+1 by Jenkins Builder
Change subject: V1.2: Change fields in ProvideEimPackage(Result)
......................................................................
V1.2: Change fields in ProvideEimPackage(Result)
Change parameters in ProvideEimPackage and ProvideEimPackageResult. The
structure is changed in IPA too. The new field eimTransactionId of
EimPackageResultResponseError is filled with the eimTransactionId of
IpaEuiccDataRequest, if exists.
Reference: SGP.32 Section 5.14.6
Related: SYS#8101
Change-Id: I24baab4f9351aec27c58403b94974cba4b274c34
---
M asn1/SGP32Definitions.asn
M src/ipa/libasn/CMakeLists.txt
A src/ipa/libasn/EimPackageResult.c
A src/ipa/libasn/EimPackageResult.h
A src/ipa/libasn/EimPackageResultErrorCode.c
A src/ipa/libasn/EimPackageResultErrorCode.h
A src/ipa/libasn/EimPackageResultResponseError.c
A src/ipa/libasn/EimPackageResultResponseError.h
M src/ipa/libasn/ProvideEimPackageResult.c
M src/ipa/libasn/ProvideEimPackageResult.h
M src/ipa/libasn/ProvideEimPackageResultResponse.c
M src/ipa/libasn/ProvideEimPackageResultResponse.h
M src/ipa/libipa/esipa_prvde_eim_pkg_rslt.c
M src/ipa/libipa/esipa_prvde_eim_pkg_rslt.h
M src/ipa/libipa/proc_euicc_data_req.c
M src/ipa/libipa/proc_euicc_pkg_dwnld_exec.c
16 files changed, 637 insertions(+), 220 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/onomondo-ipa refs/changes/55/43055/7
--
To view, visit https://gerrit.osmocom.org/c/onomondo-ipa/+/43055?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: onomondo-ipa
Gerrit-Branch: master
Gerrit-Change-Id: I24baab4f9351aec27c58403b94974cba4b274c34
Gerrit-Change-Number: 43055
Gerrit-PatchSet: 7
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: jolly <andreas(a)eversberg.eu>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Attention is currently required from: dexter, jolly, laforge.
Hello Jenkins Builder, dexter, laforge,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/onomondo-ipa/+/43054?usp=email
to look at the new patch set (#8).
The following approvals got outdated and were removed:
Code-Review+1 by dexter, Code-Review+1 by laforge, Verified+1 by Jenkins Builder
Change subject: V1.2: Add function ES10b.GetConnectivityParameters
......................................................................
V1.2: Add function ES10b.GetConnectivityParameters
Add new library function to get connectivity parameters from IoT eUICC.
Also add an option to the command line interface to call the library
function.
The function cannot be emulated with non-IoT eUICC.
Reference: SGP.32 Section 5.9.24
Related: SYS#8101
Change-Id: I075590e095dbbe05fa6cdb0a96d5b38c7a17ff78
---
M asn1/SGP32Definitions.asn
M include/onomondo/ipa/ipad.h
M src/ipa/libasn/CMakeLists.txt
A src/ipa/libasn/ConnectivityParameters.c
A src/ipa/libasn/ConnectivityParameters.h
A src/ipa/libasn/ConnectivityParametersError.c
A src/ipa/libasn/ConnectivityParametersError.h
A src/ipa/libasn/GetConnectivityParametersRequest.c
A src/ipa/libasn/GetConnectivityParametersRequest.h
A src/ipa/libasn/GetConnectivityParametersResponse.c
A src/ipa/libasn/GetConnectivityParametersResponse.h
M src/ipa/libipa/CMakeLists.txt
A src/ipa/libipa/es10b_get_conn_params.c
A src/ipa/libipa/es10b_get_conn_params.h
M src/ipa/libipa/ipad.c
M src/ipa/main.c
16 files changed, 588 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/onomondo-ipa refs/changes/54/43054/8
--
To view, visit https://gerrit.osmocom.org/c/onomondo-ipa/+/43054?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: onomondo-ipa
Gerrit-Branch: master
Gerrit-Change-Id: I075590e095dbbe05fa6cdb0a96d5b38c7a17ff78
Gerrit-Change-Number: 43054
Gerrit-PatchSet: 8
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: jolly <andreas(a)eversberg.eu>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Attention is currently required from: jolly.
Hello Jenkins Builder, dexter,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/onomondo-ipa/+/43057?usp=email
to look at the new patch set (#7).
The following approvals got outdated and were removed:
Verified+1 by Jenkins Builder
The change is no longer submittable: Verified is unsatisfied now.
Change subject: V1.2: Add StateChangeCause to GetEimPackageRequest
......................................................................
V1.2: Add StateChangeCause to GetEimPackageRequest
State change notification is optional and currently not supported by
IPA.
Reference: SGP.32 Section 6.3.2.6
Related: SYS#8101
Change-Id: I1ae561f6709a9eb490fa7a53420c332ff20bd058
---
M asn1/SGP32Definitions.asn
M src/ipa/libasn/CMakeLists.txt
M src/ipa/libasn/GetEimPackageRequest.c
M src/ipa/libasn/GetEimPackageRequest.h
A src/ipa/libasn/StateChangeCause.c
A src/ipa/libasn/StateChangeCause.h
6 files changed, 124 insertions(+), 13 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/onomondo-ipa refs/changes/57/43057/7
--
To view, visit https://gerrit.osmocom.org/c/onomondo-ipa/+/43057?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: onomondo-ipa
Gerrit-Branch: master
Gerrit-Change-Id: I1ae561f6709a9eb490fa7a53420c332ff20bd058
Gerrit-Change-Number: 43057
Gerrit-PatchSet: 7
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-Attention: jolly <andreas(a)eversberg.eu>