Attention is currently required from: dexter, laforge.
jolly has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/onomondo-ipa/+/43202?usp=email )
Change subject: Introduce 'operation' parameters to main file
......................................................................
Patch Set 3:
(2 comments)
File src/ipa/main.c:
https://gerrit.osmocom.org/c/onomondo-ipa/+/43202/comment/3fe5bdf9_e91d23c7… :
PS2, Line 50: printf(" -o get-eim-package ..... Ask eIM for eIM package and process it (default operation)\n");
: printf(" -o add-initial-eim PATH..... set initial eIM configuration from given file\n");
: printf(" -o euicc-memory-reset....... reset eUICC memory\n");
> to make it more clear, those should be gruoped somewhere at the beginning or the end of the help mes […]
Done
https://gerrit.osmocom.org/c/onomondo-ipa/+/43202/comment/46a9c722_65e285db… :
PS2, Line 193: break;
> I think this change is only half-done. […]
Done
--
To view, visit https://gerrit.osmocom.org/c/onomondo-ipa/+/43202?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: onomondo-ipa
Gerrit-Branch: master
Gerrit-Change-Id: I6b960f840820990de40fb07332669ddbfcdf1e7d
Gerrit-Change-Number: 43202
Gerrit-PatchSet: 3
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 13 Aug 2026 11:13:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>
Attention is currently required from: dexter, jolly.
laforge has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/onomondo-ipa/+/43202?usp=email )
Change subject: Introduce 'operation' parameters to main file
......................................................................
Patch Set 3: Code-Review+1
(2 comments)
File src/ipa/main.c:
https://gerrit.osmocom.org/c/onomondo-ipa/+/43202/comment/bb47e4e0_6888077c… :
PS2, Line 50: printf(" -o get-eim-package ..... Ask eIM for eIM package and process it (default operation)\n");
: printf(" -o add-initial-eim PATH..... set initial eIM configuration from given file\n");
: printf(" -o euicc-memory-reset....... reset eUICC memory\n");
> to make it more clear, those should be gruoped somewhere at the beginning or the end of the help mes […]
Done
https://gerrit.osmocom.org/c/onomondo-ipa/+/43202/comment/5e74a8c7_3a5c7c83… :
PS2, Line 193: break;
> I think this change is only half-done. […]
Done
--
To view, visit https://gerrit.osmocom.org/c/onomondo-ipa/+/43202?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: onomondo-ipa
Gerrit-Branch: master
Gerrit-Change-Id: I6b960f840820990de40fb07332669ddbfcdf1e7d
Gerrit-Change-Number: 43202
Gerrit-PatchSet: 3
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: jolly <andreas(a)eversberg.eu>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 13 Aug 2026 11:13:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>
jolly has uploaded this change for review. ( https://gerrit.osmocom.org/c/onomondo-ipa/+/43223?usp=email )
Change subject: Use mandatory transaction ID in AuthenticateClientOkDPEsipa
......................................................................
Use mandatory transaction ID in AuthenticateClientOkDPEsipa
The transaction ID in the sequence of AuthenticateClientOkDPEsipa is
optional, so lets use the mandatory transaction ID from the smdpSigned2
field instead.
If the optional transaction ID exists, check if it matches with the
mandatory one.
Related: SYS#8101
Change-Id: I3aed3f6ff6f10b49045ff7a4b0f0019ac1d75c65
---
M src/ipa/libipa/esipa_auth_clnt.c
1 file changed, 11 insertions(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/onomondo-ipa refs/changes/23/43223/1
diff --git a/src/ipa/libipa/esipa_auth_clnt.c b/src/ipa/libipa/esipa_auth_clnt.c
index 8af59a6..f579dda 100644
--- a/src/ipa/libipa/esipa_auth_clnt.c
+++ b/src/ipa/libipa/esipa_auth_clnt.c
@@ -62,11 +62,21 @@
case AuthenticateClientResponseEsipa_PR_authenticateClientOkDPEsipa:
res->auth_clnt_ok_dpe =
&msg_to_ipa->choice.authenticateClientResponseEsipa.choice.authenticateClientOkDPEsipa;
- res->transaction_id = res->auth_clnt_ok_dpe->transactionId;
+ res->transaction_id = &res->auth_clnt_ok_dpe->smdpSigned2.transactionId;
if (!IPA_ASN_STR_CMP(res->transaction_id, &req->req.transactionId)) {
IPA_LOGP_ESIPA("AuthenticateClient", LERROR,
"eIM responded with unexpected transaction ID (expected: %s, got: %s)\n",
ipa_hexdump(req->req.transactionId.buf, req->req.transactionId.size),
+ ipa_hexdump(res->auth_clnt_ok_dpe->smdpSigned2.transactionId.buf,
+ res->auth_clnt_ok_dpe->smdpSigned2.transactionId.size));
+ res->auth_clnt_err = -1;
+ }
+ if (res->auth_clnt_ok_dpe->transactionId &&
+ !IPA_ASN_STR_CMP(res->transaction_id, res->auth_clnt_ok_dpe->transactionId)) {
+ IPA_LOGP_ESIPA("AuthenticateClient", LERROR,
+ "eIM responded with different transaction IDs (%s != %s)\n",
+ ipa_hexdump(res->auth_clnt_ok_dpe->transactionId->buf,
+ res->auth_clnt_ok_dpe->transactionId->size),
ipa_hexdump(res->transaction_id->buf, res->transaction_id->size));
res->auth_clnt_err = -1;
}
--
To view, visit https://gerrit.osmocom.org/c/onomondo-ipa/+/43223?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: onomondo-ipa
Gerrit-Branch: master
Gerrit-Change-Id: I3aed3f6ff6f10b49045ff7a4b0f0019ac1d75c65
Gerrit-Change-Number: 43223
Gerrit-PatchSet: 1
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Attention is currently required from: dexter, jolly, laforge.
Hello Jenkins Builder, dexter, laforge,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/onomondo-ipa/+/43041?usp=email
to look at the new patch set (#6).
The following approvals got outdated and were removed:
Code-Review+1 by laforge, Verified+1 by Jenkins Builder
Change subject: V1.2: Add function ES10b.ExecuteFallbackMechanism
......................................................................
V1.2: Add function ES10b.ExecuteFallbackMechanism
Add new library function to enable the fallback profile on IoT eUICC.
Also add an option to the command line interface to call the library
function. The optional refresh flag may be set via command line option.
The function cannot be emulated with non-IoT eUICC.
Reference: SGP.32 Section 5.9.20
Related: SYS#8101
Change-Id: Ia751f0888c36f39ddfadf7f8bb923a8ee50178dc
---
M asn1/SGP32Definitions.asn
M include/onomondo/ipa/ipad.h
M src/ipa/libasn/CMakeLists.txt
A src/ipa/libasn/ExecuteFallbackMechanismRequest.c
A src/ipa/libasn/ExecuteFallbackMechanismRequest.h
A src/ipa/libasn/ExecuteFallbackMechanismResponse.c
A src/ipa/libasn/ExecuteFallbackMechanismResponse.h
M src/ipa/libipa/CMakeLists.txt
A src/ipa/libipa/es10b_exec_fallback_mech.c
A src/ipa/libipa/es10b_exec_fallback_mech.h
M src/ipa/libipa/ipad.c
M src/ipa/main.c
12 files changed, 383 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/onomondo-ipa refs/changes/41/43041/6
--
To view, visit https://gerrit.osmocom.org/c/onomondo-ipa/+/43041?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: onomondo-ipa
Gerrit-Branch: master
Gerrit-Change-Id: Ia751f0888c36f39ddfadf7f8bb923a8ee50178dc
Gerrit-Change-Number: 43041
Gerrit-PatchSet: 6
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: jolly <andreas(a)eversberg.eu>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Attention is currently required from: dexter, jolly, laforge.
Hello Jenkins Builder, dexter, laforge,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/onomondo-ipa/+/43042?usp=email
to look at the new patch set (#6).
The following approvals got outdated and were removed:
Code-Review+1 by laforge, Verified+1 by Jenkins Builder
Change subject: V1.2: Add function ES10b.ReturnFromFallback
......................................................................
V1.2: Add function ES10b.ReturnFromFallback
Add new library function to return from fallback profile on IoT eUICC.
Also add an option to the command line interface to call the library
function. The optional refresh flag may be set via command line
option.
The function cannot be emulated with non-IoT eUICC.
Reference: SGP.32 Section 5.9.21
Related: SYS#8101
Change-Id: Ib49a8ef3a5ea5639d881ca51eaeeea24f083fe0e
---
M asn1/SGP32Definitions.asn
M include/onomondo/ipa/ipad.h
M src/ipa/libasn/CMakeLists.txt
A src/ipa/libasn/ReturnFromFallbackRequest.c
A src/ipa/libasn/ReturnFromFallbackRequest.h
A src/ipa/libasn/ReturnFromFallbackResponse.c
A src/ipa/libasn/ReturnFromFallbackResponse.h
M src/ipa/libipa/CMakeLists.txt
A src/ipa/libipa/es10b_ret_from_fallback.c
A src/ipa/libipa/es10b_ret_from_fallback.h
M src/ipa/libipa/ipad.c
M src/ipa/main.c
12 files changed, 378 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/onomondo-ipa refs/changes/42/43042/6
--
To view, visit https://gerrit.osmocom.org/c/onomondo-ipa/+/43042?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: onomondo-ipa
Gerrit-Branch: master
Gerrit-Change-Id: Ib49a8ef3a5ea5639d881ca51eaeeea24f083fe0e
Gerrit-Change-Number: 43042
Gerrit-PatchSet: 6
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: jolly <andreas(a)eversberg.eu>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>