August 2026 - gerrit-log - lists.osmocom.org

[M] Change in osmo-trx[master]: Transceiver52M: implement TRXDv2 support
by Jenkins Builder 03 Aug '26

03 Aug '26

Attention is currently required from: fixeria. Jenkins Builder has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-trx/+/43116?usp=email ) Change subject: Transceiver52M: implement TRXDv2 support ...................................................................... Patch Set 4: (4 comments) File Transceiver52M/Transceiver.h: Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-trx/+/43116/comment/ea460578_fe7b24da?usp… : PS4, Line 222: bool sendBurstInd(size_t chan, const struct osmo_trxd_burst_ind *bi); please, no spaces at the start of a line Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-trx/+/43116/comment/c9c7e3d2_2d7d86f5?usp… : PS4, Line 226: bool queueBurstIndBatched(size_t chan, const struct osmo_trxd_burst_ind *bi); please, no spaces at the start of a line Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-trx/+/43116/comment/13c3ead1_a238e484?usp… : PS4, Line 229: bool flushBurstIndBatch(size_t chan); please, no spaces at the start of a line Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-trx/+/43116/comment/97a4635c_77605032?usp… : PS4, Line 232: bool handleBurstReq(size_t chan, const struct osmo_trxd_burst_req *br); please, no spaces at the start of a line -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/43116?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: Ie6a33e3980b3ca4ab05a3d4221d5a8ba0132233d Gerrit-Change-Number: 43116 Gerrit-PatchSet: 4 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 03 Aug 2026 22:10:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[L] Change in osmo-trx[master]: Transceiver52M: migrate to libosmo-trx
by Jenkins Builder 03 Aug '26

03 Aug '26

Attention is currently required from: pespin. Jenkins Builder has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-trx/+/43115?usp=email ) Change subject: Transceiver52M: migrate to libosmo-trx ...................................................................... Patch Set 3: (3 comments) File Transceiver52M/Transceiver.h: Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-trx/+/43115/comment/49300c37_bbd1a04c?usp… : PS3, Line 158: char data[OSMO_TRXC_MSG_BUF_SIZE]; please, no spaces at the start of a line Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-trx/+/43115/comment/7fe90438_bbd50a7a?usp… : PS3, Line 210: int pullRadioVector(size_t chan, struct osmo_trxd_burst_ind *ind); please, no spaces at the start of a line Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-trx/+/43115/comment/2a872221_a635bc9c?usp… : PS3, Line 272: void logRxBurst(size_t chan, const struct osmo_trxd_burst_ind *bi); please, no spaces at the start of a line -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/43115?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I458ec85c56e2101d073c8c35f11c147191c4ea0c Gerrit-Change-Number: 43115 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 03 Aug 2026 22:10:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[XL] Change in osmo-trx[master]: libosmo-trx: generate Doxygen API documentation
by fixeria 03 Aug '26

03 Aug '26

Attention is currently required from: fixeria, pespin. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-trx/+/43113?usp=email to look at the new patch set (#4). Change subject: libosmo-trx: generate Doxygen API documentation ...................................................................... libosmo-trx: generate Doxygen API documentation Add Doxyfile.trx.in (based on Doxyfile.core.in from libosmocore.git, upgraded using 'doxygen -u' to get rid of obsolete tags) and the usual rules to build and install the HTML documentation, as well as the --disable-doxygen configure option, like in other libosmo-* projects. Change-Id: I54cf8c0c60215c666d8fa55dafec53379a2382d5 --- M .gitignore M configure.ac A libosmo-trx/Doxyfile.trx.in M libosmo-trx/Makefile.am 4 files changed, 3,027 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/13/43113/4 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/43113?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I54cf8c0c60215c666d8fa55dafec53379a2382d5 Gerrit-Change-Number: 43113 Gerrit-PatchSet: 4 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de>

1 0

[M] Change in osmo-trx[master]: Transceiver52M: implement TRXDv2 support
by Jenkins Builder 03 Aug '26

03 Aug '26

Attention is currently required from: fixeria. Jenkins Builder has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-trx/+/43116?usp=email ) Change subject: Transceiver52M: implement TRXDv2 support ...................................................................... Patch Set 3: (4 comments) File Transceiver52M/Transceiver.h: Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-trx/+/43116/comment/74622924_bb6edc1f?usp… : PS3, Line 222: bool sendBurstInd(size_t chan, const struct osmo_trxd_burst_ind *bi); please, no spaces at the start of a line Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-trx/+/43116/comment/1fc8e32c_958d6d46?usp… : PS3, Line 226: bool queueBurstIndBatched(size_t chan, const struct osmo_trxd_burst_ind *bi); please, no spaces at the start of a line Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-trx/+/43116/comment/6e934d09_ebeb423b?usp… : PS3, Line 229: bool flushBurstIndBatch(size_t chan); please, no spaces at the start of a line Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-trx/+/43116/comment/827c611d_41a10e92?usp… : PS3, Line 232: bool handleBurstReq(size_t chan, const struct osmo_trxd_burst_req *br); please, no spaces at the start of a line -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/43116?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: Ie6a33e3980b3ca4ab05a3d4221d5a8ba0132233d Gerrit-Change-Number: 43116 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 03 Aug 2026 21:55:03 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[XL] Change in osmo-trx[master]: libosmo-trx/client: add TRXC client (command queue) API
by fixeria 03 Aug '26

03 Aug '26

Attention is currently required from: pespin. fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-trx/+/43108?usp=email ) Change subject: libosmo-trx/client: add TRXC client (command queue) API ...................................................................... Patch Set 3: (1 comment) File libosmo-trx/src/trxc_client.c: https://gerrit.osmocom.org/c/osmo-trx/+/43108/comment/86876fbd_bf82f829?usp… : PS1, Line 267: void osmo_trxc_client_flush(struct osmo_trxc_client *client) > See osmo-pcap.git src/osmo_pcap_wr_file.c on how to accomplish it, eg. […] The TRXC client does not deal with socket I/O directly, so this is not needed here. -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/43108?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I817e394f74a10e3adae4a0b58342c82acdf0794e Gerrit-Change-Number: 43108 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 03 Aug 2026 21:54:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 0

[XL] Change in osmo-trx[master]: libosmo-trx/client: add TRXC client (command queue) API
by fixeria 03 Aug '26

03 Aug '26

Attention is currently required from: pespin. fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-trx/+/43108?usp=email ) Change subject: libosmo-trx/client: add TRXC client (command queue) API ...................................................................... Patch Set 3: (3 comments) File libosmo-trx/include/osmocom/trx/trxc_client.h: https://gerrit.osmocom.org/c/osmo-trx/+/43108/comment/5b2e27b3_339276b2?usp… : PS1, Line 32: struct osmo_trxc_client_ops { > I'd rather add APIs to set each callbacks and private pointers, as done in osmo_stream, to allow for […] Acknowledged File libosmo-trx/src/trxc_client.c: https://gerrit.osmocom.org/c/osmo-trx/+/43108/comment/2f361e90_f7e479c1?usp… : PS1, Line 190: void osmo_trxc_client_set_retrans(struct osmo_trxc_client *client, unsigned int sec) > set_restrans_timeout?Is 0 allowed? document it and if not allowed return an error. Done https://gerrit.osmocom.org/c/osmo-trx/+/43108/comment/0918f3a6_ebfa27aa?usp… : PS1, Line 481: client->setformat_ver_req = ver_max; > I'd rather store the user cb + cb_data in a struct, pass it to osmo_trxc_client_send_cmd() below ins […] Good idea, done. -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/43108?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I817e394f74a10e3adae4a0b58342c82acdf0794e Gerrit-Change-Number: 43108 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 03 Aug 2026 21:53:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 0

[M] Change in osmo-trx[master]: libosmo-trx/client: add optional limit for retransmissions
by fixeria 03 Aug '26

03 Aug '26

Attention is currently required from: pespin. fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-trx/+/43109?usp=email ) Change subject: libosmo-trx/client: add optional limit for retransmissions ...................................................................... Patch Set 3: (1 comment) File libosmo-trx/src/trxc_client.c: https://gerrit.osmocom.org/c/osmo-trx/+/43109/comment/a937d05b_4d802fc2?usp… : PS1, Line 118: LOGCL(client, LOGL_NOTICE, "No response from transceiver for '" CMD_NAME_FMT "'\n", > log e->n_retrans here. Done -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/43109?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: Ib90a032b38c69ae26023e726992d3f5f7e502fcf Gerrit-Change-Number: 43109 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 03 Aug 2026 21:53:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 0

[XL] Change in osmo-trx[master]: libosmo-trx/ep: add TRX endpoint module
by fixeria 03 Aug '26

03 Aug '26

Attention is currently required from: pespin. fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-trx/+/43111?usp=email ) Change subject: libosmo-trx/ep: add TRX endpoint module ...................................................................... Patch Set 3: (4 comments) File libosmo-trx/include/osmocom/trx/ep.h: https://gerrit.osmocom.org/c/osmo-trx/+/43111/comment/dbf0aae1_0e92cc2d?usp… : PS1, Line 27: struct osmo_trx_ep_cfg { > Let's please have separate setter functions for all these, like osmo_stream, so we don't need to bre […] Done File libosmo-trx/src/trx_ep.c: https://gerrit.osmocom.org/c/osmo-trx/+/43111/comment/d28c9f25_658f98ca?usp… : PS1, Line 60: uint8_t pdu_ver; /* TRXD PDU version in use */ > iirc PDU VER stuff is defined/envisioned only for TRX0, so this can be moved to struct osmo_trx_ep. No. The TRXD PDU version is actually negotiated for each endpoint separately. At least osmo-bts does negotiate the version for each transceiver connection individually, and osmo-trx handles this properly. Only the power on/off command propagates to other connections. https://gerrit.osmocom.org/c/osmo-trx/+/43111/comment/40c30008_795a1db0?usp… : PS1, Line 70: struct osmo_trx_ep_chan *chans; /* array of cfg.num_chans channels */ > If the chans array is allocated at the end of the struct, it probably makes sense to use "struct osm […] See my comment below. https://gerrit.osmocom.org/c/osmo-trx/+/43111/comment/838ddccf_47a6a862?usp… : PS1, Line 302: ep->chans = talloc_zero_array(ep, struct osmo_trx_ep_chan, cfg->num_chans); > Ah I see you are allocating the array here as a pointer to a seaprate memory region. […] I don't see the need for such a premature optimization, sorry. A `struct osmo_trx_ep` is normally allocated once and remains in the memory until the PHY connection is closed. It's not like we're allocating/freeing tons of endpoints per second. -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/43111?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I767fa43a9ca88be40c385f6dcb9de22891a6afc3 Gerrit-Change-Number: 43111 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 03 Aug 2026 21:52:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in osmo-trx[master]: libosmo-trx/ep: flush pending TRXC messages on endpoint teardown
by fixeria 03 Aug '26

03 Aug '26

Attention is currently required from: pespin. fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-trx/+/43112?usp=email ) Change subject: libosmo-trx/ep: flush pending TRXC messages on endpoint teardown ...................................................................... Patch Set 2: (1 comment) File libosmo-trx/src/trx_ep.c: https://gerrit.osmocom.org/c/osmo-trx/+/43112/comment/c8e03909_142344ef?usp… : PS1, Line 353: /*! Close all sockets of the given endpoint. > See osmo-pcap.git src/osmo_pcap_wr_file. […] Done -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/43112?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I69e6a3bcf49afc3cfca4a72afdf459625cb91e56 Gerrit-Change-Number: 43112 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 03 Aug 2026 21:52:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 0

[L] Change in osmo-trx[master]: Transceiver52M: migrate to libosmo-trx
by fixeria 03 Aug '26

03 Aug '26

Attention is currently required from: pespin. fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-trx/+/43115?usp=email ) Change subject: Transceiver52M: migrate to libosmo-trx ...................................................................... Patch Set 3: (2 comments) File Transceiver52M/Transceiver.cpp: https://gerrit.osmocom.org/c/osmo-trx/+/43115/comment/ee2d1029_7f2ef91c?usp… : PS1, Line 660: /* Convert a soft bit normalized to 0..1 (1.0 = confident '1') into the > `float_soft_bit_to_sbit()` isn't new - it's the same quantization step the old code always did; move […] Done https://gerrit.osmocom.org/c/osmo-trx/+/43115/comment/2df522ec_17365912?usp… : PS1, Line 801: bi->toa256 = (int16_t) lround(ebp.toa * 256.0); > The reason is that libosmo-trx's `struct osmo_trxd_burst_ind` is different from the old `struct trx_ […] Done -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/43115?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I458ec85c56e2101d073c8c35f11c147191c4ea0c Gerrit-Change-Number: 43115 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 03 Aug 2026 21:48:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 0