August 2026 - gerrit-log - lists.osmocom.org

[M] Change in libosmo-sigtran[master]: asp: Support setting timer xua beat 0 through VTY
by osmith 04 Aug '26

04 Aug '26

Attention is currently required from: daniel, fixeria, laforge, pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/43156?usp=email ) Change subject: asp: Support setting timer xua beat 0 through VTY ...................................................................... Patch Set 1: Code-Review+1 (1 comment) File src/ss7_asp_vty.c: https://gerrit.osmocom.org/c/libosmo-sigtran/+/43156/comment/6428741a_1dc2b… : PS1, Line 835: if (!t) maybe print a message here as well, so the user knows what went wrong? -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/43156?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: Iadd7c6751ab09640fd2df214afa2ec87274a3210 Gerrit-Change-Number: 43156 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Tue, 04 Aug 2026 07:44:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-ttcn3-hacks[master]: stp: Define IUT default T(beat) in mp_t_beat_sec_default
by pespin 04 Aug '26

04 Aug '26

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43158?usp=email ) Change subject: stp: Define IUT default T(beat) in mp_t_beat_sec_default ...................................................................... stp: Define IUT default T(beat) in mp_t_beat_sec_default Several tests expect to know this value from the IUT in order to test related features. Since it will be used in more places in follow-up patches, move it so the information only needs to be configured once. Change-Id: Ic518e0d35f377fef85344177b630eb8599ec22d0 --- M stp/STP_Tests_Common.ttcn M stp/STP_Tests_IPA.ttcn M stp/STP_Tests_M3UA.ttcn 3 files changed, 7 insertions(+), 2 deletions(-) Approvals: osmith: Looks good to me, approved Jenkins Builder: Verified fixeria: Looks good to me, but someone else must approve diff --git a/stp/STP_Tests_Common.ttcn b/stp/STP_Tests_Common.ttcn index 0a0a436..16b6406 100644 --- a/stp/STP_Tests_Common.ttcn +++ b/stp/STP_Tests_Common.ttcn @@ -28,6 +28,11 @@ import from SCCPasp_Types all; import from SCCP_Emulation all; +modulepar { + /* Default T(beat) configured at the IUT ASP, in seconds */ + integer mp_t_beat_sec_default := 30; +} + function f_SCCP_UDT(template (value) SCCP_PAR_Address calling := ts_SccpAddr_GT('5678'H), template (value) SCCP_PAR_Address called := ts_SccpAddr_GT('1234'H), template (omit) octetstring data := omit) return octetstring diff --git a/stp/STP_Tests_IPA.ttcn b/stp/STP_Tests_IPA.ttcn index 431bdd4..7225949 100644 --- a/stp/STP_Tests_IPA.ttcn +++ b/stp/STP_Tests_IPA.ttcn @@ -849,7 +849,7 @@ } /* return to default value: */ - f_vty_cs7_ipa_asp_cmd(g_ipa_configs[0], "timer xua beat 30"); + f_vty_cs7_ipa_asp_cmd(g_ipa_configs[0], "timer xua beat " & int2str(STP_Tests_Common.mp_t_beat_sec_default)); } /* Test the IUT sends heartbeat procedure when needed. */ diff --git a/stp/STP_Tests_M3UA.ttcn b/stp/STP_Tests_M3UA.ttcn index ac9cc25..7debed6 100644 --- a/stp/STP_Tests_M3UA.ttcn +++ b/stp/STP_Tests_M3UA.ttcn @@ -598,7 +598,7 @@ } /* return to default value: */ - f_vty_cs7_asp_cmd(g_m3ua_configs[0], "timer xua beat 30"); + f_vty_cs7_asp_cmd(g_m3ua_configs[0], "timer xua beat " & int2str(STP_Tests_Common.mp_t_beat_sec_default)); f_clear_m3ua(); } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43158?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ic518e0d35f377fef85344177b630eb8599ec22d0 Gerrit-Change-Number: 43158 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[M] Change in osmo-ttcn3-hacks[master]: stp: Validate timer xua beat 0 disables BEAT procedure
by pespin 04 Aug '26

04 Aug '26

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43159?usp=email ) Change subject: stp: Validate timer xua beat 0 disables BEAT procedure ...................................................................... stp: Validate timer xua beat 0 disables BEAT procedure Check in all sort of configurations that the BEAT procedure on xUA/IPA can be disabled just fine per ASP using the VTY. Related: SYS#8156 Change-Id: Id47bf862638a099bb5f6721fcfba873001aed616 --- M stp/STP_Tests_Common.ttcn M stp/STP_Tests_IPA.ttcn M stp/STP_Tests_M3UA.ttcn M stp/STP_Tests_M3UA_TCP.ttcn M stp/expected-results.xml 5 files changed, 124 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, but someone else must approve osmith: Looks good to me, approved diff --git a/stp/STP_Tests_Common.ttcn b/stp/STP_Tests_Common.ttcn index 16b6406..2178a98 100644 --- a/stp/STP_Tests_Common.ttcn +++ b/stp/STP_Tests_Common.ttcn @@ -47,7 +47,8 @@ type component Test_CT { port TELNETasp_PT VTY; - timer g_Tguard := 30.0; + timer g_Tguard; + var float g_Tguard_timeout := 30.0; var boolean g_test_initialized := false; } @@ -69,7 +70,7 @@ f_vty_transceive(VTY, "enable"); activate(as_gTguard()); - g_Tguard.start; + g_Tguard.start(g_Tguard_timeout); } diff --git a/stp/STP_Tests_IPA.ttcn b/stp/STP_Tests_IPA.ttcn index 7225949..b16cb0e 100644 --- a/stp/STP_Tests_IPA.ttcn +++ b/stp/STP_Tests_IPA.ttcn @@ -852,18 +852,76 @@ f_vty_cs7_ipa_asp_cmd(g_ipa_configs[0], "timer xua beat " & int2str(STP_Tests_Common.mp_t_beat_sec_default)); } +/* Test ASP doesn't send a T(beat) when disabled over VTY ("timer xua beat 0") */ +friend function f_TC_beat_disabled(Misc_Helpers.ro_charstring asps) runs on IPA_CT +{ + var IpaConfigs ipa_configs := ipa_build_configs(asps); + var float timeout_val := int2float(STP_Tests_Common.mp_t_beat_sec_default) + 1.0; + var IpaCcmMsgtype ipa_ping_msg := IPAC_MSGT_PING; + var octetstring ipa_ping_data := int2oct(enum2int(ipa_ping_msg), 1); + + g_Tguard_timeout := 60.0; + f_init_common(); + f_init_ipa(ipa_configs := ipa_configs); + + f_vty_cs7_ipa_asp_cmd(ipa_configs[0], "timer xua beat 0"); + + if (ipa_configs[0].is_server) { + f_listen_ipa(0); + } else { + f_connect_ipa(0); + } + /* receive CCM IPA PING: */ + f_ipa_cfg_chg_ccm_enabled(IPA_CFG[0], false); + + timer T; + var ASP_IPA_Unitdata ipa_rx; + T.start(timeout_val); + alt { + [] IPA_CTRL[0].receive(t_ASP_IPA_UD(IPAC_PROTO_CCM, ipa_ping_data)) -> value ipa_rx { + Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, + log2str("Received unexpected IPA ", ipa_rx)); + } + [] IPA_CTRL[0].receive { + Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, + log2str("Received unexpected IPA before timeout expecting no ", + t_ASP_IPA_UD(IPAC_PROTO_CCM, ipa_ping_data))); + } + [] T.timeout { + setverdict(pass); + } + } + + log("No BEAT received, all good!"); + + /* return to default value: */ + f_vty_cs7_ipa_asp_cmd(ipa_configs[0], "timer xua beat " & int2str(STP_Tests_Common.mp_t_beat_sec_default)); +} + /* Test the IUT sends heartbeat procedure when needed. */ testcase TC_beat_timeout() runs on IPA_CT { var Misc_Helpers.ro_charstring asps := { "ipa-asp-override-sender" }; f_TC_beat_timeout(asps); } +/* Test the IUT sends no heartbeat procedure when disabled over VTY */ +testcase TC_beat_disabled() runs on IPA_CT { + var Misc_Helpers.ro_charstring asps := { "ipa-asp-override-sender" }; + f_TC_beat_disabled(asps); +} + /* Test the IUT sends heartbeat procedure when needed. */ testcase TC_clnt_beat_timeout() runs on IPA_CT { var Misc_Helpers.ro_charstring asps := { "ipa-asp-client0" }; f_TC_beat_timeout(asps); } +/* Test the IUT sends no heartbeat procedure when disabled over VTY */ +testcase TC_clnt_beat_disabled() runs on IPA_CT { + var Misc_Helpers.ro_charstring asps := { "ipa-asp-client0" }; + f_TC_beat_disabled(asps); +} + control { execute( TC_unknown_client_nodynamic() ); execute( TC_unknown_as_client_nodynamic() ); @@ -884,7 +942,9 @@ execute( TC_beat() ); execute( TC_beat_timeout() ); + execute( TC_beat_disabled() ); execute( TC_clnt_beat_timeout() ); + execute( TC_clnt_beat_disabled() ); } diff --git a/stp/STP_Tests_M3UA.ttcn b/stp/STP_Tests_M3UA.ttcn index 7debed6..f1ce309 100644 --- a/stp/STP_Tests_M3UA.ttcn +++ b/stp/STP_Tests_M3UA.ttcn @@ -603,12 +603,46 @@ f_clear_m3ua(); } +/* Test ASP doesn't send a T(beat) when disabled over VTY ("timer xua beat 0") */ +friend function f_TC_beat_disabled(Misc_Helpers.ro_charstring asps) runs on RAW_M3UA_CT +{ + var M3uaConfigs m3ua_configs := m3ua_build_configs(asps); + var M3UA_RecvFrom rx; + var template (omit) M3UA_Heartbeat_Data hbd := omit; + var float timeout_val := int2float(STP_Tests_Common.mp_t_beat_sec_default) + 1.0; + + g_Tguard_timeout := 60.0; + f_init_m3ua(answer_beat := false, m3ua_configs := m3ua_configs); + f_vty_cs7_asp_cmd(g_m3ua_configs[0], "timer xua beat 0"); + + if (m3ua_configs[0].is_server) { + f_init_m3ua_srv(); + f_M3UA_CLNT_asp_up_act(0, rctx := int2oct(m3ua_configs[0].routing_ctx, 4)); + } else { + f_M3UA_asp_up(0, ntfy_after_up := c_M3UA_ST_I_AS_INACTIVE); + } + + f_M3UA_exp_no(0, tr_M3UA_BEAT(*), timeout_val := timeout_val, answer_beat := false); + log("No BEAT received, all good!"); + + /* return to default value: */ + f_vty_cs7_asp_cmd(g_m3ua_configs[0], "timer xua beat " & int2str(STP_Tests_Common.mp_t_beat_sec_default)); + + f_clear_m3ua(); +} + /* Test the IUT sends heartbeat procedure when needed. */ testcase TC_beat_timeout() runs on RAW_M3UA_CT { var Misc_Helpers.ro_charstring asps := { "asp-sender" }; f_TC_beat_timeout(asps); } +/* Test the IUT sends no heartbeat procedure when disabled over VTY */ +testcase TC_beat_disabled() runs on RAW_M3UA_CT { + var Misc_Helpers.ro_charstring asps := { "asp-sender" }; + f_TC_beat_disabled(asps); +} + /* Test the ASP-ACTIVATE procedure (without traffic-mode or routing ctx) */ testcase TC_asp_act() runs on RAW_M3UA_CT { f_init_m3ua(); @@ -1304,6 +1338,11 @@ var Misc_Helpers.ro_charstring asps := { "asp-client0" }; f_TC_beat_timeout(asps); } +/* Test the IUT sends no heartbeat procedure when disabled over VTY */ +testcase TC_clnt_beat_disabled() runs on RAW_M3UA_CT { + var Misc_Helpers.ro_charstring asps := { "asp-client0" }; + f_TC_beat_disabled(asps); +} /* Expect inbound connection from ASP/SCTP-client, followed by ASP-UP + ASP-ACT */ testcase TC_clnt_asp_act() runs on RAW_M3UA_CT { @@ -1906,6 +1945,7 @@ execute( TC_beat() ); execute( TC_beat_payload() ); execute( TC_beat_timeout() ); + execute( TC_beat_disabled() ); execute( TC_asp_act() ); execute( TC_asp_act_override() ); execute( TC_asp_act_loadshare() ); @@ -1942,6 +1982,7 @@ /* Test STP as SCTP client + M3UA ASP role */ execute( TC_clnt_connect_asp_up() ); execute( TC_clnt_beat_timeout() ); + execute( TC_clnt_beat_disabled() ); execute( TC_clnt_asp_act() ); execute( TC_clnt_sg_to_asp() ); execute( TC_clnt_asp_to_sg() ); diff --git a/stp/STP_Tests_M3UA_TCP.ttcn b/stp/STP_Tests_M3UA_TCP.ttcn index 8bed7e2..4e0706b 100644 --- a/stp/STP_Tests_M3UA_TCP.ttcn +++ b/stp/STP_Tests_M3UA_TCP.ttcn @@ -201,12 +201,24 @@ f_TC_beat_timeout(asps); } +/* Test the IUT sends no heartbeat procedure when disabled over VTY */ +testcase TC_m3ua_tcp_beat_disabled() runs on RAW_M3UA_CT { + var Misc_Helpers.ro_charstring asps := { "asp-sender-tcp" }; + f_TC_beat_disabled(asps); +} + /* Test the IUT sends heartbeat procedure when needed. */ testcase TC_m3ua_tcp_clnt_beat_timeout() runs on RAW_M3UA_CT { var Misc_Helpers.ro_charstring asps := { "asp-client0-tcp" }; f_TC_beat_timeout(asps); } +/* Test the IUT sends no heartbeat procedure when disabled over VTY */ +testcase TC_m3ua_tcp_clnt_beat_disabled() runs on RAW_M3UA_CT { + var Misc_Helpers.ro_charstring asps := { "asp-client0-tcp" }; + f_TC_beat_disabled(asps); +} + control { /* M3UA TCP Tests */ execute( TC_m3ua_tcp_cli() ); @@ -218,7 +230,9 @@ execute( TC_m3ua_tcp_cli_adm_shutdown() ); execute( TC_m3ua_tcp_beat_timeout() ); + execute( TC_m3ua_tcp_beat_disabled() ); execute( TC_m3ua_tcp_clnt_beat_timeout() ); + execute( TC_m3ua_tcp_clnt_beat_disabled() ); } } diff --git a/stp/expected-results.xml b/stp/expected-results.xml index 92f0a92..2243959 100644 --- a/stp/expected-results.xml +++ b/stp/expected-results.xml @@ -4,6 +4,7 @@ <testcase classname='STP_Tests_M3UA' name='TC_beat' time='MASKED'/> <testcase classname='STP_Tests_M3UA' name='TC_beat_payload' time='MASKED'/> <testcase classname='STP_Tests_M3UA' name='TC_beat_timeout' time='MASKED'/> + <testcase classname='STP_Tests_M3UA' name='TC_beat_disabled' time='MASKED'/> <testcase classname='STP_Tests_M3UA' name='TC_asp_act' time='MASKED'/> <testcase classname='STP_Tests_M3UA' name='TC_asp_act_override' time='MASKED'/> <testcase classname='STP_Tests_M3UA' name='TC_asp_act_loadshare' time='MASKED'/> @@ -28,6 +29,7 @@ <testcase classname='STP_Tests_M3UA' name='TC_dyn_2asp_as_rkm_permitted' time='MASKED'/> <testcase classname='STP_Tests_M3UA' name='TC_clnt_connect_asp_up' time='MASKED'/> <testcase classname='STP_Tests_M3UA' name='TC_clnt_beat_timeout' time='MASKED'/> + <testcase classname='STP_Tests_M3UA' name='TC_clnt_beat_disabled' time='MASKED'/> <testcase classname='STP_Tests_M3UA' name='TC_clnt_asp_act' time='MASKED'/> <testcase classname='STP_Tests_M3UA' name='TC_clnt_sg_to_asp' time='MASKED'/> <testcase classname='STP_Tests_M3UA' name='TC_clnt_asp_to_sg' time='MASKED'/> @@ -54,7 +56,9 @@ <testcase classname='STP_Tests_M3UA_TCP' name='TC_m3ua_tcp_srv_adm_shutdown' time='MASKED'/> <testcase classname='STP_Tests_M3UA_TCP' name='TC_m3ua_tcp_cli_adm_shutdown' time='MASKED'/> <testcase classname='STP_Tests_M3UA_TCP' name='TC_m3ua_tcp_beat_timeout' time='MASKED'/> + <testcase classname='STP_Tests_M3UA_TCP' name='TC_m3ua_tcp_beat_disabled' time='MASKED'/> <testcase classname='STP_Tests_M3UA_TCP' name='TC_m3ua_tcp_clnt_beat_timeout' time='MASKED'/> + <testcase classname='STP_Tests_M3UA_TCP' name='TC_m3ua_tcp_clnt_beat_disabled' time='MASKED'/> <testcase classname='STP_Tests_IPA' name='TC_unknown_client_nodynamic' time='MASKED'/> <testcase classname='STP_Tests_IPA' name='TC_unknown_as_client_nodynamic' time='MASKED'/> <testcase classname='STP_Tests_IPA' name='TC_known_client_nodynamic' time='MASKED'/> @@ -72,7 +76,9 @@ <testcase classname='STP_Tests_IPA' name='TC_ipa_tcp_cli_adm_shutdown' time='MASKED'/> <testcase classname='STP_Tests_IPA' name='TC_beat' time='MASKED'/> <testcase classname='STP_Tests_IPA' name='TC_beat_timeout' time='MASKED'/> + <testcase classname='STP_Tests_IPA' name='TC_beat_disabled' time='MASKED'/> <testcase classname='STP_Tests_IPA' name='TC_clnt_beat_timeout' time='MASKED'/> + <testcase classname='STP_Tests_IPA' name='TC_clnt_beat_disabled' time='MASKED'/> <testcase classname='STP_Tests_IPA_M3UA' name='TC_m3ua_to_ipa' time='MASKED'/> <testcase classname='STP_Tests_IPA_M3UA' name='TC_ipa_to_m3ua' time='MASKED'/> <testcase classname='STP_Tests_IPA_M3UA' name='TC_ipa_to_m3ua_ni' time='MASKED'/> -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43159?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Id47bf862638a099bb5f6721fcfba873001aed616 Gerrit-Change-Number: 43159 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[M] Change in osmo-trx[master]: libosmo-trx/client: make public API operate on parsed messages
by pespin 04 Aug '26

04 Aug '26

Attention is currently required from: fixeria. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-trx/+/43110?usp=email ) Change subject: libosmo-trx/client: make public API operate on parsed messages ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/43110?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: Idf53513d06be2337383601494b225b5722c93129 Gerrit-Change-Number: 43110 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 04 Aug 2026 07:38:16 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in osmo-trx[master]: libosmo-trx/client: add optional limit for retransmissions
by pespin 04 Aug '26

04 Aug '26

Attention is currently required from: fixeria. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-trx/+/43109?usp=email ) Change subject: libosmo-trx/client: add optional limit for retransmissions ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/43109?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: Ib90a032b38c69ae26023e726992d3f5f7e502fcf Gerrit-Change-Number: 43109 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 04 Aug 2026 07:36:55 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XL] Change in osmo-trx[master]: libosmo-trx/client: add TRXC client (command queue) API
by pespin 04 Aug '26

04 Aug '26

Attention is currently required from: fixeria. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-trx/+/43108?usp=email ) Change subject: libosmo-trx/client: add TRXC client (command queue) API ...................................................................... Patch Set 3: (1 comment) File libosmo-trx/src/trxc_client.c: https://gerrit.osmocom.org/c/osmo-trx/+/43108/comment/ed2bb9cf_cf4663c9?usp… : PS3, Line 474: sf->cb(client, 0, sf->cb_data); By freeing "sf" after the cb, you may end up in a double free if the user callback frees the "client" pointer.Hence, you should better free "sf" before calling the callback. -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/43108?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I817e394f74a10e3adae4a0b58342c82acdf0794e Gerrit-Change-Number: 43108 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 04 Aug 2026 07:35:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[L] Change in osmo-trx[master]: libosmo-trx/trxc: add SETSLOT parameter parser/builder
by pespin 04 Aug '26

04 Aug '26

Attention is currently required from: fixeria. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-trx/+/43107?usp=email ) Change subject: libosmo-trx/trxc: add SETSLOT parameter parser/builder ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/43107?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I17a1176b1418edd0caf750d50acda0482d4ad04a Gerrit-Change-Number: 43107 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 04 Aug 2026 07:27:46 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in osmo-ttcn3-hacks[master]: stp: Validate timer xua beat 0 disables BEAT procedure
by osmith 04 Aug '26

04 Aug '26

Attention is currently required from: daniel, laforge, pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43159?usp=email ) Change subject: stp: Validate timer xua beat 0 disables BEAT procedure ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43159?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Id47bf862638a099bb5f6721fcfba873001aed616 Gerrit-Change-Number: 43159 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Tue, 04 Aug 2026 06:49:07 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-ttcn3-hacks[master]: stp: Define IUT default T(beat) in mp_t_beat_sec_default
by osmith 04 Aug '26

04 Aug '26

Attention is currently required from: pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43158?usp=email ) Change subject: stp: Define IUT default T(beat) in mp_t_beat_sec_default ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43158?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ic518e0d35f377fef85344177b630eb8599ec22d0 Gerrit-Change-Number: 43158 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 04 Aug 2026 06:38:53 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[L] Change in osmo-trx[master]: Transceiver52M: migrate to libosmo-trx
by Jenkins Builder 03 Aug '26

03 Aug '26

Attention is currently required from: pespin. Jenkins Builder has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-trx/+/43115?usp=email ) Change subject: Transceiver52M: migrate to libosmo-trx ...................................................................... Patch Set 4: (3 comments) File Transceiver52M/Transceiver.h: Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-trx/+/43115/comment/c3651279_cbcf77ad?usp… : PS4, Line 158: char data[OSMO_TRXC_MSG_BUF_SIZE]; please, no spaces at the start of a line Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-trx/+/43115/comment/7d47f833_592ea374?usp… : PS4, Line 210: int pullRadioVector(size_t chan, struct osmo_trxd_burst_ind *ind); please, no spaces at the start of a line Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-trx/+/43115/comment/6354650f_2e3825f4?usp… : PS4, Line 272: void logRxBurst(size_t chan, const struct osmo_trxd_burst_ind *bi); please, no spaces at the start of a line -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/43115?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I458ec85c56e2101d073c8c35f11c147191c4ea0c Gerrit-Change-Number: 43115 Gerrit-PatchSet: 4 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 03 Aug 2026 22:10:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0