Attention is currently required from: dexter, laforge, lynxis lazus.
Hello Jenkins Builder, dexter, laforge,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/simtrace2/+/43185?usp=email
to look at the new patch set (#6).
The following approvals got outdated and were removed:
Verified+1 by Jenkins Builder
Change subject: Add osmo_apdu_segment_in2() to ensure correct parsing of GP GET DATA
......................................................................
Add osmo_apdu_segment_in2() to ensure correct parsing of GP GET DATA
osmo_apdu_segment_in() doesn't have the context of the previous APDU,
for nearly all calls this is fine, except for GP GET DATA, which can be
a case 2 or case 4 APDU.
GP GET DATA defines the Le field as 0x00 which is used by osmo_apdu_segment_in
to detect if it is a case 2 or case 4.
But if the card responded to a case 2 GP GET DATA with Le = 0 with a
SW 6cXX, the previous GP GET DATA case 2 must be resent with a Le field XX,
which got misinterpreted by the osmo_apdu_segment_in() as a case 4 APDU
instead of a case 2.
Introduce osmo_apdu_segment_in2() containing the previous APDU as
context.
Modem <-> Card
81cadf2000 ->
<- 6c0b
81cadf200b ->
-- Simtrace waits for more data instead sends the APUD case 2 to the card.
Related: SYS#8147
Change-Id: Ie238662e7e6a10dd4283ede0c8d8d73bc375c247
---
M TODO-RELEASE
M host/Makefile.am
M host/configure.ac
M host/include/osmocom/simtrace2/apdu_dispatch.h
M host/lib/apdu_dispatch.c
A host/tests/Makefile.am
A host/tests/apdu_dispatch/Makefile.am
A host/tests/apdu_dispatch/apdu_dispatch_test.c
A host/tests/apdu_dispatch/apdu_dispatch_test.ok
A host/tests/testsuite.at
10 files changed, 195 insertions(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/simtrace2 refs/changes/85/43185/6
--
To view, visit https://gerrit.osmocom.org/c/simtrace2/+/43185?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: simtrace2
Gerrit-Branch: master
Gerrit-Change-Id: Ie238662e7e6a10dd4283ede0c8d8d73bc375c247
Gerrit-Change-Number: 43185
Gerrit-PatchSet: 6
Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/onomondo-eim/+/43207?usp=email )
Change subject: rest_api_resource/response_schema: add spec ref for ICCID
......................................................................
rest_api_resource/response_schema: add spec ref for ICCID
This eIM accepts the ICCID in it raw form (as found in EF.ICCID).
Let's add a spec ref so users can look up the exact format quicker.
Related: SYS#8100
Change-Id: Idf6f29386b9b6df9255e10d0dd2909c7297709e4
---
M contrib/rest_api_resource_schema.json
M contrib/rest_api_response_schema.json
2 files changed, 5 insertions(+), 5 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/onomondo-eim refs/changes/07/43207/1
diff --git a/contrib/rest_api_resource_schema.json b/contrib/rest_api_resource_schema.json
index 2e0d330..0a7764b 100644
--- a/contrib/rest_api_resource_schema.json
+++ b/contrib/rest_api_resource_schema.json
@@ -42,7 +42,7 @@
"type": "object",
"properties": {
"iccid": {
- "description": "ICCID of the profile. (ICCID in nibble-swapped raw format)",
+ "description": "ICCID of the profile. (ICCID in nibble-swapped raw format, see also ETSI TS 102 221, section 13.2)",
"type": "string",
"pattern": "^[0-9,A-F]{2,32}$"
},
@@ -62,7 +62,7 @@
"type": "object",
"properties": {
"iccid": {
- "description": "ICCID of the profile. (ICCID in nibble-swapped raw format)",
+ "description": "ICCID of the profile. (ICCID in nibble-swapped raw format, see also ETSI TS 102 221, section 13.2)",
"type": "string",
"pattern": "^[0-9,A-F]{2,32}$"
}
@@ -104,7 +104,7 @@
},
{
"iccid": {
- "description": "ICCID of the profile. (ICCID in nibble-swapped raw format)",
+ "description": "ICCID of the profile. (ICCID in nibble-swapped raw format, see also ETSI TS 102 221, section 13.2)",
"type": "string",
"pattern": "^[0-9,A-F]{2,32}$"
}
diff --git a/contrib/rest_api_response_schema.json b/contrib/rest_api_response_schema.json
index 7ec2735..867baa4 100644
--- a/contrib/rest_api_response_schema.json
+++ b/contrib/rest_api_response_schema.json
@@ -93,7 +93,7 @@
"type": "object",
"properties": {
"iccid": {
- "description": "ICCID of the profile. (ICCID in nibble-swapped raw format)",
+ "description": "ICCID of the profile. (ICCID in nibble-swapped raw format, see also ETSI TS 102 221, section 13.2)",
"type": "string",
"pattern": "^[0-9,A-F]{2,32}$"
},
@@ -402,7 +402,7 @@
]
},
"iccid": {
- "description": "ICCID of the profile. (ICCID in nibble-swapped raw format)",
+ "description": "ICCID of the profile. (ICCID in nibble-swapped raw format, see also ETSI TS 102 221, section 13.2)",
"type": "string",
"pattern": "^[0-9,A-F]{2,32}$"
}
--
To view, visit https://gerrit.osmocom.org/c/onomondo-eim/+/43207?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: onomondo-eim
Gerrit-Branch: master
Gerrit-Change-Id: Idf6f29386b9b6df9255e10d0dd2909c7297709e4
Gerrit-Change-Number: 43207
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/onomondo-eim/+/43210?usp=email )
Change subject: contrib: remove onomondo-eim.service systemd example
......................................................................
contrib: remove onomondo-eim.service systemd example
The file onomondo-eim.service is is an example to illustrate how
onomondo-eim could be started using systemd. However, this file
is outdated and we do not use it anywhere. So let's remove it.
If required, we can always add a new, working example at some
later point.
Related: SYS#8100
Change-Id: I78edeeb88fc1003483db996dce8e42f149ed5aff
---
D contrib/onomondo-eim.service
1 file changed, 0 insertions(+), 9 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/onomondo-eim refs/changes/10/43210/1
diff --git a/contrib/onomondo-eim.service b/contrib/onomondo-eim.service
deleted file mode 100644
index 35d8335..0000000
--- a/contrib/onomondo-eim.service
+++ /dev/null
@@ -1,9 +0,0 @@
-[Unit]
-Description=onomondo-eim
-
-[Service]
-Type=simple
-ExecStart=/path/to/my/onomondo_eim/_rel/onomondo_eim_release/bin/onomondo_eim_release foreground
-
-[Install]
-WantedBy=multi-user.target
\ No newline at end of file
--
To view, visit https://gerrit.osmocom.org/c/onomondo-eim/+/43210?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: onomondo-eim
Gerrit-Branch: master
Gerrit-Change-Id: I78edeeb88fc1003483db996dce8e42f149ed5aff
Gerrit-Change-Number: 43210
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Attention is currently required from: fixeria, jolly, laforge.
dexter has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/onomondo-eim/+/42881?usp=email )
Change subject: esipa_rest_utils: add support for PSMOs added in SGP.32 V.1.2
......................................................................
Patch Set 10:
(1 comment)
File contrib/rest_api_resource_schema.json:
https://gerrit.osmocom.org/c/onomondo-eim/+/42881/comment/4739850b_d24ace10… :
PS9, Line 169: ,
> @andreas@eversberg.eu is right here. […]
Ok, than its also wrong all the way through in SGP.32, section 6.4.1 - what A bummer. I also see that there are a couple of other things wrong too. (at least for this patch things should be fixed now.)
--
To view, visit https://gerrit.osmocom.org/c/onomondo-eim/+/42881?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: onomondo-eim
Gerrit-Branch: master
Gerrit-Change-Id: I03cdd70065a83dfc611d614cf32d817c13fad347
Gerrit-Change-Number: 42881
Gerrit-PatchSet: 10
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-CC: jolly <andreas(a)eversberg.eu>
Gerrit-Attention: jolly <andreas(a)eversberg.eu>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 12 Aug 2026 13:00:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: jolly <andreas(a)eversberg.eu>
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Comment-In-Reply-To: dexter <pmaier(a)sysmocom.de>
Attention is currently required from: fixeria, jolly, laforge.
Hello Jenkins Builder, fixeria, laforge,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/onomondo-eim/+/42881?usp=email
to look at the new patch set (#10).
The following approvals got outdated and were removed:
Code-Review+1 by laforge, Verified+1 by Jenkins Builder
Change subject: esipa_rest_utils: add support for PSMOs added in SGP.32 V.1.2
......................................................................
esipa_rest_utils: add support for PSMOs added in SGP.32 V.1.2
SGP.32 adds 3 additional PSMOs:
- setFallbackAttribute
- unsetFallbackAttribute
- setDefaultDpAddress
Change-Id: I03cdd70065a83dfc611d614cf32d817c13fad347
Related: SYS#8100
---
M contrib/rest_api_resource_schema.json
M contrib/rest_api_response_schema.json
M src/esipa_rest_utils.erl
3 files changed, 116 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/onomondo-eim refs/changes/81/42881/10
--
To view, visit https://gerrit.osmocom.org/c/onomondo-eim/+/42881?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: onomondo-eim
Gerrit-Branch: master
Gerrit-Change-Id: I03cdd70065a83dfc611d614cf32d817c13fad347
Gerrit-Change-Number: 42881
Gerrit-PatchSet: 10
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-CC: jolly <andreas(a)eversberg.eu>
Gerrit-Attention: jolly <andreas(a)eversberg.eu>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Attention is currently required from: dexter, laforge.
Hello Jenkins Builder, laforge,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/onomondo-eim/+/42993?usp=email
to look at the new patch set (#8).
The following approvals got outdated and were removed:
Code-Review+1 by laforge, Verified+1 by Jenkins Builder
Change subject: mnesia_db_euicc: renovate handling of euicc table (mnesia, REST)
......................................................................
mnesia_db_euicc: renovate handling of euicc table (mnesia, REST)
The REST API that allows users to set certain eUICC parameters
(we call them "states" from now on) only allows to set eUICC
states, but doesn't allow to read them back.
With this patch, we renovate the handling of the mnesia euicc
table from the ground up so that REST API users have read and
write access to the states stored in the mnesia euicc table.
Change-Id: I74c602555b194a28d6eb9dd67ec4c6a8865fcb77
Related: SYS#8100
---
M contrib/rest_api_resource_schema.json
M contrib/rest_api_response_schema.json
A contrib/tryme_euicc_get_state.sh
A contrib/tryme_euicc_set_state.sh
D contrib/tryme_set_euicc_param.sh
M doc/database.md
M doc/examples.md
M doc/rest_api.md
M src/crypto_utils.erl
M src/esipa_asn1_handler_utils.erl
M src/mnesia_db.erl
M src/mnesia_db_euicc.erl
12 files changed, 315 insertions(+), 175 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/onomondo-eim refs/changes/93/42993/8
--
To view, visit https://gerrit.osmocom.org/c/onomondo-eim/+/42993?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: onomondo-eim
Gerrit-Branch: master
Gerrit-Change-Id: I74c602555b194a28d6eb9dd67ec4c6a8865fcb77
Gerrit-Change-Number: 42993
Gerrit-PatchSet: 8
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Attention is currently required from: dexter, laforge.
Hello Jenkins Builder, laforge,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/onomondo-eim/+/43089?usp=email
to look at the new patch set (#5).
The following approvals got outdated and were removed:
Code-Review+1 by laforge, Verified+1 by Jenkins Builder
Change subject: rest_handler: add API versions and schema validation
......................................................................
rest_handler: add API versions and schema validation
The JSON based REST API currently has no version checking and also
does not use any JSON schema based validation yet. This patch adds
both. An X-ADMIN-PROTOCOL field in the HTTP header informs about
the API version (same style as the JSON interfaces defined in
GSMA SGP.32 and SGP.22 would use). For incoming messages, the
X-ADMIN-PROTOCOL field is checked to prevent outdated clients from
using the REST API.
The incoming and outgoing JSON messages are now validated against
JSON schema files. Those are the same JSON schema file which were
only provided for documentation purposes only before. Now those
files have been fixed up and moved to the priv directory, where
they are now actively used.
Change-Id: I76e91e53a009cedf2cb1a0297db86e9e5fe7047a
Related: SYS#8100
---
M contrib/restop.py
M doc/rest_api.md
R priv/rest_api_info_schema.json
R priv/rest_api_resource_schema.json
R priv/rest_api_response_schema.json
M rebar.config
M rebar.lock
M src/onomondo_eim.app.src
M src/onomondo_eim_app.erl
M src/rest_handler.erl
A src/rest_middleware.erl
11 files changed, 191 insertions(+), 63 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/onomondo-eim refs/changes/89/43089/5
--
To view, visit https://gerrit.osmocom.org/c/onomondo-eim/+/43089?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: onomondo-eim
Gerrit-Branch: master
Gerrit-Change-Id: I76e91e53a009cedf2cb1a0297db86e9e5fe7047a
Gerrit-Change-Number: 43089
Gerrit-PatchSet: 5
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Attention is currently required from: dexter, jolly, laforge.
Hello Jenkins Builder, jolly, laforge,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/onomondo-eim/+/43142?usp=email
to look at the new patch set (#3).
The following approvals got outdated and were removed:
Code-Review+1 by laforge, Verified+1 by Jenkins Builder
Change subject: contrib: restructure REST API usage examples (tryme-scripts)
......................................................................
contrib: restructure REST API usage examples (tryme-scripts)
The so called tryme scripts are using a very clumsy method to set
the varying parameters (tryme.cfg). The files also mix with other
unrelated files in the contrib directory. There is also a lot of
distracting output displayed which complicates the usage of the
examples even further. This patch fixes those shortcomings.
- put everything related to the usage example into a dedicated
directory.
- renovate restop.py so that it produces more readable output.
- in the tryme_*.sh scripts, avoid output that is not needed.
- cleanup tryme.cfg so that it only contains one set of parameters,
add some helpful comments.
- add functionality to pass the the parameters either via
commandline options or via tryme.cfg, add a parameter to point
to an alternative .cfg file, so that users can use multiple
different configurations.
- update documentation
- cleanup other minor inconsistencies
Related: SYS#8100
Change-Id: I4e42ce85c84b47d3561011083da4a1e54958fd8e
---
A contrib/rest_api_usage_example/getopts.sh
A contrib/rest_api_usage_example/lookup.sh
A contrib/rest_api_usage_example/restop.py
A contrib/rest_api_usage_example/tryme.cfg
R contrib/rest_api_usage_example/tryme_addEim.sh
R contrib/rest_api_usage_example/tryme_configureImmediateEnable.sh
R contrib/rest_api_usage_example/tryme_delete.sh
R contrib/rest_api_usage_example/tryme_deleteEim.sh
R contrib/rest_api_usage_example/tryme_disable.sh
R contrib/rest_api_usage_example/tryme_download.sh
R contrib/rest_api_usage_example/tryme_enable.sh
R contrib/rest_api_usage_example/tryme_euiccDataRequest.sh
R contrib/rest_api_usage_example/tryme_euicc_get_state.sh
R contrib/rest_api_usage_example/tryme_euicc_set_state.sh
R contrib/rest_api_usage_example/tryme_getRAT.sh
R contrib/rest_api_usage_example/tryme_listEim.sh
R contrib/rest_api_usage_example/tryme_listProfileInfo.sh
R contrib/rest_api_usage_example/tryme_updateEim.sh
D contrib/restop.py
D contrib/tryme.cfg
D contrib/tryme_lookup.sh
M doc/examples.md
22 files changed, 252 insertions(+), 239 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/onomondo-eim refs/changes/42/43142/3
--
To view, visit https://gerrit.osmocom.org/c/onomondo-eim/+/43142?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: onomondo-eim
Gerrit-Branch: master
Gerrit-Change-Id: I4e42ce85c84b47d3561011083da4a1e54958fd8e
Gerrit-Change-Number: 43142
Gerrit-PatchSet: 3
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: jolly <andreas(a)eversberg.eu>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>