Attention is currently required from: dexter, jolly, laforge. Hello Jenkins Builder, jolly, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/onomondo-eim/+/43142?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Code-Review+1 by laforge, Verified+1 by Jenkins Builder Change subject: contrib: restructure REST API usage examples (tryme-scripts) ...................................................................... contrib: restructure REST API usage examples (tryme-scripts) The so called tryme scripts are using a very clumsy method to set the varying parameters (tryme.cfg). The files also mix with other unrelated files in the contrib directory. There is also a lot of distracting output displayed which complicates the usage of the examples even further. This patch fixes those shortcomings. - put everything related to the usage example into a dedicated directory. - renovate restop.py so that it produces more readable output. - in the tryme_*.sh scripts, avoid output that is not needed. - cleanup tryme.cfg so that it only contains one set of parameters, add some helpful comments. - add functionality to pass the the parameters either via commandline options or via tryme.cfg, add a parameter to point to an alternative .cfg file, so that users can use multiple different configurations. - update documentation - cleanup other minor inconsistencies Related: SYS#8100 Change-Id: I4e42ce85c84b47d3561011083da4a1e54958fd8e --- A contrib/rest_api_usage_example/getopts.sh A contrib/rest_api_usage_example/lookup.sh A contrib/rest_api_usage_example/restop.py A contrib/rest_api_usage_example/tryme.cfg R contrib/rest_api_usage_example/tryme_addEim.sh R contrib/rest_api_usage_example/tryme_configureImmediateEnable.sh R contrib/rest_api_usage_example/tryme_delete.sh R contrib/rest_api_usage_example/tryme_deleteEim.sh R contrib/rest_api_usage_example/tryme_disable.sh R contrib/rest_api_usage_example/tryme_download.sh R contrib/rest_api_usage_example/tryme_enable.sh R contrib/rest_api_usage_example/tryme_euiccDataRequest.sh R contrib/rest_api_usage_example/tryme_euicc_get_state.sh R contrib/rest_api_usage_example/tryme_euicc_set_state.sh R contrib/rest_api_usage_example/tryme_getRAT.sh R contrib/rest_api_usage_example/tryme_listEim.sh R contrib/rest_api_usage_example/tryme_listProfileInfo.sh R contrib/rest_api_usage_example/tryme_updateEim.sh D contrib/restop.py D contrib/tryme.cfg D contrib/tryme_lookup.sh M doc/examples.md 22 files changed, 252 insertions(+), 239 deletions(-) git pull ssh://gerrit.osmocom.org:29418/onomondo-eim refs/changes/42/43142/3 -- To view, visit https://gerrit.osmocom.org/c/onomondo-eim/+/43142?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: onomondo-eim Gerrit-Branch: master Gerrit-Change-Id: I4e42ce85c84b47d3561011083da4a1e54958fd8e Gerrit-Change-Number: 43142 Gerrit-PatchSet: 3 Gerrit-Owner: dexter <pmaier@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: jolly <andreas@eversberg.eu> Gerrit-Reviewer: laforge <laforge@osmocom.org> Gerrit-Attention: jolly <andreas@eversberg.eu> Gerrit-Attention: laforge <laforge@osmocom.org> Gerrit-Attention: dexter <pmaier@sysmocom.de>