August 2026 - gerrit-log - lists.osmocom.org

[XS] Change in osmo-msc[master]: smpp: Remove unnecessary printf
by pespin 19 Aug '26

19 Aug '26

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/43292?usp=email ) Change subject: smpp: Remove unnecessary printf ...................................................................... smpp: Remove unnecessary printf This is probably a debug leftover, remove it. Related: OS#7059 Reported-By: Adam Bedard <adam.bedard(a)gmail.com> Change-Id: I183a49f70697859c625803478847d02176eea75d --- M src/libsmpputil/smpp_msc.c 1 file changed, 0 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified osmith: Looks good to me, approved diff --git a/src/libsmpputil/smpp_msc.c b/src/libsmpputil/smpp_msc.c index 5fdba36..69b86bd 100644 --- a/src/libsmpputil/smpp_msc.c +++ b/src/libsmpputil/smpp_msc.c @@ -258,7 +258,6 @@ sms_msg_len, sizeof(sms->user_data)); return ESME_RINVPARLEN; } - printf("copying %u bytes user data...\n", ud_len); memcpy(sms->user_data, sms_msg, ud_len); sms_msg += ud_len; sms_msg_len -= ud_len; -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/43292?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I183a49f70697859c625803478847d02176eea75d Gerrit-Change-Number: 43292 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in osmo-bsc[master]: OM2K: Check bounds of OM2K Negotiation Request
by jolly 19 Aug '26

19 Aug '26

jolly has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/43293?usp=email ) Change subject: OM2K: Check bounds of OM2K Negotiation Request ...................................................................... OM2K: Check bounds of OM2K Negotiation Request Check if message length and array sizes are large enough to read and store IWD versions while parsing OM2K Negotiation Request. This prevents out-of-bounds read and write, if message is corrupted. Related: OS#7057 Change-Id: I2de0db1b717a97ab07964d49509a8242c7e4c3ed --- M src/osmo-bsc/abis_om2000.c 1 file changed, 28 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/93/43293/1 diff --git a/src/osmo-bsc/abis_om2000.c b/src/osmo-bsc/abis_om2000.c index 69a86b5..825c68a 100644 --- a/src/osmo-bsc/abis_om2000.c +++ b/src/osmo-bsc/abis_om2000.c @@ -2773,7 +2773,7 @@ struct gsm_bts *bts = sign_link->trx->bts; struct abis_om2k_hdr *o2h = msgb_l2(msg); struct iwd_type iwd_types[16]; - uint8_t num_iwd_types = o2h->data[2]; + uint8_t num_iwd_types; uint8_t *cur = o2h->data+3; unsigned int i; int v; @@ -2782,18 +2782,43 @@ uint8_t *out_cur = out_buf+1; uint8_t out_num_types = 0; + if (msgb_l2len(msg) < sizeof(*o2h) + 3) { + LOGP(DNM, LOGL_ERROR, "Message too short\n"); + return -EINVAL; + } + num_iwd_types = o2h->data[2]; + memset(iwd_types, 0, sizeof(iwd_types)); /* Parse the RBS-supported IWD versions into iwd_types array */ for (i = 0; i < num_iwd_types; i++) { - uint8_t num_versions = *cur++; - uint8_t iwd_type = *cur++; + uint8_t num_versions, iwd_type; + + if (cur + 2 > (uint8_t *)msgb_l2(msg) + msgb_l2len(msg)) { + LOGP(DNM, LOGL_ERROR, "Message too short\n"); + return -EINVAL; + } + num_versions = *cur++; + iwd_type = *cur++; + + if (num_versions > ARRAY_SIZE(iwd_types[0].v)) { + LOGP(DNM, LOGL_ERROR, "Num versions %u out of range\n", num_versions); + return -EINVAL; + } + if (iwd_type >= ARRAY_SIZE(iwd_types)) { + LOGP(DNM, LOGL_ERROR, "IWD Type %u out of range\n", iwd_type); + return -EINVAL; + } iwd_types[iwd_type].num_vers = num_versions; for (v = 0; v < num_versions; v++) { struct iwd_version *iwd_v = &iwd_types[iwd_type].v[v]; + if (cur + 6 > (uint8_t *)msgb_l2(msg) + msgb_l2len(msg)) { + LOGP(DNM, LOGL_ERROR, "Message too short\n"); + return -EINVAL; + } memcpy(iwd_v->gen_char, cur, 3); cur += 3; memcpy(iwd_v->rev_char, cur, 3); -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/43293?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I2de0db1b717a97ab07964d49509a8242c7e4c3ed Gerrit-Change-Number: 43293 Gerrit-PatchSet: 1 Gerrit-Owner: jolly <andreas(a)eversberg.eu>

1 0

[XS] Change in osmo-msc[master]: smpp: Remove unnecessary printf
by osmith 19 Aug '26

19 Aug '26

Attention is currently required from: fixeria, pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-msc/+/43292?usp=email ) Change subject: smpp: Remove unnecessary printf ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/43292?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I183a49f70697859c625803478847d02176eea75d Gerrit-Change-Number: 43292 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 19 Aug 2026 08:16:09 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in osmo-msc[master]: sgs_iface: clean up code in function decode_mme_name
by pespin 19 Aug '26

19 Aug '26

Attention is currently required from: dexter, laforge. pespin has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/osmo-msc/+/43237?usp=email ) Change subject: sgs_iface: clean up code in function decode_mme_name ...................................................................... Patch Set 6: Code-Review+1 (1 comment) File src/libmsc/sgs_iface.c: https://gerrit.osmocom.org/c/osmo-msc/+/43237/comment/5e08c959_b888b659?usp… : PS6, Line 192: osmo_apn_to_str(mme_name, mme_name_enc, mme_name_enc_len); > The check in line 176 is still valid. […] Done -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/43237?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I9aec8300f15264b68ac8e7805e93e621b12cafb2 Gerrit-Change-Number: 43237 Gerrit-PatchSet: 6 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Wed, 19 Aug 2026 08:10:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: dexter <pmaier(a)sysmocom.de>

1 0

[XS] Change in libosmocore[master]: tests/sms: Validate gsm_septet_pack2() succeeds
by pespin 19 Aug '26

19 Aug '26

pespin has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/43265?usp=email ) Change subject: tests/sms: Validate gsm_septet_pack2() succeeds ...................................................................... tests/sms: Validate gsm_septet_pack2() succeeds Related: Coverity CID#562694 Change-Id: I12583ce07e7885974225ce0118f737c4a5f9bcfd --- M tests/sms/sms_test.c 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: osmith: Looks good to me, approved fixeria: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/tests/sms/sms_test.c b/tests/sms/sms_test.c index dda3c56..d9c1c8f 100644 --- a/tests/sms/sms_test.c +++ b/tests/sms/sms_test.c @@ -381,6 +381,7 @@ /* In our case: test_multiple_decode[0].ud_hdr_ind equals number of padding bits*/ octet_length = gsm_septet_pack2(coded, sizeof(coded), tmp, concatenated_part1_septet_length, test_multiple_encode[0].ud_hdr_ind); + OSMO_ASSERT(octet_length == 134); /* copy header */ memset(tmp, 0x42, sizeof(tmp)); @@ -399,6 +400,7 @@ /* In our case: test_multiple_decode[1].ud_hdr_ind equals number of padding bits*/ octet_length = gsm_septet_pack2(coded, sizeof(coded), tmp, concatenated_part2_septet_length, test_multiple_encode[1].ud_hdr_ind); + OSMO_ASSERT(octet_length == 36); /* copy header */ memset(tmp, 0x42, sizeof(tmp)); -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/43265?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I12583ce07e7885974225ce0118f737c4a5f9bcfd Gerrit-Change-Number: 43265 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in osmo-hnodeb[master]: rtp: fail if IuUP instance is not created
by pespin 19 Aug '26

19 Aug '26

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-hnodeb/+/43264?usp=email ) Change subject: rtp: fail if IuUP instance is not created ...................................................................... rtp: fail if IuUP instance is not created Related: Coverity CID#562674 Change-Id: Ic2c8352afe83586d1a5f8cb24f51ae04405a01c2 --- M src/osmo-hnodeb/rtp.c 1 file changed, 4 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified osmith: Looks good to me, approved diff --git a/src/osmo-hnodeb/rtp.c b/src/osmo-hnodeb/rtp.c index 6213eee..98da795 100644 --- a/src/osmo-hnodeb/rtp.c +++ b/src/osmo-hnodeb/rtp.c @@ -120,6 +120,10 @@ snprintf(iuup_id, sizeof(iuup_id), "ue-%u", conn->ue->conn_id); conn->iui = osmo_iuup_instance_alloc(conn, iuup_id); + if (!conn->iui) { + talloc_free(conn); + return NULL; + } osmo_iuup_instance_set_user_prim_cb(conn->iui, _iuup_user_prim_cb, conn); osmo_iuup_instance_set_transport_prim_cb(conn->iui, _iuup_transport_prim_cb, conn); -- To view, visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/43264?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-hnodeb Gerrit-Branch: master Gerrit-Change-Id: Ic2c8352afe83586d1a5f8cb24f51ae04405a01c2 Gerrit-Change-Number: 43264 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in osmo-msc[master]: smpp: Remove unnecessary printf
by pespin 19 Aug '26

19 Aug '26

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-msc/+/43292?usp=email ) Change subject: smpp: Remove unnecessary printf ...................................................................... smpp: Remove unnecessary printf This is probably a debug leftover, remove it. Related: OS#7059 Reported-By: Adam Bedard <adam.bedard(a)gmail.com> Change-Id: I183a49f70697859c625803478847d02176eea75d --- M src/libsmpputil/smpp_msc.c 1 file changed, 0 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/92/43292/1 diff --git a/src/libsmpputil/smpp_msc.c b/src/libsmpputil/smpp_msc.c index 5fdba36..69b86bd 100644 --- a/src/libsmpputil/smpp_msc.c +++ b/src/libsmpputil/smpp_msc.c @@ -258,7 +258,6 @@ sms_msg_len, sizeof(sms->user_data)); return ESME_RINVPARLEN; } - printf("copying %u bytes user data...\n", ud_len); memcpy(sms->user_data, sms_msg, ud_len); sms_msg += ud_len; sms_msg_len -= ud_len; -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/43292?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I183a49f70697859c625803478847d02176eea75d Gerrit-Change-Number: 43292 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in osmo-hnodeb[master]: rtp: fail if IuUP instance is not created
by osmith 19 Aug '26

19 Aug '26

Attention is currently required from: fixeria, pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-hnodeb/+/43264?usp=email ) Change subject: rtp: fail if IuUP instance is not created ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/43264?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-hnodeb Gerrit-Branch: master Gerrit-Change-Id: Ic2c8352afe83586d1a5f8cb24f51ae04405a01c2 Gerrit-Change-Number: 43264 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 19 Aug 2026 07:59:38 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in libosmocore[master]: tests/sms: Validate gsm_septet_pack2() succeeds
by osmith 19 Aug '26

19 Aug '26

Attention is currently required from: pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmocore/+/43265?usp=email ) Change subject: tests/sms: Validate gsm_septet_pack2() succeeds ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/43265?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I12583ce07e7885974225ce0118f737c4a5f9bcfd Gerrit-Change-Number: 43265 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 19 Aug 2026 07:59:12 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-dev[master]: all.urls: add erlang projects
by pespin 19 Aug '26

19 Aug '26

Attention is currently required from: osmith. pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-dev/+/43291?usp=email ) Change subject: all.urls: add erlang projects ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-dev/+/43291?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-dev Gerrit-Branch: master Gerrit-Change-Id: I322318da68a914762eaa12f02a8b08f041f39ee4 Gerrit-Change-Number: 43291 Gerrit-PatchSet: 3 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Wed, 19 Aug 2026 07:54:17 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

2026

2025

2024

2023

2022

gerrit-log August 2026