Attention is currently required from: jolly.
dexter has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/onomondo-ipa/+/43042?usp=email )
Change subject: V1.2: Add function ES10b.ReturnFromFallback
......................................................................
Patch Set 3:
(1 comment)
File src/ipa/main.c:
https://gerrit.osmocom.org/c/onomondo-ipa/+/43042/comment/0e533f57_d41bf472… :
PS3, Line 42: tatic void print_help(void)
: {
: printf("options:\n");
: printf(" -h ......................... print this text.\n");
: printf(" -t TAC ..................... set TAC (default: %s)\n", DEFAULT_TAC);
: printf(" -e eimId ................... set preferred eIM (in case the eUICC has multiple)\n");
: printf(" -r N ....................... set reader number (default: %d)\n", DEFAULT_READER_NUMBER);
: printf(" -c N ....................... set logical channel number (default: %d)\n", DEFAULT_CHANNEL_NUMBER);
: printf(" -f PATH .................... set initial eIM configuration\n");
: printf(" -m ......................... reset eUICC memory\n");
: printf(" --refresh-flag.............. Make eUICC send a CAT refresh after switching profile\n");
: printf(" --execute-fallback-mechanism Trigger enabling of fallback profile\n");
: printf(" --return-from-fallback...... Trigger return from fallback profile to previous profile\n");
: printf(" -n PATH .................... path to nvstate file (default: %s)\n", DEFAULT_NVSTATE_PATH);
: printf(" -y NUM ..................... number of retries for ESipa requests (default: %u)\n",
: DEFAULT_ESIPA_REQ_RETRIES);
: printf(" -a ......................... ask end user for consent\n");
: printf(" -C ......................... CA (Certificate Authority) Bundle file\n");
: printf(" -S ......................... disable HTTPS\n");
: printf(" -I ......................... disable SSL certificate verification (insecure)\n");
: printf(" -E ......................... emulate IoT eUICC (compatibility mode to use consumer eUICCs)\n");
: printf(" -1 ......................... force the IPAd to process only one eUICC package (debug, use with caution)\n");
: }
> I have a general problem with this flat approach of options, mixing actual flags/options (like -t/-e […]
Makes sense, the -m, -f are also operations, this should be re-aligned too.
So lets see what operations we have:
get-eim-package (normal)
add-initial-eim (currently -f)
euicc-memory-reset (currently -m)
execute-fallback-mechanism
return-from-fallback
--
To view, visit https://gerrit.osmocom.org/c/onomondo-ipa/+/43042?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: onomondo-ipa
Gerrit-Branch: master
Gerrit-Change-Id: Ib49a8ef3a5ea5639d881ca51eaeeea24f083fe0e
Gerrit-Change-Number: 43042
Gerrit-PatchSet: 3
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-Attention: jolly <andreas(a)eversberg.eu>
Gerrit-Comment-Date: Fri, 07 Aug 2026 15:35:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>
Attention is currently required from: jolly.
dexter has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/onomondo-ipa/+/43041?usp=email )
Change subject: V1.2: Add function ES10b.ExecuteFallbackMechanism
......................................................................
Patch Set 3: Code-Review+1
(1 comment)
File src/ipa/libipa/es10b_exec_fallback_mech.h:
https://gerrit.osmocom.org/c/onomondo-ipa/+/43041/comment/17d88bd5_baec11e4… :
PS3, Line 14: struct ExecuteFallbackMechanismResponse *res;
The response is basically just an integer, you could return that integer from ipa_es10b_exec_fallback_mech directly. This would allow you to get rid of ipa_es10b_exec_fallback_mech_res_free and the API would me much simpler.
However, the downside is that there would be less flexibility in case the response struct gets extended.
--
To view, visit https://gerrit.osmocom.org/c/onomondo-ipa/+/43041?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: onomondo-ipa
Gerrit-Branch: master
Gerrit-Change-Id: Ia751f0888c36f39ddfadf7f8bb923a8ee50178dc
Gerrit-Change-Number: 43041
Gerrit-PatchSet: 3
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: jolly <andreas(a)eversberg.eu>
Gerrit-Comment-Date: Fri, 07 Aug 2026 15:24:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Attention is currently required from: dexter, laforge.
lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/simtrace2/+/43185?usp=email )
Change subject: Add osmo_apdu_segment_in2() to ensure correct parsing of GP GET DATA
......................................................................
Patch Set 3:
(1 comment)
Patchset:
PS3:
I forgot this commit which fixes the issue in a different way:
https://gerrit.osmocom.org/c/simtrace2/+/42229/
--
To view, visit https://gerrit.osmocom.org/c/simtrace2/+/43185?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: simtrace2
Gerrit-Branch: master
Gerrit-Change-Id: Ie238662e7e6a10dd4283ede0c8d8d73bc375c247
Gerrit-Change-Number: 43185
Gerrit-PatchSet: 3
Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 07 Aug 2026 14:52:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Attention is currently required from: dexter, laforge, lynxis lazus.
pespin has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/libosmocore/+/43178?usp=email )
Change subject: RFC: sim/class_tables: add a size attribute
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
Then maybe leave the public struct and API there as deprecated, and create a new API with "2" appeneded to name + private structure.
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/43178?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Iee50063399a0c3b29594e737f44aaa125fd06a2e
Gerrit-Change-Number: 43178
Gerrit-PatchSet: 2
Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 07 Aug 2026 14:42:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No