Attention is currently required from: dexter.
laforge has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/onomondo-eim/+/43015?usp=email )
Change subject: esipa_asn1_handler_utils: use eimTransactionId in EuiccPackageErrorUnsigned
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/onomondo-eim/+/43015?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: onomondo-eim
Gerrit-Branch: master
Gerrit-Change-Id: Ibfbc6debcd36d2aae1f4530a608db823caf3a394
Gerrit-Change-Number: 43015
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 16 Jul 2026 14:45:17 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: dexter.
laforge has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/onomondo-eim/+/42994?usp=email )
Change subject: doc/build.md: fix typo
......................................................................
Patch Set 3:
(1 comment)
Patchset:
PS3:
it's not really a typo, but a question whether you'd want american or british english?
--
To view, visit https://gerrit.osmocom.org/c/onomondo-eim/+/42994?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: onomondo-eim
Gerrit-Branch: master
Gerrit-Change-Id: Ie6a066f3289fbdde40f55bd9f38a3dd90102e7e6
Gerrit-Change-Number: 42994
Gerrit-PatchSet: 3
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 16 Jul 2026 14:43:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Attention is currently required from: dexter.
laforge has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/onomondo-eim/+/42993?usp=email )
Change subject: mnesia_db_euicc: renovate handling of euicc table (mnesia, REST)
......................................................................
Patch Set 3:
(1 comment)
Patchset:
PS3:
as with other patches changing the JSON schema: shouldn't there be some kind of version in it, and that version being bumped before making incompatible changes? So that any user of the JSON interface could at runtime inquire about the schema version used by the eIM and decide if it can work with that version or raise an error?
--
To view, visit https://gerrit.osmocom.org/c/onomondo-eim/+/42993?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: onomondo-eim
Gerrit-Branch: master
Gerrit-Change-Id: I74c602555b194a28d6eb9dd67ec4c6a8865fcb77
Gerrit-Change-Number: 42993
Gerrit-PatchSet: 3
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 16 Jul 2026 14:42:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Jenkins Builder has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/onomondo-ipa/+/43032?usp=email )
Change subject: V1.2: Add new fields to ProfileInfo list
......................................................................
Patch Set 1:
(3 comments)
File src/ipa/libipa/es10c_get_prfle_info.c:
Robot Comment from checkpatch (run ID ):
https://gerrit.osmocom.org/c/onomondo-ipa/+/43032/comment/2247934f_d9252347… :
PS1, Line 78: if (conv_req && conv_req->fallback_attribute_removed) {
braces {} are not necessary for single statement blocks
Robot Comment from checkpatch (run ID ):
https://gerrit.osmocom.org/c/onomondo-ipa/+/43032/comment/8dc9f3f6_a02c5a59… :
PS1, Line 109: struct ipa_es10c_get_prfle_info_req *conv_get_prfle_info_req(const struct ipa_es10c_get_prfle_info_req *req) {
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID ):
https://gerrit.osmocom.org/c/onomondo-ipa/+/43032/comment/d5fb15a4_452e81f6… :
PS1, Line 110: uint8_t default_tags[] = { 0x5A, 0x4F, 0x9F, 0x70, 0x91, 0x92, 0x95, 0x9F,0x7B, 0x9F,0x26, 0x9F,0x67 };
space required after that ',' (ctx:VxV)
--
To view, visit https://gerrit.osmocom.org/c/onomondo-ipa/+/43032?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: onomondo-ipa
Gerrit-Branch: master
Gerrit-Change-Id: I6667dba8dd84817cfee69daa1c44b98239fa171c
Gerrit-Change-Number: 43032
Gerrit-PatchSet: 1
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-CC: Jenkins Builder
Gerrit-Comment-Date: Thu, 16 Jul 2026 14:23:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Jenkins Builder has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/onomondo-ipa/+/43029?usp=email )
Change subject: V1.2: Add EimConfigurationData.indirectProfileDownload
......................................................................
Patch Set 1:
(1 comment)
File src/ipa/libipa/proc_eim_pkg_retr.c:
Robot Comment from checkpatch (run ID ):
https://gerrit.osmocom.org/c/onomondo-ipa/+/43029/comment/d2cfef33_d353eb21… :
PS1, Line 122: "Indirect profile download is not suppoted by eIM, we don't support direct profile download, -- cannot continue!\n");
'suppoted' may be misspelled - perhaps 'supported'?
--
To view, visit https://gerrit.osmocom.org/c/onomondo-ipa/+/43029?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: onomondo-ipa
Gerrit-Branch: master
Gerrit-Change-Id: Ic40111531e6f35d5ea7f3789de6cae0f1c0d5ba7
Gerrit-Change-Number: 43029
Gerrit-PatchSet: 1
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-CC: Jenkins Builder
Gerrit-Comment-Date: Thu, 16 Jul 2026 14:22:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Jenkins Builder has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/onomondo-ipa/+/43060?usp=email )
Change subject: V1.2: Add function to set Device Capabilities
......................................................................
Patch Set 1:
(2 comments)
File include/onomondo/ipa/ipad.h:
Robot Comment from checkpatch (run ID ):
https://gerrit.osmocom.org/c/onomondo-ipa/+/43060/comment/c3823fc2_cabc9083… :
PS1, Line 90: /*! Set the Device Capabilites.
'Capabilites' may be misspelled - perhaps 'Capabilities'?
File src/ipa/main.c:
Robot Comment from checkpatch (run ID ):
https://gerrit.osmocom.org/c/onomondo-ipa/+/43060/comment/b2f7a23b_6e5266b4… :
PS1, Line 67: printf(" -D ......................... set SGP.22 device capabilites other than the 3 that are required by this IPAd\n");
'capabilites' may be misspelled - perhaps 'capabilities'?
--
To view, visit https://gerrit.osmocom.org/c/onomondo-ipa/+/43060?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: onomondo-ipa
Gerrit-Branch: master
Gerrit-Change-Id: I866787b8cda9a87a9f2e0db4965fbb554d339a6c
Gerrit-Change-Number: 43060
Gerrit-PatchSet: 1
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-CC: Jenkins Builder
Gerrit-Comment-Date: Thu, 16 Jul 2026 14:22:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Jenkins Builder has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/onomondo-ipa/+/43047?usp=email )
Change subject: V1.2: Add TERMINAL CAPABILITY for IoT support
......................................................................
Patch Set 1:
(2 comments)
File src/ipa/libipa/euicc.c:
Robot Comment from checkpatch (run ID ):
https://gerrit.osmocom.org/c/onomondo-ipa/+/43047/comment/fbd21064_30159478… :
PS1, Line 539: /* Set capabilites to enable support for eUICC functions. */
'capabilites' may be misspelled - perhaps 'capabilities'?
Robot Comment from checkpatch (run ID ):
https://gerrit.osmocom.org/c/onomondo-ipa/+/43047/comment/b2eb8cae_9c3fe749… :
PS1, Line 544: /* Set capabilites to enable support for IoT functions. */
'capabilites' may be misspelled - perhaps 'capabilities'?
--
To view, visit https://gerrit.osmocom.org/c/onomondo-ipa/+/43047?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: onomondo-ipa
Gerrit-Branch: master
Gerrit-Change-Id: I1116bee93b31ee4a159125d840d7c5866be6fdb4
Gerrit-Change-Number: 43047
Gerrit-PatchSet: 1
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-CC: Jenkins Builder
Gerrit-Comment-Date: Thu, 16 Jul 2026 14:21:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No