Attention is currently required from: Hoernchen, laforge.
lynxis lazus has posted comments on this change by Hoernchen. ( https://gerrit.osmocom.org/c/simtrace2/+/43126?usp=email )
Change subject: firmware: card_emu: use Di in the waiting time
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/c/simtrace2/+/43126?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: simtrace2
Gerrit-Branch: master
Gerrit-Change-Id: I4263176d6073029d01f9ff5b11a6311617956af6
Gerrit-Change-Number: 43126
Gerrit-PatchSet: 1
Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Comment-Date: Thu, 30 Jul 2026 11:23:11 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: Hoernchen, laforge.
lynxis lazus has posted comments on this change by Hoernchen. ( https://gerrit.osmocom.org/c/simtrace2/+/43125?usp=email )
Change subject: firmware: use the full 11 bit US_FIDI.FI_DI_RATIO
......................................................................
Patch Set 1: Code-Review+1
(3 comments)
File firmware/libcommon/source/mode_cardemu.c:
https://gerrit.osmocom.org/c/simtrace2/+/43125/comment/f9e5fa91_96394964?us… :
PS1, Line 390: usart->US_FIDI = fidi & US_FIDI_FI_DI_RATIO_Msk;
I would rather use US_FIDI_FI_DI_RATIO(fidi) here. It is correct, but only works
because the bit position of US_FIDI_FI_DI_RATIO is 0.
File firmware/libcommon/source/simtrace_iso7816.c:
https://gerrit.osmocom.org/c/simtrace2/+/43125/comment/9e8ce168_cf7e9b19?us… :
PS1, Line 130: if (ratio > 0 && ratio <= US_FIDI_FI_DI_RATIO_Msk) {
It is correct, but because this is a define from ./libchip_sam3s/include/SAM3S.h I would have used a protocol define with 0x7fffu.
https://gerrit.osmocom.org/c/simtrace2/+/43125/comment/ca9dcbb5_194a75bd?us… :
PS1, Line 137: usart->base->US_FIDI = (ratio & US_FIDI_FI_DI_RATIO_Msk);
see previous usage of US_FIDI_FI_DI_RATIO(fidi)
--
To view, visit https://gerrit.osmocom.org/c/simtrace2/+/43125?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: simtrace2
Gerrit-Branch: master
Gerrit-Change-Id: I6211dd5be7c5c5d2150af2aa37a403b33e6d340d
Gerrit-Change-Number: 43125
Gerrit-PatchSet: 1
Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Comment-Date: Thu, 30 Jul 2026 11:16:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Attention is currently required from: jolly.
dexter has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/onomondo-ipa/+/43035?usp=email )
Change subject: V1.2: Add eimTransactionId to IpaEuiccDataRequest and IpaEuiccDataResponse
......................................................................
Patch Set 2: Code-Review+2
(1 comment)
File src/ipa/libipa/proc_euicc_data_req.c:
https://gerrit.osmocom.org/c/onomondo-ipa/+/43035/comment/fdb7a609_de3e7748… :
PS1, Line 216: IPA_LOGP(SIPA, LINFO, "IPA get EUICC data succeeded!\n");
> When looking closer I can see that this code is a bit misleading. […]
As this is not in scope of this patch, we can set this to done. I took a note on my todo list so that I can create the ticket later.
--
To view, visit https://gerrit.osmocom.org/c/onomondo-ipa/+/43035?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: onomondo-ipa
Gerrit-Branch: master
Gerrit-Change-Id: I34db78c4eb8461c154459204ec13a2184085e96a
Gerrit-Change-Number: 43035
Gerrit-PatchSet: 2
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-Attention: jolly <andreas(a)eversberg.eu>
Gerrit-Comment-Date: Thu, 30 Jul 2026 11:11:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: dexter <pmaier(a)sysmocom.de>
Attention is currently required from: jolly.
dexter has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/onomondo-ipa/+/43032?usp=email )
Change subject: V1.2: Add new fields to ProfileInfo list
......................................................................
Patch Set 4: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/c/onomondo-ipa/+/43032?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: onomondo-ipa
Gerrit-Branch: master
Gerrit-Change-Id: I6667dba8dd84817cfee69daa1c44b98239fa171c
Gerrit-Change-Number: 43032
Gerrit-PatchSet: 4
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-Attention: jolly <andreas(a)eversberg.eu>
Gerrit-Comment-Date: Thu, 30 Jul 2026 11:05:01 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
osmith has submitted this change. ( https://gerrit.osmocom.org/c/docker-playground/+/43140?usp=email )
Change subject: ttcn3-asterisk-ims-ue-test: set execfn
......................................................................
ttcn3-asterisk-ims-ue-test: set execfn
The wrapper_core_bt_on_error.sh should get a backtrace if a coredump
appears. This didn't work because the execfn could not be extracted via
file for asterisk (it works with other programs):
$ file core
core: ELF 64-bit LSB core file, x86-64, version 1 (SYSV), too many program headers (2201)
Add a fallback execfn path so it works in this case too.
Change-Id: Ia6b170b127d6458c3e74b1a32a549b04ae460c75
---
M common/wrapper_core_bt_on_error.sh
M ttcn3-asterisk-ims-ue-test/jenkins.sh
2 files changed, 8 insertions(+), 2 deletions(-)
Approvals:
laforge: Looks good to me, but someone else must approve
osmith: Looks good to me, approved
Jenkins Builder: Verified
diff --git a/common/wrapper_core_bt_on_error.sh b/common/wrapper_core_bt_on_error.sh
index ca1eaef..31579fe 100755
--- a/common/wrapper_core_bt_on_error.sh
+++ b/common/wrapper_core_bt_on_error.sh
@@ -22,8 +22,13 @@
msg "Found coredump: $i"
execfn="$(file "$i" | grep -P -o "execfn: '.*?'" | cut -d "'" -f 2)"
if [ -z "$execfn" ] || ! [ -e "$execfn" ]; then
- msg "Failed to get execfn, ignoring..."
- continue
+ if [ -n "$BT_ON_ERR_EXECFN_FALLBACK" ]; then
+ msg "Failed to get execfn, using BT_ON_ERR_EXECFN_FALLBACK: $BT_ON_ERR_EXECFN_FALLBACK"
+ execfn="$BT_ON_ERR_EXECFN_FALLBACK"
+ else
+ msg "Failed to get execfn, ignoring... consider setting BT_ON_ERR_EXECFN_FALLBACK"
+ continue
+ fi
fi
echo
diff --git a/ttcn3-asterisk-ims-ue-test/jenkins.sh b/ttcn3-asterisk-ims-ue-test/jenkins.sh
index 0de3d8c..3512772 100755
--- a/ttcn3-asterisk-ims-ue-test/jenkins.sh
+++ b/ttcn3-asterisk-ims-ue-test/jenkins.sh
@@ -55,6 +55,7 @@
--cap-add=SYS_RESOURCE \
$(docker_network_params $SUBNET $ASTERISK_IP_SUFFIX) \
-e "DNS_IPADDR=${DNS_IPADDR}" \
+ -e "BT_ON_ERR_EXECFN_FALLBACK=/usr/sbin/asterisk" \
--ulimit core=-1 \
-v "$VOL_BASE_DIR/asterisk-${test_config}:/data" \
-w /data \
--
To view, visit https://gerrit.osmocom.org/c/docker-playground/+/43140?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: docker-playground
Gerrit-Branch: master
Gerrit-Change-Id: Ia6b170b127d6458c3e74b1a32a549b04ae460c75
Gerrit-Change-Number: 43140
Gerrit-PatchSet: 2
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>