Attention is currently required from: dexter, jolly.
Hello Jenkins Builder, dexter,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/onomondo-ipa/+/43047?usp=email
to look at the new patch set (#3).
The following approvals got outdated and were removed:
Verified-1 by Jenkins Builder
Change subject: V1.2: Add TERMINAL CAPABILITY for IoT support
......................................................................
V1.2: Add TERMINAL CAPABILITY for IoT support
Also enable support for IoT function by setting the TERMINAL CAPABILITY.
If not set, eUICC may not support IoT specific functions. With IoT eUICC
emulation it is disabled.
Reference: SGP.32 Section 3.8.2
Related: SYS#8101
Change-Id: I1116bee93b31ee4a159125d840d7c5866be6fdb4
---
M src/ipa/libipa/euicc.c
1 file changed, 14 insertions(+), 6 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/onomondo-ipa refs/changes/47/43047/3
--
To view, visit https://gerrit.osmocom.org/c/onomondo-ipa/+/43047?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: onomondo-ipa
Gerrit-Branch: master
Gerrit-Change-Id: I1116bee93b31ee4a159125d840d7c5866be6fdb4
Gerrit-Change-Number: 43047
Gerrit-PatchSet: 3
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-Attention: jolly <andreas(a)eversberg.eu>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Attention is currently required from: jolly.
Hello Jenkins Builder, dexter,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/onomondo-ipa/+/43050?usp=email
to look at the new patch set (#3).
The following approvals got outdated and were removed:
Verified+1 by Jenkins Builder
The change is no longer submittable: Verified is unsatisfied now.
Change subject: V1.2: Add SGP.32-custom AuthenticateClientRequest
......................................................................
V1.2: Add SGP.32-custom AuthenticateClientRequest
Add new AuthenticateClientRequest, which overrides and expands
AuthenticateClientRequest from SGP.22. There is no impact on IPA
process, because it is not used.
Reference: SGP.32 Section 5.6.1
Related: SYS#8101
Change-Id: I0003994fb82f8bbccb4de19946bbba975c98ef04
---
M asn1/SGP32Definitions.asn
M src/ipa/libasn/CMakeLists.txt
A src/ipa/libasn/SGP32-AuthenticateClientRequest.c
A src/ipa/libasn/SGP32-AuthenticateClientRequest.h
A src/ipa/libasn/SGP32-RemoteProfileProvisioningRequest.c
A src/ipa/libasn/SGP32-RemoteProfileProvisioningRequest.h
6 files changed, 296 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/onomondo-ipa refs/changes/50/43050/3
--
To view, visit https://gerrit.osmocom.org/c/onomondo-ipa/+/43050?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: onomondo-ipa
Gerrit-Branch: master
Gerrit-Change-Id: I0003994fb82f8bbccb4de19946bbba975c98ef04
Gerrit-Change-Number: 43050
Gerrit-PatchSet: 3
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-Attention: jolly <andreas(a)eversberg.eu>
Attention is currently required from: jolly.
Hello Jenkins Builder, dexter,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/onomondo-ipa/+/43053?usp=email
to look at the new patch set (#3).
The following approvals got outdated and were removed:
Verified+1 by Jenkins Builder
The change is no longer submittable: Verified is unsatisfied now.
Change subject: V1.2: Change fields in RetrieveNotificationsListResponse
......................................................................
V1.2: Change fields in RetrieveNotificationsListResponse
Remove notificationAndEprList and restructure definitions in
RetrieveNotificationsListResponse.
This requires name changes in IPA process. The notificationAndEprList
case is removed.
Reference: SGP.32 Section 5.9.11
Related: SYS#8101
Change-Id: I757586e92c5eb1ca54ddf8ab6f71eb418de20f6e
---
M asn1/SGP32Definitions.asn
M src/ipa/libasn/SGP32-RetrieveNotificationsListResponse.c
M src/ipa/libasn/SGP32-RetrieveNotificationsListResponse.h
M src/ipa/libipa/es10b_retr_notif_from_lst.c
4 files changed, 20 insertions(+), 277 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/onomondo-ipa refs/changes/53/43053/3
--
To view, visit https://gerrit.osmocom.org/c/onomondo-ipa/+/43053?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: onomondo-ipa
Gerrit-Branch: master
Gerrit-Change-Id: I757586e92c5eb1ca54ddf8ab6f71eb418de20f6e
Gerrit-Change-Number: 43053
Gerrit-PatchSet: 3
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-Attention: jolly <andreas(a)eversberg.eu>
Attention is currently required from: jolly.
Hello Jenkins Builder, dexter,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/onomondo-ipa/+/43052?usp=email
to look at the new patch set (#3).
The following approvals got outdated and were removed:
Verified+1 by Jenkins Builder
The change is no longer submittable: Verified is unsatisfied now.
Change subject: V1.2: Add new fields to IoTSpecificInfo
......................................................................
V1.2: Add new fields to IoTSpecificInfo
Add ecallSupported and fallbackSupported to IoTSpecificInfo, There is
no impact on IPA process, because it is not used.
Reference: SGP.32 Section 5.9.2
Related: SYS#8101
Change-Id: Iba95ac8dd059ee48d46f2ace54ece7a3338ae79f
---
M asn1/SGP32Definitions.asn
M src/ipa/libasn/IoTSpecificInfo.c
M src/ipa/libasn/IoTSpecificInfo.h
3 files changed, 34 insertions(+), 7 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/onomondo-ipa refs/changes/52/43052/3
--
To view, visit https://gerrit.osmocom.org/c/onomondo-ipa/+/43052?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: onomondo-ipa
Gerrit-Branch: master
Gerrit-Change-Id: Iba95ac8dd059ee48d46f2ace54ece7a3338ae79f
Gerrit-Change-Number: 43052
Gerrit-PatchSet: 3
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-Attention: jolly <andreas(a)eversberg.eu>
Attention is currently required from: laforge, pespin.
Hello Jenkins Builder, laforge,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/simtrace2/+/43004?usp=email
to look at the new patch set (#7).
The following approvals got outdated and were removed:
Code-Review+1 by laforge, Verified+1 by Jenkins Builder
Change subject: firmware: Add talloc_report_buf() encode the allocation by bits
......................................................................
firmware: Add talloc_report_buf() encode the allocation by bits
First byte encodes the amount of blocks.
The following bytes encode a block as a single bit.
Change-Id: I3a8ddbe4100f342db2c59ad1fb9aa0014efc62b8
---
M firmware/libcommon/include/talloc.h
M firmware/libcommon/source/pseudo_talloc.c
2 files changed, 34 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/simtrace2 refs/changes/04/43004/7
--
To view, visit https://gerrit.osmocom.org/c/simtrace2/+/43004?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: simtrace2
Gerrit-Branch: master
Gerrit-Change-Id: I3a8ddbe4100f342db2c59ad1fb9aa0014efc62b8
Gerrit-Change-Number: 43004
Gerrit-PatchSet: 7
Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
lynxis lazus has uploaded this change for review. ( https://gerrit.osmocom.org/c/simtrace2/+/43141?usp=email )
Change subject: cosmetic: fix typo in comment
......................................................................
cosmetic: fix typo in comment
Change-Id: I9647fd799839e1d7aa7ab9c118a2e51455536ce4
---
M host/lib/apdu_dispatch.c
1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/simtrace2 refs/changes/41/43141/1
diff --git a/host/lib/apdu_dispatch.c b/host/lib/apdu_dispatch.c
index 4c8f505..ccdadcd 100644
--- a/host/lib/apdu_dispatch.c
+++ b/host/lib/apdu_dispatch.c
@@ -64,7 +64,7 @@
/*! \brief input function for APDU segmentation
* \param ac APDU context accross successive calls
- * \param[in] apdu_buf APDU inpud data buffer
+ * \param[in] apdu_buf APDU input data buffer
* \param[in] apdu_len Length of apdu_buf
* \param[in] new_apdu Is this the beginning of a new APDU?
*
@@ -72,7 +72,7 @@
* sufficient data of the APDU received to transmit the command-APDU to
* the actual card.
*
- * The function retunrs APDU_ACT_RX_MORE_CAPDU_FROM_READER when there
+ * The function returns APDU_ACT_RX_MORE_CAPDU_FROM_READER when there
* is more data to be received from the card reader (GSM Phone).
*/
int osmo_apdu_segment_in(struct osmo_apdu_context *ac, const uint8_t *apdu_buf,
--
To view, visit https://gerrit.osmocom.org/c/simtrace2/+/43141?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: simtrace2
Gerrit-Branch: master
Gerrit-Change-Id: I9647fd799839e1d7aa7ab9c118a2e51455536ce4
Gerrit-Change-Number: 43141
Gerrit-PatchSet: 1
Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>
Attention is currently required from: dexter.
jolly has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/onomondo-ipa/+/43054?usp=email )
Change subject: V1.2: Add function ES10b.GetConnectivityParameters
......................................................................
Patch Set 2:
(1 comment)
File src/ipa/libipa/ipad.c:
https://gerrit.osmocom.org/c/onomondo-ipa/+/43054/comment/dadbf1a2_2bde8bc4… :
PS1, Line 388: IPA_LOGP(SIPA, LERROR, "Unable to emulate retrieval of connectivity patameters.\n");
> When I was developing this emulation one of my principles was to move the compatibility logic as far […]
Done
--
To view, visit https://gerrit.osmocom.org/c/onomondo-ipa/+/43054?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: onomondo-ipa
Gerrit-Branch: master
Gerrit-Change-Id: I075590e095dbbe05fa6cdb0a96d5b38c7a17ff78
Gerrit-Change-Number: 43054
Gerrit-PatchSet: 2
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 30 Jul 2026 12:25:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: dexter <pmaier(a)sysmocom.de>
Attention is currently required from: dexter.
Jenkins Builder has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/onomondo-ipa/+/43047?usp=email )
Change subject: V1.2: Add TERMINAL CAPABILITY for IoT support
......................................................................
Patch Set 2:
(1 comment)
File src/ipa/libipa/euicc.c:
Robot Comment from checkpatch (run ID ):
https://gerrit.osmocom.org/c/onomondo-ipa/+/43047/comment/c32c3986_233665d5… :
PS2, Line 540: /* Set capabilites to enable support for eUICC and IoT functions. */
'capabilites' may be misspelled - perhaps 'capabilities'?
--
To view, visit https://gerrit.osmocom.org/c/onomondo-ipa/+/43047?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: onomondo-ipa
Gerrit-Branch: master
Gerrit-Change-Id: I1116bee93b31ee4a159125d840d7c5866be6fdb4
Gerrit-Change-Number: 43047
Gerrit-PatchSet: 2
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 30 Jul 2026 12:25:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Attention is currently required from: dexter.
jolly has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/onomondo-ipa/+/43047?usp=email )
Change subject: V1.2: Add TERMINAL CAPABILITY for IoT support
......................................................................
Patch Set 2:
(3 comments)
File src/ipa/libipa/euicc.c:
https://gerrit.osmocom.org/c/onomondo-ipa/+/43047/comment/2e81eb1f_2ed1fa42… :
PS1, Line 360: /* Send terminal capablilities, see also 3gpp TS 102.221 V16.2.0, section 11.1.19.2.4 */
> I would change the section to 11.1. […]
Done
https://gerrit.osmocom.org/c/onomondo-ipa/+/43047/comment/e3a83f6c_f78e1c7b… :
PS1, Line 534: {
> I think we should add a spec reference here: […]
Done
https://gerrit.osmocom.org/c/onomondo-ipa/+/43047/comment/9f439c41_dc9ecefa… :
PS1, Line 545: if (!ctx->cfg->iot_euicc_emu_enabled) {
> I think we should pack termcap_euicc and termcap_iot into one TLV object and send it with a single T […]
Done
--
To view, visit https://gerrit.osmocom.org/c/onomondo-ipa/+/43047?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: onomondo-ipa
Gerrit-Branch: master
Gerrit-Change-Id: I1116bee93b31ee4a159125d840d7c5866be6fdb4
Gerrit-Change-Number: 43047
Gerrit-PatchSet: 2
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 30 Jul 2026 12:24:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: dexter <pmaier(a)sysmocom.de>