laforge has submitted this change. ( https://gerrit.osmocom.org/c/onomondo-eim/+/42877?usp=email )
Change subject: esipa_asn1_handler: re-align to SGP.32 section 2.11.2 and section 5.14.6
......................................................................
esipa_asn1_handler: re-align to SGP.32 section 2.11.2 and section 5.14.6
Section 2.11.2: eIM package result (EuiccPackageResult case) is now concatenated with PendingNotificationList instead of RetrieveNotificationsListResponse
Section 5.14.6: ESipa.ProvideEimPackageResult: Significant change in parameters
Change-Id: Ic0872edefc1844166943c60528557c6b7a6602ce
Related: SYS#8100
---
M src/esipa_asn1_handler.erl
1 file changed, 11 insertions(+), 24 deletions(-)
Approvals:
Jenkins Builder: Verified
laforge: Looks good to me, approved
diff --git a/src/esipa_asn1_handler.erl b/src/esipa_asn1_handler.erl
index ff35a12..111ef17 100644
--- a/src/esipa_asn1_handler.erl
+++ b/src/esipa_asn1_handler.erl
@@ -365,7 +365,8 @@
{getEimPackageResponse, EsipaResp};
%GSMA SGP.32, section 6.3.2.7
handle_asn1(Pid, {provideEimPackageResult, EsipaReq}) ->
- case EsipaReq of
+ EimPackageResult = maps:get(eimPackageResult, EsipaReq),
+ case EimPackageResult of
{euiccPackageResult, EuiccPackageResult} ->
ok = esipa_asn1_handler_utils:handle_euiccPackageResult(
Pid, EuiccPackageResult, EsipaReq
@@ -377,25 +378,8 @@
Pid, EuiccPackageResult, EsipaReq
),
% then forward the notifications in the included notification list
- RetrieveNotificationsListResponse = maps:get(notificationList, EPRAndNotifications),
- case RetrieveNotificationsListResponse of
- {notificationList, NotificationList} ->
- handle_asn1_notificationList(Pid, NotificationList);
- {notificationsListResultError, NotificationsListResultError} ->
- logger:notice(
- "Ipad is reporting a problem to retrieve notifications,~nNotificationsListResultError=~p,~nPid=~p~n",
- [NotificationsListResultError, Pid]
- );
- UnhandledObject ->
- % TODO: The RetrieveNotificationsListResponse may also contain other objects, in particular
- % euiccPackageResultList and notificationAndEprList, which again includes either a
- % notificationList or an euiccPackageResultList The spec is a bit unclear on how exactly and when
- % those data objects shall be used, so we ignore them for now and display a notice in the log
- logger:notice(
- "RetrieveNotificationsListResponse with unhandled object,~UnhandledObject=~p,~nPid=~p~n",
- [UnhandledObject, Pid]
- )
- end;
+ NotificationList = maps:get(notificationList, EPRAndNotifications),
+ handle_asn1_notificationList(Pid, NotificationList);
{ipaEuiccDataResponse, IpaEuiccDataResponse} ->
% drive-by store the eUICC public key so that we can use it later to sign PSMOs or eCOs
{EidValue, _, _} = mnesia_db:work_pickup(Pid, none),
@@ -403,17 +387,20 @@
IpaEuiccDataResponse, EidValue
),
Outcome = esipa_rest_utils:ipaEuiccDataResponse_to_outcome(IpaEuiccDataResponse),
- mnesia_db:work_finish(Pid, Outcome, EsipaReq);
+ ok = mnesia_db:work_finish(Pid, Outcome, EsipaReq);
{profileDownloadTriggerResult, _} ->
% The profileDownloadTriggerResult is sent by the IPAd in case a profile was downloaded directly from an
% RSP server, bypassing the eIM (see also SGP.32, section 3.2.3.1). This is a feature that this eIM does
% not support.
throw("unsuppported message type \"profileDownloadTriggerResult\"");
- {eimPackageError, EimPackageError} ->
- Outcome = [{[{eimPackageError, EimPackageError}]}],
+ {eimPackageResultResponseError, EimPackageResultResponseError} ->
+ EimPackageResultErrorCode = maps:get(
+ eimPackageResultErrorCode, EimPackageResultResponseError
+ ),
+ Outcome = [{[{eimPackageError, EimPackageResultErrorCode}]}],
ok = mnesia_db:work_finish(Pid, Outcome, EsipaReq)
end,
- {provideEimPackageResultResponse, undefined};
+ {provideEimPackageResultResponse, {emptyResponse, #{}}};
%Unsupported request
handle_asn1(Pid, Request) ->
mnesia_db:work_finish(Pid, [{[{procedureError, abortedOrder}]}], unsupported),
--
To view, visit https://gerrit.osmocom.org/c/onomondo-eim/+/42877?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: onomondo-eim
Gerrit-Branch: master
Gerrit-Change-Id: Ic0872edefc1844166943c60528557c6b7a6602ce
Gerrit-Change-Number: 42877
Gerrit-PatchSet: 6
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
laforge has submitted this change. ( https://gerrit.osmocom.org/c/onomondo-eim/+/42874?usp=email )
Change subject: es9p_client: convert InitiateAuthenticationOkEsipa to match SGP.32 V.1.2
......................................................................
es9p_client: convert InitiateAuthenticationOkEsipa to match SGP.32 V.1.2
In SGP.32 V.1.0.1, InitiateAuthenticationOkEsipa is almost identical to
SGP.22 InitiateAuthenticationOkEs9. However, in SGP.32 V.1.2, the member
euiccCiPKIdToBeUsed is renamed to euiccCiPKIdentifierToBeUsed. This means
it is no longer possible to pass InitiateAuthenticationOkEsipa as
InitiateAuthenticationOkEs9 to ES9+ directly. Instead we have to re-build
the the InitiateAuthenticationOkEs9 from the contents of
InitiateAuthenticationOkEsipa.
Change-Id: I44c60a2f0d1129093ea67908d2eed167643a4a87
Related: SYS#8100
---
M src/esipa_asn1_handler.erl
1 file changed, 8 insertions(+), 1 deletion(-)
Approvals:
laforge: Looks good to me, approved
Jenkins Builder: Verified
diff --git a/src/esipa_asn1_handler.erl b/src/esipa_asn1_handler.erl
index e816ee3..ff35a12 100644
--- a/src/esipa_asn1_handler.erl
+++ b/src/esipa_asn1_handler.erl
@@ -48,7 +48,14 @@
% FIXME). Otherwise we would have to add a ctxParams1 field and populate it with the matchingId and the
% deviceInfo. The deviceInfo can be retrieved via an eUICC data request.
% (see GSMA SGP.32, section 3.1.2.3).
- {initiateAuthenticationOkEsipa, InitAuthOk};
+ InitAuthOkEsipa = #{
+ transactionId => maps:get(transactionId, InitAuthOk),
+ serverSigned1 => maps:get(serverSigned1, InitAuthOk),
+ serverSignature1 => maps:get(serverSignature1, InitAuthOk),
+ euiccCiPKIdentifierToBeUsed => maps:get(euiccCiPKIdToBeUsed, InitAuthOk),
+ serverCertificate => maps:get(serverCertificate, InitAuthOk)
+ },
+ {initiateAuthenticationOkEsipa, InitAuthOkEsipa};
{initiateAuthenticationError, InitAuthErr} ->
ok = mnesia_db:work_finish(
Pid,
--
To view, visit https://gerrit.osmocom.org/c/onomondo-eim/+/42874?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: onomondo-eim
Gerrit-Branch: master
Gerrit-Change-Id: I44c60a2f0d1129093ea67908d2eed167643a4a87
Gerrit-Change-Number: 42874
Gerrit-PatchSet: 5
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Attention is currently required from: dexter.
laforge has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/onomondo-eim/+/42998?usp=email )
Change subject: contrib/onomondo-eim.sh: add option to set a mnesia dir
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/c/onomondo-eim/+/42998?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: onomondo-eim
Gerrit-Branch: master
Gerrit-Change-Id: I6a13a631da7903db4766168380ce727127a4d47b
Gerrit-Change-Number: 42998
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 14 Jul 2026 11:52:16 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: dexter, jolly, osmith.
laforge has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42967?usp=email )
Change subject: IPAd: Make tests work with testenv and current master of IPAd
......................................................................
Patch Set 4: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42967?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Id4abf15feb179b17594bd11c6e7089469684900c
Gerrit-Change-Number: 42967
Gerrit-PatchSet: 4
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: jolly <andreas(a)eversberg.eu>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 14 Jul 2026 11:50:47 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes