July 2026 - gerrit-log - lists.osmocom.org

[XS] Change in simtrace2[master]: README.md: fix typo in firmware
by lynxis lazus 14 Jul '26

14 Jul '26

lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/simtrace2/+/42999?usp=email ) Change subject: README.md: fix typo in firmware ...................................................................... Patch Set 1: This change is ready for review. -- To view, visit https://gerrit.osmocom.org/c/simtrace2/+/42999?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-Change-Id: I16721418fce55322c8730920ceaa4e65f91a8a7e Gerrit-Change-Number: 42999 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Tue, 14 Jul 2026 16:23:17 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No

1 0

[S] Change in osmo-ttcn3-hacks[master]: stp: Add TCAP_N_NOTICE_req to send a UDTS with TCAP payload
by daniel 14 Jul '26

14 Jul '26

daniel has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42936?usp=email ) Change subject: stp: Add TCAP_N_NOTICE_req to send a UDTS with TCAP payload ...................................................................... stp: Add TCAP_N_NOTICE_req to send a UDTS with TCAP payload Change-Id: Ie13cecc2f2fc8a20d9646f0fb010b91c2ecf7766 --- M library/tcap/TCAP_CodecPort.ttcn 1 file changed, 30 insertions(+), 0 deletions(-) Approvals: fixeria: Looks good to me, but someone else must approve laforge: Looks good to me, but someone else must approve Jenkins Builder: Verified daniel: Looks good to me, approved diff --git a/library/tcap/TCAP_CodecPort.ttcn b/library/tcap/TCAP_CodecPort.ttcn index 5bec2c4..d2ad994 100644 --- a/library/tcap/TCAP_CodecPort.ttcn +++ b/library/tcap/TCAP_CodecPort.ttcn @@ -241,6 +241,25 @@ importance := * } +type record TCAP_N_NOTICE_req +{ + SCCP_PAR_Address calledAddress , + SCCP_PAR_Address callingAddress , + SCCP_PAR_Reason_For_Return reasonForReturn , + TCMessage userData , + SCCP_PAR_Importance importance optional +} + +template (value) TCAP_N_NOTICE_req ts_TCAP_N_NOTICE_req(SCCP_PAR_Address called, + SCCP_PAR_Address calling, + template (value) SCCP_PAR_Reason_For_Return reason, + template (value) TCMessage payload) := { + calledAddress := called, + callingAddress := calling, + reasonForReturn := reason, + userData := payload, + importance := omit +} private function f_dec_ConnectInd(in ASP_SCCP_N_CONNECT_ind pin, out TCAP_N_CONNECT_ind pout) { pout.calledAddress := pin.calledAddress; @@ -370,12 +389,22 @@ //port.setstate(0); } with {extension "prototype(fast)" } +private function f_enc_NoticeReq(in TCAP_N_NOTICE_req pin, out ASP_SCCP_N_NOTICE_req pout) { + pout.calledAddress := pin.calledAddress; + pout.callingAddress := pin.callingAddress; + pout.reasonForReturn := pin.reasonForReturn; + pout.userData := enc_TCAP_TCMessage(pin.userData); + pout.importance := pin.importance; + //port.setstate(0); +} with {extension "prototype(fast)" } + type port TCAP_CODEC_PT message { out TCAP_N_CONNECT_req, TCAP_N_CONNECT_res, TCAP_N_DATA_req, TCAP_N_DISCONNECT_req, TCAP_N_UNITDATA_req, + TCAP_N_NOTICE_req, ASP_SCCP_N_RESET_req, ASP_SCCP_N_NOTICE_req; in TCAP_N_CONNECT_ind, @@ -394,6 +423,7 @@ TCAP_N_DATA_req -> ASP_SCCP_N_DATA_req: function(f_enc_DataReq); TCAP_N_DISCONNECT_req -> ASP_SCCP_N_DISCONNECT_req: function(f_enc_DisconnectReq); TCAP_N_UNITDATA_req -> ASP_SCCP_N_UNITDATA_req: function(f_enc_UnitdataReq); + TCAP_N_NOTICE_req -> ASP_SCCP_N_NOTICE_req: function(f_enc_NoticeReq); ASP_SCCP_N_RESET_req -> ASP_SCCP_N_RESET_req: simple; ASP_SCCP_N_NOTICE_req -> ASP_SCCP_N_NOTICE_req: simple) in(ASP_SCCP_N_CONNECT_ind -> TCAP_N_CONNECT_ind: function(f_dec_ConnectInd); -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42936?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ie13cecc2f2fc8a20d9646f0fb010b91c2ecf7766 Gerrit-Change-Number: 42936 Gerrit-PatchSet: 2 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org>

1 0

[S] Change in osmo-ttcn3-hacks[master]: stp: add ASP_SCCP_N_NOTICE_req support and f_asp_tx_notice()
by daniel 14 Jul '26

14 Jul '26

daniel has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42935?usp=email ) Change subject: stp: add ASP_SCCP_N_NOTICE_req support and f_asp_tx_notice() ...................................................................... stp: add ASP_SCCP_N_NOTICE_req support and f_asp_tx_notice() Wire ASP_SCCP_N_NOTICE_req as a simple passthrough in TCAP_CODEC_PT, so test components can send UDTS via the existing SCCP_TCAP port. Add f_asp_tx_notice() to STP_Tests_TCAP as a convenience wrapper. Change-Id: I74c05405f1c99d43b4bf863f959275ee51301f2e --- M library/tcap/TCAP_CodecPort.ttcn M stp/STP_Tests_TCAP.ttcn 2 files changed, 14 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified daniel: Looks good to me, approved laforge: Looks good to me, but someone else must approve fixeria: Looks good to me, but someone else must approve diff --git a/library/tcap/TCAP_CodecPort.ttcn b/library/tcap/TCAP_CodecPort.ttcn index a9bdcc5..5bec2c4 100644 --- a/library/tcap/TCAP_CodecPort.ttcn +++ b/library/tcap/TCAP_CodecPort.ttcn @@ -376,7 +376,8 @@ TCAP_N_DATA_req, TCAP_N_DISCONNECT_req, TCAP_N_UNITDATA_req, - ASP_SCCP_N_RESET_req; + ASP_SCCP_N_RESET_req, + ASP_SCCP_N_NOTICE_req; in TCAP_N_CONNECT_ind, TCAP_N_CONNECT_cfm, TCAP_N_DATA_ind, @@ -393,7 +394,8 @@ TCAP_N_DATA_req -> ASP_SCCP_N_DATA_req: function(f_enc_DataReq); TCAP_N_DISCONNECT_req -> ASP_SCCP_N_DISCONNECT_req: function(f_enc_DisconnectReq); TCAP_N_UNITDATA_req -> ASP_SCCP_N_UNITDATA_req: function(f_enc_UnitdataReq); - ASP_SCCP_N_RESET_req -> ASP_SCCP_N_RESET_req: simple) + ASP_SCCP_N_RESET_req -> ASP_SCCP_N_RESET_req: simple; + ASP_SCCP_N_NOTICE_req -> ASP_SCCP_N_NOTICE_req: simple) in(ASP_SCCP_N_CONNECT_ind -> TCAP_N_CONNECT_ind: function(f_dec_ConnectInd); ASP_SCCP_N_CONNECT_cfm -> TCAP_N_CONNECT_cfm: function(f_dec_ConnectCfm); ASP_SCCP_N_DATA_ind -> TCAP_N_DATA_ind: function(f_dec_DataInd); diff --git a/stp/STP_Tests_TCAP.ttcn b/stp/STP_Tests_TCAP.ttcn index f8ba240..00c08a5 100644 --- a/stp/STP_Tests_TCAP.ttcn +++ b/stp/STP_Tests_TCAP.ttcn @@ -219,6 +219,16 @@ SCCP_TCAP[asp_idx].send(sccp_unitdata_req); } +private function f_asp_tx_notice(template (value) SCCP_PAR_UserData userData, + SCCP_PAR_Reason_For_Return reasonForReturn, + integer asp_idx := 0) +runs on TCAP_CT +{ + SCCP_TCAP[asp_idx].send(t_ASP_N_NOTICE_req(g_tcap[asp_idx].sccp_addr_peer, + g_tcap[asp_idx].sccp_addr_own, + reasonForReturn, userData, omit)); +} + private altstep as_asp_rx_tcap_any(template (present) TCMessage tcap_msg := ?, integer tx_asp_idx := 0) -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42935?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I74c05405f1c99d43b4bf863f959275ee51301f2e Gerrit-Change-Number: 42935 Gerrit-PatchSet: 2 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[M] Change in osmo-ttcn3-hacks[master]: stp: Test that UDTS containing tcap is routed correctly
by daniel 14 Jul '26

14 Jul '26

daniel has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42937?usp=email ) Change subject: stp: Test that UDTS containing tcap is routed correctly ...................................................................... stp: Test that UDTS containing tcap is routed correctly Related: SYS#8090 Depends: libosmo-sigtran.git I2051aa9e84e553feb17daabb93ba3ce82358e0e4 Change-Id: I264ab424fbc3652249535bbe4f30029defa64c09 --- M stp/STP_Tests_TCAP.ttcn 1 file changed, 54 insertions(+), 0 deletions(-) Approvals: daniel: Looks good to me, approved laforge: Looks good to me, but someone else must approve Jenkins Builder: Verified fixeria: Looks good to me, but someone else must approve diff --git a/stp/STP_Tests_TCAP.ttcn b/stp/STP_Tests_TCAP.ttcn index 00c08a5..bede97d 100644 --- a/stp/STP_Tests_TCAP.ttcn +++ b/stp/STP_Tests_TCAP.ttcn @@ -918,7 +918,60 @@ setverdict(pass); } +/* Test UDTS routing with TCAP load-sharing + * If a TCAP message is returned in a UDTS and + * * it is in the TCAP session cache/tracking + * * then route it back to the correct IPA ASP. + */ +testcase TC_tcap_loadshare_m3ua_to_ipa_udts_routing() runs on TCAP_CT { + var template (value) IPA_EXT_TCAP_ROUTING_Message tcap_rt_msg; + var template (value) TCMessage tcap_msg; + var Misc_Helpers.ro_charstring tcap_asps := { "asp-m3ua-loadshare-0-0", + "asp-m3ua-loadshare-0-1", + "asp-ipa-loadshare-0-0", + "asp-ipa-loadshare-0-1" }; + var TCAP_CT_Configurations tcap_configs := tcap_build_configs(tcap_asps); + var OCT4 dtid := int2oct(198, 4); + var OCT4 otid := int2oct(202, 4); + var integer ipa_idx; + var integer m3ua_idx; + + f_init_tcap(tcap_configs); + f_tcap_loadshare_register(2, 0, 99, 3, 100, 199); + + tcap_msg := ts_TCAP_Begin(int2oct(202, 4)); + ipa_idx := f_asp_tx_tcap_exp_alt(tcap_msg, 0, 2, 3); + tcap_msg := ts_TCAP_Continue(int2oct(98 + (ipa_idx-2)*100, 4), int2oct(202, 4)); + m3ua_idx := f_asp_tx_tcap_exp_alt(tcap_msg, ipa_idx, 0, 1); + + /* reply with a UDTS */ + var template (value) TCAP_N_NOTICE_req sccp_udts := + ts_TCAP_N_NOTICE_req(g_tcap[m3ua_idx].sccp_addr_own, + g_tcap[m3ua_idx].sccp_addr_peer, + 3, /* Subsystem failure */ + tcap_msg); + timer T := 5.0; + T.start; + SCCP_TCAP[m3ua_idx].send(sccp_udts); + + var template (present) TCAP_N_NOTICE_ind exp_sccp_udts := + tr_TCAP_N_NOTICE_ind(g_tcap[m3ua_idx].sccp_addr_own, + g_tcap[m3ua_idx].sccp_addr_peer, + 3, + tcap_msg); + + alt { + [] SCCP_TCAP[ipa_idx].receive(exp_sccp_udts) { + log("Received UTDS via TCAP[3] ASP"); + } + [] T.timeout { + setverdict(fail, __SCOPE__, "(): Timeout waiting for SCCP UTDS / TCAP message"); + Misc_Helpers.f_shutdown(__BFILE__, __LINE__); + } + } + setverdict(pass); +} /* TODO: test TCAP Abort message is used. * TODO: test TCAP Begin+End message is used. @@ -943,6 +996,7 @@ execute( TC_tcap_loadshare_ipa_tcap_range_fail_pc_ssn_overlap() ); execute( TC_tcap_loadshare_ipa_tcap_norange() ); execute( TC_tcap_loadshare_m3ua_to_ipa_udts() ); + execute( TC_tcap_loadshare_m3ua_to_ipa_udts_routing() ); } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42937?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I264ab424fbc3652249535bbe4f30029defa64c09 Gerrit-Change-Number: 42937 Gerrit-PatchSet: 2 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org>

1 0

[M] Change in osmo-ttcn3-hacks[master]: stp: Test that UDTS containing tcap is routed correctly
by daniel 14 Jul '26

14 Jul '26

daniel has posted comments on this change by daniel. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42937?usp=email ) Change subject: stp: Test that UDTS containing tcap is routed correctly ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42937?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I264ab424fbc3652249535bbe4f30029defa64c09 Gerrit-Change-Number: 42937 Gerrit-PatchSet: 1 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Tue, 14 Jul 2026 16:18:16 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in osmo-ttcn3-hacks[master]: stp: Add TCAP_N_NOTICE_req to send a UDTS with TCAP payload
by daniel 14 Jul '26

14 Jul '26

daniel has posted comments on this change by daniel. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42936?usp=email ) Change subject: stp: Add TCAP_N_NOTICE_req to send a UDTS with TCAP payload ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42936?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ie13cecc2f2fc8a20d9646f0fb010b91c2ecf7766 Gerrit-Change-Number: 42936 Gerrit-PatchSet: 1 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Tue, 14 Jul 2026 16:18:05 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in osmo-ttcn3-hacks[master]: stp: add ASP_SCCP_N_NOTICE_req support and f_asp_tx_notice()
by daniel 14 Jul '26

14 Jul '26

Attention is currently required from: pespin. daniel has posted comments on this change by daniel. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42935?usp=email ) Change subject: stp: add ASP_SCCP_N_NOTICE_req support and f_asp_tx_notice() ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42935?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I74c05405f1c99d43b4bf863f959275ee51301f2e Gerrit-Change-Number: 42935 Gerrit-PatchSet: 1 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 14 Jul 2026 16:18:03 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-ttcn3-hacks[master]: deps: use a fork of titan.ProtocolEmulations.SCCP
by daniel 14 Jul '26

14 Jul '26

daniel has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42934?usp=email ) Change subject: deps: use a fork of titan.ProtocolEmulations.SCCP ...................................................................... deps: use a fork of titan.ProtocolEmulations.SCCP The fork adds support for sending UDTS via ASP_SCCP_N_NOTICE_req. Change-Id: I8c0de4dab088930d5d7a9febcbebcb5e1f9411e8 --- M deps/Makefile 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: daniel: Looks good to me, approved laforge: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/deps/Makefile b/deps/Makefile index 0bd40b4..86366c2 100644 --- a/deps/Makefile +++ b/deps/Makefile @@ -9,7 +9,6 @@ ECLIPSEGITLAB_REPOS= titan.Libraries.TCCUsefulFunctions \ titan.ProtocolEmulations.M3UA \ - titan.ProtocolEmulations.SCCP \ titan.ProtocolModules.BSSAPP_v7.3.0 \ titan.ProtocolModules.DIAMETER_ProtocolModule_Generator \ titan.ProtocolModules.DNS \ @@ -54,6 +53,7 @@ titan.TestPorts.UNIX_DOMAIN_SOCKETasp OSMOGITHUB_REPOS= titan.TestPorts.SCTPasp \ + titan.ProtocolEmulations.SCCP \ titan.ProtocolModules.BSSGP_v13.0.0 OSMOGERRIT_REPOS= osmo-uecups @@ -75,7 +75,7 @@ nas_commit= c8fb0b1dd96f45fbfdc93ffc73ffb3ca6ced47cc titan.Libraries.TCCUsefulFunctions_commit= R.35.B-6-gb3687da titan.ProtocolEmulations.M3UA_commit= a70095b9113b23d2ea2405a5775befec18dd0fe0 -titan.ProtocolEmulations.SCCP_commit= 744f3eeb58d7b5bc372c9fd01db737a20bae069a +titan.ProtocolEmulations.SCCP_commit= c6d299781558b53b4487a42f39a557aabb81c1d7 titan.ProtocolModules.BSSAPP_v7.3.0_commit= R.2.A-4-g20cfaf8 titan.ProtocolModules.BSSGP_v13.0.0_commit= e97d92a8b66bec399babea52f593771b76cb175a titan.ProtocolModules.BSSMAP_commit= 4acb6ab5f058477f0b90c2da182d52054e3614b0 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42934?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I8c0de4dab088930d5d7a9febcbebcb5e1f9411e8 Gerrit-Change-Number: 42934 Gerrit-PatchSet: 3 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org>

1 0

[XS] Change in osmo-ttcn3-hacks[master]: deps: use a fork of titan.ProtocolEmulations.SCCP
by daniel 14 Jul '26

14 Jul '26

Attention is currently required from: fixeria, laforge. daniel has posted comments on this change by daniel. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42934?usp=email ) Change subject: deps: use a fork of titan.ProtocolEmulations.SCCP ...................................................................... Patch Set 2: Code-Review+2 (1 comment) Patchset: PS2: > if the feature is generically useful, pleaes make sure to submit the patch upstream so we can avoid […] Acknowledged -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42934?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I8c0de4dab088930d5d7a9febcbebcb5e1f9411e8 Gerrit-Change-Number: 42934 Gerrit-PatchSet: 2 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 14 Jul 2026 16:17:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: laforge <laforge(a)osmocom.org>

1 0

[S] Change in libosmo-sigtran[master]: tcap_as_loadshare: Forward UDTS to the correct tcap-loadshare ASP
by daniel 14 Jul '26

14 Jul '26

daniel has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/42933?usp=email ) Change subject: tcap_as_loadshare: Forward UDTS to the correct tcap-loadshare ASP ...................................................................... tcap_as_loadshare: Forward UDTS to the correct tcap-loadshare ASP Related: SYS#8090 Change-Id: I2051aa9e84e553feb17daabb93ba3ce82358e0e4 --- M src/tcap_as_loadshare.c 1 file changed, 22 insertions(+), 2 deletions(-) Approvals: lynxis lazus: Looks good to me, approved Jenkins Builder: Verified laforge: Looks good to me, but someone else must approve diff --git a/src/tcap_as_loadshare.c b/src/tcap_as_loadshare.c index f3fd2f9..058e0c3 100644 --- a/src/tcap_as_loadshare.c +++ b/src/tcap_as_loadshare.c @@ -485,9 +485,8 @@ goto out_free_msgb; } - /* TODO: (How) should we route UDTS (CL/DR) messages containing TCAP? */ /* TCAP uses only connectionless SCCP messages */ - if (!(sua->hdr.msg_class == SUA_MSGC_CL && sua->hdr.msg_type == SUA_CL_CLDT)) { + if (sua->hdr.msg_class != SUA_MSGC_CL) { /* ignoring packets */ rc = -EPROTONOSUPPORT; goto out_free_sua; @@ -530,6 +529,27 @@ } rate_ctr_inc2(as->ctrg, SS7_AS_CTR_RX_TCAP_DECODED); + /* Handle UDTS message */ + if (sua->hdr.msg_type == SUA_CL_CLDR) { + uint32_t *otid = NULL, *dtid = NULL; + if (rc & OTID_SET) + otid = &parsed.otid; + if (rc & DTID_SET) + dtid = &parsed.dtid; + + /* Do not error out - either forward the UDTS or drop it */ + rc = 0; + + /* Address/tid needs to be swapped since the UDTS contains the TCAP message we originally forwarded the other way, not an answer */ + struct tcap_trans_track_entry *entry = tcap_trans_track_entry_find(as, &calling_addr, dtid, &called_addr, otid); + if (entry) + asp = entry->asp; + if (!asp && otid) + asp = tcap_as_asp_find_by_tcap_id(as, &called_addr, &calling_addr, *otid); + if (!asp) + LOGPAS(as, DLTCAP, LOGL_NOTICE, "Could not find an ASP for UDTS with otid %u/dtid %u\n", parsed.otid, parsed.dtid); + } + /* TCAP messages towards the IPA nodes */ switch (parsed.present) { case TCAP_TCMessage_PR_begin: -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42933?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I2051aa9e84e553feb17daabb93ba3ce82358e0e4 Gerrit-Change-Number: 42933 Gerrit-PatchSet: 1 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>

1 0

2026

2025

2024

2023

2022

gerrit-log July 2026