lists.osmocom.org
Sign In Sign Up
Manage this list Sign In Sign Up

Keyboard Shortcuts

Thread View

  • j: Next unread message
  • k: Previous unread message
  • j a: Jump to all threads
  • j l: Jump to MailingList overview

gerrit-log

Thread Start a new thread
Download
Threads by month
  • ----- 2026 -----
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2025 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2024 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2023 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2022 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
gerrit-log@lists.osmocom.org

June 2026

  • 1 participants
  • 870 discussions
[S] Change in libosmo-sigtran[master]: Add DSCP configuration support for STP server
by pespin 01 Jun '26

01 Jun '26
Attention is currently required from: jolly. pespin has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/42807?usp=email ) Change subject: Add DSCP configuration support for STP server ...................................................................... Patch Set 2: Code-Review-1 (4 comments) Patchset: PS2: This should be per ASP and be set on the per-conn socket after accept() (when creating a new srv_conn object). Commit Message: https://gerrit.osmocom.org/c/libosmo-sigtran/+/42807/comment/37b2722c_4a3d6… : PS2, Line 7: Add DSCP configuration support for STP server for server transport role https://gerrit.osmocom.org/c/libosmo-sigtran/+/42807/comment/65d24e1a_b4f40… : PS2, Line 11: transport role "server" File src/ss7_xua_srv.h: https://gerrit.osmocom.org/c/libosmo-sigtran/+/42807/comment/8260c310_befe6… : PS2, Line 30: uint8_t ip_dscp; afaiu the dscp can be set per connection-socket in server sockets, not on the listening socket. Hence, it makes sense that this is actually stored per ASP in the vty. -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42807?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I35eab3672157c318616f51ee3042243aed263d4e Gerrit-Change-Number: 42807 Gerrit-PatchSet: 2 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Comment-Date: Mon, 01 Jun 2026 15:51:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes
1 0
0 0
[S] Change in libosmo-netif[master]: Also apply DSCP settings on listening socket
by jolly 01 Jun '26

01 Jun '26
jolly has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-netif/+/42810?usp=email ) Change subject: Also apply DSCP settings on listening socket ...................................................................... Also apply DSCP settings on listening socket The TOS values should be packets that are sent during handshake. Therefore the DSCP setting must be applied to the listening socket also. Related: SYS#8071 Change-Id: Ic70422ec73c753b61843444582f8665ca42e7a6d --- M src/stream_srv.c 1 file changed, 12 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-netif refs/changes/10/42810/1 diff --git a/src/stream_srv.c b/src/stream_srv.c index 6c4eada..3c8921e 100644 --- a/src/stream_srv.c +++ b/src/stream_srv.c @@ -614,6 +614,18 @@ if (ret < 0) return ret; + if (link->ip_dscp > 0) { + int rc; + rc = osmo_sock_set_dscp(ret, link->ip_dscp); + if (rc < 0) { + LOGSLNK(link, LOGL_ERROR, "set_ip_dscp(%u): failed setsockopt err=%d\n", + link->ip_dscp, errno); + close(ret); + link->ofd.fd = -1; + return -EIO; + } + } + link->ofd.fd = ret; if (osmo_fd_register(&link->ofd) < 0) { close(ret); -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/42810?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: Ic70422ec73c753b61843444582f8665ca42e7a6d Gerrit-Change-Number: 42810 Gerrit-PatchSet: 1 Gerrit-Owner: jolly <andreas(a)eversberg.eu>
1 0
0 0
[L] Change in libosmo-sigtran[master]: Add test case to verify proper DSCP settings
by jolly 01 Jun '26

01 Jun '26
Attention is currently required from: jolly. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42809?usp=email to look at the new patch set (#4). The following approvals got outdated and were removed: Verified-1 by Jenkins Builder Change subject: Add test case to verify proper DSCP settings ...................................................................... Add test case to verify proper DSCP settings Related: SYS#8071 Change-Id: I6ac965998433b4d8213cce30fc3fcf8fe485a092 --- M .gitignore M configure.ac M tests/Makefile.am A tests/dscp/Makefile.am A tests/dscp/dscp_test.ok A tests/dscp/dscp_test.py A tests/dscp/get_tos_diag.c A tests/dscp/osmo-stp-dscp.cfg M tests/testsuite.at 9 files changed, 255 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/09/42809/4 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42809?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I6ac965998433b4d8213cce30fc3fcf8fe485a092 Gerrit-Change-Number: 42809 Gerrit-PatchSet: 4 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: jolly <andreas(a)eversberg.eu>
1 0
0 0
[S] Change in libosmo-sigtran[master]: Add DSCP configuration support for STP client
by jolly 01 Jun '26

01 Jun '26
Attention is currently required from: jolly. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42808?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Verified-1 by Jenkins Builder Change subject: Add DSCP configuration support for STP client ...................................................................... Add DSCP configuration support for STP client Introduce VTY command to configure the Differentiated Services Code Point (DSCP) values for the STP clients. Related: SYS#8071 Change-Id: Ia125a392eec5605553809774162675b5249b8494 --- M src/ss7_asp.c M src/ss7_asp.h M src/ss7_asp_vty.c M tests/vty/osmo_stp_test.vty M tests/vty/ss7_asp_test.vty 5 files changed, 20 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/08/42808/3 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42808?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: Ia125a392eec5605553809774162675b5249b8494 Gerrit-Change-Number: 42808 Gerrit-PatchSet: 3 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: jolly <andreas(a)eversberg.eu>
1 0
0 0
[M] Change in libosmo-sigtran[master]: Add test case to verify proper DSCP settings
by jolly 01 Jun '26

01 Jun '26
Attention is currently required from: jolly. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42809?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Verified-1 by Jenkins Builder Change subject: Add test case to verify proper DSCP settings ...................................................................... Add test case to verify proper DSCP settings Related: SYS#8071 Change-Id: I6ac965998433b4d8213cce30fc3fcf8fe485a092 --- M .gitignore M configure.ac M tests/Makefile.am A tests/dscp/Makefile.am A tests/dscp/dscp_test.ok A tests/dscp/dscp_test.py A tests/dscp/get_tos_diag.c A tests/dscp/osmo-stp-dscp.cfg M tests/testsuite.at 9 files changed, 248 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/09/42809/3 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42809?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I6ac965998433b4d8213cce30fc3fcf8fe485a092 Gerrit-Change-Number: 42809 Gerrit-PatchSet: 3 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: jolly <andreas(a)eversberg.eu>
1 0
0 0
[M] Change in libosmo-sigtran[master]: Add test case to verify proper DSCP settings
by Jenkins Builder 01 Jun '26

01 Jun '26
Attention is currently required from: jolly. Jenkins Builder has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/42809?usp=email ) Change subject: Add test case to verify proper DSCP settings ...................................................................... Patch Set 2: (1 comment) File tests/dscp/get_tos_diag.c: Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/libosmo-sigtran/+/42809/comment/b1907359_5d447… : PS2, Line 32: int main() Bad function definition - int main() should probably be int main(void) -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42809?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I6ac965998433b4d8213cce30fc3fcf8fe485a092 Gerrit-Change-Number: 42809 Gerrit-PatchSet: 2 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Comment-Date: Mon, 01 Jun 2026 12:48:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No
1 0
0 0
[S] Change in libosmo-sigtran[master]: Add DSCP configuration support for STP server
by jolly 01 Jun '26

01 Jun '26
Attention is currently required from: jolly. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42807?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified-1 by Jenkins Builder Change subject: Add DSCP configuration support for STP server ...................................................................... Add DSCP configuration support for STP server Introduce VTY command to configure the Differentiated Services Code Point (DSCP) values for the STP server. Related: SYS#8071 Change-Id: I35eab3672157c318616f51ee3042243aed263d4e --- M src/ss7_vty.h M src/ss7_xua_srv.c M src/ss7_xua_srv.h M src/ss7_xua_srv_vty.c 4 files changed, 29 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/07/42807/2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42807?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I35eab3672157c318616f51ee3042243aed263d4e Gerrit-Change-Number: 42807 Gerrit-PatchSet: 2 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: jolly <andreas(a)eversberg.eu>
1 0
0 0
[S] Change in libosmo-sigtran[master]: Add DSCP configuration support for STP server
by Jenkins Builder 01 Jun '26

01 Jun '26
Jenkins Builder has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/42807?usp=email ) Change subject: Add DSCP configuration support for STP server ...................................................................... Patch Set 1: (4 comments) File src/ss7_xua_srv_vty.c: Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/libosmo-sigtran/+/42807/comment/347d72f2_64625… : PS1, Line 152: "ip-dscp " IP_DSCP_RANGE_STR, code indent should use tabs where possible Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/libosmo-sigtran/+/42807/comment/fa92bea6_50cbb… : PS1, Line 152: "ip-dscp " IP_DSCP_RANGE_STR, please, no spaces at the start of a line Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/libosmo-sigtran/+/42807/comment/2660aba1_35dc5… : PS1, Line 154: IP_DSCP_RANGE_HELP_STR, code indent should use tabs where possible Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/libosmo-sigtran/+/42807/comment/f5b4e05f_55633… : PS1, Line 154: IP_DSCP_RANGE_HELP_STR, please, no spaces at the start of a line -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42807?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I35eab3672157c318616f51ee3042243aed263d4e Gerrit-Change-Number: 42807 Gerrit-PatchSet: 1 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Mon, 01 Jun 2026 12:07:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No
1 0
0 0
[M] Change in libosmo-sigtran[master]: Add test case to verify proper DSCP settings
by Jenkins Builder 01 Jun '26

01 Jun '26
Jenkins Builder has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/42809?usp=email ) Change subject: Add test case to verify proper DSCP settings ...................................................................... Patch Set 1: (1 comment) File tests/dscp/get_tos_diag.c: Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/libosmo-sigtran/+/42809/comment/7b4f35ba_b3fea… : PS1, Line 32: int main() Bad function definition - int main() should probably be int main(void) -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42809?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I6ac965998433b4d8213cce30fc3fcf8fe485a092 Gerrit-Change-Number: 42809 Gerrit-PatchSet: 1 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Mon, 01 Jun 2026 12:06:36 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No
1 0
0 0
[S] Change in libosmo-sigtran[master]: Add DSCP configuration support for STP server
by jolly 01 Jun '26

01 Jun '26
jolly has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/42807?usp=email ) Change subject: Add DSCP configuration support for STP server ...................................................................... Add DSCP configuration support for STP server Introduce VTY command to configure the Differentiated Services Code Point (DSCP) values for the STP server. Related: SYS#8071 Change-Id: I35eab3672157c318616f51ee3042243aed263d4e --- M src/ss7_xua_srv.c M src/ss7_xua_srv.h M src/ss7_xua_srv_vty.c 3 files changed, 26 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/07/42807/1 diff --git a/src/ss7_xua_srv.c b/src/ss7_xua_srv.c index c080f63..5a1a3e7 100644 --- a/src/ss7_xua_srv.c +++ b/src/ss7_xua_srv.c @@ -402,6 +402,13 @@ return false; } +bool ss7_xua_server_set_ip_dscp(struct osmo_xua_server *xs) +{ + if (xs->cfg.ip_dscp != 0) + osmo_stream_srv_link_set_ip_dscp(xs->server, xs->cfg.ip_dscp); + return true; +} + void ss7_xua_server_destroy(struct osmo_xua_server *xs) { struct osmo_ss7_asp *asp, *asp2; diff --git a/src/ss7_xua_srv.h b/src/ss7_xua_srv.h index 1eaf754..7eb00c2 100644 --- a/src/ss7_xua_srv.h +++ b/src/ss7_xua_srv.h @@ -27,6 +27,7 @@ struct { bool accept_dyn_reg; struct osmo_ss7_asp_peer local; + uint8_t ip_dscp; enum osmo_ss7_asp_protocol proto; struct { bool num_ostreams_present; @@ -70,6 +71,7 @@ ss7_xua_server_set_local_hosts(struct osmo_xua_server *xs, const char **local_hosts, size_t local_host_cnt); int ss7_xua_server_add_local_host(struct osmo_xua_server *xs, const char *local_host); int ss7_xua_server_del_local_host(struct osmo_xua_server *xs, const char *local_host); +bool ss7_xua_server_set_ip_dscp(struct osmo_xua_server *oxs); void ss7_xua_server_destroy(struct osmo_xua_server *xs); bool ss7_xua_server_set_default_local_hosts(struct osmo_xua_server *oxs); diff --git a/src/ss7_xua_srv_vty.c b/src/ss7_xua_srv_vty.c index 3a5e4ae..a44e277 100644 --- a/src/ss7_xua_srv_vty.c +++ b/src/ss7_xua_srv_vty.c @@ -148,6 +148,20 @@ return CMD_SUCCESS; } +DEFUN_ATTR(xua_ip_dscp, xua_ip_dscp_cmd, + "ip-dscp " IP_DSCP_RANGE_STR, + "Specify IP DSCP of ASP\n" + IP_DSCP_RANGE_HELP_STR, + CMD_ATTR_IMMEDIATE) +{ + struct osmo_xua_server *xs = vty->index; + + xs->cfg.ip_dscp = atoi(argv[0]); + ss7_xua_server_set_ip_dscp(xs); + + return CMD_SUCCESS; +} + DEFUN_ATTR(xua_accept_dyn_asp, xua_accept_dyn_asp_cmd, "accept-asp-connections (pre-configured|dynamic-permitted)", "Define what kind of ASP connections to accept\n" @@ -225,6 +239,8 @@ if (xs->cfg.local.host[i]) vty_out(vty, " local-ip %s%s", xs->cfg.local.host[i], VTY_NEWLINE); } + if (xs->cfg.ip_dscp) + vty_out(vty, " ip-dscp %u%s", xs->cfg.ip_dscp, VTY_NEWLINE); if (xs->cfg.accept_dyn_reg) vty_out(vty, " accept-asp-connections dynamic-permitted%s", VTY_NEWLINE); if (xs->cfg.sctp_init.num_ostreams_present) @@ -341,6 +357,7 @@ install_lib_element(L_CS7_NODE, &no_cs7_xua_cmd); install_lib_element(L_CS7_XUA_NODE, &xua_local_ip_cmd); install_lib_element(L_CS7_XUA_NODE, &xua_no_local_ip_cmd); + install_lib_element(L_CS7_XUA_NODE, &xua_ip_dscp_cmd); install_lib_element(L_CS7_XUA_NODE, &xua_accept_dyn_asp_cmd); install_lib_element(L_CS7_XUA_NODE, &xua_sctp_param_init_cmd); install_lib_element(L_CS7_XUA_NODE, &xua_no_sctp_param_init_cmd); -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42807?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I35eab3672157c318616f51ee3042243aed263d4e Gerrit-Change-Number: 42807 Gerrit-PatchSet: 1 Gerrit-Owner: jolly <andreas(a)eversberg.eu>
1 0
0 0
  • ← Newer
  • 1
  • ...
  • 81
  • 82
  • 83
  • 84
  • 85
  • 86
  • 87
  • Older →

HyperKitty Powered by HyperKitty version 1.3.12.