lists.osmocom.org
Sign In Sign Up
Manage this list Sign In Sign Up

Keyboard Shortcuts

Thread View

  • j: Next unread message
  • k: Previous unread message
  • j a: Jump to all threads
  • j l: Jump to MailingList overview

gerrit-log

Thread Start a new thread
Download
Threads by month
  • ----- 2026 -----
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2025 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2024 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2023 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2022 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
gerrit-log@lists.osmocom.org

June 2026

  • 1 participants
  • 870 discussions
[XS] Change in osmo-ci[master]: jobs/octsim_osmo-ccid-firmware: add timeout arg
by osmith 02 Jun '26

02 Jun '26
osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/42812?usp=email ) Change subject: jobs/octsim_osmo-ccid-firmware: add timeout arg ...................................................................... jobs/octsim_osmo-ccid-firmware: add timeout arg For testing the hook scripts (see next patch), it is useful to have a shorter timeout for some test runs. Make it configurable. Related: SYS#8011 Change-Id: I3bac142a9e2e5f144ad52ea7c36c05ffbad6f5d1 --- M jobs/octsim_osmo-ccid-firmware.yml 1 file changed, 5 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/12/42812/1 diff --git a/jobs/octsim_osmo-ccid-firmware.yml b/jobs/octsim_osmo-ccid-firmware.yml index 79b403e..2adbed7 100644 --- a/jobs/octsim_osmo-ccid-firmware.yml +++ b/jobs/octsim_osmo-ccid-firmware.yml @@ -15,12 +15,16 @@ name: EMAIL_NOTIFICATIONS description: For failed build notifications, set to empty to disable default: 'jenkins-notifications(a)lists.osmocom.org jsteiger(a)sysmocom.de acouzens(a)sysmocom.de' + - string: + name: TIMEOUT + description: Abort the tests after this time in case they hang + default: '30m' builders: - shell: | export PYTHONUNBUFFERED=1 cd ./tests mkdir -p sysmo-octsim/dl - timeout 30m ./run-tests + timeout $TIMEOUT ./run-tests scm: - git: url: https://gerrit.osmocom.org/osmo-ccid-firmware -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/42812?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I3bac142a9e2e5f144ad52ea7c36c05ffbad6f5d1 Gerrit-Change-Number: 42812 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de>
1 0
0 0
[S] Change in osmo-ci[master]: jobs/osmo-ccid-firmware: run hooks for logs
by osmith 02 Jun '26

02 Jun '26
osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/42813?usp=email ) Change subject: jobs/osmo-ccid-firmware: run hooks for logs ...................................................................... jobs/osmo-ccid-firmware: run hooks for logs Run the start-hook.sh / stop-hook.sh scripts that store pcscd logs and a usbmon capture. The jenkins node is configured to allow running these two scripts with sudo as jenkins user. Store the resulting files as artifacts. Related: OS#8011 Change-Id: Id0d9a39fda24813572b979588c0ca22918829ad4 --- M jobs/gerrit-osmo-ccid-firmware-hwtest.yml M jobs/octsim_osmo-ccid-firmware.yml 2 files changed, 19 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/13/42813/1 diff --git a/jobs/gerrit-osmo-ccid-firmware-hwtest.yml b/jobs/gerrit-osmo-ccid-firmware-hwtest.yml index 3b9c7c5..d124e86 100644 --- a/jobs/gerrit-osmo-ccid-firmware-hwtest.yml +++ b/jobs/gerrit-osmo-ccid-firmware-hwtest.yml @@ -24,7 +24,13 @@ # Run tests export SKIP_FETCH_IMAGE=1 cd ./tests - timeout 30m ./run-tests + + sudo /etc/osmo-ccid-firmware-tests/start-hook.sh + FAIL=0 + timeout 30m ./run-tests || FAIL=1 + sudo /etc/osmo-ccid-firmware-tests/stop-hook.sh + + exit $FAIL scm: - git: @@ -39,5 +45,8 @@ - build-discarder: days-to-keep: 30 num-to-keep: 120 + publishers: + - archive: + artifacts: 'tests/logs/**' retry-count: 3 # scm checkout diff --git a/jobs/octsim_osmo-ccid-firmware.yml b/jobs/octsim_osmo-ccid-firmware.yml index 2adbed7..e094c98 100644 --- a/jobs/octsim_osmo-ccid-firmware.yml +++ b/jobs/octsim_osmo-ccid-firmware.yml @@ -24,7 +24,13 @@ export PYTHONUNBUFFERED=1 cd ./tests mkdir -p sysmo-octsim/dl - timeout $TIMEOUT ./run-tests + + sudo /etc/osmo-ccid-firmware-tests/start-hook.sh + FAIL=0 + timeout $TIMEOUT ./run-tests || FAIL=1 + sudo /etc/osmo-ccid-firmware-tests/stop-hook.sh + + exit $FAIL scm: - git: url: https://gerrit.osmocom.org/osmo-ccid-firmware @@ -42,6 +48,8 @@ notify-every-unstable-build: true recipients: '$EMAIL_NOTIFICATIONS' send-to-individuals: true + - archive: + artifacts: 'tests/logs/**' retry-count: 3 # scm checkout triggers: - reverse: -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/42813?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Id0d9a39fda24813572b979588c0ca22918829ad4 Gerrit-Change-Number: 42813 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de>
1 0
0 0
[XS] Change in libosmo-sigtran[master]: tcap loadshare: move last_asp_idx_sent from cfg to runtime struct
by lynxis lazus 02 Jun '26

02 Jun '26
lynxis lazus has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/42761?usp=email ) Change subject: tcap loadshare: move last_asp_idx_sent from cfg to runtime struct ...................................................................... tcap loadshare: move last_asp_idx_sent from cfg to runtime struct The last_asp_idx_sent is a runtime information and not configurable. Move it to the other runtime state. Change-Id: Id52bb0f6c67949b5e03f7ad36996f37a0d25214a --- M src/ss7_as.h M src/tcap_as_loadshare.c 2 files changed, 4 insertions(+), 4 deletions(-) Approvals: Jenkins Builder: Verified daniel: Looks good to me, approved diff --git a/src/ss7_as.h b/src/ss7_as.h index 919e587..7d873b8 100644 --- a/src/ss7_as.h +++ b/src/ss7_as.h @@ -133,6 +133,7 @@ /* TODO: the hash tables size might not be optimal */ DECLARE_HASHTABLE(trans_track_own, 10); DECLARE_HASHTABLE(trans_track_peer, 10); + struct ss7_as_asp_assoc *last_asp_idx_sent; } tcap; #endif /* WITH_TCAP_LOADSHARING */ @@ -179,7 +180,6 @@ struct { bool enabled; unsigned int timeout_s; - struct ss7_as_asp_assoc *last_asp_idx_sent; enum ss7_as_tcap_unroutable unroutable_tcap_msg; } tcap; #endif /* WITH_TCAP_LOADSHARING */ diff --git a/src/tcap_as_loadshare.c b/src/tcap_as_loadshare.c index 315d7b1..6a45d9a 100644 --- a/src/tcap_as_loadshare.c +++ b/src/tcap_as_loadshare.c @@ -259,7 +259,7 @@ struct ss7_as_asp_assoc *assoc; for (unsigned int i = 0; i < as->num_assoc_asps; i++) { - assoc = ss7_as_asp_assoc_llist_round_robin(as, &as->cfg.loadshare.tcap.last_asp_idx_sent); + assoc = ss7_as_asp_assoc_llist_round_robin(as, &as->tcap.last_asp_idx_sent); if (assoc && osmo_ss7_asp_active(assoc->asp) && assoc->asp->tcap.enabled) return assoc->asp; } @@ -941,7 +941,7 @@ return; /* Update round robin state */ - ss7_as_del_asp_update_llist_round_robin(as, asp, &as->cfg.loadshare.tcap.last_asp_idx_sent); + ss7_as_del_asp_update_llist_round_robin(as, asp, &as->tcap.last_asp_idx_sent); _tcap_range_asp_down(as, asp); if (as->tcap.contains_pc || as->tcap.contains_ssn) tcap_range_as_update_pc_ssn(as); @@ -964,7 +964,7 @@ as->cfg.loadshare.tcap.enabled = false; as->tcap.contains_pc = false; as->tcap.contains_ssn = false; - as->cfg.loadshare.tcap.last_asp_idx_sent = NULL; + as->tcap.last_asp_idx_sent = NULL; tcap_trans_track_garbage_collect_stop(as); tcap_trans_track_entries_free_all(as); } -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42761?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: Id52bb0f6c67949b5e03f7ad36996f37a0d25214a Gerrit-Change-Number: 42761 Gerrit-PatchSet: 8 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
1 0
0 0
[S] Change in libosmo-sigtran[master]: vty-tests: Re-introduce the check on the help
by lynxis lazus 02 Jun '26

02 Jun '26
lynxis lazus has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/42765?usp=email ) Change subject: vty-tests: Re-introduce the check on the help ...................................................................... vty-tests: Re-introduce the check on the help With the support of regex within vty tests, the help message can be checked again. Depends-on: Iadcd7a8c3677548a6405e098fe53d0614ef2012c (osmo-python-tests) Change-Id: I3fad268b7a8925f378f6331fcab073637bd80e08 --- M tests/vty/osmo_stp_test.vty 1 file changed, 14 insertions(+), 0 deletions(-) Approvals: daniel: Looks good to me, approved Jenkins Builder: Verified diff --git a/tests/vty/osmo_stp_test.vty b/tests/vty/osmo_stp_test.vty index c180dd7..359d65e 100644 --- a/tests/vty/osmo_stp_test.vty +++ b/tests/vty/osmo_stp_test.vty @@ -406,6 +406,20 @@ no point-code override (opc|dpc) point-code override patch-sccp (disabled|both) +OsmoSTP(config-cs7-as)# ? +... +!r! description [ ]+Save human-readable description of the object +!r! asp [ ]+Specify that a given ASP is part of this AS +!r! no [ ]+Negate a command or set its defaults +!r! traffic-mode[ ]+Specifies traffic mode of operation of the ASP within the AS +!r! sls-shift [ ]+Shift SLS bits used during routing decision +... +!r! binding-table [ ]+AS Loadshare binding table operations +!r! recovery-timeout[ ]+Specifies RFC4666 recovery timer T\(r\) timeout +!r! qos-class [ ]+Specity QoS Class of AS +!r! routing-key [ ]+Define a routing key +!r! point-code [ ]+Point Code Specific Features + OsmoSTP(config-cs7-as)# no ? asp Specify ASP to be removed from this AS traffic-mode Remove explicit traffic mode of operation of this AS -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42765?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I3fad268b7a8925f378f6331fcab073637bd80e08 Gerrit-Change-Number: 42765 Gerrit-PatchSet: 7 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu>
1 0
0 0
[M] Change in libosmo-sigtran[master]: tcap loadshare: allow to define the fallback mechanism for unroutable...
by lynxis lazus 02 Jun '26

02 Jun '26
lynxis lazus has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/42760?usp=email ) Change subject: tcap loadshare: allow to define the fallback mechanism for unroutable TCAP messages ...................................................................... tcap loadshare: allow to define the fallback mechanism for unroutable TCAP messages When a TCAP Continue/End/Abort message is received, but no TCAP session entry can be found and no valid TCAP range is available for the dtid, the message can be either: - rejected by returning an error with udts - routed by round robin to all available ASP of this AS To define the behaviour, a new vty option is introduced: ``` tcap-unroutable-sessions (reject-udts | load-share-over-as) ``` Defaults to reject-udts. Related: SYS#5432 Change-Id: Ic1c876da30b05065a476d3a7c1bbf0680adf55bd --- M src/ss7_as.c M src/ss7_as.h M src/ss7_as_vty.c M src/tcap_as_loadshare.c M tests/vty/osmo_stp_test_tcap.vty 5 files changed, 70 insertions(+), 18 deletions(-) Approvals: daniel: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/ss7_as.c b/src/ss7_as.c index 8cddae9..064ea4f 100644 --- a/src/ss7_as.c +++ b/src/ss7_as.c @@ -93,6 +93,12 @@ { 0, NULL } }; +struct value_string osmo_ss7_as_tcap_unroutable_vals[] = { + { SS7_AS_TCAP_UNROUTABLE_REJECT_UDTS, "reject-udts" }, + { SS7_AS_TCAP_UNROUTABLE_LOAD_SHARE_AS, "load-share-over-as" }, + { 0, NULL } +}; + #define SS7_AS_CTR_RX_MSU_SLS_STR "Number of MSU received on SLS " #define SS7_AS_CTR_TX_MSU_SLS_STR "Number of MSU transmitted on SLS " static const struct rate_ctr_desc ss7_as_rcd[] = { @@ -135,7 +141,7 @@ [SS7_AS_CTR_RX_TCAP_DECODED] = { "tcap:decoded", "Number of TCAP-messages decoded successfully (loadshare-tcap)" }, [SS7_AS_CTR_RX_TCAP_FAILED] = { "tcap:failed", "Number of TCAP-messages that failed decoding (loadshare-tcap)" }, [SS7_AS_CTR_TCAP_ASP_SELECTED] = { "tcap:asp:selected", "ASP selection successful for a TCAP-message (loadshare-tcap)" }, - [SS7_AS_CTR_TCAP_ASP_FALLBACK] = { "tcap:asp:fallback", "Fallback ASP selected for a TCAP-message (loadshare-tcap)" }, + [SS7_AS_CTR_TCAP_ASP_FALLBACK] = { "tcap:asp:fallback", "A non-starting TCAP message had to be routed by round-robin over all ASP. (loadshare-tcap)" }, [SS7_AS_CTR_TCAP_ASP_FAILED] = { "tcap:asp:failed", "ASP selection failed for a TCAP-message (loadshare-tcap)" }, [SS7_AS_CTR_TCAP_ASP_MISS] = { "tcap:session:miss", "A non-starting TCAP message (Continue, End, Abort) was missing a session entry, but routed successful. (loadshare-tcap)" }, #endif /* WITH_TCAP_LOADSHARING */ @@ -184,6 +190,7 @@ /* TODO: use Tdef */ as->cfg.loadshare.tcap.timeout_s = 30; + as->cfg.loadshare.tcap.unroutable_tcap_msg = SS7_AS_TCAP_UNROUTABLE_REJECT_UDTS; #endif /* WITH_TCAP_LOADSHARING */ as->fi = xua_as_fsm_start(as, LOGL_DEBUG); diff --git a/src/ss7_as.h b/src/ss7_as.h index e67ca1b..919e587 100644 --- a/src/ss7_as.h +++ b/src/ss7_as.h @@ -75,6 +75,14 @@ #endif /* WITH_TCAP_LOADSHARING */ }; +/* when receiving an TCAP Continue/End/Abort which can't be assosiated to a node (either by sesssion tracking or by DTID over TCAP ranges, + * how to handle those */ +enum ss7_as_tcap_unroutable { + SS7_AS_TCAP_UNROUTABLE_REJECT_UDTS, /*! reject the unroutable TCAP message with a UDTS */ + SS7_AS_TCAP_UNROUTABLE_LOAD_SHARE_AS, /*! fallback to round robin load-share over all available ASP */ +}; +extern struct value_string osmo_ss7_as_tcap_unroutable_vals[]; + #define NUM_AS_EXT_SLS 128 typedef uint8_t as_ext_sls_t; /* range: 0-127, 7 bit */ struct osmo_ss7_as_esls_entry { @@ -172,6 +180,7 @@ bool enabled; unsigned int timeout_s; struct ss7_as_asp_assoc *last_asp_idx_sent; + enum ss7_as_tcap_unroutable unroutable_tcap_msg; } tcap; #endif /* WITH_TCAP_LOADSHARING */ } loadshare; diff --git a/src/ss7_as_vty.c b/src/ss7_as_vty.c index d9fd58d..0370f2f 100644 --- a/src/ss7_as_vty.c +++ b/src/ss7_as_vty.c @@ -245,6 +245,22 @@ return CMD_SUCCESS; } + +DEFUN_USRATTR(as_tcap_unroutable_sessions, as_tcap_unroutable_sessions_cmd, + OSMO_SCCP_LIB_ATTR_RSTRT_ASP, + "tcap-unroutable-sessions (reject-udts | load-share-over-as)", + "When receiving a TCAP Continue/End/Abort message where no ASP can be assosiated (either via session tracking or by TCAP range for dtid). How should this message handled.\n" + "Reject the message with a UDTS\n" + "Fallback to load-share over AS by using all available AS (round robin)\n") +{ + struct osmo_ss7_as *as = vty->index; + int value = get_string_value(osmo_ss7_as_tcap_unroutable_vals, argv[0]); + if (value < 0) + return CMD_WARNING; + + as->cfg.loadshare.tcap.unroutable_tcap_msg = value; + return CMD_SUCCESS; +} #endif /* WITH_TCAP_LOADSHARING */ DEFUN_ATTR(as_bindingtable_reset, as_bindingtable_reset_cmd, @@ -507,6 +523,13 @@ #ifdef WITH_TCAP_LOADSHARING if (as->cfg.loadshare.tcap.enabled) vty_out(vty, " tcap-routing%s", VTY_NEWLINE); + + if (as->cfg.loadshare.tcap.unroutable_tcap_msg != SS7_AS_TCAP_UNROUTABLE_REJECT_UDTS) { + const char *str = get_value_string_or_null(osmo_ss7_as_tcap_unroutable_vals, + as->cfg.loadshare.tcap.unroutable_tcap_msg); + if (str) + vty_out(vty, " tcap-unroutable-sessions %s%s", str, VTY_NEWLINE); + } #endif /* WITH_TCAP_LOADSHARING */ if (as->cfg.recovery_timeout_msec != 2000) { @@ -714,6 +737,7 @@ if (cs7_role == CS7_ROLE_SG) { install_lib_element(L_CS7_AS_NODE, &as_tcap_routing_cmd); install_lib_element(L_CS7_AS_NODE, &as_no_tcap_routing_cmd); + install_lib_element(L_CS7_AS_NODE, &as_tcap_unroutable_sessions_cmd); } #endif /* WITH_TCAP_LOADSHARING */ install_lib_element(L_CS7_AS_NODE, &as_bindingtable_reset_cmd); diff --git a/src/tcap_as_loadshare.c b/src/tcap_as_loadshare.c index a6b71d2..315d7b1 100644 --- a/src/tcap_as_loadshare.c +++ b/src/tcap_as_loadshare.c @@ -546,6 +546,12 @@ LOGPAS(as, DLTCAP, LOGL_INFO, "Couldn't find cached ASP for TCAP Continue, dtid %u/otid %u, using tcap route", parsed.dtid, parsed.otid); rate_ctr_inc2(as->ctrg, SS7_AS_CTR_TCAP_ASP_MISS); asp = tcap_as_asp_find_by_tcap_id(as, &calling_addr, &called_addr, parsed.dtid); + if (!asp && as->cfg.loadshare.tcap.unroutable_tcap_msg == SS7_AS_TCAP_UNROUTABLE_LOAD_SHARE_AS) { + asp = select_asp_tcap_enabled_rr(as); + if (asp) + rate_ctr_inc2(as->ctrg, SS7_AS_CTR_TCAP_ASP_FALLBACK); + } + if (asp) tcap_trans_track_entry_create(as, asp, &called_addr, &parsed.dtid, &calling_addr, &parsed.otid); } @@ -564,6 +570,11 @@ LOGPAS(as, DLTCAP, LOGL_INFO, "Couldn't find cached ASP for TCAP End, dtid %u, using tcap route", parsed.dtid); rate_ctr_inc2(as->ctrg, SS7_AS_CTR_TCAP_ASP_MISS); asp = tcap_as_asp_find_by_tcap_id(as, &calling_addr, &called_addr, parsed.dtid); + if (!asp && as->cfg.loadshare.tcap.unroutable_tcap_msg == SS7_AS_TCAP_UNROUTABLE_LOAD_SHARE_AS) { + asp = select_asp_tcap_enabled_rr(as); + if (asp) + rate_ctr_inc2(as->ctrg, SS7_AS_CTR_TCAP_ASP_FALLBACK); + } /* Don't create an entry for an End */ } rc = asp ? 0 : -ENOKEY; diff --git a/tests/vty/osmo_stp_test_tcap.vty b/tests/vty/osmo_stp_test_tcap.vty index 3085074..7ffff77 100644 --- a/tests/vty/osmo_stp_test_tcap.vty +++ b/tests/vty/osmo_stp_test_tcap.vty @@ -22,23 +22,24 @@ ... OsmoSTP(config-cs7-as)# ? - help Description of the interactive help system - list Print command list - show Show running system information - write Write running configuration to memory, network, or terminal - exit Exit current mode and down to previous mode - end End current mode and change to enable mode. - description Save human-readable description of the object - asp Specify that a given ASP is part of this AS - no Negate a command or set its defaults - traffic-mode Specifies traffic mode of operation of the ASP within the AS - sls-shift Shift SLS bits used during routing decision - tcap-routing Enable TCAP-based routing when in traffic-mode loadshare - binding-table AS Loadshare binding table operations - recovery-timeout Specifies RFC4666 recovery timer T(r) timeout - qos-class Specity QoS Class of AS - routing-key Define a routing key - point-code Point Code Specific Features + help Description of the interactive help system + list Print command list + show Show running system information + write Write running configuration to memory, network, or terminal + exit Exit current mode and down to previous mode + end End current mode and change to enable mode. + description Save human-readable description of the object + asp Specify that a given ASP is part of this AS + no Negate a command or set its defaults + traffic-mode Specifies traffic mode of operation of the ASP within the AS + sls-shift Shift SLS bits used during routing decision + tcap-routing Enable TCAP-based routing when in traffic-mode loadshare + tcap-unroutable-sessions When receiving a TCAP Continue/End/Abort message where no ASP can be assosiated (either via session tracking or by TCAP range for dtid). How should this message handled. + binding-table AS Loadshare binding table operations + recovery-timeout Specifies RFC4666 recovery timer T(r) timeout + qos-class Specity QoS Class of AS + routing-key Define a routing key + point-code Point Code Specific Features OsmoSTP(config-cs7-as)# no ? asp Specify ASP to be removed from this AS -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42760?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: Ic1c876da30b05065a476d3a7c1bbf0680adf55bd Gerrit-Change-Number: 42760 Gerrit-PatchSet: 9 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
1 0
0 0
[S] Change in libosmo-sigtran[master]: vty-tests: Re-introduce the check on the help
by daniel 02 Jun '26

02 Jun '26
Attention is currently required from: lynxis lazus. daniel has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/42765?usp=email ) Change subject: vty-tests: Re-introduce the check on the help ...................................................................... Patch Set 7: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42765?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I3fad268b7a8925f378f6331fcab073637bd80e08 Gerrit-Change-Number: 42765 Gerrit-PatchSet: 7 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Tue, 02 Jun 2026 09:57:57 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes
1 0
0 0
[XS] Change in libosmo-sigtran[master]: tcap loadshare: move last_asp_idx_sent from cfg to runtime struct
by daniel 02 Jun '26

02 Jun '26
Attention is currently required from: lynxis lazus, pespin. daniel has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/42761?usp=email ) Change subject: tcap loadshare: move last_asp_idx_sent from cfg to runtime struct ...................................................................... Patch Set 8: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42761?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: Id52bb0f6c67949b5e03f7ad36996f37a0d25214a Gerrit-Change-Number: 42761 Gerrit-PatchSet: 8 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Tue, 02 Jun 2026 09:55:58 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes
1 0
0 0
[M] Change in libosmo-sigtran[master]: tcap loadshare: allow to define the fallback mechanism for unroutable...
by daniel 02 Jun '26

02 Jun '26
Attention is currently required from: laforge, lynxis lazus, pespin. daniel has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/42760?usp=email ) Change subject: tcap loadshare: allow to define the fallback mechanism for unroutable TCAP messages ...................................................................... Patch Set 9: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42760?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: Ic1c876da30b05065a476d3a7c1bbf0680adf55bd Gerrit-Change-Number: 42760 Gerrit-PatchSet: 9 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Tue, 02 Jun 2026 09:55:18 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes
1 0
0 0
[M] Change in libosmo-sigtran[master]: tcap loadshare: allow to define the fallback mechanism for unroutable...
by lynxis lazus 02 Jun '26

02 Jun '26
Attention is currently required from: daniel, laforge, pespin. lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/42760?usp=email ) Change subject: tcap loadshare: allow to define the fallback mechanism for unroutable TCAP messages ...................................................................... Patch Set 8: (1 comment) File src/tcap_as_loadshare.c: https://gerrit.osmocom.org/c/libosmo-sigtran/+/42760/comment/99691e80_25ebe… : PS8, Line 263: if (assoc && osmo_ss7_asp_active(assoc->asp) && assoc->asp->tcap.enabled) { > I'm personally in favor of braces around single-statement blocks, but I think this goes against our […] Done -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42760?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: Ic1c876da30b05065a476d3a7c1bbf0680adf55bd Gerrit-Change-Number: 42760 Gerrit-PatchSet: 8 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Tue, 02 Jun 2026 09:54:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: daniel <dwillmann(a)sysmocom.de>
1 0
0 0
[M] Change in libosmo-sigtran[master]: tcap loadshare: allow to define the fallback mechanism for unroutable...
by lynxis lazus 02 Jun '26

02 Jun '26
Attention is currently required from: daniel, laforge, pespin. Hello Jenkins Builder, daniel, laforge, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42760?usp=email to look at the new patch set (#9). The following approvals got outdated and were removed: Code-Review+1 by daniel, Code-Review+1 by pespin, Verified+1 by Jenkins Builder Change subject: tcap loadshare: allow to define the fallback mechanism for unroutable TCAP messages ...................................................................... tcap loadshare: allow to define the fallback mechanism for unroutable TCAP messages When a TCAP Continue/End/Abort message is received, but no TCAP session entry can be found and no valid TCAP range is available for the dtid, the message can be either: - rejected by returning an error with udts - routed by round robin to all available ASP of this AS To define the behaviour, a new vty option is introduced: ``` tcap-unroutable-sessions (reject-udts | load-share-over-as) ``` Defaults to reject-udts. Related: SYS#5432 Change-Id: Ic1c876da30b05065a476d3a7c1bbf0680adf55bd --- M src/ss7_as.c M src/ss7_as.h M src/ss7_as_vty.c M src/tcap_as_loadshare.c M tests/vty/osmo_stp_test_tcap.vty 5 files changed, 70 insertions(+), 18 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/60/42760/9 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42760?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: Ic1c876da30b05065a476d3a7c1bbf0680adf55bd Gerrit-Change-Number: 42760 Gerrit-PatchSet: 9 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de>
1 0
0 0
  • ← Newer
  • 1
  • ...
  • 78
  • 79
  • 80
  • 81
  • 82
  • 83
  • 84
  • ...
  • 87
  • Older →

HyperKitty Powered by HyperKitty version 1.3.12.