April 2026 - gerrit-log - lists.osmocom.org

[S] Change in pysim[master]: pysim/pcsc: do not use getProtocol for protocol selection
by dexter 02 Apr '26

02 Apr '26

Attention is currently required from: fixeria, jolly, laforge. dexter has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/42475?usp=email ) Change subject: pysim/pcsc: do not use getProtocol for protocol selection ...................................................................... Patch Set 4: (1 comment) File pySim/transport/pcsc.py: https://gerrit.osmocom.org/c/pysim/+/42475/comment/5c6b8069_12915cb8?usp=em… : PS2, Line 88: on > 'on' is not needed here? Done -- To view, visit https://gerrit.osmocom.org/c/pysim/+/42475?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ib119948aa68c430e42ac84daec8b9bd542db7963 Gerrit-Change-Number: 42475 Gerrit-PatchSet: 4 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 02 Apr 2026 10:53:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[S] Change in pysim[master]: pysim/pcsc: do not use getProtocol for protocol selection
by dexter 02 Apr '26

02 Apr '26

Attention is currently required from: fixeria, jolly, laforge. Hello Jenkins Builder, fixeria, jolly, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/pysim/+/42475?usp=email to look at the new patch set (#4). The following approvals got outdated and were removed: Code-Review+1 by fixeria, Code-Review+1 by laforge, Verified+1 by Jenkins Builder Change subject: pysim/pcsc: do not use getProtocol for protocol selection ...................................................................... pysim/pcsc: do not use getProtocol for protocol selection The documentation of the getProtocol provided by pyscard says: "Return bit mask for the protocol of connection, or None if no protocol set. The return value is a bit mask of CardConnection.T0_protocol, CardConnection.T1_protocol, CardConnection.RAW_protocol, CardConnection.T15_protocol" This suggests that the purpose of getProtocol is not to determine which protocols are supported. Its purpose is to determine which protocol is currently selected (either through auto selection or through the explicit selection made by the API user). This means we are using getProtocol wrong. So far this was no problem, since the auto-selected protocol should be a supported protocol anyway. However, the automatic protocol selection may not always return a correct result (see bug report from THD-siegfried [1]). Let's not trust the automatic protocol selection. Instead let's parse the ATR and make the decision based on the TD1/TD2 bytes). [1] https://osmocom.org/issues/6952 Related: OS#6952 Change-Id: Ib119948aa68c430e42ac84daec8b9bd542db7963 --- M pySim/transport/pcsc.py 1 file changed, 11 insertions(+), 7 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/75/42475/4 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/42475?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ib119948aa68c430e42ac84daec8b9bd542db7963 Gerrit-Change-Number: 42475 Gerrit-PatchSet: 4 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[S] Change in osmo-ttcn3-hacks[master]: msc: Fix race condition in TC_reset_two(_1iu)
by jolly 02 Apr '26

02 Apr '26

Attention is currently required from: pespin. jolly has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42578?usp=email ) Change subject: msc: Fix race condition in TC_reset_two(_1iu) ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42578?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I27afd7a47e6c6cf0f70e1ecc9e26dd2c220e72ab Gerrit-Change-Number: 42578 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 02 Apr 2026 10:17:52 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-ci[master]: jobs/octsim_osmo-ccid-firmware: add 30 min timeout
by osmith 02 Apr '26

02 Apr '26

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/42579?usp=email ) Change subject: jobs/octsim_osmo-ccid-firmware: add 30 min timeout ...................................................................... jobs/octsim_osmo-ccid-firmware: add 30 min timeout I just stopped a job run that was going for 2 days 16 h. When successful, the job finishes in 10 min, so let it abort automatically after 30 min. Change-Id: Iaccc96b8b29880c9e115e52561fcd43f7b6a8f77 --- M jobs/octsim_osmo-ccid-firmware.yml 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins Builder: Verified lynxis lazus: Looks good to me, approved fixeria: Looks good to me, but someone else must approve diff --git a/jobs/octsim_osmo-ccid-firmware.yml b/jobs/octsim_osmo-ccid-firmware.yml index 61e609c..599acc1 100644 --- a/jobs/octsim_osmo-ccid-firmware.yml +++ b/jobs/octsim_osmo-ccid-firmware.yml @@ -11,7 +11,7 @@ - shell: | cd ./tests mkdir -p sysmo-octsim/dl - ./run-tests + timeout 30m ./run-tests concurrent: false description: octsim osmo-ccid-firmware CI - flash every build to octsim and see if it still works -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/42579?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Iaccc96b8b29880c9e115e52561fcd43f7b6a8f77 Gerrit-Change-Number: 42579 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in osmo-ttcn3-hacks[master]: msc: Fix race condition in TC_reset_two(_1iu)
by osmith 02 Apr '26

02 Apr '26

Attention is currently required from: jolly, pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42578?usp=email ) Change subject: msc: Fix race condition in TC_reset_two(_1iu) ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42578?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I27afd7a47e6c6cf0f70e1ecc9e26dd2c220e72ab Gerrit-Change-Number: 42578 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 02 Apr 2026 10:06:19 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-ccid-firmware[master]: contrib/jenkins: add SKIP_FIRMWARE_CLEAN argument
by osmith 02 Apr '26

02 Apr '26

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42580?usp=email ) Change subject: contrib/jenkins: add SKIP_FIRMWARE_CLEAN argument ...................................................................... contrib/jenkins: add SKIP_FIRMWARE_CLEAN argument If this is set, then don't clean the firmware at the end. This is needed to store the built firmware as artifact in jenkins, for passing it along to another job. Related: SYS#7963 Change-Id: I9e2342b8111645ef5d3b7bf4ac364ca592aa600b --- M contrib/jenkins.sh 1 file changed, 5 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ccid-firmware refs/changes/80/42580/1 diff --git a/contrib/jenkins.sh b/contrib/jenkins.sh index 9462cc3..bd90e45 100755 --- a/contrib/jenkins.sh +++ b/contrib/jenkins.sh @@ -99,6 +99,8 @@ fi fi -echo -echo "=============== FIRMWARE CLEAN ==============" -make clean +if [ -z "$SKIP_FIRMWARE_CLEAN" ]; then + echo + echo "=============== FIRMWARE CLEAN ==============" + make clean +fi -- To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42580?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ccid-firmware Gerrit-Branch: master Gerrit-Change-Id: I9e2342b8111645ef5d3b7bf4ac364ca592aa600b Gerrit-Change-Number: 42580 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de>

1 0

[XS] Change in osmo-ci[master]: jobs/octsim_osmo-ccid-firmware: add 30 min timeout
by lynxis lazus 02 Apr '26

02 Apr '26

Attention is currently required from: osmith, pespin. lynxis lazus has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ci/+/42579?usp=email ) Change subject: jobs/octsim_osmo-ccid-firmware: add 30 min timeout ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/42579?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Iaccc96b8b29880c9e115e52561fcd43f7b6a8f77 Gerrit-Change-Number: 42579 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 02 Apr 2026 09:48:47 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-ci[master]: jobs/octsim_osmo-ccid-firmware: add 30 min timeout
by fixeria 02 Apr '26

02 Apr '26

Attention is currently required from: lynxis lazus, osmith, pespin. fixeria has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ci/+/42579?usp=email ) Change subject: jobs/octsim_osmo-ccid-firmware: add 30 min timeout ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/42579?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Iaccc96b8b29880c9e115e52561fcd43f7b6a8f77 Gerrit-Change-Number: 42579 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Thu, 02 Apr 2026 09:47:18 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-ci[master]: jobs/octsim_osmo-ccid-firmware: add 30 min timeout
by osmith 02 Apr '26

02 Apr '26

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/42579?usp=email ) Change subject: jobs/octsim_osmo-ccid-firmware: add 30 min timeout ...................................................................... jobs/octsim_osmo-ccid-firmware: add 30 min timeout I just stopped a job run that was going for 2 days 16 h. When successful, the job finishes in 10 min, so let it abort automatically after 30 min. Change-Id: Iaccc96b8b29880c9e115e52561fcd43f7b6a8f77 --- M jobs/octsim_osmo-ccid-firmware.yml 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/79/42579/1 diff --git a/jobs/octsim_osmo-ccid-firmware.yml b/jobs/octsim_osmo-ccid-firmware.yml index 61e609c..599acc1 100644 --- a/jobs/octsim_osmo-ccid-firmware.yml +++ b/jobs/octsim_osmo-ccid-firmware.yml @@ -11,7 +11,7 @@ - shell: | cd ./tests mkdir -p sysmo-octsim/dl - ./run-tests + timeout 30m ./run-tests concurrent: false description: octsim osmo-ccid-firmware CI - flash every build to octsim and see if it still works -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/42579?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Iaccc96b8b29880c9e115e52561fcd43f7b6a8f77 Gerrit-Change-Number: 42579 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de>

1 0

[S] Change in osmo-ttcn3-hacks[master]: msc: Fix race condition in TC_reset_two(_1iu)
by fixeria 02 Apr '26

02 Apr '26

Attention is currently required from: jolly, osmith, pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42578?usp=email ) Change subject: msc: Fix race condition in TC_reset_two(_1iu) ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42578?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I27afd7a47e6c6cf0f70e1ecc9e26dd2c220e72ab Gerrit-Change-Number: 42578 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 02 Apr 2026 09:02:29 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

2026

2025

2024

2023

2022

gerrit-log April 2026