April 2026 - gerrit-log - lists.osmocom.org

[S] Change in osmo-bsc[master]: lchan_fsm: don't mark lchan as BORKEN on unsupported mode NACK
by fixeria 06 Apr '26

06 Apr '26

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/42592?usp=email ) Change subject: lchan_fsm: don't mark lchan as BORKEN on unsupported mode NACK ...................................................................... lchan_fsm: don't mark lchan as BORKEN on unsupported mode NACK When the BTS NACKs a Channel Activation with RSL_ERR_SERV_OPT_UNAVAIL or RSL_ERR_SERV_OPT_UNIMPL, it means the requested service or channel mode is not supported - not that the hardware is broken. In this case the lchan should transition to LCHAN_ST_WAIT_AFTER_ERROR rather than LCHAN_ST_BORKEN, which is reserved for genuine hardware failures. Also add LCHAN_EV_RTP_ERROR to LCHAN_ST_WAIT_AFTER_ERROR's in_event_mask so that a late LCHAN_EV_RTP_ERROR (e.g. MGCP CRCX timeout arriving after the NACK was already handled) is silently absorbed rather than triggering an unexpected-event warning. Change-Id: Ide3830a697501a0c245a41451302f1e68d553b3c Related: osmo-ttcn3-hacks.git I000b7b44749380c5af4da42abe37b4ada6e06ee4 Related: OS#6324 --- M src/osmo-bsc/lchan_fsm.c 1 file changed, 14 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/92/42592/1 diff --git a/src/osmo-bsc/lchan_fsm.c b/src/osmo-bsc/lchan_fsm.c index 524d66e..afb5cc8 100644 --- a/src/osmo-bsc/lchan_fsm.c +++ b/src/osmo-bsc/lchan_fsm.c @@ -977,12 +977,22 @@ lchan->release.rsl_error_cause = *(uint8_t*)data; lchan->release.rr_cause = bsc_gsm48_rr_cause_from_rsl_cause(lchan->release.rsl_error_cause); lchan->release.in_error = true; - if (lchan->release.rsl_error_cause != RSL_ERR_RCH_ALR_ACTV_ALLOC) - next_state = LCHAN_ST_BORKEN; - else + switch (lchan->release.rsl_error_cause) { + case RSL_ERR_RCH_ALR_ACTV_ALLOC: /* Taking this over from legacy code: send an RF Chan Release even though * the Activ was NACKed. Is this really correct? */ next_state = LCHAN_ST_WAIT_RF_RELEASE_ACK; + break; + case RSL_ERR_SERV_OPT_UNAVAIL: + case RSL_ERR_SERV_OPT_UNIMPL: + /* BTS does not support the requested service or mode; the lchan + * itself is not broken, so don't mark it as such. */ + next_state = LCHAN_ST_WAIT_AFTER_ERROR; + break; + default: + next_state = LCHAN_ST_BORKEN; + break; + } lchan_fail_to(next_state, "Chan Activ NACK: %s (0x%x)", rsl_err_name(lchan->release.rsl_error_cause), lchan->release.rsl_error_cause); @@ -1759,6 +1769,7 @@ .out_state_mask = 0 | S(LCHAN_ST_UNUSED) | S(LCHAN_ST_WAIT_RLL_RTP_ESTABLISH) + | S(LCHAN_ST_WAIT_AFTER_ERROR) | S(LCHAN_ST_BORKEN) | S(LCHAN_ST_WAIT_RF_RELEASE_ACK) , -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/42592?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ide3830a697501a0c245a41451302f1e68d553b3c Gerrit-Change-Number: 42592 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[XS] Change in osmo-bsc[master]: handover_fsm: fix send_handover_performed() using wrong lchan
by fixeria 06 Apr '26

06 Apr '26

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/42593?usp=email ) Change subject: handover_fsm: fix send_handover_performed() using wrong lchan ...................................................................... handover_fsm: fix send_handover_performed() using wrong lchan send_handover_performed() is called from handover_end() before gscon_change_primary_lchan() updates conn->lchan to the new lchan. As a result, the Cell Identifier, Chosen Channel, Chosen Encryption Algorithm, and Speech Version/Codec IEs were all populated from the source (old) lchan rather than the target (new) lchan. As per 3GPP TS 48.008 §3.2.1.25, HANDOVER PERFORMED must report the target cell and channel. For intra-BSC handover to a different BTS this caused the MSC to receive the wrong Cell Identifier. Fix by initialising lchan from ho->new_lchan instead of conn->lchan, and deriving the BTS via lchan->ts->trx->bts. Change-Id: I4111351dc38fc2dbe844c2bd07b3ecfaaadd864e Related: osmo-ttcn3-hacks.git I82aadcc3a80c183cb93522b829071294b156a218 Found-By: Claude Sonnet 4.6 --- M src/osmo-bsc/handover_fsm.c 1 file changed, 3 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/93/42593/1 diff --git a/src/osmo-bsc/handover_fsm.c b/src/osmo-bsc/handover_fsm.c index 24766a5..cddb138 100644 --- a/src/osmo-bsc/handover_fsm.c +++ b/src/osmo-bsc/handover_fsm.c @@ -897,8 +897,8 @@ static void send_handover_performed(struct gsm_subscriber_connection *conn) { - struct gsm_lchan *lchan = conn->lchan; struct handover *ho = &conn->ho; + struct gsm_lchan *lchan = ho->new_lchan; struct osmo_cell_global_id *cell; struct gsm0808_handover_performed ho_perf_params = {}; struct msgb *msg; @@ -909,7 +909,7 @@ ho_perf_params.cause = GSM0808_CAUSE_HANDOVER_SUCCESSFUL; /* Cell Identifier 3.2.2.17 */ - cell = cgi_for_msc(conn->sccp.msc, conn_get_bts(conn)); + cell = cgi_for_msc(conn->sccp.msc, lchan->ts->trx->bts); if (!cell) { LOG_HO(conn, LOGL_ERROR, "Failed to generate Cell Identifier IE, can't send HANDOVER PERFORMED!\n"); return; @@ -941,7 +941,7 @@ if (gscon_is_aoip(conn)) { /* Extrapolate speech codec from speech mode */ gsm0808_speech_codec_from_chan_type(&sc, ho_perf_params.speech_version_chosen); - sc.cfg = conn->lchan->current_ch_mode_rate.s15_s0; + sc.cfg = lchan->current_ch_mode_rate.s15_s0; memcpy(&ho_perf_params.speech_codec_chosen, &sc, sizeof(sc)); ho_perf_params.speech_codec_chosen_present = true; } -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/42593?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I4111351dc38fc2dbe844c2bd07b3ecfaaadd864e Gerrit-Change-Number: 42593 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[XS] Change in osmo-bsc[master]: bssap: use LOGPFSML in bssmap_handle_assignm_req()
by fixeria 06 Apr '26

06 Apr '26

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/42585?usp=email ) Change subject: bssap: use LOGPFSML in bssmap_handle_assignm_req() ...................................................................... bssap: use LOGPFSML in bssmap_handle_assignm_req() Change-Id: If99661c0ff1177214bacdb2d1bcb9da1d2d2957c --- M src/osmo-bsc/osmo_bsc_bssap.c 1 file changed, 3 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/85/42585/1 diff --git a/src/osmo-bsc/osmo_bsc_bssap.c b/src/osmo-bsc/osmo_bsc_bssap.c index 7a9688d..dbd1a20 100644 --- a/src/osmo-bsc/osmo_bsc_bssap.c +++ b/src/osmo-bsc/osmo_bsc_bssap.c @@ -1144,7 +1144,7 @@ /* Check for channel type element, if its missing, immediately reject */ if (!TLVP_PRESENT(&tp, GSM0808_IE_CHANNEL_TYPE)) { - LOGP(DMSC, LOGL_ERROR, "Mandatory channel type not present.\n"); + LOGPFSML(conn->fi, LOGL_ERROR, "Mandatory channel type not present.\n"); cause = GSM0808_CAUSE_INFORMATION_ELEMENT_OR_FIELD_MISSING; goto reject; } @@ -1153,7 +1153,7 @@ rc = gsm0808_dec_channel_type(&ct, TLVP_VAL(&tp, GSM0808_IE_CHANNEL_TYPE), TLVP_LEN(&tp, GSM0808_IE_CHANNEL_TYPE)); if (rc < 0) { - LOGP(DMSC, LOGL_ERROR, "unable to decode channel type.\n"); + LOGPFSML(conn->fi, LOGL_ERROR, "unable to decode channel type.\n"); cause = GSM0808_CAUSE_INCORRECT_VALUE; goto reject; } @@ -1167,7 +1167,7 @@ rc = gsm0808_dec_group_callref(&gc, TLVP_VAL(&tp, GSM0808_IE_GROUP_CALL_REFERENCE), TLVP_LEN(&tp, GSM0808_IE_GROUP_CALL_REFERENCE)); if (rc < 0) { - LOGP(DMSC, LOGL_ERROR, "Unable to decode Group Call Reference.\n"); + LOGPFSML(conn->fi, LOGL_ERROR, "Unable to decode Group Call Reference.\n"); cause = GSM0808_CAUSE_INCORRECT_VALUE; goto reject; } -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/42585?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: If99661c0ff1177214bacdb2d1bcb9da1d2d2957c Gerrit-Change-Number: 42585 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[M] Change in osmo-bsc[master]: bssap: mark some pointers as const
by fixeria 06 Apr '26

06 Apr '26

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/42584?usp=email ) Change subject: bssap: mark some pointers as const ...................................................................... bssap: mark some pointers as const Change-Id: Iebb28d6ae0b468545994669248a442dd17f36d4c --- M include/osmocom/bsc/vgcs_fsm.h M src/osmo-bsc/osmo_bsc_bssap.c 2 files changed, 33 insertions(+), 18 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/84/42584/1 diff --git a/include/osmocom/bsc/vgcs_fsm.h b/include/osmocom/bsc/vgcs_fsm.h index 80ea21f..57acae0 100644 --- a/include/osmocom/bsc/vgcs_fsm.h +++ b/include/osmocom/bsc/vgcs_fsm.h @@ -104,9 +104,12 @@ int vgcs_vbs_chan_start(struct gsm_subscriber_connection *conn, struct msgb *msg); int vgcs_vbs_call_start(struct gsm_subscriber_connection *conn, struct msgb *msg); -int bssmap_handle_ass_req_ct_speech(struct gsm_subscriber_connection *conn, struct gsm_bts *bts, - struct tlv_parsed *tp, struct gsm0808_channel_type *ct, - struct assignment_request *req, uint8_t *cause); +int bssmap_handle_ass_req_ct_speech(struct gsm_subscriber_connection *conn, + struct gsm_bts *bts, + const struct tlv_parsed *tp, + const struct gsm0808_channel_type *ct, + struct assignment_request *req, + uint8_t *cause); void bsc_tx_setup_ack(struct gsm_subscriber_connection *conn, struct gsm0808_vgcs_feature_flags *ff); void bsc_tx_setup_refuse(struct gsm_subscriber_connection *conn, uint8_t cause); void bsc_tx_vgcs_vbs_assignment_result(struct gsm_subscriber_connection *conn, struct gsm0808_channel_type *ct, diff --git a/src/osmo-bsc/osmo_bsc_bssap.c b/src/osmo-bsc/osmo_bsc_bssap.c index 395fa49..7a9688d 100644 --- a/src/osmo-bsc/osmo_bsc_bssap.c +++ b/src/osmo-bsc/osmo_bsc_bssap.c @@ -684,7 +684,8 @@ * lchan is requested. The preferred lchan will be requested first. If we * find an alternate setting here, this one will be tried secondly if our * primary choice fails. */ -static int select_data_rates(struct assignment_request *req, struct gsm0808_channel_type *ct, +static int select_data_rates(struct assignment_request *req, + const struct gsm0808_channel_type *ct, struct gsm_subscriber_connection *conn) { int rc, i, nc = 0; @@ -815,7 +816,8 @@ return 0; } -static int select_sign_chan(struct assignment_request *req, struct gsm0808_channel_type *ct) +static int select_sign_chan(struct assignment_request *req, + const struct gsm0808_channel_type *ct) { int i, nc = 0; @@ -864,7 +866,8 @@ return nc > 0 ? 0 : -EINVAL; } -static int bssmap_handle_ass_req_tp_cic(struct tlv_parsed *tp, bool aoip, uint16_t *cic, uint8_t *cause) +static int bssmap_handle_ass_req_tp_cic(const struct tlv_parsed *tp, + bool aoip, uint16_t *cic, uint8_t *cause) { if (TLVP_PRESENT(tp, GSM0808_IE_CIRCUIT_IDENTITY_CODE)) { /* CIC is permitted in both AoIP and SCCPlite */ @@ -882,7 +885,7 @@ return 0; } -static int bssmap_handle_ass_req_tp_rtp_addr(struct tlv_parsed *tp, bool aoip, char *msc_rtp_addr, +static int bssmap_handle_ass_req_tp_rtp_addr(const struct tlv_parsed *tp, bool aoip, char *msc_rtp_addr, size_t msc_rtp_addr_len, uint16_t *msc_rtp_port, uint8_t *cause) { struct sockaddr_storage rtp_addr; @@ -927,7 +930,8 @@ return 0; } -static int bssmap_handle_ass_req_tp_osmux(struct gsm_subscriber_connection *conn, struct tlv_parsed *tp, +static int bssmap_handle_ass_req_tp_osmux(struct gsm_subscriber_connection *conn, + const struct tlv_parsed *tp, bool *use_osmux, uint8_t *osmux_cid, uint8_t *cause) { int rc; @@ -963,8 +967,9 @@ return 0; } -static int bssmap_handle_ass_req_tp_codec_list(struct gsm_subscriber_connection *conn, struct tlv_parsed *tp, bool aoip, - uint8_t *cause) +static int bssmap_handle_ass_req_tp_codec_list(struct gsm_subscriber_connection *conn, + const struct tlv_parsed *tp, + bool aoip, uint8_t *cause) { int rc; @@ -993,7 +998,7 @@ return 0; } -static int bssmap_handle_ass_req_tp_rtp_ext(struct tlv_parsed *tp, +static int bssmap_handle_ass_req_tp_rtp_ext(const struct tlv_parsed *tp, struct assignment_request *req, uint8_t *cause) { @@ -1013,8 +1018,10 @@ return 0; } -static int bssmap_handle_ass_req_ct_data(struct gsm_subscriber_connection *conn, struct tlv_parsed *tp, - struct gsm0808_channel_type *ct, struct assignment_request *req, +static int bssmap_handle_ass_req_ct_data(struct gsm_subscriber_connection *conn, + const struct tlv_parsed *tp, + const struct gsm0808_channel_type *ct, + struct assignment_request *req, uint8_t *cause) { bool aoip = gscon_is_aoip(conn); @@ -1045,9 +1052,12 @@ return 0; } -int bssmap_handle_ass_req_ct_speech(struct gsm_subscriber_connection *conn, struct gsm_bts *bts, - struct tlv_parsed *tp, struct gsm0808_channel_type *ct, - struct assignment_request *req, uint8_t *cause) +int bssmap_handle_ass_req_ct_speech(struct gsm_subscriber_connection *conn, + struct gsm_bts *bts, + const struct tlv_parsed *tp, + const struct gsm0808_channel_type *ct, + struct assignment_request *req, + uint8_t *cause) { bool aoip = gscon_is_aoip(conn); int rc; @@ -1084,8 +1094,10 @@ return 0; } -static int bssmap_handle_ass_req_ct_sign(struct gsm_subscriber_connection *conn, struct gsm0808_channel_type *ct, - struct assignment_request *req, uint8_t *cause) +static int bssmap_handle_ass_req_ct_sign(struct gsm_subscriber_connection *conn, + const struct gsm0808_channel_type *ct, + struct assignment_request *req, + uint8_t *cause) { int rc; -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/42584?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Iebb28d6ae0b468545994669248a442dd17f36d4c Gerrit-Change-Number: 42584 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[XS] Change in osmo-bsc[master]: bssap: use LOGPFSML in bssmap_handle_ass_req_tp_codec_list()
by fixeria 06 Apr '26

06 Apr '26

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/42586?usp=email ) Change subject: bssap: use LOGPFSML in bssmap_handle_ass_req_tp_codec_list() ...................................................................... bssap: use LOGPFSML in bssmap_handle_ass_req_tp_codec_list() Change-Id: Ie51ada174388f4c3e9ffe8a5bec4297bda38584b --- M src/osmo-bsc/osmo_bsc_bssap.c 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/86/42586/1 diff --git a/src/osmo-bsc/osmo_bsc_bssap.c b/src/osmo-bsc/osmo_bsc_bssap.c index dbd1a20..fa16aac 100644 --- a/src/osmo-bsc/osmo_bsc_bssap.c +++ b/src/osmo-bsc/osmo_bsc_bssap.c @@ -982,14 +982,14 @@ TLVP_VAL(tp, GSM0808_IE_SPEECH_CODEC_LIST), TLVP_LEN(tp, GSM0808_IE_SPEECH_CODEC_LIST)); if (rc < 0) { - LOGP(DMSC, LOGL_ERROR, "Unable to decode speech codec list\n"); + LOGPFSML(conn->fi, LOGL_ERROR, "Unable to decode speech codec list\n"); *cause = GSM0808_CAUSE_INCORRECT_VALUE; return -1; } } if (aoip && !conn->codec_list.len) { - LOGP(DMSC, LOGL_ERROR, "%s: AoIP Assignment Request:" + LOGPFSML(conn->fi, LOGL_ERROR, "%s: AoIP Assignment Request:" " Missing or empty Speech Codec List IE\n", bsc_subscr_name(conn->bsub)); *cause = GSM0808_CAUSE_INFORMATION_ELEMENT_OR_FIELD_MISSING; return -1; -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/42586?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ie51ada174388f4c3e9ffe8a5bec4297bda38584b Gerrit-Change-Number: 42586 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[XS] Change in osmo-bsc[master]: ipaccess: fix buffer overread in ipacc_parse_supp_flags()
by fixeria 06 Apr '26

06 Apr '26

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/42587?usp=email ) Change subject: ipaccess: fix buffer overread in ipacc_parse_supp_flags() ...................................................................... ipaccess: fix buffer overread in ipacc_parse_supp_flags() The loop used OSMO_MAX(e->len, 4), which iterates at least 4 times even when the IE is shorter than 4 bytes, causing a buffer overread. Replace with OSMO_MIN(e->len, sizeof(u32)) to cap the iteration both at the actual IE length and at the uint32_t accumulator size. Change-Id: I97c69a71eb650cbef1cc3652d0a2a966cfd6cf60 --- M src/osmo-bsc/bts_ipaccess_nanobts_omlattr.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/87/42587/1 diff --git a/src/osmo-bsc/bts_ipaccess_nanobts_omlattr.c b/src/osmo-bsc/bts_ipaccess_nanobts_omlattr.c index 23196fc..a197a79 100644 --- a/src/osmo-bsc/bts_ipaccess_nanobts_omlattr.c +++ b/src/osmo-bsc/bts_ipaccess_nanobts_omlattr.c @@ -47,7 +47,7 @@ { uint32_t u32 = 0; - for (unsigned int i = 0; i < OSMO_MAX(e->len, 4); i++) + for (unsigned int i = 0; i < OSMO_MIN(e->len, sizeof(u32)); i++) u32 |= e->val[i] << (i * 8); for (const struct value_string *vs = flags; vs->value && vs->str; vs++) { if (u32 & vs->value) -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/42587?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I97c69a71eb650cbef1cc3652d0a2a966cfd6cf60 Gerrit-Change-Number: 42587 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[M] Change in osmo-bsc[master]: ipaccess: store Supported Features IE to the MO state
by fixeria 06 Apr '26

06 Apr '26

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/42588?usp=email ) Change subject: ipaccess: store Supported Features IE to the MO state ...................................................................... ipaccess: store Supported Features IE to the MO state Change-Id: Ic89d42c478677ffda4d544f461e7850dd3157040 Related: OS#6324 --- M include/osmocom/bsc/gsm_data.h M src/osmo-bsc/bts_ipaccess_nanobts_omlattr.c 2 files changed, 104 insertions(+), 31 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/88/42588/1 diff --git a/include/osmocom/bsc/gsm_data.h b/include/osmocom/bsc/gsm_data.h index 63cc8e2..cb19536 100644 --- a/include/osmocom/bsc/gsm_data.h +++ b/include/osmocom/bsc/gsm_data.h @@ -533,6 +533,11 @@ uint8_t availability; }; +struct ipacc_supp_feat { + bool present; + uint32_t val; +}; + struct gsm_abis_mo { uint8_t obj_class; uint8_t procedure_pending; @@ -555,6 +560,18 @@ union { struct { uint8_t obj_version; + /* relevant for NM_OC_BTS */ + struct ipacc_supp_feat max_ta; + /* relevant for NM_OC_RADIO_CARRIER */ + struct ipacc_supp_feat freq_bands; + /* relevant for NM_OC_BASEB_TRANSC */ + struct ipacc_supp_feat ciph_algos; + struct ipacc_supp_feat chan_types; + struct ipacc_supp_feat chan_modes; + struct ipacc_supp_feat rtp_features; + struct ipacc_supp_feat rsl_features; + /* relevant for NM_OC_GPRS_CELL */ + struct ipacc_supp_feat gprs_coding; } ipaccess; }; }; diff --git a/src/osmo-bsc/bts_ipaccess_nanobts_omlattr.c b/src/osmo-bsc/bts_ipaccess_nanobts_omlattr.c index a197a79..34f3d02 100644 --- a/src/osmo-bsc/bts_ipaccess_nanobts_omlattr.c +++ b/src/osmo-bsc/bts_ipaccess_nanobts_omlattr.c @@ -40,29 +40,42 @@ } }; -static inline uint32_t ipacc_parse_supp_flags(const struct abis_om_fom_hdr *foh, - const struct value_string *flags, - const struct tlv_p_entry *e, - const char *text) +static void ipacc_parse_supp_flags(const struct abis_om_fom_hdr *foh, + const struct tlv_parsed *tp, + const enum ipac_eie tag, + struct ipacc_supp_feat *feat, + const struct value_string *flags, + const char *text) { - uint32_t u32 = 0; + const struct tlv_p_entry *e; - for (unsigned int i = 0; i < OSMO_MIN(e->len, sizeof(u32)); i++) - u32 |= e->val[i] << (i * 8); - for (const struct value_string *vs = flags; vs->value && vs->str; vs++) { - if (u32 & vs->value) - LOGPFOH(DNM, LOGL_INFO, foh, "%s '%s' is supported\n", text, vs->str); + feat->present = false; + feat->val = 0; + + if ((e = TLVP_GET(tp, tag)) == NULL) + return; + + for (unsigned int i = 0; i < OSMO_MIN(e->len, sizeof(feat->val)); i++) + feat->val |= e->val[i] << (i * 8); + feat->present = true; + + if (flags == NULL) { + LOGPFOH(DNM, LOGL_INFO, foh, "%s: %u\n", text, feat->val); + return; } - return u32; + for (const struct value_string *vs = flags; vs->value && vs->str; vs++) { + if (feat->val & vs->value) + LOGPFOH(DNM, LOGL_INFO, foh, "%s '%s' is supported\n", text, vs->str); + } } /* Parse ip.access Supported Features IE */ -int ipacc_parse_supp_features(const struct gsm_bts *bts, +int ipacc_parse_supp_features(struct gsm_bts *bts, const struct abis_om_fom_hdr *foh, const uint8_t *data, uint16_t data_len) { - const struct tlv_p_entry *e; + struct gsm_abis_mo *mo; struct tlv_parsed tp; if (tlv_parse(&tp, &ipacc_eie_tlv_def, data, data_len, 0, 0) < 0) { @@ -70,24 +83,67 @@ return -EINVAL; } - /* TODO: store the flags in the respective MO state */ - if ((e = TLVP_GET(&tp, NM_IPAC_EIE_FREQ_BANDS)) != NULL) - ipacc_parse_supp_flags(foh, abis_nm_ipacc_freq_band_desc, e, "Freq. band"); - if ((e = TLVP_GET(&tp, NM_IPAC_EIE_CIPH_ALGOS)) != NULL) - ipacc_parse_supp_flags(foh, abis_nm_ipacc_ciph_algo_desc, e, "Ciphering algorithm"); - if ((e = TLVP_GET(&tp, NM_IPAC_EIE_CHAN_TYPES)) != NULL) - ipacc_parse_supp_flags(foh, abis_nm_ipacc_chant_desc, e, "Channel type"); - if ((e = TLVP_GET(&tp, NM_IPAC_EIE_CHAN_MODES)) != NULL) - ipacc_parse_supp_flags(foh, abis_nm_ipacc_chanm_desc, e, "Channel mode"); - if ((e = TLVP_GET(&tp, NM_IPAC_EIE_GPRS_CODING)) != NULL) - ipacc_parse_supp_flags(foh, abis_nm_ipacc_gprs_coding_desc, e, "GPRS Coding Scheme"); - if ((e = TLVP_GET(&tp, NM_IPAC_EIE_RTP_FEATURES)) != NULL) - ipacc_parse_supp_flags(foh, abis_nm_ipacc_rtp_feat_desc, e, "RTP Feature"); - if ((e = TLVP_GET(&tp, NM_IPAC_EIE_RSL_FEATURES)) != NULL) - ipacc_parse_supp_flags(foh, abis_nm_ipacc_rsl_feat_desc, e, "RSL Feature"); - if (TLVP_PRES_LEN(&tp, NM_IPAC_EIE_MAX_TA, 1)) { - uint8_t u8 = *TLVP_VAL(&tp, NM_IPAC_EIE_MAX_TA); - LOGPFOH(DNM, LOGL_DEBUG, foh, "Max Timing Advance %u\n", u8); + /* store the flags to the respective MO state */ + mo = gsm_objclass2mo(bts, foh->obj_class, &foh->obj_inst); + if (mo == NULL) { + LOGPFOH(DNM, LOGL_ERROR, foh, + "%s(): gsm_objclass2mo() failed\n", __func__); + return -ENODEV; + } + + switch (mo->obj_class) { + case NM_OC_BTS: + ipacc_parse_supp_flags(foh, &tp, + NM_IPAC_EIE_MAX_TA, + &mo->ipaccess.max_ta, + NULL, "Max Timing Advance"); + break; + case NM_OC_RADIO_CARRIER: + ipacc_parse_supp_flags(foh, &tp, + NM_IPAC_EIE_FREQ_BANDS, + &mo->ipaccess.freq_bands, + abis_nm_ipacc_freq_band_desc, + "Freq. band"); + break; + case NM_OC_BASEB_TRANSC: + ipacc_parse_supp_flags(foh, &tp, + NM_IPAC_EIE_CIPH_ALGOS, + &mo->ipaccess.ciph_algos, + abis_nm_ipacc_ciph_algo_desc, + "Ciphering algorithm"); + ipacc_parse_supp_flags(foh, &tp, + NM_IPAC_EIE_CHAN_TYPES, + &mo->ipaccess.chan_types, + abis_nm_ipacc_chant_desc, + "Channel type"); + ipacc_parse_supp_flags(foh, &tp, + NM_IPAC_EIE_CHAN_MODES, + &mo->ipaccess.chan_modes, + abis_nm_ipacc_chanm_desc, + "Channel mode"); + ipacc_parse_supp_flags(foh, &tp, + NM_IPAC_EIE_RTP_FEATURES, + &mo->ipaccess.rtp_features, + abis_nm_ipacc_rtp_feat_desc, + "RTP Feature"); + ipacc_parse_supp_flags(foh, &tp, + NM_IPAC_EIE_RSL_FEATURES, + &mo->ipaccess.rsl_features, + abis_nm_ipacc_rsl_feat_desc, + "RSL Feature"); + break; + case NM_OC_GPRS_CELL: + ipacc_parse_supp_flags(foh, &tp, + NM_IPAC_EIE_GPRS_CODING, + &mo->ipaccess.gprs_coding, + abis_nm_ipacc_gprs_coding_desc, + "GPRS Coding Scheme"); + break; + default: + LOGPFOH(DNM, LOGL_NOTICE, foh, + "Unhandled NM_ATT_IPACC_SUPP_FEATURES IE: %s\n", + osmo_hexdump(data, data_len)); + return -ENOTSUP; } return 0; -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/42588?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ic89d42c478677ffda4d544f461e7850dd3157040 Gerrit-Change-Number: 42588 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[S] Change in osmo-ttcn3-hacks[master]: bsc: add TC_chan_act_nack_not_borken
by fixeria 06 Apr '26

06 Apr '26

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42583?usp=email ) Change subject: bsc: add TC_chan_act_nack_not_borken ...................................................................... bsc: add TC_chan_act_nack_not_borken Test that when the BTS NACKs a CHANnel ACTIVation with RSL_ERR_SERV_OPT_UNAVAIL or RSL_ERR_SERV_OPT_UNIMPL, the BSC: does NOT mark the lchan as BORKEN. Change-Id: I000b7b44749380c5af4da42abe37b4ada6e06ee4 Related: osmo-bsc.git Ide3830a697501a0c245a41451302f1e68d553b3c Related: OS#6324 --- M bsc/BSC_Tests.ttcn M bsc/expected-results.xml 2 files changed, 25 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/83/42583/1 diff --git a/bsc/BSC_Tests.ttcn b/bsc/BSC_Tests.ttcn index a4c666e..9911368 100644 --- a/bsc/BSC_Tests.ttcn +++ b/bsc/BSC_Tests.ttcn @@ -1623,6 +1623,29 @@ f_shutdown_helper(); } +/* Verify that a Chan Activ NACK with RSL_ERR_SERV_OPT_UNAVAIL or RSL_ERR_SERV_OPT_UNIMPL + * does not mark the lchan as BORKEN. The channel mode was not supported by the BTS, but + * the lchan hardware itself is fine and must remain available for future assignments. */ +testcase TC_chan_act_nack_not_borken() runs on test_CT { + var RSL_Message rx_rsl; + + f_init(1); + + f_ipa_tx(ts_RSL_CHAN_RQD('33'O, 33)); + rx_rsl := f_exp_ipa_rx(tr_RSL_CHAN_ACT); + f_ipa_tx(ts_RSL_CHAN_ACT_NACK(rx_rsl.ies[0].body.chan_nr, RSL_ERR_SERV_OPT_UNAVAIL)); + f_sleep(0.5); + f_vty_expect_borken(BSCVTY, false); + + f_ipa_tx(ts_RSL_CHAN_RQD('33'O, 33)); + rx_rsl := f_exp_ipa_rx(tr_RSL_CHAN_ACT); + f_ipa_tx(ts_RSL_CHAN_ACT_NACK(rx_rsl.ies[0].body.chan_nr, RSL_ERR_SERV_OPT_UNIMPL)); + f_sleep(0.5); + f_vty_expect_borken(BSCVTY, false); + + f_shutdown_helper(); +} + /* Test for channel exhaustion due to RACH overload */ testcase TC_chan_exhaustion() runs on test_CT { var ASP_RSL_Unitdata rsl_ud; @@ -12762,6 +12785,7 @@ execute( TC_chan_act_ack_est_ind_noreply() ); execute( TC_chan_act_ack_est_ind_refused() ); execute( TC_chan_act_nack() ); + execute( TC_chan_act_nack_not_borken() ); execute( TC_chan_exhaustion() ); execute( TC_chan_deact_silence() ); execute( TC_chan_rel_rll_rel_ind() ); diff --git a/bsc/expected-results.xml b/bsc/expected-results.xml index 90b613d..65a4ef1 100644 --- a/bsc/expected-results.xml +++ b/bsc/expected-results.xml @@ -35,6 +35,7 @@ <testcase classname='BSC_Tests' name='TC_chan_act_ack_est_ind_noreply' time='MASKED'/> <testcase classname='BSC_Tests' name='TC_chan_act_ack_est_ind_refused' time='MASKED'/> <testcase classname='BSC_Tests' name='TC_chan_act_nack' time='MASKED'/> + <testcase classname='BSC_Tests' name='TC_chan_act_nack_not_borken' time='MASKED'/> <testcase classname='BSC_Tests' name='TC_chan_exhaustion' time='MASKED'/> <testcase classname='BSC_Tests' name='TC_chan_deact_silence' time='MASKED'/> <testcase classname='BSC_Tests' name='TC_chan_rel_rll_rel_ind' time='MASKED'/> -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42583?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I000b7b44749380c5af4da42abe37b4ada6e06ee4 Gerrit-Change-Number: 42583 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[S] Change in osmo-ttcn3-hacks[master]: bsc: verify Cell ID in BSSMAP HandoverPerformed
by fixeria 06 Apr '26

06 Apr '26

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42582?usp=email ) Change subject: bsc: verify Cell ID in BSSMAP HandoverPerformed ...................................................................... bsc: verify Cell ID in BSSMAP HandoverPerformed As per 3GPP TS 48.008 §3.2.1.25, HANDOVER PERFORMED must report the target cell. Add an optional cell_id parameter to the template (defaulting to '?' for backward compatibility) and update the two intra-BSC handover test helpers to assert that the Cell Identifier IE carries the target BTS (BTS 1: MCC=001 MNC=01 LAC=1 CI=1). Also remove the unnecessary interleave wrapper in f_tc_ho_during_lcs_loc_req(): the two receives arrive on separate ports (RAN_CONN vs BSSAP_LE) so sequential receive is sufficient. Change-Id: I82aadcc3a80c183cb93522b829071294b156a218 Related: osmo-bsc.git I4111351dc38fc2dbe844c2bd07b3ecfaaadd864e --- M bsc/BSC_Tests.ttcn M library/BSSMAP_Templates.ttcn 2 files changed, 21 insertions(+), 10 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/82/42582/1 diff --git a/bsc/BSC_Tests.ttcn b/bsc/BSC_Tests.ttcn index e97ecb0..a4c666e 100644 --- a/bsc/BSC_Tests.ttcn +++ b/bsc/BSC_Tests.ttcn @@ -5887,8 +5887,14 @@ } /* Since this is an internal handover we expect the BSC to inform the - * MSC about the event */ - RAN_CONN.receive(tr_BSSMAP_HandoverPerformed); + * MSC about the event. The Cell Identifier must report the *target* BTS + * (BTS 1: MCC=001 MNC=01 LAC=1 CI=1), not the source BTS. */ + alt { + [] RAN_CONN.receive(tr_BSSMAP_HandoverPerformed(tr_CellId_CGI('00F110'O, 1, 1))); + [] RAN_CONN.receive(tr_BSSMAP_HandoverPerformed) { + setverdict(fail, "BSSMAP HandoverPerformed indicates unexpected Cell ID"); + } + } /* Check the amount of MGCP transactions is still consistant with the * test expectation */ @@ -10855,17 +10861,21 @@ [] as_handover(hs); } + /* Expect the BSC to inform the MSC about the handover. The Cell Identifier + * must report the *target* BTS (BTS 1: MCC=001 MNC=01 LAC=1 CI=1). */ + alt { + [] RAN_CONN.receive(tr_BSSMAP_HandoverPerformed(tr_CellId_CGI('00F110'O, 1, 1))); + [] RAN_CONN.receive(tr_BSSMAP_HandoverPerformed) { + setverdict(fail, "BSSMAP HandoverPerformed indicates unexpected Cell ID"); + } + } + var PDU_BSSAP_LE rx_bsslap; - interleave { - /* Expect the BSC to inform the MSC about the handover */ - [] RAN_CONN.receive(tr_BSSMAP_HandoverPerformed); - /* Expect the BSC to inform the SMLC about the handover */ - [] BSSAP_LE.receive(tr_BSSMAP_LE_ConnInfo(BSSMAP_LE_PROT_BSSLAP, ?)) -> value(rx_bsslap) { + BSSAP_LE.receive(tr_BSSMAP_LE_ConnInfo(BSSMAP_LE_PROT_BSSLAP, ?)) -> value(rx_bsslap) { f_match_bsslap(rx_bsslap, tr_BSSLAP_Reset(BSSLAP_CAUSE_INTRA_BSS_HO)); } - } /* SMLC now responds with geo information data. */ BSSAP_LE.send(ts_BSSMAP_LE_PerfLocResp(gad_ell_point_unc_circle, omit)); diff --git a/library/BSSMAP_Templates.ttcn b/library/BSSMAP_Templates.ttcn index 563d6d1..deeabda 100644 --- a/library/BSSMAP_Templates.ttcn +++ b/library/BSSMAP_Templates.ttcn @@ -1331,14 +1331,15 @@ } } -template PDU_BSSAP tr_BSSMAP_HandoverPerformed +template PDU_BSSAP +tr_BSSMAP_HandoverPerformed(template (present) BSSMAP_IE_CellIdentifier cell_id := ?) modifies tr_BSSAP_BSSMAP := { pdu := { bssmap := { handoverPerformed := { messageType := '17'O, cause := ?, - cellIdentifier := ?, + cellIdentifier := cell_id, chosenChannel := *, chosenEncryptionAlgorithm := *, speechVersion := *, -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42582?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I82aadcc3a80c183cb93522b829071294b156a218 Gerrit-Change-Number: 42582 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[S] Change in osmo-ttcn3-hacks[master]: library/RSL_Types: improve CHAN_ACTIV templates
by fixeria 06 Apr '26

06 Apr '26

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42581?usp=email ) Change subject: library/RSL_Types: improve CHAN_ACTIV templates ...................................................................... library/RSL_Types: improve CHAN_ACTIV templates Change-Id: I80af30fe9b24b93908876fd8059f45b6e3105406 --- M library/RSL_Types.ttcn 1 file changed, 8 insertions(+), 6 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/81/42581/1 diff --git a/library/RSL_Types.ttcn b/library/RSL_Types.ttcn index 4597cc0..d757731 100644 --- a/library/RSL_Types.ttcn +++ b/library/RSL_Types.ttcn @@ -1612,9 +1612,10 @@ /* DEDICATED CANNEL MANAGEMENT MESSAGES */ /* 8.4.1 BSC -> BTS */ - template (value) RSL_Message ts_RSL_CHAN_ACT(template (value) RslChannelNr chan_nr, - template (value) RSL_IE_ChannelMode mode, - template (value) RSL_IE_ActivationType at := c_RSL_IE_ActType_IA) := { + template (value) + RSL_Message ts_RSL_CHAN_ACT(template (value) RslChannelNr chan_nr, + template (value) RSL_IE_ChannelMode mode, + template (value) RSL_IE_ActivationType at := c_RSL_IE_ActType_IA) := { msg_disc := ts_RSL_MsgDisc(RSL_MDISC_DCHAN, false), msg_type := RSL_MT_CHAN_ACTIV, ies :={ @@ -1624,9 +1625,10 @@ /* lots of optional IEs */ } } - template RSL_Message tr_RSL_CHAN_ACT(template RslChannelNr chan_nr, - template RSL_IE_ChannelMode mode, - template (value) RSL_IE_ActivationType at := c_RSL_IE_ActType_IA) := { + template (present) RSL_Message + tr_RSL_CHAN_ACT(template (present) RslChannelNr chan_nr := ?, + template (present) RSL_IE_ChannelMode mode := ?, + template (present) RSL_IE_ActivationType at := ?) := { msg_disc := tr_RSL_MsgDisc(RSL_MDISC_DCHAN, false), msg_type := RSL_MT_CHAN_ACTIV, ies :={ -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42581?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I80af30fe9b24b93908876fd8059f45b6e3105406 Gerrit-Change-Number: 42581 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>

1 0

2026

2025

2024

2023

2022

gerrit-log April 2026