April 2026 - gerrit-log - lists.osmocom.org

[S] Change in osmo-bts[master]: osmo-bts-omldummy: properly report NM_ATT_IPACC_SUPP_FEATURES
by laforge 07 Apr '26

07 Apr '26

Attention is currently required from: fixeria. laforge has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-bts/+/42596?usp=email ) Change subject: osmo-bts-omldummy: properly report NM_ATT_IPACC_SUPP_FEATURES ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/42596?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I7fe83f78c829c300e70a59509847b815a77974d7 Gerrit-Change-Number: 42596 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 07 Apr 2026 10:14:23 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in osmo-bts[master]: osmo-bts-omldummy: properly report NM_ATT_IPACC_SUPP_FEATURES
by jolly 07 Apr '26

07 Apr '26

Attention is currently required from: fixeria. jolly has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-bts/+/42596?usp=email ) Change subject: osmo-bts-omldummy: properly report NM_ATT_IPACC_SUPP_FEATURES ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/42596?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I7fe83f78c829c300e70a59509847b815a77974d7 Gerrit-Change-Number: 42596 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 07 Apr 2026 09:51:57 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in osmo-bts[master]: osmo-bts-omldummy: properly report NM_ATT_IPACC_SUPP_FEATURES
by fixeria 07 Apr '26

07 Apr '26

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/42596?usp=email ) Change subject: osmo-bts-omldummy: properly report NM_ATT_IPACC_SUPP_FEATURES ...................................................................... osmo-bts-omldummy: properly report NM_ATT_IPACC_SUPP_FEATURES osmo-bts-omldummy is used as the OML backend in the ttcn3-bsc-test. The common OML code encodes bts->support.* and trx->support.* fields verbatim into the IPA Supported Features IE (NM_ATT_IPACC_SUPP_FEATURES) in Get Attributes Responses. Since bts_model_init() and bts_model_trx_init() never initialized these fields, they were reported as all-zeros to osmo-bsc. osmo-bsc now inspects the supported channel modes before activating a channel. An all-zero chan_modes value (present but no bits set) causes osmo-bsc to reject every speech mode, breaking all assignment-related TTCN-3 test cases. Initialize ciphers, gprs_codings, freq_bands, chan_types and chan_modes to sensible values, matching what osmo-bts-virtual does, so that osmo-bts-omldummy reports its capabilities correctly. Change-Id: I7fe83f78c829c300e70a59509847b815a77974d7 Fixes: 0978d1df ("oml: implement handling of NM_ATT_IPACC_SUPP_FEATURES") Related: OS#6324 --- M src/osmo-bts-omldummy/bts_model.c 1 file changed, 22 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/96/42596/1 diff --git a/src/osmo-bts-omldummy/bts_model.c b/src/osmo-bts-omldummy/bts_model.c index 0690d9d..8abca39 100644 --- a/src/osmo-bts-omldummy/bts_model.c +++ b/src/osmo-bts-omldummy/bts_model.c @@ -172,6 +172,9 @@ int bts_model_init(struct gsm_bts *bts) { bts->variant = BTS_OSMO_OMLDUMMY; + bts->support.ciphers = CIPHER_A5(1) | CIPHER_A5(2) | CIPHER_A5(3) | CIPHER_A5(4); + bts->gprs.cell.support.gprs_codings = NM_IPAC_MASK_GPRS_CODING_CS + | NM_IPAC_MASK_GPRS_CODING_MCS; /* order alphabetically */ osmo_bts_set_feature(bts->features, BTS_FEAT_BCCH_POWER_RED); osmo_bts_set_feature(bts->features, BTS_FEAT_CBCH); @@ -186,6 +189,25 @@ struct trx_power_params *tpp = &trx->power_params; /* Speed up shutdown, we don't care about power ramping in omldummy */ tpp->ramp.step_interval_sec = 0; + /* Frequency bands indicated to the BSC */ + trx->support.freq_bands = NM_IPAC_F_FREQ_BAND_PGSM + | NM_IPAC_F_FREQ_BAND_EGSM + | NM_IPAC_F_FREQ_BAND_RGSM + | NM_IPAC_F_FREQ_BAND_DCS + | NM_IPAC_F_FREQ_BAND_PCS + | NM_IPAC_F_FREQ_BAND_850 + | NM_IPAC_F_FREQ_BAND_480 + | NM_IPAC_F_FREQ_BAND_450; + + /* Channel types and modes indicated to the BSC */ + trx->support.chan_types = NM_IPAC_MASK_CHANT_COMMON + | NM_IPAC_F_CHANT_BCCH_SDCCH4_CBCH + | NM_IPAC_F_CHANT_SDCCH8_CBCH + | NM_IPAC_F_CHANT_PDCHF + | NM_IPAC_F_CHANT_TCHF_PDCHF; + trx->support.chan_modes = NM_IPAC_MASK_CHANM_SPEECH + | NM_IPAC_MASK_CHANM_CSD_NT + | NM_IPAC_MASK_CHANM_CSD_T; return 0; } -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/42596?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I7fe83f78c829c300e70a59509847b815a77974d7 Gerrit-Change-Number: 42596 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[M] Change in osmo-bsc[master]: assignment_fsm: check ipaccess channel mode support
by fixeria 07 Apr '26

07 Apr '26

fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-bsc/+/42590?usp=email ) Change subject: assignment_fsm: check ipaccess channel mode support ...................................................................... Set Ready For Review -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/42590?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I680ba7993786f5486d671f931e75df4543670a37 Gerrit-Change-Number: 42590 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Comment-Date: Tue, 07 Apr 2026 09:21:59 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No

1 0

[XS] Change in osmo-sgsn[master]: tests/osmo-sgsn_test-nodes.vty: add missing list entries
by lynxis lazus 07 Apr '26

07 Apr '26

Attention is currently required from: fixeria. lynxis lazus has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/42595?usp=email ) Change subject: tests/osmo-sgsn_test-nodes.vty: add missing list entries ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/42595?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I6b4cbbae30c602d0fd4ef9b2f91c97f20217eb53 Gerrit-Change-Number: 42595 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 07 Apr 2026 08:20:22 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in osmo-sgsn[master]: gprs_sm: QoS: make max-sdu-size configurable
by lynxis lazus 07 Apr '26

07 Apr '26

Attention is currently required from: fixeria. lynxis lazus has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/40822?usp=email ) Change subject: gprs_sm: QoS: make max-sdu-size configurable ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/40822?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I0819da18dafecf322f8902643dae8dbcaa5dc98b Gerrit-Change-Number: 40822 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 07 Apr 2026 08:20:10 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in osmo-sgsn[master]: gprs_gmm: gsm48_rx_gmm_att_req(): drop stale PDP contexts on re-Attach
by fixeria 07 Apr '26

07 Apr '26

Attention is currently required from: lynxis lazus. fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/42594?usp=email ) Change subject: gprs_gmm: gsm48_rx_gmm_att_req(): drop stale PDP contexts on re-Attach ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > I would like to postpone this patch until the vlr patch series has been applied. Fine with me, as long as this does not get blocked for half of a year. -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/42594?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I20c1f5f741275115635188b2f4b1c5fe7c6e40f1 Gerrit-Change-Number: 42594 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Tue, 07 Apr 2026 08:19:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: lynxis lazus <lynxis(a)fe80.eu>

1 0

[S] Change in osmo-sgsn[master]: gprs_sm: gsm48_tx_gsm_act_pdp_acc(): fix QoS profile length
by lynxis lazus 07 Apr '26

07 Apr '26

Attention is currently required from: canghaiwuhen, fixeria, laforge, pespin. lynxis lazus has posted comments on this change by canghaiwuhen. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/42050?usp=email ) Change subject: gprs_sm: gsm48_tx_gsm_act_pdp_acc(): fix QoS profile length ...................................................................... Patch Set 19: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/42050?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I11c24b64f0e49cf80c825969dbf018b2948d855c Gerrit-Change-Number: 42050 Gerrit-PatchSet: 19 Gerrit-Owner: canghaiwuhen <canghaiwuhen(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: canghaiwuhen <canghaiwuhen(a)gmail.com> Gerrit-Comment-Date: Tue, 07 Apr 2026 08:15:17 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in osmo-sgsn[master]: gprs_gmm: gsm48_rx_gmm_att_req(): drop stale PDP contexts on re-Attach
by lynxis lazus 07 Apr '26

07 Apr '26

Attention is currently required from: fixeria. lynxis lazus has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/42594?usp=email ) Change subject: gprs_gmm: gsm48_rx_gmm_att_req(): drop stale PDP contexts on re-Attach ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: I would like to postpone this patch until the vlr patch series has been applied. -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/42594?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I20c1f5f741275115635188b2f4b1c5fe7c6e40f1 Gerrit-Change-Number: 42594 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 07 Apr 2026 08:14:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[M] Change in osmo-sgsn[master]: gprs_sm: QoS: make max-sdu-size configurable
by fixeria 06 Apr '26

06 Apr '26

fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/40822?usp=email ) Change subject: gprs_sm: QoS: make max-sdu-size configurable ...................................................................... Set Ready For Review -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/40822?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I0819da18dafecf322f8902643dae8dbcaa5dc98b Gerrit-Change-Number: 40822 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Comment-Date: Mon, 06 Apr 2026 16:55:51 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No

1 0

2026

2025

2024

2023

2022

gerrit-log April 2026