lists.osmocom.org
Sign In Sign Up
Manage this list Sign In Sign Up

Keyboard Shortcuts

Thread View

  • j: Next unread message
  • k: Previous unread message
  • j a: Jump to all threads
  • j l: Jump to MailingList overview

gerrit-log

Thread Start a new thread
Download
Threads by month
  • ----- 2026 -----
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2025 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2024 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2023 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2022 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
gerrit-log@lists.osmocom.org

November 2026

  • 1 participants
  • 714 discussions
[S] Change in osmo-ttcn3-hacks[master]: s1gw/osmo-s1gw.config: modernize the config syntax
by fixeria 08 Nov '26

08 Nov '26
fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/44041?usp=email ) Change subject: s1gw/osmo-s1gw.config: modernize the config syntax ...................................................................... s1gw/osmo-s1gw.config: modernize the config syntax Change-Id: I0f7130616ca7b1601ff3f87086dd7b39c3d375e9 Related: osmo-s1gw.git a6a31cf ("config/sys.config: group pfcp_peer params into a map") Related: osmo-s1gw.git ade7e52 ("mme_registry: the MME registry (pool) implementation") Related: osmo-s1gw.git 75a7446 ("mme_registry: add backwards compat for old sctp_client config") --- M s1gw/osmo-s1gw.config 1 file changed, 7 insertions(+), 8 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/41/44041/1 diff --git a/s1gw/osmo-s1gw.config b/s1gw/osmo-s1gw.config index 5788446..be9974d 100644 --- a/s1gw/osmo-s1gw.config +++ b/s1gw/osmo-s1gw.config @@ -15,12 +15,6 @@ }}, %% SCTP client configuration {sctp_client, #{ - %% local (bind) address for outgoing connections to the MME - laddr => "127.0.2.1", - %% remote address for outgoing connections to the MME - raddr => "127.0.2.10", - %% remote port for outgoing connections to the MME - rport => 36412, %% socket options (if omitted or left empty, defaults apply) sockopts => #{ } }}, @@ -30,8 +24,13 @@ #{name => "mme1", laddr => "127.0.2.1", raddr => "127.0.2.11"}, #{name => "mme2", laddr => "127.0.2.1", raddr => "127.0.2.12"} ]}, - {pfcp_loc_addr, "127.0.3.1"}, %% local address for incoming PFCP PDUs from the UPF - {pfcp_rem_addr, "127.0.3.10"} %% remote address for outgoing PFCP PDUs to the UPF + %% PFCP peer (UPF) configuration + {pfcp_peer, #{ + %% local address for incoming PFCP PDUs from the UPF + laddr => "127.0.3.1", + %% remote address for outgoing PFCP PDUs to the UPF + raddr => "127.0.3.10" + }} ]}, %% ================================================================================ %% kernel config -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/44041?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I0f7130616ca7b1601ff3f87086dd7b39c3d375e9 Gerrit-Change-Number: 44041 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
1 0
0 0
[XS] Change in osmo-ttcn3-hacks[master]: s1gw/testenv.cfg: remove program_latest=
by fixeria 08 Nov '26

08 Nov '26
fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/44040?usp=email ) Change subject: s1gw/testenv.cfg: remove program_latest= ...................................................................... s1gw/testenv.cfg: remove program_latest= The osmo-s1gw launcher loads /etc/osmocom/osmo-s1gw.config by default unless a '-c CONFIG' is given explicitly. Since we still run the -latest package with ERL_FLAGS="-config osmo-s1gw.config", our test's osmo-s1gw.config is simply merged on top of the packaged default, per application-parameter rather than replacing it. This has been the case since we tagged 0.4.0 (Dec 6 2025) and there were no problems until we tagged 0.5.0 (Nov 6 2026). The new release changed the PFCP configuration syntax: after grouping the PFCP params into a 'pfcp_peer' map, the packaged default carries that map, which wins over the legacy pfcp_loc_addr/pfcp_rem_addr keys in our test config, so osmo-s1gw talked PFCP to the wrong UPF address and every test failed with a PFCP association timeout. Change-Id: Ibf4d0d068ca2f12f4d04dd696e6eaa46f67c2e0b Related: osmo-s1gw.git a6a31cf ("config/sys.config: group pfcp_peer params into a map") --- M s1gw/testenv.cfg 1 file changed, 0 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/40/44040/1 diff --git a/s1gw/testenv.cfg b/s1gw/testenv.cfg index 5ddc9de..692e0b4 100644 --- a/s1gw/testenv.cfg +++ b/s1gw/testenv.cfg @@ -7,5 +7,3 @@ make=osmo-s1gw package=osmo-s1gw copy=osmo-s1gw.config -# Remove *_latest after osmo-s1gw >= 0.3.x is released -program_latest=ERL_FLAGS="-config osmo-s1gw.config" osmo-s1gw -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/44040?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ibf4d0d068ca2f12f4d04dd696e6eaa46f67c2e0b Gerrit-Change-Number: 44040 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
1 0
0 0
[XS] Change in ...osmo-s1gw[master]: doc/manuals: fix the Asciidoc source code URL
by fixeria 08 Nov '26

08 Nov '26
fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/44039?usp=email ) Change subject: doc/manuals: fix the Asciidoc source code URL ...................................................................... doc/manuals: fix the Asciidoc source code URL Change-Id: I858f1b414f3ebed14075b54ec151f0973266748d --- M doc/manuals/osmo-s1gw-usermanual-docinfo.xml 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/erlang/osmo-s1gw refs/changes/39/44039/1 diff --git a/doc/manuals/osmo-s1gw-usermanual-docinfo.xml b/doc/manuals/osmo-s1gw-usermanual-docinfo.xml index 27fd2f3..f8037e5 100644 --- a/doc/manuals/osmo-s1gw-usermanual-docinfo.xml +++ b/doc/manuals/osmo-s1gw-usermanual-docinfo.xml @@ -31,8 +31,8 @@ </para> <para> The Asciidoc source code of this manual can be found at - <ulink url="https://gitea.osmocom.org/osmocom/osmo-s1gw"> - https://gitea.osmocom.org/osmocom/osmo-s1gw + <ulink url="https://gitea.osmocom.org/erlang/osmo-s1gw"> + https://gitea.osmocom.org/erlang/osmo-s1gw </ulink> </para> </legalnotice> -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/44039?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: I858f1b414f3ebed14075b54ec151f0973266748d Gerrit-Change-Number: 44039 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
1 0
0 0
[M] Change in osmo-msc[master]: mgw: add "X-Side: CN" / "X-Side: RAN" to emitted CRCX
by laforge 08 Nov '26

08 Nov '26
Attention is currently required from: falconia, pespin. laforge has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/osmo-msc/+/44001?usp=email ) Change subject: mgw: add "X-Side: CN" / "X-Side: RAN" to emitted CRCX ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/44001?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Ie26ece9035ee579f2af84a13d71a553f98817592 Gerrit-Change-Number: 44001 Gerrit-PatchSet: 2 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: falconia <falcon(a)freecalypso.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Sun, 08 Nov 2026 14:28:38 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes
1 0
0 0
[M] Change in osmo-msc[master]: mgw: add "X-Side: CN" / "X-Side: RAN" to emitted CRCX
by falconia 07 Nov '26

07 Nov '26
Attention is currently required from: pespin. falconia has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/osmo-msc/+/44001?usp=email ) Change subject: mgw: add "X-Side: CN" / "X-Side: RAN" to emitted CRCX ...................................................................... Patch Set 2: (2 comments) This change is ready for review. Patchset: PS1: > Debian build failure happens because that Jenkins job uses deb packages for all dependencies, buildi […] Done PS1: > It probably makes sense to have transmission of this mgcp extension configurable over VTY. The new patch version includes vty option to enable or disable the sending of X-Side extension parameter. -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/44001?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Ie26ece9035ee579f2af84a13d71a553f98817592 Gerrit-Change-Number: 44001 Gerrit-PatchSet: 2 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Sat, 07 Nov 2026 11:44:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: falconia <falcon(a)freecalypso.org> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
1 0
0 0
[XL] Change in pysim[master]: esim/asn1: add the SGP.22 v3.1 RSPDefinitions module as rsp_v3
by laforge 07 Nov '26

07 Nov '26
Attention is currently required from: hampushellsberg. laforge has posted comments on this change by hampushellsberg. ( https://gerrit.osmocom.org/c/pysim/+/44007?usp=email ) Change subject: esim/asn1: add the SGP.22 v3.1 RSPDefinitions module as rsp_v3 ...................................................................... Patch Set 1: (1 comment) File pySim/esim/rsp.py: https://gerrit.osmocom.org/c/pysim/+/44007/comment/6384ecef_8e19aac2?usp=em… : PS1, Line 35: asn1_v3 > Yes: lru_cache runs the compile once, on the first call, and returns the same module after that. […] Ideally i would have something that looks like a variable at module level (or an instance variable, if esim.rsp was a class), but which would incur the runtime overhead at first access (like your function) instead of at module load time (like the existing approach). I'm not sure if there is any syntactic sugar in python that can be used for this? -- To view, visit https://gerrit.osmocom.org/c/pysim/+/44007?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I670ec73f9958882a8d3fe4b589bdafa3fbf702ea Gerrit-Change-Number: 44007 Gerrit-PatchSet: 1 Gerrit-Owner: hampushellsberg <hampushellsberg(a)gmail.com> Gerrit-CC: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: hampushellsberg <hampushellsberg(a)gmail.com> Gerrit-Comment-Date: Sat, 07 Nov 2026 11:12:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: hampushellsberg <hampushellsberg(a)gmail.com> Comment-In-Reply-To: laforge <laforge(a)osmocom.org>
1 0
0 0
[XS] Change in osmo-msc[master]: mm-info: properly encode length 8n-1 network names
by laforge 07 Nov '26

07 Nov '26
laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/43918?usp=email ) Change subject: mm-info: properly encode length 8n-1 network names ...................................................................... mm-info: properly encode length 8n-1 network names Because of the way CBS-format GSM messages are encoded (see 3GPP TS 23.038 6.1.2.3.1), messages of length 8n-1 require an special padding character to avoid being interpreted as a message of length 8n with some extra character postpended (commonly an @ character in the case of all zeroes, this case is explicitly mentioned in the aformentioned spec). Using the already existing gsm_7bit_encode_n_ussd instead of the SMS format gsm_7bit_encode_n resolves this issue of network names of length 8n-1 (commonly 7) showing with an erroneous @ character postpended on the end of the network name. Note: because gsm_7bit_encode_n_ussd relies on the returned octets pointer from gsm_7bit_encode_n, osmo-msc will segfault if NULL is passed to the USSD encode function. Unless a patch is wanted in libosmocore, a temporary octets variable works fine. Change-Id: Ib8328cd2c9984b490951d39f21e86a4ef63e35d5 Related: OS#6847 --- M src/libmsc/gsm_04_08.c 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified laforge: Looks good to me, approved fixeria: Looks good to me, but someone else must approve diff --git a/src/libmsc/gsm_04_08.c b/src/libmsc/gsm_04_08.c index 0347f63..8a303d4 100644 --- a/src/libmsc/gsm_04_08.c +++ b/src/libmsc/gsm_04_08.c @@ -469,7 +469,7 @@ struct msgb *msg = gsm48_msgb_alloc_name("GSM 04.08 MM INF"); struct gsm48_hdr *gh; uint8_t *ptr8; - int name_len, name_pad; + int name_len, name_pad, octets; time_t cur_t; struct tm* gmt_time; @@ -508,7 +508,7 @@ ptr8[2] = 0x80 | name_pad; /* Cell Broadcast DCS, no CI */ ptr8 = msgb_put(msg, name_len); - gsm_7bit_encode_n(ptr8, name_len, net->name_long, NULL); + gsm_7bit_encode_n_ussd(ptr8, name_len, net->name_long, &octets); } @@ -536,7 +536,7 @@ ptr8[2] = 0x80 | name_pad; /* Cell Broadcast DCS, no CI */ ptr8 = msgb_put(msg, name_len); - gsm_7bit_encode_n(ptr8, name_len, net->name_short, NULL); + gsm_7bit_encode_n_ussd(ptr8, name_len, net->name_short, &octets); } -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/43918?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Ib8328cd2c9984b490951d39f21e86a4ef63e35d5 Gerrit-Change-Number: 43918 Gerrit-PatchSet: 1 Gerrit-Owner: tempest <jackleea1b(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
1 0
0 0
[XS] Change in osmo-msc[master]: mm-info: properly encode length 8n-1 network names
by laforge 07 Nov '26

07 Nov '26
Attention is currently required from: tempest. laforge has posted comments on this change by tempest. ( https://gerrit.osmocom.org/c/osmo-msc/+/43918?usp=email ) Change subject: mm-info: properly encode length 8n-1 network names ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/43918?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Ib8328cd2c9984b490951d39f21e86a4ef63e35d5 Gerrit-Change-Number: 43918 Gerrit-PatchSet: 1 Gerrit-Owner: tempest <jackleea1b(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: tempest <jackleea1b(a)gmail.com> Gerrit-Comment-Date: Sat, 07 Nov 2026 11:10:43 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes
1 0
0 0
[M] Change in osmo-msc[master]: add configurable DTMF support via RTP or SIP
by falconia 07 Nov '26

07 Nov '26
Attention is currently required from: lynxis lazus. falconia has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-msc/+/44024?usp=email ) Change subject: add configurable DTMF support via RTP or SIP ...................................................................... Patch Set 1: (3 comments) File include/osmocom/msc/gsm_data.h: https://gerrit.osmocom.org/c/osmo-msc/+/44024/comment/79156a9d_0e810196?usp… : PS1, Line 149: DTMF_MODE_SIP = 0, /* forward via MNCC to SIP connector (default) */ > Acknowledged I second the request to change the naming from SIP to MNCC. In Osmocom+ThemWi hybrid networks like the one being built by American 2G Cooperative, the MNCC system connected to osmo-msc is absolutely not SIP - while we do have SIP-I deeper in the CN, there is no osmo-sip-connector and no SIP directly coupled to osmo-msc. https://gerrit.osmocom.org/c/osmo-msc/+/44024/comment/d6eeae28_3f508394?usp… : PS1, Line 150: DTMF_MODE_RTP, /* RFC 4733 telephone-event via MGCP RQNT */ > Acknowledged, I when I read "DTMF via RTP" i was immediately thinking of in-line tones being injecte […] In the network being built by A2GC, we are in fact injecting actual DTMF waveforms into the G.711 PCM sample stream generated by our transcoding MGW! Hence I vote for a name like MGCP_RQNT (out of @pespin@sysmocom.de's suggestions), as opposed to something that refers specifically to RFC 4733 to the exclusion of the in-band option. File src/libmsc/msc_vty.c: https://gerrit.osmocom.org/c/osmo-msc/+/44024/comment/040517f3_6cf48084?usp… : PS1, Line 691: rtp|sip Can we please make it `(mgw|mncc)` instead? This way it will cover alternative possibilities of MNCC being non-SIP and the MGW being a transcoder that can do either RFC 4733 or in-band. -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/44024?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Icd33a0b412f39a56046e57038551332776be2ba1 Gerrit-Change-Number: 44024 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: falconia <falcon(a)freecalypso.org> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Sat, 07 Nov 2026 09:57:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
1 0
0 0
[XL] Change in onomondo-eim[master]: contrib/sample_ssl_certs: add scripts to generate SSL certificates
by laforge 06 Nov '26

06 Nov '26
Attention is currently required from: dexter. laforge has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/onomondo-eim/+/44033?usp=email ) Change subject: contrib/sample_ssl_certs: add scripts to generate SSL certificates ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: > To get rid of the jenkins lint errors, add these lines to `.checkpatch.conf`: […] Acknowledged -- To view, visit https://gerrit.osmocom.org/c/onomondo-eim/+/44033?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: onomondo-eim Gerrit-Branch: master Gerrit-Change-Id: Ie75293e5177ccacc45e11d85ef526159e999b7bb Gerrit-Change-Number: 44033 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Fri, 06 Nov 2026 12:43:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <osmith(a)sysmocom.de>
1 0
0 0
  • ← Newer
  • 1
  • ...
  • 53
  • 54
  • 55
  • 56
  • 57
  • 58
  • 59
  • ...
  • 72
  • Older →

HyperKitty Powered by HyperKitty version 1.3.12.