Attention is currently required from: fixeria, osmith, pespin.
Hello Jenkins Builder, fixeria, osmith,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/libosmo-sigtran/+/43763?usp=email
to look at the new patch set (#6).
The following approvals got outdated and were removed:
Code-Review+1 by fixeria, Code-Review+1 by osmith, Verified+1 by Jenkins Builder
Change subject: sccp: Introduce N-DISCONNECT.req/ind Release/Refusal reason
......................................................................
sccp: Introduce N-DISCONNECT.req/ind Release/Refusal reason
N-DISCONNECT.req has a "Reason" Parameter. the "Reason" Parameter is
mandatory according to Table 6/Q.711. The options possible for the
"Reason" can be found in ITU Q.711 "6.1.1.2.4 Release phase", and
contain no explicit value. That enum is different from the wire-format
defined in:
* ITU-T Q.713, Section 3.11 Release cause
* ITU-T Q.713 Section 3.15 Refusal cause
Actually, ITU-T Q.713 "ANNEX A" describes a mapping between the former
(N-DISCONNECT.req Reason) and the later (SCCP Release/Refusal cause).
Use that table to translate as much as possible between the two (despite
the mapping is described as being one-to-one, well, it leaves a lot to
interpretation due to missing enums, N-to-M mappings, etc.).
Related: OS#2601
Change-Id: I158463c2e9b34abe06554371d628e4fa7ea8c5c1
---
M TODO-RELEASE
M include/osmocom/sigtran/sccp_sap.h
M src/sccp_connection.c
M src/sccp_connection.h
M src/sccp_sap.c
M src/sccp_scoc.c
M src/sccp_scoc_fsm.c
M src/sccp_user.h
8 files changed, 431 insertions(+), 6 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/63/43763/6
--
To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/43763?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: libosmo-sigtran
Gerrit-Branch: master
Gerrit-Change-Id: I158463c2e9b34abe06554371d628e4fa7ea8c5c1
Gerrit-Change-Number: 43763
Gerrit-PatchSet: 6
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Attention is currently required from: lynxis lazus.
pespin has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/39562?usp=email )
Change subject: Rework SGSN code to use new libvlr code
......................................................................
Patch Set 24: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/39562?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-Change-Id: I9c5b4ec1b337c35e85c2d1a3d09b318380ae6ef8
Gerrit-Change-Number: 39562
Gerrit-PatchSet: 24
Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Comment-Date: Wed, 07 Oct 2026 10:32:45 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: lynxis lazus.
pespin has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/39562?usp=email )
Change subject: Rework SGSN code to use new libvlr code
......................................................................
Patch Set 24:
(1 comment)
File tests/osmo-sgsn_test-nodes.vty:
https://gerrit.osmocom.org/c/osmo-sgsn/+/39562/comment/c9f7603f_a81d1aeb?us… :
PS23, Line 36: imsi-acl (add|del) IMSI
> I merged the commit which removed imsi-acl stuff into this one because you sad, this is missing here […]
Done in previous commit.
--
To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/39562?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-Change-Id: I9c5b4ec1b337c35e85c2d1a3d09b318380ae6ef8
Gerrit-Change-Number: 39562
Gerrit-PatchSet: 24
Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Comment-Date: Wed, 07 Oct 2026 10:29:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Comment-In-Reply-To: lynxis lazus <lynxis(a)fe80.eu>
Attention is currently required from: lynxis lazus.
pespin has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/43798?usp=email )
Change subject: Remove authentication acls and auth policy != REMOTE
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
File src/sgsn/sgsn_auth.c:
https://gerrit.osmocom.org/c/osmo-sgsn/+/43798/comment/7ede0069_78230629?us… :
PS1, Line 49: return SGSN_AUTH_REJECTED;
AFAIU it should be possible to drop the SGSN_AUTH_POLICY_* above in this same commit, since they are not used anymore.
--
To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/43798?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-Change-Id: Iea267bfbd9e0f3d1ba00c6d8d8f308b24e8ec6d4
Gerrit-Change-Number: 43798
Gerrit-PatchSet: 1
Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: Jenkins Builder
Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Comment-Date: Wed, 07 Oct 2026 10:29:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Attention is currently required from: pespin.
fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/43763?usp=email )
Change subject: sccp: Introduce N-DISCONNECT.req/ind Release/Refusal reason
......................................................................
Patch Set 4: Code-Review+1
Copied votes on follow-up patch sets have been updated:
* Code-Review+1 has been copied to patch set 5 (copy condition: "changekind:NO_CHANGE OR changekind:TRIVIAL_REBASE OR is:MIN").
(2 comments)
File src/sccp_scoc.c:
https://gerrit.osmocom.org/c/libosmo-sigtran/+/43763/comment/014e412d_9e880… :
PS4, Line 341: xua_msg_add_u32(xua, SUA_IEI_CAUSE, SUA_CAUSE_T_RELEASE | scu_rel_reason_to_sccp_release_cause(prim->u.disconnect.originator, prim->u.disconnect.cause));
cosmetic: line is too long
https://gerrit.osmocom.org/c/libosmo-sigtran/+/43763/comment/1bde46a7_8997e… :
PS4, Line 376: xua_msg_add_u32(xua, SUA_IEI_CAUSE, SUA_CAUSE_T_REFUSAL | scu_rel_reason_to_sccp_refusal_cause(prim->u.disconnect.originator, prim->u.disconnect.cause));
cosmetic: line is too long
--
To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/43763?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: libosmo-sigtran
Gerrit-Branch: master
Gerrit-Change-Id: I158463c2e9b34abe06554371d628e4fa7ea8c5c1
Gerrit-Change-Number: 43763
Gerrit-PatchSet: 4
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 07 Oct 2026 10:25:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Attention is currently required from: fixeria.
pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/43797?usp=email )
Change subject: tests: ss7_test: Check stderr output
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS1:
> You may want to disable color in logging to make `ss7_test.err` easier to read.
Done
--
To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/43797?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: libosmo-sigtran
Gerrit-Branch: master
Gerrit-Change-Id: I285eaeaa05e3651b0e4a69b3982d9b750cec92f0
Gerrit-Change-Number: 43797
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 07 Oct 2026 10:22:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>