October 2026 - gerrit-log - lists.osmocom.org

[M] Change in libosmo-sigtran[master]: tests: ss7_test: Check stderr output
by pespin 07 Oct '26

07 Oct '26

pespin has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/43797?usp=email ) Change subject: tests: ss7_test: Check stderr output ...................................................................... tests: ss7_test: Check stderr output The content of the file was outdated since it wasn't being checked, update it. Change-Id: I285eaeaa05e3651b0e4a69b3982d9b750cec92f0 --- M tests/ss7/ss7_test.c M tests/ss7/ss7_test.err M tests/testsuite.at 3 files changed, 100 insertions(+), 51 deletions(-) Approvals: osmith: Looks good to me, approved fixeria: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/tests/ss7/ss7_test.c b/tests/ss7/ss7_test.c index c092d4e..f2abb08 100644 --- a/tests/ss7/ss7_test.c +++ b/tests/ss7/ss7_test.c @@ -464,7 +464,13 @@ msgb_talloc_ctx_init(tall_ctx, 0); osmo_init_logging2(tall_ctx, &log_info); + log_set_print_category(osmo_stderr_target, 1); + log_set_print_category_hex(osmo_stderr_target, 0); + log_set_print_level(osmo_stderr_target, 1); log_set_print_filename2(osmo_stderr_target, LOG_FILENAME_NONE); + log_set_use_color(osmo_stderr_target, 0); + + osmo_fsm_log_addr(false); for (i = 0; i < ARRAY_SIZE(log_cats); i++) log_set_category_filter(osmo_stderr_target, log_cats[i], 1, LOGL_DEBUG); @@ -473,7 +479,6 @@ int main(int argc, char **argv) { init_logging(); - osmo_fsm_log_addr(false); /* init */ OSMO_ASSERT(osmo_ss7_init() == 0); diff --git a/tests/ss7/ss7_test.err b/tests/ss7/ss7_test.err index 8823d1c..4d2e308 100644 --- a/tests/ss7/ss7_test.err +++ b/tests/ss7/ss7_test.err @@ -1,49 +1,92 @@ -0: Creating SS7 Instance -[0;m0: Creating Route Table system -[0;m0: Point Code Format 8-8-8 is longer than 14 bits, odd? -[0;mregistering user=testuser for SI 1 with priv 0x1234 -[0;mdelivering MTP-TRANSFER.ind to user testuser, priv=0x1234 -[0;mNo MTP-User for SI 1 -[0;mUnsupported Primitive -[0;m0: Creating Route Table foobar -[0;m0: Creating Linkset a -[0;m0: Creating Linkset b -[0;m0: Destroying Linkset a -[0;m0: Destroying Linkset b -[0;m0: Creating Linkset a -[0;m0: Creating Linkset b -[0;m0: Creating Link a:1 -[0;m0: Creating Link a:2 -[0;m0: Destroying Link a:1 -[0;m0: Destroying Link a:2 -[0;m0: Destroying Linkset a -[0;m0: Destroying Linkset b -[0;m0: Creating AS as1 -[0;mXUA_AS(as1){AS_DOWN}: Allocated -[0;m0: Adding ASP asp1 to AS as1 -[0;m0: Restarting ASP asp1 -[0;munable to connect/bind socket: (null):0: Connection refused -[0;mconnection closed -[0;mretrying in 5 seconds... -[0;m0: Unable to open stream client for ASP asp1 -[0;mXUA_ASP(asp1){ASP_DOWN}: Allocated -[0;mXUA_ASP(asp1){ASP_DOWN}: Received Event M-ASP_UP.req -[0;mXUA_ASP(asp1){ASP_DOWN}: Received Event ASPSM-ASP_UP_ACK -[0;mXUA_ASP(asp1){ASP_DOWN}: T(ack) stopped -[0;mXUA_ASP(asp1){ASP_DOWN}: state_chg to ASP_INACTIVE -[0;mXUA_ASP(asp1){ASP_INACTIVE}: Received Event M-ASP_ACTIVE.req -[0;mXUA_ASP(asp1){ASP_INACTIVE}: Received Event ASPTM-ASP_AC_ACK -[0;mXUA_ASP(asp1){ASP_INACTIVE}: T(ack) stopped -[0;mXUA_ASP(asp1){ASP_INACTIVE}: state_chg to ASP_ACTIVE -[0;m0: Removing ASP asp1 from AS as1 -[0;m0: Removing ASP asp1 from AS as1 -[0;m0: Destroying ASP asp1 -[0;mXUA_ASP(asp1){ASP_ACTIVE}: Terminating (cause = OSMO_FSM_TERM_REQUEST) -[0;mXUA_ASP(asp1){ASP_ACTIVE}: Freeing instance -[0;mXUA_ASP(asp1){ASP_ACTIVE}: Deallocated -[0;m0: Destroying AS as1 -[0;mXUA_AS(as1){AS_DOWN}: Terminating (cause = OSMO_FSM_TERM_REQUEST) -[0;mXUA_AS(as1){AS_DOWN}: Freeing instance -[0;mXUA_AS(as1){AS_DOWN}: Deallocated -[0;m0: Destroying SS7 Instance -[0;m \ No newline at end of file +DLSS7 INFO 0: Creating SS7 Instance +DLSS7 INFO 0: Creating Route Table system +DLSS7 NOTICE 0: Point Code Format 8-8-8 is longer than 14 bits, odd? +DLSS7 DEBUG 0: ss7_user(testuser) registering for SI 1 with priv 0x1234 +DLSS7 DEBUG 0: ss7_user(testuser) Delivering to MTP User: MTP-TRANSFER.indication +DLSS7 DEBUG 0: ss7_user(testuser) unregistering from SI 1 with priv 0x1234 +DLSS7 INFO 0: Creating Route Table foobar +DLSS7 INFO 0: Creating Linkset a +DLSS7 INFO 0: Creating Link a:0 +DLSS7 INFO 0: Creating Linkset b +DLSS7 INFO 0: Creating Link b:0 +DLSS7 INFO 0: RT(dpc=12=0.1.4,mask=0x3fff=7.255.7,prio=5,via=a,st=available) Creating route: pc=12=0.1.4 mask=0x3fff=7.255.7 prio=5 via linkset a +DLSS7 INFO 0: CombinedLinkset(dpc=12=0.1.4,mask=0x3fff=7.255.7,prio=5) RT loookup: OPC=0=0.0.0,DPC=12=0.1.4,SLS=0 -> eSLS=80: picked Normal Route via '<linkset>' round-robin style (available) +DLSS7 INFO 0: RT(dpc=12=0.1.4,mask=0x3fff=7.255.7,prio=5,via=a,st=available) Destroying route: pc=12=0.1.4 mask=0x3fff=7.255.7 prio=5 via linkset a +DLSS7 INFO 0: RT(dpc=8=0.1.0,mask=0x3ff8=7.255.0,prio=5,via=a,st=available) Creating route: pc=8=0.1.0 mask=0x3ff8=7.255.0 prio=5 via linkset a +DLSS7 INFO 0: CombinedLinkset(dpc=8=0.1.0,mask=0x3ff8=7.255.0,prio=5) RT loookup: OPC=0=0.0.0,DPC=8=0.1.0,SLS=0 -> eSLS=16: picked Normal Route via '<linkset>' round-robin style (available) +DLSS7 INFO 0: CombinedLinkset(dpc=8=0.1.0,mask=0x3ff8=7.255.0,prio=5) RT loookup: OPC=0=0.0.0,DPC=9=0.1.1,SLS=0 -> eSLS=0: picked Normal Route via '<linkset>' round-robin style (available) +DLSS7 INFO 0: CombinedLinkset(dpc=8=0.1.0,mask=0x3ff8=7.255.0,prio=5) RT loookup: OPC=0=0.0.0,DPC=12=0.1.4,SLS=0 -> eSLS=80: picked Normal Route via '<linkset>' round-robin style (available) +DLSS7 INFO 0: CombinedLinkset(dpc=8=0.1.0,mask=0x3ff8=7.255.0,prio=5) RT loookup: OPC=0=0.0.0,DPC=15=0.1.7,SLS=0 -> eSLS=96: picked Normal Route via '<linkset>' round-robin style (available) +DLSS7 INFO 0: RT(dpc=12=0.1.4,mask=0x3fff=7.255.7,prio=5,via=b,st=available) Creating route: pc=12=0.1.4 mask=0x3fff=7.255.7 prio=5 via linkset b +DLSS7 INFO 0: CombinedLinkset(dpc=12=0.1.4,mask=0x3fff=7.255.7,prio=5) RT loookup: OPC=0=0.0.0,DPC=12=0.1.4,SLS=0 -> eSLS=80: picked Normal Route via '<linkset>' round-robin style (available) +DLSS7 DEBUG 0: CombinedLinkset(dpc=8=0.1.0,mask=0x3ff8=7.255.0,prio=5) RT lookup: OPC=0=0.0.0,DPC=15=0.1.7,SLS=0 -> eSLS=96: use Normal Route via '<linkset>' +DLSS7 INFO 0: RT(dpc=0=0.0.0,mask=0x0=0.0.0,prio=5,via=a,st=available) Creating route: pc=0=0.0.0 mask=0x0=0.0.0 prio=5 via linkset a +DLSS7 DEBUG 0: CombinedLinkset(dpc=12=0.1.4,mask=0x3fff=7.255.7,prio=5) RT lookup: OPC=0=0.0.0,DPC=12=0.1.4,SLS=0 -> eSLS=80: use Normal Route via '<linkset>' +DLSS7 DEBUG 0: CombinedLinkset(dpc=8=0.1.0,mask=0x3ff8=7.255.0,prio=5) RT lookup: OPC=0=0.0.0,DPC=15=0.1.7,SLS=0 -> eSLS=96: use Normal Route via '<linkset>' +DLSS7 INFO 0: CombinedLinkset(dpc=0=0.0.0,mask=0x0=0.0.0,prio=5) RT loookup: OPC=0=0.0.0,DPC=16=0.2.0,SLS=0 -> eSLS=32: picked Normal Route via '<linkset>' round-robin style (available) +DLSS7 INFO 0: RT(dpc=0=0.0.0,mask=0x0=0.0.0,prio=5,via=a,st=available) Destroying route: pc=0=0.0.0 mask=0x0=0.0.0 prio=5 via linkset a +DLSS7 INFO 0: RT(dpc=12=0.1.4,mask=0x3fff=7.255.7,prio=5,via=b,st=available) Destroying route: pc=12=0.1.4 mask=0x3fff=7.255.7 prio=5 via linkset b +DLSS7 INFO 0: RT(dpc=8=0.1.0,mask=0x3ff8=7.255.0,prio=5,via=a,st=available) Destroying route: pc=8=0.1.0 mask=0x3ff8=7.255.0 prio=5 via linkset a +DLSS7 INFO 0: RT(dpc=8=0.1.0,mask=0x3ff9=7.255.1,prio=5,via=a,st=available) Creating route: pc=8=0.1.0 mask=0x3ff9=7.255.1 prio=5 via linkset a +DLSS7 INFO 0: RT(dpc=8=0.1.0,mask=0x3ff9=7.255.1,prio=5,via=a,st=available) Destroying route: pc=8=0.1.0 mask=0x3ff9=7.255.1 prio=5 via linkset a +DLSS7 INFO 0: Destroying Linkset a +DLSS7 INFO 0: Destroying Link a:0 +DLSS7 INFO 0: Destroying Linkset b +DLSS7 INFO 0: Destroying Link b:0 +DLSS7 INFO 0: Creating Linkset a +DLSS7 INFO 0: Creating Linkset b +DLSS7 INFO 0: Creating Link a:1 +DLSS7 INFO 0: Creating Link a:2 +DLSS7 INFO 0: Destroying Link a:1 +DLSS7 INFO 0: Destroying Link a:2 +DLSS7 INFO 0: Destroying Linkset a +DLSS7 INFO 0: Destroying Linkset b +DLSS7 DEBUG XUA_AS(as1){AS_DOWN}: Allocated +DLSS7 INFO 0: AS(as1) Created AS +DLSS7 INFO 0: AS(as1) Adding ASP asp1 to AS +DLSS7 INFO 0: ASP(asp1) Restarting ASP asp1, r=:0<->l=:2905 +DLSS7 DEBUG xua_default_lm(asp1){IDLE}: Allocated +DLSS7 DEBUG XUA_ASP(asp1){ASP_DOWN}: Allocated +DLINP ERROR CLICONN(asp1,){CLOSED} connect: socket creation error (-22) +DLINP DEBUG CLICONN(asp1,){CLOSED} close() +DLINP INFO CLICONN(asp1,){WAIT_RECONNECT} retrying reconnect in 5 seconds... +DLSS7 ERROR 0: ASP(asp1) Unable to open stream client for ASP asp1, :2905 ==> :0 +DLSS7 DEBUG XUA_ASP(asp1){ASP_DOWN}: Received Event M-ASP_UP.req +DLSS7 DEBUG 0: ASP(asp1) Tx 8 bytes: [L2]> 01 00 03 01 00 00 00 08 +DLSS7 ERROR 0: ASP(asp1) Cannot transmit, asp->client not connected +DLSS7 DEBUG XUA_ASP(asp1){ASP_DOWN}: Received Event ASPSM-ASP_UP_ACK +DLSS7 DEBUG XUA_ASP(asp1){ASP_DOWN}: state_chg to ASP_INACTIVE +DLSS7 DEBUG XUA_ASP(asp1){ASP_INACTIVE}: Tx HEARTBEAT (0 unacked) +DLSS7 DEBUG 0: ASP(asp1) Tx 8 bytes: [L2]> 01 00 03 03 00 00 00 08 +DLSS7 ERROR 0: ASP(asp1) Cannot transmit, asp->client not connected +DLSS7 DEBUG XUA_AS(as1){AS_DOWN}: Received Event ASPAS-ASP_INACTIVE.ind +DLSS7 DEBUG XUA_AS(as1){AS_DOWN}: state_chg to AS_INACTIVE +DLSS7 DEBUG XUA_AS(as1){AS_INACTIVE}: Broadcasting NOTIFY Type State Change:AS Inactive () to all non-DOWN ASPs +DLSS7 DEBUG xua_default_lm(asp1){IDLE}: Received primitive M-ASP_UP.confirm +DLSS7 DEBUG xua_default_lm(asp1){IDLE}: Received Event ASP-UP.conf +DLSS7 ERROR xua_default_lm(asp1){IDLE}: Event ASP-UP.conf not permitted +DLSS7 DEBUG XUA_ASP(asp1){ASP_INACTIVE}: Received Event ASPTM-ASP_AC_ACK +DLSS7 DEBUG XUA_ASP(asp1){ASP_INACTIVE}: state_chg to ASP_ACTIVE +DLSS7 DEBUG XUA_AS(as1){AS_INACTIVE}: Received Event ASPAS-ASP_ACTIVE.ind +DLSS7 DEBUG XUA_AS(as1){AS_INACTIVE}: state_chg to AS_ACTIVE +DLSS7 DEBUG XUA_AS(as1){AS_ACTIVE}: Broadcasting NOTIFY Type State Change:AS Active () to all non-DOWN ASPs +DLSS7 DEBUG xua_default_lm(asp1){IDLE}: Received primitive M-ASP_ACTIVE.confirm +DLSS7 DEBUG xua_default_lm(asp1){IDLE}: Received Event ASP-ACT.conf +DLSS7 ERROR xua_default_lm(asp1){IDLE}: Event ASP-ACT.conf not permitted +DLSS7 INFO 0: AS(as1) Removing ASP asp1 from AS +DLSS7 INFO 0: ASP(asp1) Destroying ASP +DLINP DEBUG CLICONN(asp1,){WAIT_RECONNECT} destroy() +DLINP DEBUG CLICONN(asp1,){WAIT_RECONNECT} close() +DLINP DEBUG CLICONN(asp1,){CLOSED} free(destroy) +DLSS7 DEBUG XUA_ASP(asp1){ASP_ACTIVE}: Terminating (cause = OSMO_FSM_TERM_REQUEST) +DLSS7 DEBUG XUA_ASP(asp1){ASP_ACTIVE}: T(beat) stopped +DLSS7 DEBUG XUA_ASP(asp1){ASP_ACTIVE}: Freeing instance +DLSS7 DEBUG XUA_ASP(asp1){ASP_ACTIVE}: Deallocated +DLSS7 DEBUG xua_default_lm(asp1){IDLE}: Terminating (cause = OSMO_FSM_TERM_ERROR) +DLSS7 DEBUG xua_default_lm(asp1){IDLE}: Freeing instance +DLSS7 DEBUG xua_default_lm(asp1){IDLE}: Deallocated +DLSS7 INFO 0: AS(as1) Destroying AS +DLSS7 DEBUG XUA_AS(as1){AS_ACTIVE}: Terminating (cause = OSMO_FSM_TERM_REQUEST) +DLSS7 DEBUG XUA_AS(as1){AS_ACTIVE}: Freeing instance +DLSS7 DEBUG XUA_AS(as1){AS_ACTIVE}: Deallocated +DLSS7 INFO 0: Destroying SS7 Instance diff --git a/tests/testsuite.at b/tests/testsuite.at index 910fc0b..765463f 100644 --- a/tests/testsuite.at +++ b/tests/testsuite.at @@ -17,7 +17,8 @@ AT_SETUP([ss7]) AT_KEYWORDS([ss7]) cat $abs_srcdir/ss7/ss7_test.ok > expout -AT_CHECK([$abs_top_builddir/tests/ss7/ss7_test], [], [expout], [ignore]) +cat $abs_srcdir/ss7/ss7_test.err > experr +AT_CHECK([$abs_top_builddir/tests/ss7/ss7_test], [], [expout], [experr]) AT_CLEANUP AT_SETUP([tcap_transaction_tracking]) -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/43797?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I285eaeaa05e3651b0e4a69b3982d9b750cec92f0 Gerrit-Change-Number: 43797 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[M] Change in libosmo-sigtran[master]: ss7_asp_peer: Improvements in ss7_asp_peer_snprintf()
by pespin 07 Oct '26

07 Oct '26

pespin has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/43753?usp=email ) Change subject: ss7_asp_peer: Improvements in ss7_asp_peer_snprintf() ...................................................................... ss7_asp_peer: Improvements in ss7_asp_peer_snprintf() Convert it to osmo_strbuf, which simplifies the logic of the function, taking osmo_multiaddr_ip_and_port_snprintf() as reference to implement it. As a result: * Single IPv6 addresses now get properly enclosed in [], eg: "[::]:2905". * We avoid passing NULL to snprintf(), which is unspecified on some platforms. Change-Id: I115951627adb0c6778a9a36159237c3eea130300 --- M src/ss7_asp_peer.c M tests/ss7/ss7_test.err M tests/ss7/ss7_test.ok 3 files changed, 31 insertions(+), 30 deletions(-) Approvals: fixeria: Looks good to me, but someone else must approve osmith: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/ss7_asp_peer.c b/src/ss7_asp_peer.c index c31cdd9..2fd4c63 100644 --- a/src/ss7_asp_peer.c +++ b/src/ss7_asp_peer.c @@ -53,35 +53,36 @@ int ss7_asp_peer_snprintf(char *buf, size_t buf_len, struct osmo_ss7_asp_peer *peer) { - int len = 0, offset = 0, rem = buf_len; - int ret, i; - char *after; + struct osmo_strbuf sb = { .buf = buf, .len = buf_len }; + bool is_v6 = false; + unsigned int i; char *primary; - if (buf_len < 3) - return -EINVAL; - - if (peer->host_cnt > 1) { - ret = snprintf(buf, rem, "("); - if (ret < 0) - return ret; - OSMO_SNPRINTF_RET(ret, rem, offset, len); + if (peer->host_cnt == 0) { + OSMO_STRBUF_PRINTF(sb, "NULL:%u", peer->port); + return sb.chars_needed; } - for (i = 0; i < peer->host_cnt; i++) { + + if (peer->host_cnt > 1) + OSMO_STRBUF_PRINTF(sb, "("); + else if (peer->host[0] && (is_v6 = !!strchr(peer->host[0], ':'))) + OSMO_STRBUF_PRINTF(sb, "["); /* IPv6, add [] to separate from port. */ + + for (i = 0; i < peer->host_cnt - 1; i++) { primary = (peer->idx_primary == i) ? "*" : ""; - if (peer->host_cnt == 1) - after = ""; - else - after = (i == (peer->host_cnt - 1)) ? ")" : "|"; - ret = snprintf(buf + offset, rem, "%s%s%s", peer->host[i] ? : "0.0.0.0", primary, after); - OSMO_SNPRINTF_RET(ret, rem, offset, len); + OSMO_STRBUF_PRINTF(sb, "%s%s|", peer->host[i] ? : "NULL", primary); } - ret = snprintf(buf + offset, rem, ":%u", peer->port); - if (ret < 0) - return ret; - OSMO_SNPRINTF_RET(ret, rem, offset, len); + primary = (peer->idx_primary == i) ? "*" : ""; + OSMO_STRBUF_PRINTF(sb, "%s%s", peer->host[i] ? : "NULL", primary); - return len; + if (peer->host_cnt > 1) + OSMO_STRBUF_PRINTF(sb, ")"); + else if (is_v6) + OSMO_STRBUF_PRINTF(sb, "]"); + + OSMO_STRBUF_PRINTF(sb, ":%u", peer->port); + + return sb.chars_needed; } /*! \brief Set (copy) addresses for a given ASP peer. Previous addresses are freed. diff --git a/tests/ss7/ss7_test.err b/tests/ss7/ss7_test.err index 4d2e308..7333bb6 100644 --- a/tests/ss7/ss7_test.err +++ b/tests/ss7/ss7_test.err @@ -44,13 +44,13 @@ DLSS7 DEBUG XUA_AS(as1){AS_DOWN}: Allocated DLSS7 INFO 0: AS(as1) Created AS DLSS7 INFO 0: AS(as1) Adding ASP asp1 to AS -DLSS7 INFO 0: ASP(asp1) Restarting ASP asp1, r=:0<->l=:2905 +DLSS7 INFO 0: ASP(asp1) Restarting ASP asp1, r=NULL:0<->l=NULL:2905 DLSS7 DEBUG xua_default_lm(asp1){IDLE}: Allocated DLSS7 DEBUG XUA_ASP(asp1){ASP_DOWN}: Allocated DLINP ERROR CLICONN(asp1,){CLOSED} connect: socket creation error (-22) DLINP DEBUG CLICONN(asp1,){CLOSED} close() DLINP INFO CLICONN(asp1,){WAIT_RECONNECT} retrying reconnect in 5 seconds... -DLSS7 ERROR 0: ASP(asp1) Unable to open stream client for ASP asp1, :2905 ==> :0 +DLSS7 ERROR 0: ASP(asp1) Unable to open stream client for ASP asp1, NULL:2905 ==> NULL:0 DLSS7 DEBUG XUA_ASP(asp1){ASP_DOWN}: Received Event M-ASP_UP.req DLSS7 DEBUG 0: ASP(asp1) Tx 8 bytes: [L2]> 01 00 03 01 00 00 00 08 DLSS7 ERROR 0: ASP(asp1) Cannot transmit, asp->client not connected diff --git a/tests/ss7/ss7_test.ok b/tests/ss7/ss7_test.ok index 532d6f0..b8e7d00 100644 --- a/tests/ss7/ss7_test.ok +++ b/tests/ss7/ss7_test.ok @@ -28,13 +28,13 @@ route with partial mask: 0.1.0/11 route with non-consecutive mask: 0.1.0/7.255.1 Testing SS7 linkset/link -ss7_asp_peer_snprintf: :0 -ss7_asp_peer_snprintf: :2905 +ss7_asp_peer_snprintf: NULL:0 +ss7_asp_peer_snprintf: NULL:2905 ss7_asp_peer_snprintf: (127.0.0.1*|::1):2905 ss7_asp_peer_snprintf: (127.0.0.1*|::1):2905 ss7_asp_peer_snprintf: (127.0.0.1|::1):2905 ss7_asp_peer_snprintf: (127.0.0.1|::1*):2905 -ss7_asp_peer_snprintf: ::1*:2905 -ss7_asp_peer_snprintf: :2905 +ss7_asp_peer_snprintf: [::1*]:2905 +ss7_asp_peer_snprintf: NULL:2905 ss7_asp_peer_snprintf: 0.0.0.0:2905 -ss7_asp_peer_snprintf: :::2905 +ss7_asp_peer_snprintf: [::]:2905 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/43753?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I115951627adb0c6778a9a36159237c3eea130300 Gerrit-Change-Number: 43753 Gerrit-PatchSet: 5 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in osmo-iuh[master]: iu_client: N-DISCONNECT.req: Use proper SCCP-User release reason
by pespin 07 Oct '26

07 Oct '26

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-iuh/+/43801?usp=email ) Change subject: iu_client: N-DISCONNECT.req: Use proper SCCP-User release reason ...................................................................... iu_client: N-DISCONNECT.req: Use proper SCCP-User release reason Until recently, libosmo-sigtran was incorrectly expecting low-level wire-format cause in N-DISCONNECT.req. Nowadays it supports specific reason values in the SCCP-User SAP, so use those instead. Change-Id: I2b3a875c22f00d0790ce4fd8381daebc1520f1f3 Related: OS#2601 --- M TODO-RELEASE M src/iu_client.c 2 files changed, 3 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-iuh refs/changes/01/43801/1 diff --git a/TODO-RELEASE b/TODO-RELEASE index 0ed7189..b6d61b1 100644 --- a/TODO-RELEASE +++ b/TODO-RELEASE @@ -7,3 +7,4 @@ # If any interfaces have been added since the last public release: c:r:a + 1. # If any interfaces have been removed or changed since the last public release: c:r:0. #library what description / commit summary line +libosmo-sigtran >2.3.0 OSMO_SCCP_REL_REASON_NSU_* diff --git a/src/iu_client.c b/src/iu_client.c index 8df8c7d..ae87460 100644 --- a/src/iu_client.c +++ b/src/iu_client.c @@ -184,7 +184,8 @@ return; osmo_timer_del(&ue_ctx->release_timeout); - osmo_sccp_tx_disconn(g_scu, ue_ctx->conn_id, NULL, 0); + osmo_sccp_tx_disconn(g_scu, ue_ctx->conn_id, NULL, + OSMO_SCCP_REL_REASON_NSU_DISC_NORMAL); llist_del(&ue_ctx->list); talloc_free(ue_ctx); } -- To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/43801?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-iuh Gerrit-Branch: master Gerrit-Change-Id: I2b3a875c22f00d0790ce4fd8381daebc1520f1f3 Gerrit-Change-Number: 43801 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

[M] Change in libosmo-sigtran[master]: ss7_asp_peer: Improvements in ss7_asp_peer_snprintf()
by osmith 07 Oct '26

07 Oct '26

Attention is currently required from: jolly, pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/43753?usp=email ) Change subject: ss7_asp_peer: Improvements in ss7_asp_peer_snprintf() ...................................................................... Patch Set 5: Code-Review+2 (2 comments) Patchset: PS3: > @osmith@sysmocom.de see prepended patches. Thanks! File src/ss7_asp_peer.c: https://gerrit.osmocom.org/c/libosmo-sigtran/+/43753/comment/c039959d_37015… : PS3, Line 73: | > No, becuase it iterates until "< peer->host_cnt - 1", so last one is handled after the loop. Ack -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/43753?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I115951627adb0c6778a9a36159237c3eea130300 Gerrit-Change-Number: 43753 Gerrit-PatchSet: 5 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 07 Oct 2026 11:22:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: osmith <osmith(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 0

[M] Change in libosmo-sigtran[master]: tests: ss7_test: Check stderr output
by osmith 07 Oct '26

07 Oct '26

Attention is currently required from: pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/43797?usp=email ) Change subject: tests: ss7_test: Check stderr output ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/43797?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I285eaeaa05e3651b0e4a69b3982d9b750cec92f0 Gerrit-Change-Number: 43797 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 07 Oct 2026 11:20:34 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in osmo-bsc[master]: sigtran: N-DISCONNECT.req: Use proper SCCP-User release reason
by pespin 07 Oct '26

07 Oct '26

Attention is currently required from: pespin. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bsc/+/43799?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified-1 by Jenkins Builder Change subject: sigtran: N-DISCONNECT.req: Use proper SCCP-User release reason ...................................................................... sigtran: N-DISCONNECT.req: Use proper SCCP-User release reason Until recently, libosmo-sigtran was incorrectly expecting low-level wire-format cause in N-DISCONNECT.req. Nowadays it supports specific reason values in the SCCP-User SAP, so use those instead. Related: OS#2601 Change-Id: I17bceb7dbd6d8198a07c232eee8aebb7b89a3bf2 --- M TODO-RELEASE M src/osmo-bsc/bsc_subscr_conn_fsm.c M src/osmo-bsc/lb.c M src/osmo-bsc/osmo_bsc_sigtran.c 4 files changed, 22 insertions(+), 8 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/99/43799/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/43799?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I17bceb7dbd6d8198a07c232eee8aebb7b89a3bf2 Gerrit-Change-Number: 43799 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: pespin <pespin(a)sysmocom.de>

1 0

[M] Change in libosmo-sigtran[master]: tests: Add unit tests for ss7_asp_peer
by osmith 07 Oct '26

07 Oct '26

Attention is currently required from: pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/43796?usp=email ) Change subject: tests: Add unit tests for ss7_asp_peer ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/43796?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I158dd8b8d514ad8a68074a16a0702d3d33f71bbc Gerrit-Change-Number: 43796 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 07 Oct 2026 11:19:29 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-hnbgw[master]: sigtran: N-DISCONNECT.req: Use proper SCCP-User release reason
by pespin 07 Oct '26

07 Oct '26

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/43800?usp=email ) Change subject: sigtran: N-DISCONNECT.req: Use proper SCCP-User release reason ...................................................................... sigtran: N-DISCONNECT.req: Use proper SCCP-User release reason Until recently, libosmo-sigtran was incorrectly expecting low-level wire-format cause in N-DISCONNECT.req. Nowadays it supports specific reason values in the SCCP-User SAP, so use those instead. Related: OS#2601 Change-Id: I702718a00031592c2aa870ea8981228848129659 --- M TODO-RELEASE M src/osmo-hnbgw/hnbgw_sccp.c 2 files changed, 2 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hnbgw refs/changes/00/43800/1 diff --git a/TODO-RELEASE b/TODO-RELEASE index 0ed7189..b6d61b1 100644 --- a/TODO-RELEASE +++ b/TODO-RELEASE @@ -7,3 +7,4 @@ # If any interfaces have been added since the last public release: c:r:a + 1. # If any interfaces have been removed or changed since the last public release: c:r:0. #library what description / commit summary line +libosmo-sigtran >2.3.0 OSMO_SCCP_REL_REASON_NSU_* diff --git a/src/osmo-hnbgw/hnbgw_sccp.c b/src/osmo-hnbgw/hnbgw_sccp.c index 6f01f7c..2e9b79a 100644 --- a/src/osmo-hnbgw/hnbgw_sccp.c +++ b/src/osmo-hnbgw/hnbgw_sccp.c @@ -449,7 +449,7 @@ } rc = osmo_sccp_tx_disconn(hsu->sccp_user, scu_conn_id, NULL, - SCCP_RELEASE_CAUSE_END_USER_ORIGINATED); + OSMO_SCCP_REL_REASON_NSU_DISC_NORMAL); if (rc) LOG_HSU(hsu, DCN, LOGL_ERROR, "Failed to send SCCP N-DISCONNECT.req(%u)\n", scu_conn_id); return rc; -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/43800?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I702718a00031592c2aa870ea8981228848129659 Gerrit-Change-Number: 43800 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in osmo-bsc[master]: sigtran: N-DISCONNECT.req: Use proper SCCP-User release reason
by pespin 07 Oct '26

07 Oct '26

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/43799?usp=email ) Change subject: sigtran: N-DISCONNECT.req: Use proper SCCP-User release reason ...................................................................... sigtran: N-DISCONNECT.req: Use proper SCCP-User release reason Until recently, libosmo-sigtran was incorrectly expecting low-level wire-format cause in N-DISCONNECT.req. Nowadays it supports specific reason values in the SCCP-User SAP, so use those instead. Related: OS#2601 Change-Id: I17bceb7dbd6d8198a07c232eee8aebb7b89a3bf2 --- M TODO-RELEASE M src/osmo-bsc/osmo_bsc_sigtran.c 2 files changed, 5 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/99/43799/1 diff --git a/TODO-RELEASE b/TODO-RELEASE index 0ed7189..b6d61b1 100644 --- a/TODO-RELEASE +++ b/TODO-RELEASE @@ -7,3 +7,4 @@ # If any interfaces have been added since the last public release: c:r:a + 1. # If any interfaces have been removed or changed since the last public release: c:r:0. #library what description / commit summary line +libosmo-sigtran >2.3.0 OSMO_SCCP_REL_REASON_NSU_* diff --git a/src/osmo-bsc/osmo_bsc_sigtran.c b/src/osmo-bsc/osmo_bsc_sigtran.c index 1fe7739..c96aebf 100644 --- a/src/osmo-bsc/osmo_bsc_sigtran.c +++ b/src/osmo-bsc/osmo_bsc_sigtran.c @@ -234,7 +234,10 @@ return 0; refuse: - osmo_sccp_tx_disconn(scu, scu_prim->u.connect.conn_id, &scu_prim->u.connect.called_addr, 0); + osmo_sccp_tx_disconn(scu, + scu_prim->u.connect.conn_id, + &scu_prim->u.connect.called_addr, + OSMO_SCCP_REL_REASON_NSU_CREF_END_USER_ORIGIN); return rc; } -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/43799?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I17bceb7dbd6d8198a07c232eee8aebb7b89a3bf2 Gerrit-Change-Number: 43799 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

[L] Change in libosmo-sigtran[master]: sccp: Introduce N-DISCONNECT.req/ind Release/Refusal reason
by fixeria 07 Oct '26

07 Oct '26

Attention is currently required from: osmith, pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/43763?usp=email ) Change subject: sccp: Introduce N-DISCONNECT.req/ind Release/Refusal reason ...................................................................... Patch Set 6: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/43763?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I158463c2e9b34abe06554371d628e4fa7ea8c5c1 Gerrit-Change-Number: 43763 Gerrit-PatchSet: 6 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 07 Oct 2026 10:48:41 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

2026

2025

2024

2023

2022

gerrit-log October 2026