October 2026 - gerrit-log - lists.osmocom.org

[S] Change in osmo-ttcn3-hacks[master]: ngap: Add dec/enc functions for PDUSessionResourceRelease{Command,Res...
by pespin 15 Oct '26

15 Oct '26

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43891?usp=email ) Change subject: ngap: Add dec/enc functions for PDUSessionResourceRelease{Command,Response} ...................................................................... ngap: Add dec/enc functions for PDUSessionResourceRelease{Command,Response} Change-Id: I1d3709ae160d0b2be9cbdf8cc5dd98042c38f3cc --- M library/ngap/NGAP_EncDec.cc M library/ngap/NGAP_Types.ttcn 2 files changed, 46 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, but someone else must approve pespin: Looks good to me, approved diff --git a/library/ngap/NGAP_EncDec.cc b/library/ngap/NGAP_EncDec.cc index ae2f34f..d15cab6 100644 --- a/library/ngap/NGAP_EncDec.cc +++ b/library/ngap/NGAP_EncDec.cc @@ -129,6 +129,46 @@ return ret; } +OCTETSTRING enc__NGAP__PDUSessionResourceReleaseCommandTransfer(const NGAP__IEs::PDUSessionResourceReleaseCommandTransfer &p) +{ + TTCN_Buffer TTCN_buf; + TTCN_buf.clear(); + p.encode(NGAP__IEs::PDUSessionResourceReleaseCommandTransfer_descr_, TTCN_buf, + TTCN_EncDec::CT_PER, PER_ALIGNED); + return OCTETSTRING(TTCN_buf.get_len(), TTCN_buf.get_data()); +} + +NGAP__IEs::PDUSessionResourceReleaseCommandTransfer dec__NGAP__PDUSessionResourceReleaseCommandTransfer(const OCTETSTRING &stream) +{ + NGAP__IEs::PDUSessionResourceReleaseCommandTransfer ret; + TTCN_Buffer TTCN_buf; + TTCN_buf.clear(); + TTCN_buf.put_os(stream); + ret.decode(NGAP__IEs::PDUSessionResourceReleaseCommandTransfer_descr_, TTCN_buf, + TTCN_EncDec::CT_PER, PER_ALIGNED); + return ret; +} + +OCTETSTRING enc__NGAP__PDUSessionResourceReleaseResponseTransfer(const NGAP__IEs::PDUSessionResourceReleaseResponseTransfer &p) +{ + TTCN_Buffer TTCN_buf; + TTCN_buf.clear(); + p.encode(NGAP__IEs::PDUSessionResourceReleaseResponseTransfer_descr_, TTCN_buf, + TTCN_EncDec::CT_PER, PER_ALIGNED); + return OCTETSTRING(TTCN_buf.get_len(), TTCN_buf.get_data()); +} + +NGAP__IEs::PDUSessionResourceReleaseResponseTransfer dec__NGAP__PDUSessionResourceReleaseResponseTransfer(const OCTETSTRING &stream) +{ + NGAP__IEs::PDUSessionResourceReleaseResponseTransfer ret; + TTCN_Buffer TTCN_buf; + TTCN_buf.clear(); + TTCN_buf.put_os(stream); + ret.decode(NGAP__IEs::PDUSessionResourceReleaseResponseTransfer_descr_, TTCN_buf, + TTCN_EncDec::CT_PER, PER_ALIGNED); + return ret; +} + OCTETSTRING enc__NGAP__UEContextSuspendRequestTransfer(const NGAP__IEs::UEContextSuspendRequestTransfer &p) { TTCN_Buffer TTCN_buf; diff --git a/library/ngap/NGAP_Types.ttcn b/library/ngap/NGAP_Types.ttcn index 78054bc..08d0f22 100644 --- a/library/ngap/NGAP_Types.ttcn +++ b/library/ngap/NGAP_Types.ttcn @@ -21,6 +21,12 @@ external function enc_NGAP_PDUSessionResourceModifyIndicationTransfer(NGAP_IEs.PDUSessionResourceModifyIndicationTransfer p) return octetstring; external function dec_NGAP_PDUSessionResourceModifyIndicationTransfer(in octetstring pdu) return NGAP_IEs.PDUSessionResourceModifyIndicationTransfer; + external function enc_NGAP_PDUSessionResourceReleaseCommandTransfer(NGAP_IEs.PDUSessionResourceReleaseCommandTransfer p) return octetstring; + external function dec_NGAP_PDUSessionResourceReleaseCommandTransfer(in octetstring pdu) return NGAP_IEs.PDUSessionResourceReleaseCommandTransfer; + + external function enc_NGAP_PDUSessionResourceReleaseResponseTransfer(NGAP_IEs.PDUSessionResourceReleaseResponseTransfer p) return octetstring; + external function dec_NGAP_PDUSessionResourceReleaseResponseTransfer(in octetstring pdu) return NGAP_IEs.PDUSessionResourceReleaseResponseTransfer; + external function enc_NGAP_UEContextSuspendRequestTransfer(NGAP_IEs.UEContextSuspendRequestTransfer p) return octetstring; external function dec_NGAP_UEContextSuspendRequestTransfer(in octetstring pdu) return NGAP_IEs.UEContextSuspendRequestTransfer; -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43891?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I1d3709ae160d0b2be9cbdf8cc5dd98042c38f3cc Gerrit-Change-Number: 43891 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in osmo-ttcn3-hacks[master]: ngap: Add dec/enc functions for PDUSessionResourceRelease{Command,Res...
by pespin 15 Oct '26

15 Oct '26

pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43891?usp=email ) Change subject: ngap: Add dec/enc functions for PDUSessionResourceRelease{Command,Response} ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43891?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I1d3709ae160d0b2be9cbdf8cc5dd98042c38f3cc Gerrit-Change-Number: 43891 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 15 Oct 2026 23:27:54 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in libosmo-sigtran[master]: tcap: Add SUA spec references regarding TCAP routing
by pespin 15 Oct '26

15 Oct '26

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/43903?usp=email ) Change subject: tcap: Add SUA spec references regarding TCAP routing ...................................................................... tcap: Add SUA spec references regarding TCAP routing It seems most of TCAP routing we have implemented is somehow documented in RFC3868 (SUA). The main difference is that we are implementing TCAP routing on top of SCCPLite (IPA/SCCP) instead. Change-Id: I9c1806570529e1568c5f65152b4bb298f19afe14 --- M src/tcap_as_loadshare.c M src/tcap_trans_tracking.c 2 files changed, 41 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/03/43903/1 diff --git a/src/tcap_as_loadshare.c b/src/tcap_as_loadshare.c index 2e8d86a..12a482c 100644 --- a/src/tcap_as_loadshare.c +++ b/src/tcap_as_loadshare.c @@ -505,17 +505,35 @@ switch (as->cfg.loadshare.tcap.unroutable_tcap_msg) { case SS7_AS_TCAP_UNROUTABLE_LOAD_SHARE_AS: + /* RFC3868 A.3.1 Connectionless Transport: + * "load sharing is only possible for the first message in a + * TCAP dialogue (TC_Begin, TC_Query, TC_Unidirectional) [...] + * unless the ASPs are able to share state and maintain sequenced + * delivery. To this end, the SGP needs to know the TID + * allocation policy of the ASPs in a single AS". + * + * Hence, if UNROUTABLE_LOAD_SHARE_AS is configured, allocation + * policy "State sharing" at the peer is assumed. */ asp = select_asp_tcap_enabled_rr(as); if (asp) rc = 0; break; case SS7_AS_TCAP_UNROUTABLE_ROUTE_FALLBACK: + /* RFC3868 A.2: + * "Replicated relay points: in normal circumstances, the path + * from SEP to ASP will always go via the same SGP when + * in-sequence-delivery is requested. However, linkset failures + * may cause MTP to reroute to the other SG." */ /* No ASP selection. Try to route the SCCP msg to the fallback DPC */ rc = asp_loadshare_tcap_route_fallback(as, mtp3_rtlb, sccp_msg); if (!rc) /* rc == 0 would require a valid asp, use > 0 to drop the msg, but don't send an error back if needed */ rc = 1; break; case SS7_AS_TCAP_UNROUTABLE_REJECT_UDTS: + /* RFC3868 4.7.3.1 TCAP traffic: + * "If an ASP is not available, the SG may generate (X)UDTS + * "routing failure", if the return option is used." */ + /* fall-through */ default: /* default case, asp stays NULL, will reject when returning -ENOKEY */ rc = -ENOKEY; @@ -632,6 +650,11 @@ goto out_free_sua; } + /* RFC3868 4.7.3.1 TCAP traffic: + * "Messages not containing a destination (or "responding") TID, i.e., + * Query, Begin, Unidirectional, are loadshared among the available + * ASPs. Any scheme permitting a fair load distribution among the ASPs + * is allowed (e.g., round robin)." */ asp = select_asp_tcap_enabled_rr(as); if (asp) { rate_ctr_inc2(as->ctrg, SS7_AS_CTR_TCAP_ASP_SELECTED); @@ -651,6 +674,9 @@ goto out_free_sua; } + /* RFC3868 4.7.3.1 TCAP traffic: + * "When a destination TID is present, the SG extracts the label and + * selects the ASP that corresponds with it." */ asp = tcap_trans_track_continue(as, &called_addr, &parsed.dtid, &calling_addr, &parsed.otid); if (!asp) { LOGPAS(as, DLTCAP, LOGL_INFO, "Couldn't find cached ASP for TCAP Continue, dtid %u/otid %u, using tcap route", parsed.dtid, parsed.otid); @@ -794,6 +820,14 @@ uint8_t data[0]; } __attribute__((packed)); +/* This message is similar to provided "TID Label" in SUA ASP ACTIVATE, + * since there's no ASP management messages such as ASP ACTIVATE in IPA. + * + * RFC3868 A.3.1: "Fixed range of TIDs per ASP in the AS. [...] + * This information may be provisioned in the SG, or may be dynamically + * exchanged via the ASP_Active message." + * See also RFC3868 4.7.2.1. Association Setup, ASP going active + */ struct ipa_tcap_routing_add_range { uint32_t tid_start; uint32_t tid_end; @@ -907,6 +941,7 @@ LOGPASP(asp, DLTCAP, LOGL_INFO, "Rx: TCAP Add Range command: seq: %u pc: %u ssn: %u [%u-%u]\n", osmo_ntohl(hdr->seq), tcar.pc, tcar.ssn, tcar.tid_start, tcar.tid_end); + /* RFC3868 4.7.2.1 "The SG has to perform some trivial plausibility checks on the parameters" */ tcrng = tcap_overlap_tid(as, tcar.pc, tcar.ssn, tcar.tid_start, tcar.tid_end); if (tcrng) { LOGPASP(asp, DLTCAP, LOGL_ERROR, "New TCAP Range overlaps with existing range to ASP %s [%u-%u]. Rejecting Add Range Command seq: %u pc: %u ssn: %u [%u-%u]\n", diff --git a/src/tcap_trans_tracking.c b/src/tcap_trans_tracking.c index 421ad7b..d88a12b 100644 --- a/src/tcap_trans_tracking.c +++ b/src/tcap_trans_tracking.c @@ -21,6 +21,12 @@ * */ +/* RFC3868 4.7.2 Support for Loadsharing: + * "the loadsharing scheme used at the SG must make sure that messages continuing or ending the + * transactions/connections arrive at the same ASP where the initial message (TC_Query, TC_Begin, + * CR) was sent to/received from." +*/ + #include <stdint.h> #include <osmocom/core/msgb.h> -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/43903?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I9c1806570529e1568c5f65152b4bb298f19afe14 Gerrit-Change-Number: 43903 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in osmo-ttcn3-hacks[master]: ngap: Add dec/enc functions for PDUSessionResourceRelease{Command,Res...
by fixeria 15 Oct '26

15 Oct '26

Attention is currently required from: pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43891?usp=email ) Change subject: ngap: Add dec/enc functions for PDUSessionResourceRelease{Command,Response} ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43891?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I1d3709ae160d0b2be9cbdf8cc5dd98042c38f3cc Gerrit-Change-Number: 43891 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 15 Oct 2026 20:48:13 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in osmo-ttcn3-hacks[master]: smf: Introduce test TC_pfcp_heartbeat_recovery_timestamp
by fixeria 15 Oct '26

15 Oct '26

Attention is currently required from: pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43880?usp=email ) Change subject: smf: Introduce test TC_pfcp_heartbeat_recovery_timestamp ...................................................................... Patch Set 7: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43880?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I15ad5c295fc47ed9f38b91b6392b674bd0b4c4d7 Gerrit-Change-Number: 43880 Gerrit-PatchSet: 7 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 15 Oct 2026 20:47:40 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in osmo-ttcn3-hacks[master]: smf: TC_pfcp_heartbeat_timeout: Expect Delete Bearer Request
by fixeria 15 Oct '26

15 Oct '26

Attention is currently required from: pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43886?usp=email ) Change subject: smf: TC_pfcp_heartbeat_timeout: Expect Delete Bearer Request ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43886?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I5d55801923533b36ca2a1a573f1205281809f76d Gerrit-Change-Number: 43886 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 15 Oct 2026 20:45:06 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in osmo-ttcn3-hacks[master]: PFCP_Templates: Support passing PFCPSEReq_Flags IE to tr_PFCP_Session...
by fixeria 15 Oct '26

15 Oct '26

Attention is currently required from: pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43879?usp=email ) Change subject: PFCP_Templates: Support passing PFCPSEReq_Flags IE to tr_PFCP_Session_Est_Req() ...................................................................... Patch Set 5: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43879?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Idc7fc117d25940f9e032dc347141a2fada57c912 Gerrit-Change-Number: 43879 Gerrit-PatchSet: 5 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 15 Oct 2026 20:43:28 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in osmo-ttcn3-hacks[master]: PFCP_Templates: Avoid int2oct() conversion in PFCP_Create_PDR
by fixeria 15 Oct '26

15 Oct '26

Attention is currently required from: pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43884?usp=email ) Change subject: PFCP_Templates: Avoid int2oct() conversion in PFCP_Create_PDR ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43884?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ie4eeb8df5a55dc0b47ebdff0a256d57031eb35df Gerrit-Change-Number: 43884 Gerrit-PatchSet: 4 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 15 Oct 2026 20:43:16 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in osmo-ttcn3-hacks[master]: PFCP_Templates: Avoid enum2int() conversion in Outer_Header_Removal
by fixeria 15 Oct '26

15 Oct '26

Attention is currently required from: pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43883?usp=email ) Change subject: PFCP_Templates: Avoid enum2int() conversion in Outer_Header_Removal ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43883?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I17a97301308af0e77e5693e7dba36d0a07504b0e Gerrit-Change-Number: 43883 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 15 Oct 2026 20:41:58 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in osmo-ttcn3-hacks[master]: PFCP_Templates: Avoid enum2int() conversion in Src/Dst_Iface
by fixeria 15 Oct '26

15 Oct '26

Attention is currently required from: pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43882?usp=email ) Change subject: PFCP_Templates: Avoid enum2int() conversion in Src/Dst_Iface ...................................................................... Patch Set 5: Code-Review+2 (1 comment) File library/PFCP_Templates.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43882/comment/fa2a049b_4a79… : PS5, Line 809: Src_Iface Not willing to block here, but I find it weird that you kept the Pascal Case in these definitions. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43882?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I6ed23538660be5ca97df47e66c3b6ab60b39074f Gerrit-Change-Number: 43882 Gerrit-PatchSet: 5 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 15 Oct 2026 20:41:04 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0