lists.osmocom.org
Sign In Sign Up
Manage this list Sign In Sign Up

Keyboard Shortcuts

Thread View

  • j: Next unread message
  • k: Previous unread message
  • j a: Jump to all threads
  • j l: Jump to MailingList overview

gerrit-log

Thread Start a new thread
Download
Threads by month
  • ----- 2026 -----
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2025 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2024 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2023 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2022 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
gerrit-log@lists.osmocom.org

October 2026

  • 1 participants
  • 1245 discussions
[XS] Change in osmo-ttcn3-hacks[master]: REST_Types_JSON: fix typo in field names
by dexter 16 Oct '26

16 Oct '26
dexter has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43874?usp=email ) ( 1 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: REST_Types_JSON: fix typo in field names ...................................................................... REST_Types_JSON: fix typo in field names Field names must not begin with capital letters. Related: SYS#8203 Change-Id: I6ea321e2375d2c2db341120974c2e1668c7dd5bc --- M eim/REST_Types_JSON.ttcn 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified jolly: Looks good to me, approved diff --git a/eim/REST_Types_JSON.ttcn b/eim/REST_Types_JSON.ttcn index b3a74b7..3b468b5 100644 --- a/eim/REST_Types_JSON.ttcn +++ b/eim/REST_Types_JSON.ttcn @@ -192,8 +192,8 @@ charstring profileInfoListError, charstring listEimError, record { - charstring BppCommandId, - charstring ErrorReason, + charstring bppCommandId, + charstring errorReason, charstring simaResponse } profileInstallationError, charstring eimProcedureError -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43874?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I6ea321e2375d2c2db341120974c2e1668c7dd5bc Gerrit-Change-Number: 43874 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: jolly <andreas(a)eversberg.eu>
1 0
0 0
[L] Change in osmo-ttcn3-hacks[master]: SGP23_Constants: collect constants at a central place
by jolly 16 Oct '26

16 Oct '26
Attention is currently required from: dexter. jolly has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43841?usp=email ) Change subject: SGP23_Constants: collect constants at a central place ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43841?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I00e3de0b20156993b8e15b5bbd4734faa20b66cf Gerrit-Change-Number: 43841 Gerrit-PatchSet: 3 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Fri, 16 Oct 2026 07:58:19 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes
1 0
0 0
[XS] Change in osmo-ttcn3-hacks[master]: eIM_Tests: remove code dup in f_esipa_transceive
by jolly 16 Oct '26

16 Oct '26
Attention is currently required from: dexter. jolly has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43820?usp=email ) Change subject: eIM_Tests: remove code dup in f_esipa_transceive ...................................................................... Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43820?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I11f0b7bcf1bf8c763e6915eda34c3ede2a9a5c94 Gerrit-Change-Number: 43820 Gerrit-PatchSet: 4 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Fri, 16 Oct 2026 07:52:28 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes
1 0
0 0
[S] Change in osmo-ttcn3-hacks[master]: RSPDefinitions_Templates: add parameters to ts/tr_profileInstallation...
by dexter 16 Oct '26

16 Oct '26
Attention is currently required from: jolly. dexter has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43875?usp=email ) Change subject: RSPDefinitions_Templates: add parameters to ts/tr_profileInstallationResultData ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: thanks for the +2, but unfortunately I had to completely rework this patch... -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43875?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I445c906a0142a401c305dbcbb3e94843a8f5fce9 Gerrit-Change-Number: 43875 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Comment-Date: Fri, 16 Oct 2026 07:49:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No
1 0
0 0
[L] Change in osmo-ttcn3-hacks[master]: WIP: add SGP.33-3/SGP.23 testcases
by dexter 16 Oct '26

16 Oct '26
dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43904?usp=email ) Change subject: WIP: add SGP.33-3/SGP.23 testcases ...................................................................... WIP: add SGP.33-3/SGP.23 testcases Change-Id: Ide8fdec56eca4d4577baedfacd2a6a675d9c0e6e --- M eim/eIM_Tests.ttcn 1 file changed, 585 insertions(+), 7 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/04/43904/1 diff --git a/eim/eIM_Tests.ttcn b/eim/eIM_Tests.ttcn index e2ed6ef..102c206 100644 --- a/eim/eIM_Tests.ttcn +++ b/eim/eIM_Tests.ttcn @@ -45,6 +45,7 @@ import from PIPEasp_Types all; import from SGP23_Constants all; +import from esx_header_Types_JSON all; type component MTC_CT { timer g_Tguard; @@ -128,7 +129,7 @@ return vc_conn; } -private function f_init(charstring id, float t_guard := 40.0) runs on MTC_CT { +private function f_init(charstring id, float t_guard := 60.0) runs on MTC_CT { g_Tguard.start(t_guard); activate(as_Tguard()); @@ -194,6 +195,7 @@ if (not istemplatekind(expected_es9p_req, "omit") and not match(request, expected_es9p_req)) { setverdict(fail, "unexpected request from eIM on ES9+"); + log(request); } return request; @@ -206,6 +208,15 @@ HTTP_SRV[0].send(ts_http_resp(es9p_res_json)); } +/* Send Es9p HTTP response (error) */ +private function f_es9p_send_err(template JSON_ESx_ResponseHeader json_err) runs on eIM_ConnHdlr { + var charstring es9p_res_json; + var JSON_ES9p_RemoteProfileProvisioningResponse json_pdu; + json_pdu.emptyResponse.header := valueof(json_err); + es9p_res_json := oct2char(enc_JSON_ES9p_RemoteProfileProvisioningResponse(json_pdu)); + HTTP_SRV[0].send(ts_http_resp(es9p_res_json)); +} + /* Perform Es9p HTTP request/response cycle */ private function f_es9p_transceive(RemoteProfileProvisioningResponse es9p_res, template RemoteProfileProvisioningRequest expected_es9p_req := omit) @@ -420,7 +431,8 @@ } /* Receive ESipa HTTP response */ -private function f_esipa_receive(template EsipaMessageFromEimToIpa expected_esipa_res := omit) +private function f_esipa_receive(template EsipaMessageFromEimToIpa expected_esipa_res := omit, + template JSON_ESx_FunctionExecutionStatusCodeData expected_json_err := omit) runs on eIM_ConnHdlr return template EsipaMessageFromEimToIpa { var template EsipaMessageFromEimToIpa esipa_res; var DecodedEimToIpaMessage_Wrap esipa_res_wrap; /* JSON */ @@ -455,13 +467,39 @@ } else if (ispresent(response_http.response)) { if (mp_esipa_json == true) { dec_EsipaMessageFromEimToIpa_from_JSON(response_http.response.body, esipa_res_wrap); - esipa_res := esipa_res_wrap.asn1_pdu; - if (not istemplatekind(expected_esipa_res, "omit")) { - if (not match(valueof(esipa_res), expected_esipa_res)) { - setverdict(fail, "unexpected response (JSON) from eIM on ESipa"); + if (isbound(esipa_res_wrap.asn1_pdu)) { + esipa_res := esipa_res_wrap.asn1_pdu; + + if (not istemplatekind(expected_esipa_res, "omit")) { + /* The JSON message definition of the ProvideEimPackageResultResponse contains + * only one optional field (eimAcknowledgements). When this field is missing, + * the ProvideEimPackageResultResponse becomes indistinguishable from an empty + * response and is decoded as such. In case an expected_esipa_res is given, we + * can check if a ProvideEimPackageResultResponse is expected. When this is the + * case and the decoded response (esipa_res) was empty, we may infer the + * appropriate ProvideEimPackageResultResponse. */ + if (ispresent(expected_esipa_res.provideEimPackageResultResponse) and istemplatekind(esipa_res, "omit")) { + esipa_res := { provideEimPackageResultResponse := { emptyResponse := { } } } + } + if (not match(valueof(esipa_res), expected_esipa_res)) { + setverdict(fail, "unexpected response (JSON) from eIM on ESipa"); + log(valueof(esipa_res)); + } } + return esipa_res; + } else if (isbound(esipa_res_wrap.err)) { + if (not istemplatekind(expected_json_err, "omit")) { + if (not match(valueof(esipa_res_wrap.err), expected_json_err)) { + setverdict(fail, "unexpected error response (JSON) from eIM on ESipa"); + } + } + return omit; + } else { + /* The decoder should always either return an error result or a decoded asn1_pdu, but the + * result should never be completely empty. */ + setverdict(fail, "unexpected empty decoding result while decoding received response (JSON) from eIM on ESipa"); + return omit; } - return esipa_res; } else { setverdict(fail, "unexpected response from eIM on ESipa (response is ASN.1 instead of JSON?)"); return omit; @@ -984,7 +1022,538 @@ setverdict(pass); } +/* See SGP.33-3, section 4.2.12.2.1, Test Sequence #01 and SGP.23, section 4.4.23.2.1, Test Sequence #01 */ +private function f_TC_eIM_AuthenticateClient_Nominal_without_Confirmation_Code(charstring id) runs on eIM_ConnHdlr { + var charstring resource_id; + var template EsipaMessageFromEimToIpa esipa_res; + var octetstring eim_transaction_id; + var charstring smdpp_addr := mp_es9p_ip & ":" & int2str(mp_es9p_port) + var charstring activationCode := f_SGP23_ACTIVATION_CODE_1(test_dp_address := smdpp_addr); + + /* Create a new download at the eIM */ + resource_id := f_rest_create_order("download", ts_JSON_REST_download_order(SGP23_EID1, activationCode)); + + /* Check the eIM for new eIM packages, we expect to get a profileDownloadTriggerRequest that contains the + * activationCode that we have created the download with (see above) */ + esipa_res := f_esipa_transceive(valueof(ts_getEimPackageRequest(SGP23_EID1)), + tr_getEimPackageResponse_dnlTrigReq( + tr_profileDownloadTriggerRequest(activationCode))); + eim_transaction_id := valueof(esipa_res.getEimPackageResponse.profileDownloadTriggerRequest.eimTransactionId); + + + /* Step IC1/IC2: */ + f_esipa_send(valueof(ts_initiateAuthenticationRequestEsipa(euiccChallenge := SGP23_S_EUICC_CHALLENGE, + smdpAddress := smdpp_addr, + eimTransactionId := eim_transaction_id))); + f_es9p_receive(tr_initiateAuthenticationRequest(euiccChallenge := SGP23_S_EUICC_CHALLENGE, + smdpAddress := smdpp_addr)); + + /* Step 1a Initiate Authentication Response */ + var template RemoteProfileProvisioningResponse INITIATE_AUTH_OK := + ts_initiateAuthenticationResponse( + transactionId := SGP23_S_TRANSACTION_ID, + serverSigned1 := ts_serverSigned1(transactionId := SGP23_S_TRANSACTION_ID, + euiccChallenge := SGP23_S_EUICC_CHALLENGE, + serverAddress := smdpp_addr, + serverChallenge := SGP23_SMDP_CHALLENGE), + serverSignature1 := SGP23_SERVER_SIGNATURE1, + euiccCiPKIdToBeUsed := SGP23_EUICC_CI_PK_ID_TO_BE_USED, + serverCertificate := ts_cert_s_sm_dpauth_nist); + f_es9p_send(valueof(INITIATE_AUTH_OK)); + var template EsipaMessageFromEimToIpa R_INITIATE_AUTH_OK := + tr_initiateAuthenticationResponseEsipa(transactionId := SGP23_S_TRANSACTION_ID, + serverSigned1 := tr_serverSigned1, + serverSignature1 := SGP23_SERVER_SIGNATURE1, + euiccCiPKIdentifierToBeUsed := SGP23_EUICC_CI_PK_ID_TO_BE_USED, + serverCertificate := ?, + matchingId := omit, + ctxParams1 := omit) + f_esipa_receive(R_INITIATE_AUTH_OK); + + /* Step 1b: Authenticatate Server Response */ + var template SGP32_AuthenticateServerResponse SGP32_S_AUTH_SERVER_MATCH_ID_DEV_INFO := + ts_SGP32_authenticateServerResponse( + euiccSigned1 := ts_SGP32_euiccSigned1(transactionId := SGP23_S_TRANSACTION_ID, + serverAddress := smdpp_addr, + serverChallenge := SGP23_SMDP_CHALLENGE, + ctxParams1 := ts_ctxParams1(matchingId := SGP23_MATCHING_ID_1, + imei := SGP23_S_IMEI, + tac := SGP23_S_TAC) + ), + euiccSignature1 := SGP23_EUICC_SIGNATURE1, + euiccCertificate := ts_cert_euicc_nist, + eumCertificate := ts_cert_eum_nist); + f_esipa_send(valueof(ts_authenticateClientRequestEsipa(authenticateServerResponse := + SGP32_S_AUTH_SERVER_MATCH_ID_DEV_INFO))); + var template AuthenticateServerResponse R_AUTH_SERVER_MATCH_ID_DEV_INFO := + tr_authenticateServerResponse(transactionId := SGP23_S_TRANSACTION_ID, + serverAddress := smdpp_addr, + serverChallenge := SGP23_SMDP_CHALLENGE, + ctxParams1 := tr_ctxParams1(matchingId := SGP23_MATCHING_ID_1, + imei := SGP23_S_IMEI, tac := SGP23_S_TAC), + euiccSignature1 := SGP23_EUICC_SIGNATURE1, + euiccCertificate := ?, + eumCertificate := ?); + f_es9p_receive(tr_authenticateClientRequest(transactionId := SGP23_S_TRANSACTION_ID, + authenticateServerResponse := R_AUTH_SERVER_MATCH_ID_DEV_INFO)); + + /* Step 2a: Download profile normally */ + f_es9p_send(valueof(ts_authenticateClientResponseEs9)); + f_esipa_receive(tr_authenticateClientResponseEsipa_dpe); + f_esipa_send(valueof(ts_getBoundProfilePackageRequestEsipa)); + f_es9p_transceive(valueof(ts_getBoundProfilePackageResponse), tr_getBoundProfilePackageRequest); + f_esipa_receive(tr_getBoundProfilePackageResponseEsipa); + + /* Step 2b: Remove rest resource + * (Even though the profile package is downloaded at this point, the transaction will still linger because + * the eIM is waiting for the notification that confirms the success or failure of the download. When we + * delete the rest resource, this lingering transaction is also removed from the eIM and the testcase + * should exit with a clean state) */ + f_rest_delete_resource(resource_id, "download"); + + f_sleep(2.0); + setverdict(pass); +} +testcase TC_eIM_AuthenticateClient_Nominal_without_Confirmation_Code() runs on MTC_CT { + var charstring id := testcasename(); + var eIM_ConnHdlrPars pars := f_init_pars(); + var eIM_ConnHdlr vc_conn; + f_init(id); + vc_conn := f_start_handler(refers(f_TC_eIM_AuthenticateClient_Nominal_without_Confirmation_Code), pars); + vc_conn.done; + setverdict(pass); +} + +/* Helper function to generate a common eIM related error case. + * See SGP.33-3, section 4.2.12.2.2, and SGP.23, section 4.4.23.2.2 */ +private function f_TC_eIM_AuthenticateClient_ErrorCases_Error_eim( + charstring id, + charstring subjectCode, + charstring reasonCode) +runs on eIM_ConnHdlr { + var charstring resource_id; + var template JSON_REST_Results expected_outcome := { { authenticateClientError := "undefinedError" } }; + var template EsipaMessageFromEimToIpa esipa_res; + var octetstring eim_transaction_id; + var charstring smdpp_addr := mp_es9p_ip & ":" & int2str(mp_es9p_port) + var charstring activation_code := f_SGP23_ACTIVATION_CODE_1(test_dp_address := smdpp_addr); + + /* Create a new download at the eIM */ + resource_id := f_rest_create_order("download", ts_JSON_REST_download_order(SGP23_EID1, activation_code)); + + /* Check the eIM for new eIM packages, we expect to get a profileDownloadTriggerRequest that contains the + * activationCode that we have created the download with (see above) */ + esipa_res := f_esipa_transceive(valueof(ts_getEimPackageRequest(SGP23_EID1)), + tr_getEimPackageResponse_dnlTrigReq( + tr_profileDownloadTriggerRequest(activation_code))); + eim_transaction_id := valueof(esipa_res.getEimPackageResponse.profileDownloadTriggerRequest.eimTransactionId); + + /* Step IC1/IC2: */ + f_esipa_send(valueof(ts_initiateAuthenticationRequestEsipa(smdpAddress := smdpp_addr, + eimTransactionId := eim_transaction_id))); + f_es9p_receive(tr_initiateAuthenticationRequest); + + /* Step 1 Initiate Authentication Response */ + f_es9p_send(valueof(ts_initiateAuthenticationResponse)); + f_esipa_receive(tr_initiateAuthenticationResponseEsipa); + f_esipa_send(valueof(ts_authenticateClientRequestEsipa)); + f_es9p_receive(tr_authenticateClientRequest); + + /* Step 2a: SM-DP+ error response */ + f_es9p_send_err(ts_responseHeader(status := "Failed", + statusCodeData := ts_statusCodeData(subjectCode := subjectCode, + reasonCode := reasonCode))); + f_esipa_receive(tr_authenticateClientResponseEsipa_err, tr_statusCodeData); + + /* Step 2a: Check outcome and remove rest resource */ + f_rest_lookup_resource(resource_id, "download", tr_JSON_REST_success(outcome := expected_outcome) ); + f_rest_delete_resource(resource_id, "download"); + + f_sleep(2.0); + setverdict(pass); +} + +/* See SGP.33-3, section 4.2.12.2.2, Test Sequence #01 and SGP.23, section 4.4.23.2.2, Test Sequence #01 */ +/* TODO: Implement remaining test sequences (#02-#14) when useful. At the moment those test sequences are not + * implemented because they would not increase the test coverage. The code paths inside the eIM do not change when a + * different subjectCode or reasonCode is sent. */ +private function f_TC_eIM_AuthenticateClient_ErrorCases_Error_Invalid_EUM_Certificate(charstring id) +runs on eIM_ConnHdlr { + f_TC_eIM_AuthenticateClient_ErrorCases_Error_eim(id, "8.1.2", "6.1"); +} +testcase TC_eIM_AuthenticateClient_ErrorCases_Error_Invalid_EUM_Certificate() runs on MTC_CT { + var charstring id := testcasename(); + var eIM_ConnHdlrPars pars := f_init_pars(); + var eIM_ConnHdlr vc_conn; + f_init(id); + vc_conn := f_start_handler(refers(f_TC_eIM_AuthenticateClient_ErrorCases_Error_Invalid_EUM_Certificate), pars); + vc_conn.done; + setverdict(pass); +} + +/* Helper function to generate a common IPAd related error case. + * See SGP.33-3, section 4.2.12.2.2, and SGP.23, section 4.4.23.2.2 */ +private function f_TC_eIM_AuthenticateClient_ErrorCases_Error_ipad( + template RemoteProfileProvisioningResponse invalid_authenticateClientResponseEs9) +runs on eIM_ConnHdlr { + var charstring resource_id; + var template JSON_REST_Results expected_outcome := { { eimProcedureError := "stuckOrder" } }; + var template EsipaMessageFromEimToIpa esipa_res; + var octetstring eim_transaction_id; + var charstring smdpp_addr := mp_es9p_ip & ":" & int2str(mp_es9p_port) + var charstring activation_code := f_SGP23_ACTIVATION_CODE_1(test_dp_address := smdpp_addr); + + /* Create a new download at the eIM */ + resource_id := f_rest_create_order("download", ts_JSON_REST_download_order(SGP23_EID1, activation_code)); + + /* Check the eIM for new eIM packages, we expect to get a profileDownloadTriggerRequest that contains the + * activationCode that we have created the download with (see above) */ + esipa_res := f_esipa_transceive(valueof(ts_getEimPackageRequest(SGP23_EID1)), + tr_getEimPackageResponse_dnlTrigReq( + tr_profileDownloadTriggerRequest(activation_code))); + eim_transaction_id := valueof(esipa_res.getEimPackageResponse.profileDownloadTriggerRequest.eimTransactionId); + + /* Step IC1/IC2: */ + f_esipa_send(valueof(ts_initiateAuthenticationRequestEsipa(smdpAddress := smdpp_addr, + eimTransactionId := eim_transaction_id))); + f_es9p_receive(tr_initiateAuthenticationRequest); + + /* Step 1 Initiate Authentication Response */ + f_es9p_send(valueof(ts_initiateAuthenticationResponse)); + f_esipa_receive(tr_initiateAuthenticationResponseEsipa); + f_esipa_send(valueof(ts_authenticateClientRequestEsipa)); + f_es9p_receive(tr_authenticateClientRequest); + + /* Step 2a: SM-DP+ responds with invalid response */ + f_es9p_send(valueof(invalid_authenticateClientResponseEs9)); + f_esipa_receive(tr_authenticateClientResponseEsipa_dpe); + + /* Step 2b: IPAd aborts the procedure by doing nothing. After some time (30 sec.), the eIM should detect that + * nothing happens anymore and mark the order as stuck. To allow this testcase to succed, the sys.config value + * for rest_timeout_stuck must be set low enough. A recommended setting is 15 sec. */ + f_sleep(30.0); + + /* Step 2c: Check outcome and remove rest resource, we expect that the eIM has detected a stuck order */ + f_rest_lookup_resource(resource_id, "download", tr_JSON_REST_success(outcome := expected_outcome) ); + f_rest_delete_resource(resource_id, "download"); + + f_sleep(2.0); + setverdict(pass); +} + +/* See SGP.33-3, section 4.2.12.2.2, Test Sequence #15 and SGP.23, section 4.4.23.2.2, Test Sequence #15 */ +/* TODO: Implement remaining test sequences (#16-#18) when useful. At the moment those test sequences are not + * implemented because they would not increase the test coverage. The code paths inside the eIM do not change when a + * different authenticateClientResponseEs9 is sent. */ +private function f_TC_eIM_AuthenticateClient_ErrorCases_Error_Invalid_SM_DPp_pb_certificate(charstring id) +runs on eIM_ConnHdlr { + f_TC_eIM_AuthenticateClient_ErrorCases_Error_ipad(ts_authenticateClientResponseEs9); +} +testcase TC_eIM_AuthenticateClient_ErrorCases_Error_Invalid_SM_DPp_pb_certificate() runs on MTC_CT { + var charstring id := testcasename(); + var eIM_ConnHdlrPars pars := f_init_pars(); + var eIM_ConnHdlr vc_conn; + f_init(id); + vc_conn := f_start_handler(refers( + f_TC_eIM_AuthenticateClient_ErrorCases_Error_Invalid_SM_DPp_pb_certificate), pars); + vc_conn.done; + setverdict(pass); +} + +/* Helper function to pass a notification (IPAd/TTCN3 -> eIM -> SM-DP+/TTCN3). + * See SGP.33-3, section 4.2.13.2.1 and SGP.23, section 4.4.24.2.1 */ +private function f_TC_eIM_ES9p_HandleNotification_Pass_Notifications( + template OtherSignedNotification otherSignedNotif_esipa, + template OtherSignedNotification otherSignedNotif_es9p) +runs on eIM_ConnHdlr { + f_esipa_send(valueof(ts_handleNotificationEsipa_pendingNotif( + ts_SGP32_pendingNotification_otherSignedNotif( + otherSignedNotification := otherSignedNotif_esipa)))); + f_es9p_transceive_empty_response(tr_handleNotification( + pendingNotification := tr_pendingNotification_otherSignedNotif( + otherSignedNotification := otherSignedNotif_es9p))); +} + +/* Helper function to generate a (nominal) profile download. + * See SGP.33-3, section 4.2.13.2.1 and SGP.23, section 4.4.24.2.1 */ +private function f_TC_eIM_ES9p_HandleNotification_Nominal_PIR( + template SGP32_ProfileInstallationResult prfleInstRslt_esipa, + template ProfileInstallationResult prfleInstRslt_es9p, + template JSON_REST_Results prfleInstRslt_rest := ?) +runs on eIM_ConnHdlr { + var charstring resource_id; + var template EsipaMessageFromEimToIpa esipa_res; + var octetstring eim_transaction_id; + var charstring smdpp_addr := mp_es9p_ip & ":" & int2str(mp_es9p_port) + var charstring activation_code := f_SGP23_ACTIVATION_CODE_1(test_dp_address := smdpp_addr); + + /* Create a new download at the eIM */ + resource_id := f_rest_create_order("download", ts_JSON_REST_download_order(SGP23_EID1, activation_code)); + + /* Check the eIM for new eIM packages, we expect to get a profileDownloadTriggerRequest that contains the + * activationCode that we have created the download with (see above) */ + esipa_res := f_esipa_transceive(valueof(ts_getEimPackageRequest(SGP23_EID1)), + tr_getEimPackageResponse_dnlTrigReq( + tr_profileDownloadTriggerRequest(activation_code))); + eim_transaction_id := valueof(esipa_res.getEimPackageResponse.profileDownloadTriggerRequest.eimTransactionId); + + /* Step IC1/IC2: Initiate Authentication */ + f_esipa_send(valueof(ts_initiateAuthenticationRequestEsipa(smdpAddress := smdpp_addr, + eimTransactionId := eim_transaction_id))); + f_es9p_receive(tr_initiateAuthenticationRequest); + f_es9p_send(valueof(ts_initiateAuthenticationResponse)); + f_esipa_receive(tr_initiateAuthenticationResponseEsipa); + + /* Step IC3: Authenticate Client */ + f_esipa_send(valueof(ts_authenticateClientRequestEsipa)); + f_es9p_receive(tr_authenticateClientRequest); + f_es9p_send(valueof(ts_authenticateClientResponseEs9)); + f_esipa_receive(tr_authenticateClientResponseEsipa_dpe); + + /* Step IC4: Get Bound Profiele Package*/ + f_esipa_send(valueof(ts_getBoundProfilePackageRequestEsipa)); + f_es9p_transceive(valueof(ts_getBoundProfilePackageResponse), tr_getBoundProfilePackageRequest); + f_esipa_receive(tr_getBoundProfilePackageResponseEsipa); + + /* Step 1/2a: Handle notification (Profile Installation Result) + * When the Notification arrives at the eIM, the eIM will record the Profile Installation Result from the + * notification and mark the download as done. */ + f_esipa_send(valueof(ts_handleNotificationEsipa_pendingNotif( + ts_SGP32_pendingNotification_prfleInstRslt(prfleInstRslt_esipa)))); + f_es9p_transceive_empty_response(tr_handleNotification( + tr_pendingNotification_prfleInstRslt(prfleInstRslt_es9p))); + + /* Step 1/2b: Check REST API result (outcome), then remove order from REST API */ + f_rest_lookup_resource(resource_id, "download", tr_JSON_REST_success(outcome := prfleInstRslt_rest)); + f_rest_delete_resource(resource_id, "download"); +} + +/* See SGP.33-3, section 4.2.13.2.1, Test Sequence #01 and SGP.23, section 4.4.24.2.1, Test Sequence #01 */ +private function f_TC_eIM_ES9p_HandleNotification_Nominal_Successful_PIR_and_Install_Notifications(charstring id) +runs on eIM_ConnHdlr { + var template OtherSignedNotification otherSignedNotif_esipa; + var template OtherSignedNotification otherSignedNotif_es9p; + var template SGP32_ProfileInstallationResult prfleInstRslt_esipa; + var template ProfileInstallationResult prfleInstRslt_es9p; + var template JSON_REST_Results prfleInstRslt_rest; + var charstring smdpp_addr := mp_es9p_ip & ":" & int2str(mp_es9p_port) + + /* Step 1-2 */ + prfleInstRslt_esipa := ts_SGP32_profileInstallationResult( + profileInstallationResultData := + ts_profileInstallationResultData( + notificationAddress := smdpp_addr, + iccid := SGP23_ICCID_OP_PROF1, + aid := SGP23_SSD_AID, + simaResponse := SGP23_SIMA_RESULT_OK), + euiccSignPIR := SGP23_EUICC_SIGN_PIR); + prfleInstRslt_es9p := tr_profileInstallationResult( + profileInstallationResultData := + tr_profileInstallationResultData( + notificationAddress := smdpp_addr, + iccid := SGP23_ICCID_OP_PROF1, + aid := SGP23_SSD_AID, + simaResponse := SGP23_SIMA_RESULT_OK), + euiccSignPIR := SGP23_EUICC_SIGN_PIR); + prfleInstRslt_rest := {{profileInstallationResult := {iccid := oct2str(SGP23_ICCID_OP_PROF1), + aid := oct2str(SGP23_SSD_AID), + simaResponse := oct2str(SGP23_SIMA_RESULT_OK)}}}; + f_TC_eIM_ES9p_HandleNotification_Nominal_PIR(prfleInstRslt_esipa, prfleInstRslt_es9p, prfleInstRslt_rest); + + /* Step 3/4: Handle notification (Other Signed Notification) */ + otherSignedNotif_esipa := ts_otherSignedNotification( + tbsOtherNotification := ts_notificationMetadata( + seqNumber := 123456, + profileManagementOperation := '1'B, /* notificationInstall */ + notificationAddress := smdpp_addr, + iccid := SGP23_ICCID_OP_PROF1), + euiccNotificationSignature := SGP23_TBS_EUICC_NOTIF_SIG); + + otherSignedNotif_es9p := tr_otherSignedNotification( + tbsOtherNotification := tr_notificationMetadata( + seqNumber := 123456, + profileManagementOperation := '1'B, /* notificationInstall */ + notificationAddress := smdpp_addr, + iccid := SGP23_ICCID_OP_PROF1), + euiccNotificationSignature := SGP23_TBS_EUICC_NOTIF_SIG); + f_TC_eIM_ES9p_HandleNotification_Pass_Notifications(otherSignedNotif_esipa, otherSignedNotif_es9p); + + f_sleep(2.0); +} +testcase TC_eIM_ES9p_HandleNotification_Nominal_Successful_PIR_and_Install_Notifications() runs on MTC_CT { + var charstring id := testcasename(); + var eIM_ConnHdlrPars pars := f_init_pars(); + var eIM_ConnHdlr vc_conn; + f_init(id); + vc_conn := f_start_handler(refers( + f_TC_eIM_ES9p_HandleNotification_Nominal_Successful_PIR_and_Install_Notifications), pars); + vc_conn.done; + setverdict(pass); +} + +/* See SGP.33-3, section 4.2.13.2.1, Test Sequence #02 and SGP.23, section 4.4.24.2.1, Test Sequence #02 */ +private function f_TC_eIM_ES9p_HandleNotification_Nominal_Successful_PIR_and_Enable_Notifications(charstring id) +runs on eIM_ConnHdlr { + var template OtherSignedNotification otherSignedNotif_esipa; + var template OtherSignedNotification otherSignedNotif_es9p; + var template SGP32_ProfileInstallationResult prfleInstRslt_esipa; + var template ProfileInstallationResult prfleInstRslt_es9p; + var template JSON_REST_Results prfleInstRslt_rest; + var charstring smdpp_addr := mp_es9p_ip & ":" & int2str(mp_es9p_port) + + /* Step 1-2 */ + prfleInstRslt_esipa := ts_SGP32_profileInstallationResult( + profileInstallationResultData := + ts_profileInstallationResultData( + notificationAddress := smdpp_addr, + iccid := SGP23_ICCID_OP_PROF1, + aid := SGP23_SSD_AID, + simaResponse := SGP23_SIMA_RESULT_OK), + euiccSignPIR := SGP23_EUICC_SIGN_PIR); + prfleInstRslt_es9p := tr_profileInstallationResult( + profileInstallationResultData := + tr_profileInstallationResultData( + notificationAddress := smdpp_addr, + iccid := SGP23_ICCID_OP_PROF1, + aid := SGP23_SSD_AID, + simaResponse := SGP23_SIMA_RESULT_OK), + euiccSignPIR := SGP23_EUICC_SIGN_PIR); + prfleInstRslt_rest := {{profileInstallationResult := {iccid := oct2str(SGP23_ICCID_OP_PROF1), + aid := oct2str(SGP23_SSD_AID), + simaResponse := oct2str(SGP23_SIMA_RESULT_OK)}}}; + f_TC_eIM_ES9p_HandleNotification_Nominal_PIR(prfleInstRslt_esipa, prfleInstRslt_es9p, prfleInstRslt_rest); + + /* Step 4: Handle notification (Other Signed Notification) */ + otherSignedNotif_esipa := ts_otherSignedNotification( + tbsOtherNotification := ts_notificationMetadata( + seqNumber := 789, + profileManagementOperation := '01'B, /* notificationEnable */ + notificationAddress := smdpp_addr, + iccid := SGP23_ICCID_OP_PROF1), + euiccNotificationSignature := SGP23_TBS_EUICC_NOTIF_SIG); + + otherSignedNotif_es9p := tr_otherSignedNotification( + tbsOtherNotification := tr_notificationMetadata( + seqNumber := 789, + profileManagementOperation := '01'B, /* notificationEnable */ + notificationAddress := smdpp_addr, + iccid := SGP23_ICCID_OP_PROF1), + euiccNotificationSignature := SGP23_TBS_EUICC_NOTIF_SIG); + f_TC_eIM_ES9p_HandleNotification_Pass_Notifications(otherSignedNotif_esipa, otherSignedNotif_es9p); + + f_sleep(2.0); +} +testcase TC_eIM_ES9p_HandleNotification_Nominal_Successful_PIR_and_Enable_Notifications() runs on MTC_CT { + var charstring id := testcasename(); + var eIM_ConnHdlrPars pars := f_init_pars(); + var eIM_ConnHdlr vc_conn; + f_init(id); + vc_conn := f_start_handler(refers( + f_TC_eIM_ES9p_HandleNotification_Nominal_Successful_PIR_and_Enable_Notifications), pars); + vc_conn.done; + setverdict(pass); +} + +/* See SGP.33-3, section 4.2.13.2.1, Test Sequence #03 and SGP.23, section 4.4.24.2.1, Test Sequence #03 */ +private function f_TC_eIM_ES9p_HandleNotification_Nominal_Disable_and_Delete_Notifications(charstring id) +runs on eIM_ConnHdlr { + var template OtherSignedNotification otherSignedNotif_esipa; + var template OtherSignedNotification otherSignedNotif_es9p; + var charstring smdpp_addr := mp_es9p_ip & ":" & int2str(mp_es9p_port) + + /* Pass first Notification: Disable profile */ + otherSignedNotif_esipa := ts_otherSignedNotification( + tbsOtherNotification := ts_notificationMetadata( + seqNumber := 7890, + profileManagementOperation := '001'B, /* notificationDisable */ + notificationAddress := smdpp_addr, + iccid := SGP23_ICCID_OP_PROF1), + euiccNotificationSignature := SGP23_TBS_EUICC_NOTIF_SIG); + + otherSignedNotif_es9p := tr_otherSignedNotification( + tbsOtherNotification := tr_notificationMetadata( + seqNumber := 7890, + profileManagementOperation := '001'B, /* notificationDisable*/ + notificationAddress := smdpp_addr, + iccid := SGP23_ICCID_OP_PROF1), + euiccNotificationSignature := SGP23_TBS_EUICC_NOTIF_SIG); + f_TC_eIM_ES9p_HandleNotification_Pass_Notifications(otherSignedNotif_esipa, otherSignedNotif_es9p); + + /* Pass second Notification: Delete profile */ + otherSignedNotif_esipa := ts_otherSignedNotification( + tbsOtherNotification := ts_notificationMetadata( + seqNumber := 7890, + profileManagementOperation := '0001'B, /* notificationDelete */ + notificationAddress := smdpp_addr, + iccid := SGP23_ICCID_OP_PROF1), + euiccNotificationSignature := SGP23_TBS_EUICC_NOTIF_SIG); + + otherSignedNotif_es9p := tr_otherSignedNotification( + tbsOtherNotification := tr_notificationMetadata( + seqNumber := 7890, + profileManagementOperation := '0001'B, /* notificationDelete*/ + notificationAddress := smdpp_addr, + iccid := SGP23_ICCID_OP_PROF1), + euiccNotificationSignature := SGP23_TBS_EUICC_NOTIF_SIG); + f_TC_eIM_ES9p_HandleNotification_Pass_Notifications(otherSignedNotif_esipa, otherSignedNotif_es9p); + + f_sleep(2.0); +} +testcase TC_eIM_ES9p_HandleNotification_Nominal_Disable_and_Delete_Notifications() runs on MTC_CT { + var charstring id := testcasename(); + var eIM_ConnHdlrPars pars := f_init_pars(); + var eIM_ConnHdlr vc_conn; + f_init(id); + vc_conn := f_start_handler(refers( + f_TC_eIM_ES9p_HandleNotification_Nominal_Disable_and_Delete_Notifications), pars); + vc_conn.done; + setverdict(pass); +} + +/* See SGP.33-3, section 4.2.13.2.1, Test Sequence #06 and SGP.23, section 4.4.24.2.1, Test Sequence #06 */ +private function f_TC_eIM_ES9p_HandleNotification_Nominal_Profile_Download_with_PIR_Failed(charstring id) +runs on eIM_ConnHdlr { + var template OtherSignedNotification otherSignedNotif_esipa; + var template OtherSignedNotification otherSignedNotif_es9p; + var template SGP32_ProfileInstallationResult prfleInstRslt_esipa; + var template ProfileInstallationResult prfleInstRslt_es9p; + var template JSON_REST_Results prfleInstRslt_rest; + var charstring smdpp_addr := mp_es9p_ip & ":" & int2str(mp_es9p_port) + + /* Step 1-2 */ + prfleInstRslt_esipa := ts_SGP32_profileInstallationResult( + profileInstallationResultData := + ts_profileInstallationResultData_err( + notificationAddress := smdpp_addr), + euiccSignPIR := SGP23_EUICC_SIGN_PIR); + prfleInstRslt_es9p := tr_profileInstallationResult( + profileInstallationResultData := + tr_profileInstallationResultData_err( + notificationAddress := smdpp_addr, + bppCommandId := 5, /* loadProfileElements */ + errorReason := 1, /* incorrectInputValues */ + simaResponse := omit), + euiccSignPIR := SGP23_EUICC_SIGN_PIR); + prfleInstRslt_rest := {{profileInstallationError := {bppCommandId := "loadProfileElements", + errorReason := "incorrectInputValues", + simaResponse := ""}}}; + f_TC_eIM_ES9p_HandleNotification_Nominal_PIR(prfleInstRslt_esipa, prfleInstRslt_es9p, prfleInstRslt_rest); + + f_sleep(2.0); +} +testcase TC_eIM_ES9p_HandleNotification_Nominal_Profile_Download_with_PIR_Failed() runs on MTC_CT { + var charstring id := testcasename(); + var eIM_ConnHdlrPars pars := f_init_pars(); + var eIM_ConnHdlr vc_conn; + f_init(id); + vc_conn := f_start_handler(refers( + f_TC_eIM_ES9p_HandleNotification_Nominal_Profile_Download_with_PIR_Failed), pars); + vc_conn.done; + setverdict(pass); +} + control { + /* Custom testcases (common situations) */ execute ( TC_proc_indirect_prfle_dwnld() ); execute ( TC_proc_indirect_prfle_dwnld_cancel_session() ); execute ( TC_proc_euicc_pkg_dwnld_exec_enable_psmo() ); @@ -1004,6 +1573,15 @@ execute ( TC_proc_euicc_data_req() ); execute ( TC_proc_euicc_data_req_err() ); execute ( TC_proc_notifyStateChange() ); + + /* SGP.33-3 testcases */ + execute ( TC_eIM_AuthenticateClient_Nominal_without_Confirmation_Code() ); + execute ( TC_eIM_AuthenticateClient_ErrorCases_Error_Invalid_EUM_Certificate() ); + execute ( TC_eIM_AuthenticateClient_ErrorCases_Error_Invalid_SM_DPp_pb_certificate() ); + execute ( TC_eIM_ES9p_HandleNotification_Nominal_Successful_PIR_and_Install_Notifications() ); + execute ( TC_eIM_ES9p_HandleNotification_Nominal_Successful_PIR_and_Enable_Notifications() ); + execute ( TC_eIM_ES9p_HandleNotification_Nominal_Disable_and_Delete_Notifications() ); + execute ( TC_eIM_ES9p_HandleNotification_Nominal_Profile_Download_with_PIR_Failed() ); } } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43904?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ide8fdec56eca4d4577baedfacd2a6a675d9c0e6e Gerrit-Change-Number: 43904 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
1 0
0 0
[L] Change in osmo-ttcn3-hacks[master]: SGP23_Constants: collect constants at a central place
by dexter 16 Oct '26

16 Oct '26
Attention is currently required from: jolly. Hello Jenkins Builder, jolly, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43841?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: SGP23_Constants: collect constants at a central place ...................................................................... SGP23_Constants: collect constants at a central place The modules RSPDefinitions_Templates and SGP32Definitions_Templates have inline constants all over the place. Some of those constants even interact with each other (e.g. it is important to use the same transactionId value consistently). This is difficult difficult to maintain and the constants currently in use also do not follow any specification. Let's collect those constants and re-define them in a central module. Fortunately SGP.23 already defines a lot of those constants and values we can use. Related: SYS#8203 Change-Id: I00e3de0b20156993b8e15b5bbd4734faa20b66cf --- M eim/gen_links.sh M ipad/gen_links.sh M library/euicc/RSPDefinitions_Templates.ttcn A library/euicc/SGP23_Constants.ttcn M library/euicc/SGP32Definitions_Templates.ttcn M smdpp/gen_links.sh 6 files changed, 321 insertions(+), 166 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/41/43841/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43841?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I00e3de0b20156993b8e15b5bbd4734faa20b66cf Gerrit-Change-Number: 43841 Gerrit-PatchSet: 3 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Attention: jolly <andreas(a)eversberg.eu>
1 0
0 0
[XS] Change in osmo-ttcn3-hacks[master]: REST_Types_JSON: fix typo in field names
by dexter 16 Oct '26

16 Oct '26
Attention is currently required from: dexter. Hello Jenkins Builder, jolly, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43874?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder The change is no longer submittable: Verified is unsatisfied now. Change subject: REST_Types_JSON: fix typo in field names ...................................................................... REST_Types_JSON: fix typo in field names Field names must not begin with capital letters. Related: SYS#8203 Change-Id: I6ea321e2375d2c2db341120974c2e1668c7dd5bc --- M eim/REST_Types_JSON.ttcn 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/74/43874/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43874?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I6ea321e2375d2c2db341120974c2e1668c7dd5bc Gerrit-Change-Number: 43874 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
1 0
0 0
[L] Change in osmo-ttcn3-hacks[master]: SGP23_Constants: collect constants at a central place
by dexter 16 Oct '26

16 Oct '26
Attention is currently required from: jolly. dexter has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43841?usp=email ) Change subject: SGP23_Constants: collect constants at a central place ...................................................................... Patch Set 3: (4 comments) File library/euicc/RSPDefinitions_Templates.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43841/comment/6a036986_7086… : PS2, Line 485: tac := ?, > shoudn't it be "tac := tac," ? Done https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43841/comment/bfb2a918_241e… : PS2, Line 513: tac := SGP23_S_TAC, > same as above. […] Done https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43841/comment/14ba5f5b_83fe… : PS2, Line 1014: ctxParams1 := tr_ctxParams1 > also here: […] Done https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43841/comment/eac7b018_82ee… : PS2, Line 1035: ctxParams1 := ts_ctxParams1 > also here: […] Done -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43841?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I00e3de0b20156993b8e15b5bbd4734faa20b66cf Gerrit-Change-Number: 43841 Gerrit-PatchSet: 3 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Comment-Date: Fri, 16 Oct 2026 07:48:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: jolly <andreas(a)eversberg.eu>
1 0
0 0
[S] Change in osmo-ttcn3-hacks[master]: RSPDefinitions_Templates: add parameters to ts/tr_profileInstallation...
by dexter 16 Oct '26

16 Oct '26
Attention is currently required from: dexter, jolly. Hello Jenkins Builder, jolly, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43875?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Code-Review+2 by jolly, Verified+1 by Jenkins Builder The change is no longer submittable: Code-Review and Verified are unsatisfied now. Change subject: RSPDefinitions_Templates: add parameters to ts/tr_profileInstallationResultData ...................................................................... RSPDefinitions_Templates: add parameters to ts/tr_profileInstallationResultData The templates ts/tr_profileInstallationResultData currently do not allow to set parameters. In particular not in the finalResult field. Let's extend the template so that we can set the parameters. Change-Id: I445c906a0142a401c305dbcbb3e94843a8f5fce9 Related: SYS#8203 --- M library/euicc/RSPDefinitions_Templates.ttcn 1 file changed, 21 insertions(+), 8 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/75/43875/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43875?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I445c906a0142a401c305dbcbb3e94843a8f5fce9 Gerrit-Change-Number: 43875 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
1 0
0 0
[S] Change in osmo-ttcn3-hacks[master]: RSPDefinitions_Templates: add tr/ts_profileInstallationResultData_err
by dexter 16 Oct '26

16 Oct '26
Attention is currently required from: jolly. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43877?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: RSPDefinitions_Templates: add tr/ts_profileInstallationResultData_err ...................................................................... RSPDefinitions_Templates: add tr/ts_profileInstallationResultData_err We already have a tr/ts_profileInstallationResultData template for the success case (successResult), let's now add a coresponding template for the error case (errorResult). Change-Id: Ib927cdea65adc633a8e4b93739f894b4adabffb5 Related: SYS#8203 --- M library/euicc/RSPDefinitions_Templates.ttcn 1 file changed, 42 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/77/43877/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43877?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ib927cdea65adc633a8e4b93739f894b4adabffb5 Gerrit-Change-Number: 43877 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: jolly <andreas(a)eversberg.eu> Gerrit-Attention: jolly <andreas(a)eversberg.eu>
1 0
0 0
  • ← Newer
  • 1
  • ...
  • 44
  • 45
  • 46
  • 47
  • 48
  • 49
  • 50
  • ...
  • 125
  • Older →

HyperKitty Powered by HyperKitty version 1.3.12.